[Lldb-commits] [lldb] 25495c9 - [lldb][NFCI] Remove n^2 loops and simplify iterator usage

Author: Felipe de Azevedo Piovezan Date: 2023-05-10T06:18:27-04:00 New Revision: 25495c9b4c05cb52bacdbc91ba7ee7da7b9a857c URL: https://github.com/llvm/llvm-project/commit/25495c9b4c05cb52bacdbc91ba7ee7da7b9a857c DIFF: https://github.com/llvm/llvm-project/commit/25495c9b4c05cb52bacdbc91ba7ee7da7

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

This revision was automatically updated to reflect the committed changes. Closed by commit rG25495c9b4c05: [lldb][NFCI] Remove n^2 loops and simplify iterator usage (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ ht

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! I like how the static_cast now is explicit about the fact that some truncation is going on from the ULEB reading. Do you have plans to do something similar for the attribute typedef? Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord added a comment. In D150228#4331943 , @fdeazeve wrote: > Do you have plans to do something similar for the attribute typedef? Yes I would like to do that too! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 521047. bulbazord added a comment. Fix a warning in HashedNameToDIE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https://reviews.llvm.org/D150228 Files: lldb/include/lldb/Core/dwarf.h lldb/s

[Lldb-commits] [lldb] 2ec334d - [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

Author: Alex Langford Date: 2023-05-10T11:17:30-07:00 New Revision: 2ec334dc7b7329c6b71faa037a0d926e8e130c20 URL: https://github.com/llvm/llvm-project/commit/2ec334dc7b7329c6b71faa037a0d926e8e130c20 DIFF: https://github.com/llvm/llvm-project/commit/2ec334dc7b7329c6b71faa037a0d926e8e130c20.diff

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ec334dc7b73: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed. I don't understand why the succeeding return value for `GetFramesUpTo` is `false`. It looks counter-intuitive to me. What's the motivation behind that ? Comment at: lldb

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

codemzs created this revision. codemzs added reviewers: tahonermann, erichkeane, stuij. Herald added subscribers: mattd, gchakrabarti, asavonic, ctetreau, kerbowa, arphaman, kristof.beyls, jvesely. Herald added a project: All. codemzs requested review of this revision. Herald added subscribers: ll

[Lldb-commits] [PATCH] D150299: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

bulbazord created this revision. bulbazord added reviewers: aprantl, jingham, clayborg, rastogishubham, fdeazeve. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald adde

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This simple diff declares some enum values needed to create a REPL for the mojo language. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

rriddle added a comment. Could we switch the RTTI to use the llvm RTTI extension mechanism, instead of enums? Other classes have started doing this, and it'd be really nice if users can write REPLS without needing to touch upstream LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

bulbazord added a comment. In D150303#4333215 , @rriddle wrote: > Could we switch the RTTI to use the llvm RTTI extension mechanism, instead of > enums? Other classes have started doing this, and it'd be really nice if > users can write REPLS without ne

[Lldb-commits] [PATCH] D150313: Fix libstdc++ data formatter for reference/pointer to std::string

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fix

[Lldb-commits] [PATCH] D150239: ObjectFileMachO: Prioritize the TEXT segment as the mach header segment, regardless of the order the segments appear in the file

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM for support of something that really should hurt a little more than you are making it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D150315: Make sure the "Relevant Frame" gets selected before the initial stop printing

jingham created this revision. jingham added reviewers: mib, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When the Debugger runs HandleProcessEvent it should allow selecting the "Mos

[Lldb-commits] [PATCH] D150315: Make sure the "Relevant Frame" gets selected before the initial stop printing

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150315/new/ https://reviews.llvm.org/D150315 ___ lldb

[Lldb-commits] [lldb] 7b5dc63 - When the Debugger runs HandleProcessEvent it should allow

Author: Jim Ingham Date: 2023-05-10T15:40:40-07:00 New Revision: 7b5dc63fc4464e777e4210a68120b36cb283a9fd URL: https://github.com/llvm/llvm-project/commit/7b5dc63fc4464e777e4210a68120b36cb283a9fd DIFF: https://github.com/llvm/llvm-project/commit/7b5dc63fc4464e777e4210a68120b36cb283a9fd.diff LO

[Lldb-commits] [PATCH] D150315: Make sure the "Relevant Frame" gets selected before the initial stop printing

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b5dc63fc446: When the Debugger runs HandleProcessEvent it should allow (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150315/new/ htt

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks great, thank you for doing this! Requested changes are just to undo some of the style changes. Comment at: clang/include/clang/Basic/Specifier

[Lldb-commits] [lldb] f9759d0 - Prioritize using a segment with the name TEXT instead off fileoff 0

Author: Jason Molenda Date: 2023-05-10T16:42:38-07:00 New Revision: f9759d0cb6dc19aa67dbe1c3d56404041f8b4c7e URL: https://github.com/llvm/llvm-project/commit/f9759d0cb6dc19aa67dbe1c3d56404041f8b4c7e DIFF: https://github.com/llvm/llvm-project/commit/f9759d0cb6dc19aa67dbe1c3d56404041f8b4c7e.diff

[Lldb-commits] [PATCH] D150239: ObjectFileMachO: Prioritize the TEXT segment as the mach header segment, regardless of the order the segments appear in the file

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9759d0cb6dc: Prioritize using a segment with the name TEXT instead off fileoff 0 (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521163. codemzs marked 4 inline comments as done. codemzs retitled this revision from "[Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`" to "[Clang] Rename internal type identifier(s) for __bf16 to BF16Ty". codemzs added a comment. PR feed

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. Thank you for pointing that out and for reviewing my code. I appreciate your guidance. I was following the LLVM contribution guidelines to use git clang-format, but I understand the importance of maintaining existing code styles that may be altered by git-clang format.

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

jingham added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:103-104 - void GetFramesUpTo(uint32_t end_idx); + /// Gets frames up to end_idx (which can be greater than the actual number of + /// frames.) Returns true if the function was interrupted,

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

jingham updated this revision to Diff 521183. jingham added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150236/new/ https://reviews.llvm.org/D150236 Files: lldb/include/lldb/Target/StackFrameList.h lldb/sou