[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord added a comment. I previously uploaded a similar patch that I've since abandoned. It contains valuable context so I'm linking it here for other contributors to read: D149214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord abandoned this revision. bulbazord added a comment. Thanks for the reviews and suggestions. I took a step back and looked at DWARFAbbreviationDeclaration and DWARFAttribute in more detail and I've decided I'm going to take this in a slightly different direction. I don't want to

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, labath, kastiglione, rastogishubham, fdeazeve, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber:

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

bulbazord added a comment. Ok, this looks like it's doing the same thing to me which is good. My understanding of this change is that you're changing `lldb::DWARFDebugRanges::Extract` to use `llvm::DWARFDebugRangeList` instead of `lldb::DWARFRangeList`. Out of curiosity, do you have an idea

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

This revision was automatically updated to reflect the committed changes. Closed by commit rGe19387e6936c: We cant let GetStackFrameCount get interrupted or it will give the (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e19387e - We can't let GetStackFrameCount get interrupted or it will give the

Author: Jim Ingham Date: 2023-05-11T14:48:54-07:00 New Revision: e19387e6936c9ccc6200b32f3affea7b1020664c URL: https://github.com/llvm/llvm-project/commit/e19387e6936c9ccc6200b32f3affea7b1020664c DIFF: https://github.com/llvm/llvm-project/commit/e19387e6936c9ccc6200b32f3affea7b1020664c.diff

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere, clayborg, jingham, rastogishubham, fdeazeve. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project:

[Lldb-commits] [lldb] 1585ee1 - Relax test to not rely on the variable being optimized out

Author: Adrian Prantl Date: 2023-05-11T13:38:19-07:00 New Revision: 1585ee1077930d4a906b3265bb40a90ba4758c99 URL: https://github.com/llvm/llvm-project/commit/1585ee1077930d4a906b3265bb40a90ba4758c99 DIFF: https://github.com/llvm/llvm-project/commit/1585ee1077930d4a906b3265bb40a90ba4758c99.diff

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

This revision was automatically updated to reflect the committed changes. Closed by commit rGefbd5870402b: [lldb] Correct elision of line zero in mixed disassembly (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150383/new/

[Lldb-commits] [lldb] efbd587 - [lldb] Correct elision of line zero in mixed disassembly

Author: Dave Lee Date: 2023-05-11T13:24:32-07:00 New Revision: efbd5870402b53dc8aeee2d087db3109d198e3dc URL: https://github.com/llvm/llvm-project/commit/efbd5870402b53dc8aeee2d087db3109d198e3dc DIFF: https://github.com/llvm/llvm-project/commit/efbd5870402b53dc8aeee2d087db3109d198e3dc.diff

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61 uint8_t m_has_children = 0; - DWARFAttribute::collection m_attributes; }; kastiglione wrote: > With this change, can the following be

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

kastiglione added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61 uint8_t m_has_children = 0; - DWARFAttribute::collection m_attributes; }; With this change, can the following be removed from`

[Lldb-commits] [PATCH] D150392: [lldb-vscode] Fix handling of RestartRequest arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b11034c672f: [lldb-vscode] Fix handling of RestartRequest arguments. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150392/new/

[Lldb-commits] [lldb] 1b11034 - [lldb-vscode] Fix handling of RestartRequest arguments.

Author: Jorge Gorbe Moya Date: 2023-05-11T13:11:38-07:00 New Revision: 1b11034c672fc90d35b4bc0e93f3507657b14094 URL: https://github.com/llvm/llvm-project/commit/1b11034c672fc90d35b4bc0e93f3507657b14094 DIFF:

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

kastiglione updated this revision to Diff 521420. kastiglione added a comment. add positive check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150383/new/ https://reviews.llvm.org/D150383 Files: lldb/source/Core/Disassembler.cpp

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4335858 , @aprantl wrote: > I'm not opposed to using this implementation, but have you considered using > something like the stdlib regex library to do the heavy lifting? I had not considered it actually... I don't

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

aprantl added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.test:12 + +// CHECK-NOT: do_not_show Can you add some positive check too? Otherwise this test succeeds even on an empty output.. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

aprantl added a comment. I'm not opposed to using this implementation, but have you considered using something like the stdlib regex library to do the heavy lifting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord updated this revision to Diff 521414. bulbazord added a comment. Update documentation for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/ https://reviews.llvm.org/D149914 Files:

[Lldb-commits] [PATCH] D150392: [lldb-vscode] Fix handling of RestartRequest arguments.

jgorbe updated this revision to Diff 521412. jgorbe added a comment. Added test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150392/new/ https://reviews.llvm.org/D150392 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. Ok, I'm back with actual data on this patch. I have a test ObjC app with some UI, it loads a couple hundred modules. I place a breakpoint on main, I run until we hit main, and then I continue. My app will stop at `-[NSBlockOperation main]` after loading all the

[Lldb-commits] [PATCH] D150392: [lldb-vscode] Fix handling of RestartRequest arguments.

rupprecht added a comment. Is there a test case you can add for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150392/new/ https://reviews.llvm.org/D150392 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150392: [lldb-vscode] Fix handling of RestartRequest arguments.

jgorbe created this revision. jgorbe added reviewers: clayborg, wallace, labath, rupprecht. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. According to the spec, RestartRequest has an optional

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

kastiglione updated this revision to Diff 521392. kastiglione added a comment. add Shell test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150383/new/ https://reviews.llvm.org/D150383 Files: lldb/source/Core/Disassembler.cpp

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. I guess the `InterruptionControl` argument makes it clearer. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150236/new/

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

jingham marked 2 inline comments as done. jingham added a comment. I added the enum, that's a good idea. I agree that we should centralize internal reporting of Interrupt events, but as your "longer term" suggests, that's a design task and orthogonal to this patch. I'll do that in a

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

jingham updated this revision to Diff 521380. jingham added a comment. Address Review Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150236/new/ https://reviews.llvm.org/D150236 Files: lldb/include/lldb/Target/StackFrameList.h

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a subscriber: efriedma. bolshakov-a added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4397 +// argument. +// As proposed in https://github.com/itanium-cxx-abi/cxx-abi/issues/111. +auto *SNTTPE = cast(E); erichkeane

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

mib added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:106 + /// Returns true if the function was interrupted, false otherwise. + bool GetFramesUpTo(uint32_t end_idx, bool allow_interrupt = true); JDevlieghere wrote: > I personally

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

rastogishubham added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32 - typedef std::map range_map; - typedef range_map::iterator range_map_iterator; - typedef range_map::const_iterator range_map_const_iterator; - range_map

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

bulbazord accepted this revision. bulbazord added a comment. LGTM! I know we have this pattern in many places in LLDB. It's good to see this work being done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150363/new/

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. In D150291#4335352 , @tahonermann wrote: > Thanks for all the updates @codemzs! I'm going to go ahead and accept. But > please wait a few days for recently subscribed folks to have a chance to > comment before landing this.

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521363. codemzs marked an inline comment as done. codemzs added a comment. Addressing feedback from @barannikov88 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 Files: clang/include/clang-c/Index.h

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added a comment. In D150291#4335414 , @codemzs wrote: > I've provided the git log message that I see on my end below. I ensured that > it is split into multiple lines, with each line not exceeding the character > limit. Please let me know

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs marked an inline comment as done. codemzs added a comment. In D150291#4335360 , @barannikov88 wrote: > The summary as it is will be hard to read in git log. Please split it into > multiple lines 72~80 chars each. >

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

kastiglione added a comment. Herald added a subscriber: JDevlieghere. For testing, can anyone recommend a way to construct debug info with line entries that have line zero? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150383/new/

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl, jasonmolenda. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When `disassemble --mixed` is run, do not show source

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added a comment. The summary as it is will be hard to read in git log. Please split it into multiple lines 72~80 chars each. https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks for all the updates @codemzs! I'm going to go ahead and accept. But please wait a few days for recently subscribed folks to have a chance to comment before landing this.

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added inline comments. Comment at: clang/lib/AST/Type.cpp:2187 + BT->getKind() <= BuiltinType::Ibm128 && + BT->getKind() != BuiltinType::BF16; if (const auto *ET = dyn_cast(CanonicalType)) Looks like another clang-format

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32 - typedef std::map range_map; - typedef range_map::iterator range_map_iterator; - typedef range_map::const_iterator range_map_const_iterator; - range_map m_range_map; +

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

rastogishubham accepted this revision. rastogishubham added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32 - typedef std::map range_map; - typedef range_map::iterator

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521353. codemzs marked 2 inline comments as done. codemzs set the repository for this revision to rG LLVM Github Monorepo. codemzs added a comment. Update comments as per feedback from @tahonermann Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann added a subscriber: clang-vendors. tahonermann added a comment. Heads up @clang-vendors. This patch changes the names of many internal identifiers for enumerators, class data members, and functions (including virtual functions) that are related to support for the `__bf16` type. The

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann added subscribers: lenary, foad. tahonermann added a comment. > I was following the LLVM contribution guidelines to use git clang-format, but > I understand the importance of maintaining existing code styles that may be > altered by git-clang format. The guidelines are slightly in

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In an effort to unify the different dwarf parsers available in the codebase, this commit removes LLDB's custom parsing

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Most of the code changed here dates back to 2010, when LLDB was first introduced upstream, as such it benefits from a

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:106 + /// Returns true if the function was interrupted, false otherwise. + bool GetFramesUpTo(uint32_t end_idx, bool allow_interrupt = true); I personally would prefer