[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:420 + /// A std::vector of std::strings for each path component. + std::vector GetComponents() const; + bulbazord wrote: > JDevlieghere wrote: > > I'm surprised this returns

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:420 + /// A std::vector of std::strings for each path component. + std::vector GetComponents() const; + JDevlieghere wrote: > I'm surprised this returns a vector of

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:420 + /// A std::vector of std::strings for each path component. + std::vector GetComponents() const; + I'm surprised this returns a vector of `std::string`s and not

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch introduces FileSpec::GetComponents, a

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I have no objections but you should probably wait for others to take another look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151366/new/ https://reviews.llvm.org/D151366

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

bulbazord added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:1099-1103 // 64 - T1Sz is the highest bit used for auth. // The value we pass in to SetVirtualAddressableBits is // the

[Lldb-commits] [PATCH] D151392: Fix SBValue::FindValue for file static variables

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151392/new/ https://reviews.llvm.org/D151392

[Lldb-commits] [PATCH] D151392: Fix SBValue::FindValue for file static variables

jingham created this revision. jingham added reviewers: JDevlieghere, mib. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This was just a thinko. The API StackFrame::GetVariableList takes a bool for

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

JDevlieghere added a comment. The array approach is cool but makes it hard to be backwards compatible: an old lldb is going to error out when presented with more than one value. If you made this two separate options, a client can use `settings set -e` to set the setting if it exists and still

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib added a comment. In D151366#4370123 , @aprantl wrote: > Just so I understand the limitations: > This works for > > int main() { > int val = 0; > // Break here > val++; > val++; > return 0; > } > > but not for > > int main()

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM The help string for the setting seems clear. There's also some logic to handle the setting vrs. the values we find from the stub which you describe in the comment to the review, but

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib updated this revision to Diff 525367. mib marked 4 inline comments as done. mib added a comment. Address @bulbazord & @aprantl comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151366/new/ https://reviews.llvm.org/D151366 Files: lldb/include/lldb/Breakpoint/Watchpoint.h

[Lldb-commits] [PATCH] D151381: [lldb][NFCI] Include in SBDefines for FILE * definition

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151381/new/ https://reviews.llvm.org/D151381

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

aprantl added a comment. Just so I understand the limitations: This works for int main() { int val = 0; // Break here val++; val++; return 0; } but not for int main() { { int val = 0; // Break here val++; val++; } { int other

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib marked 5 inline comments as done. mib added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:140-141 + + LLDB_LOGF(log, "Watchpoint::%s called by breakpoint %" PRIu64 ".%" PRIu64, +__FUNCTION__, break_id, break_loc_id); +

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:103-104 + TargetSP target_sp = exe_ctx.GetTargetSP(); + if (!target_sp) +return false; + bulbazord wrote: > Is it even possible to have an

[Lldb-commits] [PATCH] D151384: [lldb] Override GetVariable in ValueObjectSynthetic (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make `GetVariable` a passthrough function the the underlying value object in

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

bulbazord added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:86 +bool Watchpoint::SetupVariableWatchpointDisabler(StackFrameSP frame_sp) const { + ThreadSP thread_sp = frame_sp->GetThread(); Should you also verify that the `frame_sp` you

[Lldb-commits] [PATCH] D151381: [lldb][NFCI] Include in SBDefines for FILE * definition

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are a few API headers that use FILE * but do not include

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

saugustine added a comment. Any more thoughts on this from the reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150805/new/ https://reviews.llvm.org/D150805 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

glandium added a comment. I haven't tested this patch, but it looks like it contains everything that unbreaks our builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151344/new/ https://reviews.llvm.org/D151344

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib created this revision. mib added reviewers: jingham, JDevlieghere, bulbazord, aprantl. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. If we use a variable watchpoint with a condition using a scope

[Lldb-commits] [PATCH] D150996: LLVM_FALLTHROUGH => [[fallthrough]]. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6006d43e2d7d: LLVM_FALLTHROUGH = [[fallthrough]]. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150996/new/

[Lldb-commits] [lldb] 6006d43 - LLVM_FALLTHROUGH => [[fallthrough]]. NFC

Author: Craig Topper Date: 2023-05-24T12:40:10-07:00 New Revision: 6006d43e2d7dda56844f1c3867baa981cfefb8ea URL: https://github.com/llvm/llvm-project/commit/6006d43e2d7dda56844f1c3867baa981cfefb8ea DIFF: https://github.com/llvm/llvm-project/commit/6006d43e2d7dda56844f1c3867baa981cfefb8ea.diff

[Lldb-commits] [PATCH] D150996: LLVM_FALLTHROUGH => [[fallthrough]]. NFC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150996/new/ https://reviews.llvm.org/D150996

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

mysterymath updated this revision to Diff 525283. mysterymath added a comment. Fixed commit message typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/new/ https://reviews.llvm.org/D151269 Files: lldb/test/Shell/helper/build.py

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to lldb tests

mysterymath updated this revision to Diff 525282. mysterymath added a comment. Restrict description to Shell tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/new/ https://reviews.llvm.org/D151269 Files:

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to lldb tests

mysterymath added a comment. In D151269#4366484 , @JDevlieghere wrote: > The change itself looks fine, but isn't this an issue for the API tests too? > If so, how is the sys root passed to `dotest.py` and can the shell tests do > the same? Ah, thanks

[Lldb-commits] [lldb] e108638 - [lldb] Disable `watchpoint_callback.test` temporarily on darwin

Author: Med Ismail Bennani Date: 2023-05-24T10:58:40-07:00 New Revision: e1086384e5841e861cd19d5d980394cfcf94ef98 URL: https://github.com/llvm/llvm-project/commit/e1086384e5841e861cd19d5d980394cfcf94ef98 DIFF:

[Lldb-commits] [PATCH] D151351: [lldb] Prevent dwim-print from showing kNoResult error

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Expression evaluation for `void` valued expressions sets an error

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

MaskRay added a comment. Herald added a subscriber: JDevlieghere. Thank you for making another try for the treewide change (which is admittedly very painful and not many people do such work). Can you include the original patch description to the summary? That is the main part and the message

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. I've created D151344 @glandium @hans @thakis I really would appreciate when you can test the patch locally to avoid another revert round. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: glandium, hans, thakis. Herald added subscribers: libc-commits, bviyer, ekilmer, Moerafaat, zero9178, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Michael137 closed this revision. Michael137 added a comment. Committed in https://reviews.llvm.org/rG44bb442fd5be CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151268/new/ https://reviews.llvm.org/D151268 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 44bb442 - [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Author: Michael Buch Date: 2023-05-24T13:01:11+01:00 New Revision: 44bb442fd5be3860e7819cb216621b5ea59970c3 URL: https://github.com/llvm/llvm-project/commit/44bb442fd5be3860e7819cb216621b5ea59970c3 DIFF: https://github.com/llvm/llvm-project/commit/44bb442fd5be3860e7819cb216621b5ea59970c3.diff

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Michael137 updated this revision to Diff 525110. Michael137 added a comment. Fix expected string in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151268/new/ https://reviews.llvm.org/D151268 Files: lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp