[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:52 - void SetSDKRootDirectory(ConstString sdk_root_directory) { -m_sdk_sysroo

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/ https://reviews.llvm.org/D152594 ___

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:21 +def generate_c_header(directory: str, index: int) -> None: +header_path = f"{directory}/obj{index}.h" +with open(header_path, "w") as f: kastiglione wrote: > os.path.join

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:21 +def generate_c_header(directory: str, index: int) -> None: +header_path = f"{directory}/obj{index}.h" +with open(header_path, "w") as f: os.path.join to be windows friendl

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack created this revision. Herald added subscribers: danielkiss, krytarowski. Herald added a project: All. splhack added reviewers: clayborg, labath, lanza, srhines. splhack published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In Android AP

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

bulbazord updated this revision to Diff 530720. bulbazord added a comment. Renamed from `CreateFromDict` to `Create` to be more consistent with the rest of LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack created this revision. Herald added a subscriber: emaste. Herald added a project: All. splhack added reviewers: clayborg, labath, friss, lanza. splhack published this revision for review. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. In Android API level 23

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord updated this revision to Diff 530712. bulbazord marked an inline comment as done. bulbazord added a comment. Address the other suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https://reviews.llvm.org/D151597 Files:

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

This revision was automatically updated to reflect the committed changes. Closed by commit rGf687850de877: [lldb] Change return type of UnixSignals::GetShortName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152582/new/ http

[Lldb-commits] [lldb] f687850 - [lldb] Change return type of UnixSignals::GetShortName

Author: Alex Langford Date: 2023-06-12T16:44:05-07:00 New Revision: f687850de87759fa4a76a883971c2f909ae4d1b9 URL: https://github.com/llvm/llvm-project/commit/f687850de87759fa4a76a883971c2f909ae4d1b9 DIFF: https://github.com/llvm/llvm-project/commit/f687850de87759fa4a76a883971c2f909ae4d1b9.diff

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

bulbazord added a comment. In D152324#4415324 , @jingham wrote: > I wonder about this one. In every instance where the API is used, its result > is turned into a ConstString first. That's because this variable name lives > in the same slot as normal v

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord updated this revision to Diff 530694. bulbazord added a comment. Address Jonas's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https://reviews.llvm.org/D151597 Files: lldb/include/lldb/Core/Debugger.h lldb/includ

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord updated this revision to Diff 530692. bulbazord added a comment. Remove temp variables More multiline string literals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152569/new/ https://reviews.llvm.org/D152569 Files: lldb/scripts/genera

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

This revision was automatically updated to reflect the committed changes. Closed by commit rGf09cca4c6f67: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] f09cca4 - [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

Author: Alex Langford Date: 2023-06-12T14:53:44-07:00 New Revision: f09cca4c6f67c2ab135c391ea8090130c5327c02 URL: https://github.com/llvm/llvm-project/commit/f09cca4c6f67c2ab135c391ea8090130c5327c02 DIFF: https://github.com/llvm/llvm-project/commit/f09cca4c6f67c2ab135c391ea8090130c5327c02.diff

[Lldb-commits] [lldb] 59b5581 - Speculative fix for windows test

Author: Adrian Prantl Date: 2023-06-12T14:51:24-07:00 New Revision: 59b55818337b59f3e75511d9fb2b0b7b5e3d14a7 URL: https://github.com/llvm/llvm-project/commit/59b55818337b59f3e75511d9fb2b0b7b5e3d14a7 DIFF: https://github.com/llvm/llvm-project/commit/59b55818337b59f3e75511d9fb2b0b7b5e3d14a7.diff

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/IOHandler.h:110 + virtual llvm::StringRef GetControlSequence(char ch) { +return llvm::StringRef(); + } I would `return {}` or `return ""`. Comment at: lldb/include/ll

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

jingham added a comment. I don't think we need to support the case where the "end line token" doesn't have to stand on its own line. It's reasonable for lldb to impose this policy, and if we are going to do that then requiring the "\n" after the end line token also seems odd. The way this is

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

jingham added a comment. I wonder about this one. In every instance where the API is used, its result is turned into a ConstString first. That's because this variable name lives in the same slot as normal variable names, which come from the debug information and so tend to be in the ConstStri

[Lldb-commits] [PATCH] D152573: [lldb][NFCI] Remove use of ConstString from Listener

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM, if no one has found a use for this way of filtering by this point, there probably isn't a good one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

lanza accepted this revision. lanza added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152494/new/ https://reviews.llvm.org/D152494

[Lldb-commits] [lldb] 73927d5 - [lldb][test] incomplete-tag-type.cpp: fix expected error message

Author: Michael Buch Date: 2023-06-12T19:33:10+01:00 New Revision: 73927d574f57c1bdf792e2cefe2974b7e9375ed6 URL: https://github.com/llvm/llvm-project/commit/73927d574f57c1bdf792e2cefe2974b7e9375ed6 DIFF: https://github.com/llvm/llvm-project/commit/73927d574f57c1bdf792e2cefe2974b7e9375ed6.diff

[Lldb-commits] [PATCH] D152590: Streamline expression parser error messages

kastiglione added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/source/Interpreter/CommandReturnObject.cpp:104 return; - error(GetErrorStream()) << in_string.rtrim() << '\n'; + // Workaround to deal with already fully formatted compiler diagnosti

[Lldb-commits] [PATCH] D152590: Streamline expression parser error messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG133c3eaac0a5: Streamline expression parser error messages. (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [lldb] 133c3ea - Streamline expression parser error messages.

Author: Adrian Prantl Date: 2023-06-12T10:29:48-07:00 New Revision: 133c3eaac0a532380c3d6ad21a60da1490f51fb8 URL: https://github.com/llvm/llvm-project/commit/133c3eaac0a532380c3d6ad21a60da1490f51fb8 DIFF: https://github.com/llvm/llvm-project/commit/133c3eaac0a532380c3d6ad21a60da1490f51fb8.diff

[Lldb-commits] [PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

dblaikie added a comment. Are there any known (or vague/unknown) limitations on the implementation with respect to the actual output/on-disk representation? (like, would doing some kind of size analysis of the output when using this patch/feature lead to incorrect conclusions about the cost of

[Lldb-commits] [PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

dblaikie added a comment. Really appreciate you providing this prototype. > This solves one of the current weaknesses in DWARF debugging, which is the > inability to set breakpoints or step onto inlined callsites. However, there > are other proposals (such as Location View Numbering) that could

[Lldb-commits] [PATCH] D152590: Streamline expression parser error messages

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152590/new/ https://reviews.llvm.org/D152590 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D152590: Streamline expression parser error messages

aprantl added a comment. pinging after the weekend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152590/new/ https://reviews.llvm.org/D152590 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added reviewers: clayborg, hans. splhack published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb-server for Android does not build with

[Lldb-commits] [PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

aprantl added a comment. Thanks for prototyping this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152708/new/ https://reviews.llvm.org/D152708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

DavidSpickett added a comment. If you wanted to indent the long strings to the same level as the function's code you could use https://docs.python.org/3/library/textwrap.html#textwrap.dedent (but it's fine as is). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

StephenTozer created this revision. StephenTozer added a project: debug-info. Herald added subscribers: ormris, hiraditya. Herald added a project: All. StephenTozer requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, jplehr, sstefan1, MaskRay. Hera