[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo code duplication. Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:3639-3644 + struct proc_bsdshortinfo proc; + int ppid = 0; + if

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

bulbazord added a comment. In D149213#4491889 , @VladimirMakaev wrote: > In D149213#4491594 , @bulbazord > wrote: > >> I'm curious to know why you don't try and implement some kind of >> `TypeSystemRust`? I

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 539359. kastiglione added a comment. Change `bool IsSwift()` to `LanguageType GetImplementationLanguage()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 Files:

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. On Darwin, we first get a

[Lldb-commits] [PATCH] D155035: [lldb][NFCI] Remove unneeded temporary std::string allocations in SBAPI

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This uses some friend class trickery to avoid some

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

jasonmolenda added a comment. I have no experience with the linux support so I'm not an ideal person to review, but when I was reading about watchpoints I saw the caveats about SSVE mode and false watchpoint hits so I read through the patch out of curiosity about SME/SSVE. You mention a

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added inline comments. Comment at: lldb/source/API/SBPlatform.cpp:664-689 + if (platform_sp) { +if (callback) { + platform_sp->SetLocateModuleCallback( + [callback, callback_baton](const ModuleSpec _spec, + FileSpec

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack updated this revision to Diff 539351. splhack added a comment. update SetLocateModuleCallback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:884-887 + typedef std::function + LocateModuleCallback; clayborg wrote: > I think we still need a baton for the callback so clients can register a > callback + void *. Yes,

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

bulbazord added inline comments. Comment at: lldb/source/API/SBPlatform.cpp:664-689 + if (platform_sp) { +if (callback) { + platform_sp->SetLocateModuleCallback( + [callback, callback_baton](const ModuleSpec _spec, +

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. @clayborg yes, it'd be possible to pass the baton down to Platform.h since it is just `void *`, so no dependencies required. But, first, let me explain the callback and baton flow. For Python, user will set a callable Python object as the callback. For C++ API,

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

VladimirMakaev added a comment. In D149213#4491594 , @bulbazord wrote: > I'm curious to know why you don't try and implement some kind of > `TypeSystemRust`? I assume it's going to be a lengthy process, but eventually > you (or somebody else) is going

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

clayborg added a comment. In D149213#4491594 , @bulbazord wrote: > I'm curious to know why you don't try and implement some kind of > `TypeSystemRust`? I assume it's going to be a lengthy process, but eventually > you (or somebody else) is going to

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:944 const std::unique_ptr m_module_cache; + LocateModuleCallback m_locate_module_callback; clayborg wrote: > We probably need a baton still. In order to make this work for

[Lldb-commits] [PATCH] D155030: [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D155018: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 5)

MaskRay added a comment. Still, would be good to land the lldb commit separately. And ensure that you have performed the last-minute testing... Ensure that projects like `flang bolt` still build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

clayborg added a comment. It would be nice to pass the baton down into the platform layer if possible so that internal users could use the callback + baton. See comments in the other diff and see if you agree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

bulbazord added a comment. I'm curious to know why you don't try and implement some kind of `TypeSystemRust`? I assume it's going to be a lengthy process, but eventually you (or somebody else) is going to want to implement a `TypeSystemRust` in some form and they'll have to revisit all of

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

clayborg added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:884-887 + typedef std::function + LocateModuleCallback; I think we still need a baton for the callback so clients can register a callback + void *. Comment

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3184 +case DW_TAG_variant_part: + ParseVariantPart(die, parent_die, class_clang_type, default_accessibility, + layout_info);

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

clayborg added a comment. Overall this looks fine as a way to help rust users see rust enums without having to implement a new TypeSystem for rust. I would just ask that we check the language of the CU before calling the ParseVariantPart, so that this would only get enabled for Rust.

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti marked an inline comment as done. ashgti added a comment. In D154030#4491470 , @rastogishubham wrote: > I am reverting the change for now, I apologize for any inconvenience Thanks for reverting that, I'll take a look at the tests and double

[Lldb-commits] [lldb] 78af051 - Revert "[lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands."

Author: Shubham Sandeep Rastogi Date: 2023-07-11T15:16:03-07:00 New Revision: 78af051ff0e16db73201b1370e34206a6a4c1b93 URL: https://github.com/llvm/llvm-project/commit/78af051ff0e16db73201b1370e34206a6a4c1b93 DIFF:

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

rastogishubham added a comment. I am reverting the change for now, I apologize for any inconvenience Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 ___

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

rastogishubham added a comment. It looks like this change is breaking some lldb tests. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/57586/consoleFull#-1731262255a1ca8a51-895e-46c6-af87-ce24fa4cd561 - TEST 'lldb-api :: tools/lldb-vscode/console/TestVSCode_console.py' FAILED

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

bulbazord added a comment. My concerns have been addressed, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti updated this revision to Diff 539304. ashgti added a comment. Applying clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 Files: lldb/tools/lldb-vscode/JSONUtils.cpp

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti updated this revision to Diff 539302. ashgti added a comment. Removing the focus_tid invalidation on the continue event, that was incorrectly setting the focus_tid to 0 for all continue events. Instead allow the existing logic in the SendThreadStoppedEvent to infer the correct focus_tid

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione added a comment. @bulbazord @augusto2112 hopefully this is a quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 ___ lldb-commits

[Lldb-commits] [PATCH] D155018: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 5)

IncludeGuardian added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:17 #include "llvm/Support/FormatVariadic.h" #if defined(_WIN32) #define NOMINMAX This should be the final failure on the last time

[Lldb-commits] [PATCH] D155018: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 5)

IncludeGuardian created this revision. IncludeGuardian added a reviewer: MaskRay. Herald added a subscriber: hiraditya. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. **1st

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

dgoldman added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:285 if (num_threads_with_reason == 0) { lldb::SBThread thread = process.GetThreadAtIndex(0); g_vsc.SendJSON(CreateThreadStopped(thread, stop_id)); Should

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rG16317f1ced77: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl… (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 16317f1 - [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

Author: John Harrison Date: 2023-07-11T16:37:25-04:00 New Revision: 16317f1ced77e1d8711188f2fcc6c86a783d9c56 URL: https://github.com/llvm/llvm-project/commit/16317f1ced77e1d8711188f2fcc6c86a783d9c56 DIFF: https://github.com/llvm/llvm-project/commit/16317f1ced77e1d8711188f2fcc6c86a783d9c56.diff

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 539268. kastiglione added a comment. Refactor for better API layering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 Files:

[Lldb-commits] [PATCH] D154990: [lldb-vsocde] Cleaning up the usage of the Separate helper in Options.td.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. wooo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154990/new/ https://reviews.llvm.org/D154990

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030

[Lldb-commits] [PATCH] D154992: Add a generic Process method to dump plugin history

This revision was automatically updated to reflect the committed changes. Closed by commit rG8402ad23104b: Add a generic Process method to dump plugin history. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154992/new/

[Lldb-commits] [lldb] 8402ad2 - Add a generic Process method to dump plugin history.

Author: Jim Ingham Date: 2023-07-11T12:33:22-07:00 New Revision: 8402ad23104b6b20f07596738b02a4ab101a8af9 URL: https://github.com/llvm/llvm-project/commit/8402ad23104b6b20f07596738b02a4ab101a8af9 DIFF: https://github.com/llvm/llvm-project/commit/8402ad23104b6b20f07596738b02a4ab101a8af9.diff

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 539238. splhack added a comment. - Rename 'get module callback' to 'locate module callback' - SBPlatform will do - capture callback(SBPlatformLocateModuleCallback) and baton(void *) - convert ModuleSpec/FileSpec from/to SBModuleSpec/SBFileSpec for calling

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack marked 3 inline comments as done. splhack added a comment. SBPlatform API and Python will use SBPlatformLocateModuleCallback type. typedef SBError (*SBPlatformLocateModuleCallback)( void *baton, const SBModuleSpec _spec, SBFileSpec _file_spec, SBFileSpec

[Lldb-commits] [PATCH] D154992: Add a generic Process method to dump plugin history

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah excellent, thanks for adding this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154992/new/ https://reviews.llvm.org/D154992

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 539213. splhack added a comment. - Rename 'get module callback' to 'locate module callback' - Enable C++ callback aside from Python callback - Introduce LocateModuleCallback typedef to use std::function in order to capture callback and baton, to convert

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

mib added a comment. LGTM with @clayborg comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack updated this revision to Diff 539207. splhack added a comment. sync with D153734 and D153735 changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/

[Lldb-commits] [PATCH] D154992: Add a generic Process method to dump plugin history

jingham created this revision. jingham added reviewers: jasonmolenda, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I need to dump the gdb-remote communication history when we fail the

[Lldb-commits] [PATCH] D154990: [lldb-vsocde] Cleaning up the usage of the Separate helper in Options.td.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154990 Files: lldb/tools/lldb-vscode/Options.td

[Lldb-commits] [PATCH] D154883: [lldb][NFCI] Methods to load scripting resources should take a Stream by reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d796b48e4d4: [lldb][NFCI] Methods to load scripting resources should take a Stream by… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1d796b4 - [lldb][NFCI] Methods to load scripting resources should take a Stream by reference

Author: Alex Langford Date: 2023-07-11T10:36:11-07:00 New Revision: 1d796b48e4d48bd0e4b29972a1b8d653493ee30c URL: https://github.com/llvm/llvm-project/commit/1d796b48e4d48bd0e4b29972a1b8d653493ee30c DIFF: https://github.com/llvm/llvm-project/commit/1d796b48e4d48bd0e4b29972a1b8d653493ee30c.diff

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti updated this revision to Diff 539185. ashgti added a comment. Herald added a subscriber: JDevlieghere. Applying clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 Files:

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When the process is contiuned using an lldb command expression the thread state in VS Code is never informed and will be out

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti marked 2 inline comments as done. ashgti added inline comments. Comment at: lldb/tools/lldb-vscode/Options.td:20-38 +def port: S<"port">, MetaVarName<"">, HelpText<"Communicate with the lldb-vscode tool over the defined port.">; def: Separate<["-"], "p">, Alias,

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 539182. ashgti marked an inline comment as done. ashgti added a comment. Apply clang-format and split out some parts of this into smaller commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/

[Lldb-commits] [PATCH] D154890: [lldb][NFCI] Avoid construction of temporary std::strings in Variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7c48ffde1c8: [lldb][NFCI] Avoid construction of temporary std::strings in Variable (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e7c48ff - [lldb][NFCI] Avoid construction of temporary std::strings in Variable

Author: Alex Langford Date: 2023-07-11T10:22:02-07:00 New Revision: e7c48ffde1c8137822a1b0a1ba6c4be5b4624aa6 URL: https://github.com/llvm/llvm-project/commit/e7c48ffde1c8137822a1b0a1ba6c4be5b4624aa6 DIFF: https://github.com/llvm/llvm-project/commit/e7c48ffde1c8137822a1b0a1ba6c4be5b4624aa6.diff

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

DavidSpickett added a comment. > SIMD registers must be read and written via the SVE regset when in SSVE mode. > Writing to them exits streaming mode. In my testing it did actually work if you always used the current mode. I think that's an artifact of QEMU or the kernel's implementation

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Feel free to bombard me with questions about SME, if it's quicker than reading the entire spec yourself. It has some quirks to it for sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This changes the TLS regset to not only be dynamic in that it could

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. Software can tell if it is in streaming SVE

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. The Scalable Matrix Extension (SME) adds a new