[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f4a0c762fe2: hi/low addr space bits can be sent in stop-rely packet (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158041/new/ h

[Lldb-commits] [lldb] 6f4a0c7 - hi/low addr space bits can be sent in stop-rely packet

Author: Jason Molenda Date: 2023-08-16T16:12:18-07:00 New Revision: 6f4a0c762fe2c0077865e0e30e3dfd67cd6287d1 URL: https://github.com/llvm/llvm-project/commit/6f4a0c762fe2c0077865e0e30e3dfd67cd6287d1 DIFF: https://github.com/llvm/llvm-project/commit/6f4a0c762fe2c0077865e0e30e3dfd67cd6287d1.diff

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda updated this revision to Diff 550924. jasonmolenda added a comment. Updated back to my most recent version of this patch, thanks for the help all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155905/new/ https://reviews.llvm.org/D1559

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158041/new/ https://reviews.llvm.org/D158041 _

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda updated this revision to Diff 550919. jasonmolenda added a comment. Update patch to remove the HasValue/IsValue and Clear methods from AddressableBits. Change methods that may fill in an AddressableBits object with values to return an AddressableBits object unconditionally. Change

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. ah dangit, I meant to update the patch in https://reviews.llvm.org/D158041 and accidentally blew away the last patch I had for this one. let's see if I can extract it from here somehow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda updated this revision to Diff 550917. jasonmolenda added a comment. Update patch to remove the HasValue/IsValue and Clear methods from AddressableBits. Change methods that may fill in an AddressableBits object with values to return an AddressableBits object unconditionally. Change

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

JDevlieghere added a comment. In D158041#4593205 , @jasonmolenda wrote: > Update patch to change the `AddressableBits::IsValid` to > `AddressableBits::HasValue` which is a clearer description. The `IsValid` > methods are used across the lldb_private c

[Lldb-commits] [PATCH] D158024: [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f382bfb14e3: [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath (authored by bulbazord). Repository: rG LLVM Github Mo

[Lldb-commits] [lldb] 2f382bf - [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath

Author: Alex Langford Date: 2023-08-16T14:23:58-07:00 New Revision: 2f382bfb14e38429e69885406ae8cedc9bb3028e URL: https://github.com/llvm/llvm-project/commit/2f382bfb14e38429e69885406ae8cedc9bb3028e DIFF: https://github.com/llvm/llvm-project/commit/2f382bfb14e38429e69885406ae8cedc9bb3028e.diff

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi added a comment. In D157059#4572809 , @Michael137 wrote: > Hi, this is failing on swift-ci (runs on x86 bots) with the following error: > > > /Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/build/Ninja-ReleaseAssert+stdli

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:62-64 +void AddressableBits::Clear() { + m_low_memory_addr_bits = m_high_memory_addr_bits = 0; +} JDevlieghere wrote: > jasonmolenda wrote: > > jasonmolenda wrote: > > > JDev

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

JDevlieghere added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:62-64 +void AddressableBits::Clear() { + m_low_memory_addr_bits = m_high_memory_addr_bits = 0; +} jasonmolenda wrote: > jasonmolenda wrote: > > JDevlieghere wrote: > > > Wher

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda updated this revision to Diff 550868. jasonmolenda added a comment. Update patch to change the `AddressableBits::IsValid` to `AddressableBits::HasValue` which is a clearer description. The `IsValid` methods are used across the lldb_private classes everywhere. I tried changing thi

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:62-64 +void AddressableBits::Clear() { + m_low_memory_addr_bits = m_high_memory_addr_bits = 0; +} jasonmolenda wrote: > JDevlieghere wrote: > > Where is this called? > Hm. W

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:58-60 +bool AddressableBits::IsValid() { + return m_low_memory_addr_bits != 0 || m_high_memory_addr_bits != 0; +} JDevlieghere wrote: > Please implement `operator bool()` ins

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

JDevlieghere added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:58-60 +bool AddressableBits::IsValid() { + return m_low_memory_addr_bits != 0 || m_high_memory_addr_bits != 0; +} Please implement `operator bool()` instead. =

[Lldb-commits] [lldb] d268ba3 - Test follow-up to 2e7aa2ee34eb53347396731dc8a3b2dbc6a3df45

Author: Jim Ingham Date: 2023-08-16T12:19:07-07:00 New Revision: d268ba38083cd7c9c4f55cb0792d4a0db1d4768b URL: https://github.com/llvm/llvm-project/commit/d268ba38083cd7c9c4f55cb0792d4a0db1d4768b DIFF: https://github.com/llvm/llvm-project/commit/d268ba38083cd7c9c4f55cb0792d4a0db1d4768b.diff LO

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

mib accepted this revision. mib added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Good catch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord updated this revision to Diff 550824. bulbazord added a comment. Remove `const` from parameter in DebugMapModule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043 Files: lldb/include/lldb/Core/M

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord updated this revision to Diff 550822. bulbazord added a comment. Give the parameter a default value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043 Files: lldb/include/lldb/Core/Module.h lld

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Module.h:126 Module( - const FileSpec &file_spec, const ArchSpec &arch, - const ConstString *object_name = nullptr, + const FileSpec &file_spec, const ArchSpec &arch, ConstString object_name,

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

fdeazeve added inline comments. Comment at: lldb/include/lldb/Core/Module.h:126 Module( - const FileSpec &file_spec, const ArchSpec &arch, - const ConstString *object_name = nullptr, + const FileSpec &file_spec, const ArchSpec &arch, ConstString object_name,

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

mib added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:806 + target.GetArchitecture(), + ConstString()); }

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord updated this revision to Diff 550812. bulbazord added a comment. Addressing @aprantl's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043 Files: lldb/include/lldb/Core/Module.h lldb/so

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7aa2ee34eb: Replace the singleton "ShadowListener" with a primary and N secondary Listeners (authored by jingham). C

[Lldb-commits] [lldb] 2e7aa2e - Replace the singleton "ShadowListener" with a primary and N secondary Listeners

Author: Jim Ingham Date: 2023-08-16T10:35:32-07:00 New Revision: 2e7aa2ee34eb53347396731dc8a3b2dbc6a3df45 URL: https://github.com/llvm/llvm-project/commit/2e7aa2ee34eb53347396731dc8a3b2dbc6a3df45 DIFF: https://github.com/llvm/llvm-project/commit/2e7aa2ee34eb53347396731dc8a3b2dbc6a3df45.diff LO

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. Thanks for all the work to clean up some of those interfaces! I know that was not straightforward. :) I left a few more comments about minor things I noticed while re-reading t

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies updated this revision to Diff 550795. electriclilies added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/ https://reviews.llvm.org/D158010 Files: lldb/include/lldb/DataFormatters/TypeSynthetic.h lldb/so

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

bulbazord accepted this revision. bulbazord added a comment. This is in line with my understanding of cross-compiling LLDB. It could be useful to also document some other interesting cross-compilation options like `CMAKE_TOOLCHAIN_FILE` or mention the use of CMake caches, but if you're unfamili

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with Alex' comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157851/new/ https://reviews.llvm.org/D157851 ___

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

JDevlieghere updated this revision to Diff 550791. JDevlieghere added a comment. - Rename "Extending LLDB" to "Scripting LLDB". - Move "DWARF Extensions" to the developer section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158023/new/ https://reviews.llvm.org/D158023 Files: lldb/d

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

This revision was automatically updated to reflect the committed changes. Closed by commit rG5afa519c1ae9: [lldb] Print better error message when sphinx_automodapi is not installed (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 5afa519 - [lldb] Print better error message when sphinx_automodapi is not installed

Author: Jonas Devlieghere Date: 2023-08-16T09:14:42-07:00 New Revision: 5afa519c1ae9e17c3ac556b7ed42ab96b487ef0f URL: https://github.com/llvm/llvm-project/commit/5afa519c1ae9e17c3ac556b7ed42ab96b487ef0f DIFF: https://github.com/llvm/llvm-project/commit/5afa519c1ae9e17c3ac556b7ed42ab96b487ef0f.d

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

aprantl added inline comments. Comment at: lldb/include/lldb/Core/Module.h:127 const FileSpec &file_spec, const ArchSpec &arch, - const ConstString *object_name = nullptr, - lldb::offset_t object_offset = 0, + const ConstString object_name, lldb::offset_t ob

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. At the moment, the TargetParser architecture is extensible. This complicates the addition of new architectures, operating systems, and so on. In the main discussion, it was proposed to redesign the architecture of this module in order to increase the possibility of adding

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158085/new/ https://reviews.llvm.org/D158085 ___

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 550769. DavidSpickett added a comment. Correct regiter -> register in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Proc

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett added reviewers: JDevlieghere, bulbazord. DavidSpickett added a comment. I've confirmed the instructions work for x86 -> AArch64. The original issue was x86 -> Arm 32 bit, so I hope to get the issue reporter to confirm whether the instructions make sense with this change. Reposit

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To address https://github.com/llvm/llvm-project/issues/64616, this cha

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

fdeazeve added a comment. In D158023#4590502 , @bulbazord wrote: > I think the categories you've set are the same ones I would have created. May > I suggest renaming `Extending LLDB` to `Scripting LLDB` or something similar? > I think "Extending" and "D

[Lldb-commits] [PATCH] D157960: [lldb][gui] Update TreeItem children's m_parent on move

This revision was automatically updated to reflect the committed changes. Closed by commit rG83695d45d621: [lldb][gui] Update TreeItem children's m_parent on move (authored by kpdev42). Changed prior to commit: https://reviews.llvm.org/D157960?vs=550240&id=550655#toc Repository: rG LLVM Gith

[Lldb-commits] [lldb] 83695d4 - [lldb][gui] Update TreeItem children's m_parent on move

Author: Pavel Kosov Date: 2023-08-16T11:10:00+03:00 New Revision: 83695d45d62121ab306d0dc108b549d9056a2f28 URL: https://github.com/llvm/llvm-project/commit/83695d45d62121ab306d0dc108b549d9056a2f28 DIFF: https://github.com/llvm/llvm-project/commit/83695d45d62121ab306d0dc108b549d9056a2f28.diff L