[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

hawkinsw added a comment. I hope that some comments are helpful! The documentation that you added is tremendously helpful -- I know how documentation is sometimes a thankless task, so I will say what everyone is thinking: "THANK YOU". Comment at:

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/StructuredData.h:448 - if (!key.empty()) { -ConstString key_cs(key); -collection::const_iterator iter = m_dict.find(key_cs);

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG764287f1ad69: [lldb] Add support for recognizing swift ast sections in object files (authored by bulbazord). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 764287f - [lldb] Add support for recognizing swift ast sections in object files

Author: Alex Langford Date: 2023-08-31T15:16:12-07:00 New Revision: 764287f1ad69469cc264bb094e8fcdcfdd0fcdfb URL: https://github.com/llvm/llvm-project/commit/764287f1ad69469cc264bb094e8fcdcfdd0fcdfb DIFF: https://github.com/llvm/llvm-project/commit/764287f1ad69469cc264bb094e8fcdcfdd0fcdfb.diff

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

fdeazeve added inline comments. Comment at: lldb/include/lldb/Utility/StructuredData.h:436 auto array_sp = std::make_shared(); - collection::const_iterator iter; - for (iter = m_dict.begin(); iter != m_dict.end(); ++iter) { + for (auto iter =

[Lldb-commits] [PATCH] D159234: [llvm-objdump] Enable assembly highlighting in llvm-objdump

JDevlieghere abandoned this revision. JDevlieghere added a comment. Merged with D159224 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159234/new/ https://reviews.llvm.org/D159234 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduce an `OperatingSystem` base implementation in the `lldb` python

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make us it

mib created this revision. mib added reviewers: JDevlieghere, jingham, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch aims to consolidate the OperatingSystem scripting affordance by

[Lldb-commits] [PATCH] D159310: [lldb] Move template python files to separate directory

bulbazord added a comment. This looks fine to me. You'll probably want to wait for @JDevlieghere to take a look though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159310/new/ https://reviews.llvm.org/D159310

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a subscriber: mgrang. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The remaining use

[Lldb-commits] [PATCH] D159310: [lldb] Move template python files to separate directory

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch moves the template files for the various scripting affordances to a separate

[Lldb-commits] [lldb] c9ecaf3 - [lldb] Fix test failure for breakpoint_function_callback.test

Author: Med Ismail Bennani Date: 2023-08-31T22:19:02+01:00 New Revision: c9ecaf32f6aa92f79a054478df55b4b8c3e53697 URL: https://github.com/llvm/llvm-project/commit/c9ecaf32f6aa92f79a054478df55b4b8c3e53697 DIFF:

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 555155. ted marked an inline comment as done. ted added a comment. Implement Jason Molenda's request to use an ivar instead of static variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159101/new/

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC` or refactoring, adding documentation etc..) Add your unit tests in

[Lldb-commits] [lldb] 6813ef3 - Re-land "[lldb/docs] Silence warnings when generating website"

Author: Med Ismail Bennani Date: 2023-08-31T20:35:10+01:00 New Revision: 6813ef37377e8d8fadf6efe01e1ed80cc53b9c86 URL: https://github.com/llvm/llvm-project/commit/6813ef37377e8d8fadf6efe01e1ed80cc53b9c86 DIFF:

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added a comment. In D159101#4627705 , @DavidSpickett wrote: > Great. Could you include that in the commit message? Seems like we get a lot > of questions about how mature risc-v support is, so we can point to this as a > milestone for that. Will

[Lldb-commits] [PATCH] D159237: [lldb][NFCI] Remove unneeded ConstString conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14d95b26aee0: [lldb][NFCI] Remove unneeded ConstString conversions (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 14d95b2 - [lldb][NFCI] Remove unneeded ConstString conversions

Author: Alex Langford Date: 2023-08-31T11:27:59-07:00 New Revision: 14d95b26aee0ac0ac8a70252e8a3c7a986e0e812 URL: https://github.com/llvm/llvm-project/commit/14d95b26aee0ac0ac8a70252e8a3c7a986e0e812 DIFF: https://github.com/llvm/llvm-project/commit/14d95b26aee0ac0ac8a70252e8a3c7a986e0e812.diff

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

clayborg added a comment. We shouldn't need to pass in "bool use_color" to the Disassembler creation functions as the only reason to pass something to the creation function for any plug-in is if that data would exclude a disassembler if it didn't support color. But we always want to see some

[Lldb-commits] [PATCH] D159150: [lldb][NFCI] Replace bespoke iterator check with std::next

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed72d4d4d50: [lldb][NFCI] Replace bespoke iterator check with std::next (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 9ed72d4 - [lldb][NFCI] Replace bespoke iterator check with std::next

Author: Alex Langford Date: 2023-08-31T10:55:00-07:00 New Revision: 9ed72d4d4d507b60a54f6b74e86433f837ded93c URL: https://github.com/llvm/llvm-project/commit/9ed72d4d4d507b60a54f6b74e86433f837ded93c DIFF: https://github.com/llvm/llvm-project/commit/9ed72d4d4d507b60a54f6b74e86433f837ded93c.diff

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c215e8a8af: Fix shared library loading when users define duplicate _r_debug structure. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 07c215e - Fix shared library loading when users define duplicate _r_debug structure.

Author: Greg Clayton Date: 2023-08-31T10:37:20-07:00 New Revision: 07c215e8a8af54d0084af7291ac29fef3672fcd8 URL: https://github.com/llvm/llvm-project/commit/07c215e8a8af54d0084af7291ac29fef3672fcd8 DIFF: https://github.com/llvm/llvm-project/commit/07c215e8a8af54d0084af7291ac29fef3672fcd8.diff

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158833/new/ https://reviews.llvm.org/D158833 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added a comment. > add a way to make an SBTypeSynthetic from the appropriate C++ class That's a great idea. Once we implement a couple of providers for our plugin I'll revisit the idea. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

ldionne added a comment. Herald added subscribers: wangpc, gysit, Dinistro, hoy, bviyer, wlei, jplehr, PiotrZSL, luke, sunshaoce. Herald added a reviewer: springerm. Herald added a reviewer: kiranchandramohan. Herald added a project: clang-format. Herald added reviewers: rymiel,

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne commandeered this revision. ldionne added a reviewer: t-tye. ldionne added a comment. Herald added a subscriber: jplehr. Herald added a project: All. [GitHub PR transition cleanup] This has been open for 2 years with multiple subscribers able to see this discussion, but there doesn't

[Lldb-commits] [lldb] 380c5da - Revert "Re-land "[lldb/docs] Silence warnings when generating website""

Author: Med Ismail Bennani Date: 2023-08-31T16:31:10+01:00 New Revision: 380c5da98efa62920e9fbf3aa9a4fa8add236fb9 URL: https://github.com/llvm/llvm-project/commit/380c5da98efa62920e9fbf3aa9a4fa8add236fb9 DIFF:

[Lldb-commits] [PATCH] D159150: [lldb][NFCI] Replace bespoke iterator check with std::next

fdeazeve accepted this revision. fdeazeve added a comment. Nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159150/new/ https://reviews.llvm.org/D159150 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 554993. DavidSpickett added a comment. Herald added a subscriber: sunshaoce. As for the SVE test, the sync variables don't need to be atomic. Each one has one writer and one reader only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

mib updated this revision to Diff 554991. mib marked an inline comment as done. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158833/new/ https://reviews.llvm.org/D158833 Files:

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

This revision was automatically updated to reflect the committed changes. Closed by commit rG22044f0bde01: [lldb][AArch64] Add testing of save/restore for Linux MTE control register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 22044f0 - [lldb][AArch64] Add testing of save/restore for Linux MTE control register

Author: David Spickett Date: 2023-08-31T12:25:08+01:00 New Revision: 22044f0bde015f4bf53fca24831d030ff96efc51 URL: https://github.com/llvm/llvm-project/commit/22044f0bde015f4bf53fca24831d030ff96efc51 DIFF:

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rG6697afe99fb6: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test (authored by DavidSpickett).

[Lldb-commits] [lldb] 6697afe - [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

Author: David Spickett Date: 2023-08-31T10:21:53+01:00 New Revision: 6697afe99fb6df08d4c1903eb1df5446f2ec1993 URL: https://github.com/llvm/llvm-project/commit/6697afe99fb6df08d4c1903eb1df5446f2ec1993 DIFF:

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. > The only area of concern could be a LLDB running on a resource constrained > container but we can ignore that for now. Ironically we're the ones who are most likely to see that issue :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added a comment. In D156687#4628743 , @DavidSpickett wrote: > First thing to note is that WriteRegister also behaves this way, but there it > is more appropriate because it updates only part of the buffer before writing > it out in its

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett added a comment. The only way to know this truly works is to observe it on the bot for a while and I'm already piling too many reviews on Omair as it is. So I've gone ahead and landed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0407f681a7ef: [lldb][AArch64] Use atomics to sync threads in SVE threading test (authored by DavidSpickett). Repository:

[Lldb-commits] [lldb] 0407f68 - [lldb][AArch64] Use atomics to sync threads in SVE threading test

Author: David Spickett Date: 2023-08-31T10:06:16+01:00 New Revision: 0407f681a7efa61f81f885e186c25ed99aecb8d4 URL: https://github.com/llvm/llvm-project/commit/0407f681a7efa61f81f885e186c25ed99aecb8d4 DIFF:

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett updated this revision to Diff 554938. DavidSpickett added a comment. Actually these don't need to be atomic. They aren't writing to the same locations we just have one writer and one reader, and if the reader is delayed a bit it's not a problem. The volatile isn't needed at -O0

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I understand the mechanism now, so for lack of any other strong opinions, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION