[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

2023-09-05 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 555822. DavidSpickett added a comment. Rename as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 Files: lldb/source/Plugins/SymbolFile/DWARF/Symbol

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

2023-09-05 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 555827. DavidSpickett added a comment. In the fallback, only check binary dir + dwo name if the dwo name is relative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

2023-09-05 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1808-1810 +FileSpec dwo_name_next_to_binary(next_to_binary); +dwo_name_next_to_binary.AppendPathComponent(dwo_name); +dwo_paths.Append(dwo_name_next_to_binary); -

[Lldb-commits] [lldb] f6b6234 - [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos

2023-09-05 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-05T10:03:50+01:00 New Revision: f6b6234d14d2fa379a1f2d6b54259cac89a7fc73 URL: https://github.com/llvm/llvm-project/commit/f6b6234d14d2fa379a1f2d6b54259cac89a7fc73 DIFF: https://github.com/llvm/llvm-project/commit/f6b6234d14d2fa379a1f2d6b54259cac89a7fc73.diff

[Lldb-commits] [PATCH] D157845: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos

2023-09-05 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf6b6234d14d2: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65311: The main way I cross build lldb is to point CMake at an existing host build to get the native tablegen tools. This is what we had documented before. There is another option where you start from scratch an

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: This isn't worth documenting but just for review background, you end up with these tools: ``` $ ls /work/open_source/test_lldb_cross/NATIVE/bin/ clang-tblgen lldb-tblgen llvm-config llvm-lit llvm-min-tblgen llvm-tblgen ``` Previous update to these docs was https://revi

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also, Github is able to preview the rst which is very nice for review. https://github.com/llvm/llvm-project/pull/65311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65311: >From e310a8a41688f1e3eff9a39e38b4c954b1316851 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 5 Sep 2023 11:22:38 +0100 Subject: [PATCH] [lldb][Docs] Add simpler "automatic" cross-compile option

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65332: We have docs about how to use lldb on other programs, this tells you how to use lldb on ldlb and lldb-server. Lacking any Mac experience I've not included any debugserver information apart from stating i

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: For some reason I can't add the `pr-subscribers-lldb` team to this, but maybe I'm not supposed to be able to. https://github.com/llvm/llvm-project/pull/65332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread David Spickett via lldb-commits
@@ -0,0 +1,254 @@ +Debugging LLDB +== + +This page details various ways to debug LLDB itself and other LLDB tools. If +you want to know how to use LLDB in general, please refer to +:doc:`/use/tutorial`. + +As LLDB is generally split into 2 tools, ``lldb`` and ``lldb-se

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,254 @@ +Debugging LLDB JDevlieghere wrote: Before the reshuffle of the pages, there were a handful of pages that had "LLDB" in their title, something like "Building LLDB" or "Testing LLDB", I don't remember. This page is somewhat different, because p

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,254 @@ +Debugging LLDB +== + +This page details various ways to debug LLDB itself and other LLDB tools. If +you want to know how to use LLDB in general, please refer to +:doc:`/use/tutorial`. + +As LLDB is generally split into 2 tools, ``lldb`` and ``lldb-se

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,254 @@ +Debugging LLDB +== + +This page details various ways to debug LLDB itself and other LLDB tools. If +you want to know how to use LLDB in general, please refer to +:doc:`/use/tutorial`. + +As LLDB is generally split into 2 tools, ``lldb`` and ``lldb-se

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,254 @@ +Debugging LLDB +== + +This page details various ways to debug LLDB itself and other LLDB tools. If +you want to know how to use LLDB in general, please refer to +:doc:`/use/tutorial`. + +As LLDB is generally split into 2 tools, ``lldb`` and ``lldb-se

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/65311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

2023-09-05 Thread Louis Dionne via Phabricator via lldb-commits
ldionne added a comment. (sorry, no idea why it says "this revision is now accepted and ready to land on my behalf, I was just removing the libc++ review group to clear our review queue) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ h

[Lldb-commits] [lldb] d227c8a - Add missing nullptr check.

2023-09-05 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2023-09-05T09:48:06-07:00 New Revision: d227c8a1200081fdab14e93165927787544c5f12 URL: https://github.com/llvm/llvm-project/commit/d227c8a1200081fdab14e93165927787544c5f12 DIFF: https://github.com/llvm/llvm-project/commit/d227c8a1200081fdab14e93165927787544c5f12.diff

[Lldb-commits] [PATCH] D159408: Switch over to using the LLVM archive parser for BSD archives.

2023-09-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Overall this looks good, but instead of consuming all the errors, let's log them with `LLDB_LOG_ERROR`. Note that the API is a bit tricky and still requires you to provide a format string: LLDB_LOG_ERROR(GetLog(LLDBLog::Object), something.takeError(), "context b

[Lldb-commits] [lldb] be0e42c - [lldb][Plugins] Reflect structure changes in ObjectContainer

2023-09-05 Thread Antonio Frighetto via lldb-commits
Author: Antonio Frighetto Date: 2023-09-05T19:13:43+02:00 New Revision: be0e42c16b8cfb59d5e8e3527141cd7f4931cd17 URL: https://github.com/llvm/llvm-project/commit/be0e42c16b8cfb59d5e8e3527141cd7f4931cd17 DIFF: https://github.com/llvm/llvm-project/commit/be0e42c16b8cfb59d5e8e3527141cd7f4931cd17.d

[Lldb-commits] [lldb] [lldb][Docs] Add simpler "automatic" cross-compile option to build docs (PR #65311)

2023-09-05 Thread via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM! Big fan of removing the "just" everywhere, I definitely agree that everyone's perspective is different;. https://github.com/llvm/llvm-project/pull/65311 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread via lldb-commits
@@ -0,0 +1,254 @@ +Debugging LLDB +== + +This page details various ways to debug LLDB itself and other LLDB tools. If +you want to know how to use LLDB in general, please refer to +:doc:`/use/tutorial`. + +As LLDB is generally split into 2 tools, ``lldb`` and ``lldb-se

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread via lldb-commits
@@ -0,0 +1,254 @@ +Debugging LLDB +== + +This page details various ways to debug LLDB itself and other LLDB tools. If +you want to know how to use LLDB in general, please refer to +:doc:`/use/tutorial`. + +As LLDB is generally split into 2 tools, ``lldb`` and ``lldb-se

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread via lldb-commits
https://github.com/bulbazord commented: Generally seems good to me. Thanks for taking the time to write this up. https://github.com/llvm/llvm-project/pull/65332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb][Docs] Add page about debugging lldb itself (PR #65332)

2023-09-05 Thread via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/65332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

lldb-commits@lists.llvm.org

2023-09-05 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-05T10:53:56-07:00 New Revision: 5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9 URL: https://github.com/llvm/llvm-project/commit/5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9 DIFF: https://github.com/llvm/llvm-project/commit/5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9.diff

lldb-commits@lists.llvm.org

2023-09-05 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5bff905c0de5: [lldb][NFCI] Remove unused method TypeCategoryMap::Get(uint32_t, ValueSP &) (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

2023-09-05 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1747-1754 if (!comp_dir) { unit.SetDwoError(Status::createWithFormat( "unable to locate relative .dwo debug file \"{0}\" for " "skeleton DIE {1:x

[Lldb-commits] [PATCH] D159408: Switch over to using the LLVM archive parser for BSD archives.

2023-09-05 Thread Greg Clayton via Phabricator via lldb-commits
clayborg updated this revision to Diff 555933. clayborg added a comment. Log any errors we encounter during archive object parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159408/new/ https://reviews.llvm.org/D159408 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D159408: Switch over to using the LLVM archive parser for BSD archives.

2023-09-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159408/new/ https://reviews.llvm.org/D159408 __

[Lldb-commits] [lldb] d4a141e - Switch over to using the LLVM archive parser for BSD archives.

2023-09-05 Thread Greg Clayton via lldb-commits
Author: Greg Clayton Date: 2023-09-05T16:54:05-07:00 New Revision: d4a141ef932a596df61581090b70d0b546de68b2 URL: https://github.com/llvm/llvm-project/commit/d4a141ef932a596df61581090b70d0b546de68b2 DIFF: https://github.com/llvm/llvm-project/commit/d4a141ef932a596df61581090b70d0b546de68b2.diff

[Lldb-commits] [PATCH] D159408: Switch over to using the LLVM archive parser for BSD archives.

2023-09-05 Thread Greg Clayton via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd4a141ef932a: Switch over to using the LLVM archive parser for BSD archives. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159408/new