https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/68300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-10-06T09:07:20+01:00
New Revision: f74aaca63202cabb512c78fe19196ff348d436a8
URL:
https://github.com/llvm/llvm-project/commit/f74aaca63202cabb512c78fe19196ff348d436a8
DIFF:
https://github.com/llvm/llvm-project/commit/f74aaca63202cabb512c78fe19196ff348d436a8.diff
https://github.com/stepthomas updated
https://github.com/llvm/llvm-project/pull/68197
>From ed42bb63a3fe4a840071b74a3f9613dda815aa29 Mon Sep 17 00:00:00 2001
From: Stephen Thomas
Date: Wed, 4 Oct 2023 10:16:49 +0100
Subject: [PATCH] [AMDGPU] Add encoding/decoding support for
non-result-returni
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/65852
>From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sat, 9 Sep 2023 23:07:29 +0800
Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a
ne/eq
https://github.com/omjavaid commented:
After this change isAArch64SME check will be replaced on all locations?
So the manual says "The SVE FFR predicate register is not architecturally
visible when the PE is in Streaming SVE mode if FEAT_SME_FA64 is not
implemented or not enabled at the curre
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
https://github.com/omjavaid deleted
https://github.com/llvm/llvm-project/pull/66767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/65852
>From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sat, 9 Sep 2023 23:07:29 +0800
Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a
ne/eq
https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/65852
>From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sat, 9 Sep 2023 23:07:29 +0800
Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext
nikic wrote:
Looks like incorrect conflict resolution in the last merge.
https://github.com/llvm/llvm-project/pull/65852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
antmox wrote:
Hello! It looks like this broke lldb-aarch64-windows bot:
https://lab.llvm.org/buildbot/#/builders/219/builds/6130
Could you please look at this ?
https://github.com/llvm/llvm-project/pull/68300
___
lldb-commits mailing list
lldb-commits@
https://github.com/omjavaid edited
https://github.com/llvm/llvm-project/pull/66767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
https://github.com/omjavaid commented:
The document looks great but I have left some comments. They are just more like
my opinions you may consider some or all of them while updating this document.
https://github.com/llvm/llvm-project/pull/66767
___
l
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/68405
Fixes misleading comment introduced in
`f74aaca63202cabb512c78fe19196ff348d436a8`
>From 90db577879200ac4bd33f1078626ca54d8d1dc62 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 6 Oct 2023 11:38:03 +010
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/68405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-10-06T11:41:37+01:00
New Revision: a233a49b6037240adcde2dab74571fec13354a08
URL:
https://github.com/llvm/llvm-project/commit/a233a49b6037240adcde2dab74571fec13354a08
DIFF:
https://github.com/llvm/llvm-project/commit/a233a49b6037240adcde2dab74571fec13354a08.diff
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> Hello! It looks like this broke lldb-aarch64-windows bot:
> https://lab.llvm.org/buildbot/#/builders/219/builds/6130 Could you please
> look at this ?
Yup! Was in the process of fixing. I think we just skip this test on windows
https://github.com/llvm/llvm-project/pull/683
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Fixes misleading comment introduced in
`f74aaca63202cabb512c78fe19196ff348d436a8`
(https://github.com/llvm/llvm-project/pull/68300)
---
Full diff: https://github.com/llvm/llvm-project/pull/68405.diff
1 Files Affected:
- (modified) lldb/s
@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() {
std::optional svg_reg_value;
const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg");
if (svg_reg_info) {
+// When vg is written it is automatically made invalid. Writing vg wi
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/68408
These tests never worked since their introduction in
https://github.com/llvm/llvm-project/pull/68300
>From c5f0e050d8bfaad588693c99b2f680084a956718 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 6 Oct
Michael137 wrote:
@antmox Addressed in https://github.com/llvm/llvm-project/pull/68408
https://github.com/llvm/llvm-project/pull/68300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
These tests never worked since their introduction in
https://github.com/llvm/llvm-project/pull/68300
---
Full diff: https://github.com/llvm/llvm-project/pull/68408.diff
2 Files Affected:
- (modified) lldb/packages/Python/lldbsuite/test/de
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
a16f6462d756804276d4b39267b3c19bcd6949fe..eac7b78ad0e655da2cf997690a55e8a928657e47
lldb/p
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/65852
>From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sat, 9 Sep 2023 23:07:29 +0800
Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a
ne/eq
dtcxzyw wrote:
The conflict resolution should be correct now.
https://github.com/llvm/llvm-project/pull/65852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/68408
>From 0692935303b47e3c3f51c55df5ec5d7aac71a6eb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 6 Oct 2023 12:00:28 +0100
Subject: [PATCH 1/3] [lldb][test] TestCppUnionStaticMembers.py: split out
assert
https://github.com/nikic approved this pull request.
Yeah, it looks correct now.
https://github.com/llvm/llvm-project/pull/65852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/67915
>From c4ce28c942c172e5646b5922f0b02b4169197840 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sun, 1 Oct 2023 21:52:47 +0800
Subject: [PATCH 1/2] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y`
when
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/68094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dtcxzyw closed
https://github.com/llvm/llvm-project/pull/65852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I ran all the tests that originally had `isAArch64SME` in, on an FVP without
smefa64 and added checks as needed. But I did not make note of the unchanged
ones at the time, so I've redone that and added it to the commit message.
The ffr use you specifically noticed, the tes
@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() {
std::optional svg_reg_value;
const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg");
if (svg_reg_info) {
+// When vg is written it is automatically made invalid. Writing vg wi
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/66767
>From 705251d8ecbed546f46a5929a298ad88c70cc330 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 22 Aug 2023 11:12:23 +0100
Subject: [PATCH 1/2] [lldb][AArch64] Add release notes and documentation fo
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
@@ -0,0 +1,190 @@
+Using LLDB On AArch64 Linux
+===
+
+This page explains the details of debugging certain AArch64 extensions using
+LLDB. If something is not mentioned here, it likely works as you would expect.
+
+This is not a replacement for ptrace and L
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-10-06T15:28:10+01:00
New Revision: 21030b9ab4487d845e29792063f5666d8c4b8e09
URL:
https://github.com/llvm/llvm-project/commit/21030b9ab4487d845e29792063f5666d8c4b8e09
DIFF:
https://github.com/llvm/llvm-project/commit/21030b9ab4487d845e29792063f5666d8c4b8e09.diff
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/68408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,7 +18,9 @@
#include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h"
#include
+namespace lldb_plugin::dwarf {
JDevlieghere wrote:
I'd prefer the old way for the sake of consistency.
https://github.com/llvm/llvm-project/pull/68150
___
@@ -18,7 +18,9 @@
#include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h"
#include
+namespace lldb_plugin::dwarf {
walter-erquinigo wrote:
Sure, I'll change that!!
https://github.com/llvm/llvm-project/pull/68150
___
JDevlieghere wrote:
In the previous iteration of this PR, @bulbazord suggested keeping this in the
`lldb_private` namespace. Something like `lldb_private::plugin::dwarf` for
example? Is there a reason to make this not part of `lldb_private`? As Jim
pointed out in that thread, the way LLDB plug
Author: Michael Buch
Date: 2023-10-06T16:05:40+01:00
New Revision: d579a1a24adc26794d9a720cea52f7bb8f37c683
URL:
https://github.com/llvm/llvm-project/commit/d579a1a24adc26794d9a720cea52f7bb8f37c683
DIFF:
https://github.com/llvm/llvm-project/commit/d579a1a24adc26794d9a720cea52f7bb8f37c683.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/68408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@JDevlieghere , now that I think of it twice, I like the approach you mention
better. I'll use `lldb_private::plugin::dwarf` for the namespace then. Do you
still want these nested namespaces to be defined in three lines instead of one?
I could keep consistency as you me
JDevlieghere wrote:
> Do you still want these nested namespaces to be defined in three lines
> instead of one? I could keep consistency as you mention, but I don't know if
> that would be visually too much.
If the plan is to move all plugins under `lldb_private::plugin` then the
one-line is f
walter-erquinigo wrote:
sounds good! I'll do the change now
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/66768
>From 8b292d573710e1c37227d6f80b9770220abd658e Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 22 Aug 2023 14:42:35 +0100
Subject: [PATCH 1/2] [lldb][AArch64] Invalidate SVG prior to reconfiguring
@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() {
std::optional svg_reg_value;
const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg");
if (svg_reg_info) {
+// When vg is written it is automatically made invalid. Writing vg wi
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68150
>From 96c00272c96f546b57902f0f98b0af383dae24c5 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 16:56:16 -0400
Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin
A
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@JDevlieghere PTAL
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PeimingLiu approved this pull request.
https://github.com/llvm/llvm-project/pull/68360
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2023-10-06T10:43:31-07:00
New Revision: 8f378ff7a0a36137619a446b0bb13b8bc0ef6721
URL:
https://github.com/llvm/llvm-project/commit/8f378ff7a0a36137619a446b0bb13b8bc0ef6721
DIFF:
https://github.com/llvm/llvm-project/commit/8f378ff7a0a36137619a446b0bb13b8bc0ef6721.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/68378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1462,6 +1464,87 @@ static bool DumpModuleSymbolFile(Stream &strm, Module
*module) {
return false;
}
+static bool GetSeparateDebugInfoList(StructuredData::Array &list,
+ Module *module) {
+ if (module) {
+if (SymbolFile *symbol_fi
@@ -729,3 +729,92 @@ Value sparse_tensor::createOrFoldSliceStrideOp(OpBuilder
&builder, Location loc,
return constantIndex(builder, loc, *stride);
return builder.create(loc, tensor, APInt(64, dim));
}
+
+void sparse_tensor::fillDimShape(OpBuilder &builder, Location loc,
https://github.com/yinying-lisa-li approved this pull request.
https://github.com/llvm/llvm-project/pull/68360
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
I am not a big fan of having a specialized name `separate-debug-info` to dump
external debug info. Ideally, I would like a single/centralized command for end
users to see check symbols/debug info status for a target including all
possible situations.
How about we rename th
@@ -1462,6 +1464,87 @@ static bool DumpModuleSymbolFile(Stream &strm, Module
*module) {
return false;
}
+static bool GetSeparateDebugInfoList(StructuredData::Array &list,
+ Module *module) {
+ if (module) {
+if (SymbolFile *symbol_fi
https://github.com/aartbik closed
https://github.com/llvm/llvm-project/pull/68360
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PortalPete created
https://github.com/llvm/llvm-project/pull/68452
The `po` alias now matches the behavior of the `expression` command when the it
can apply a Fix-It to an expression.
Modifications
- Add has `m_fixed_expression` to the `CommandObjectDWIMPrint` class a
`prot
@@ -173,7 +173,16 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_op
@@ -173,7 +173,16 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_op
@@ -173,7 +173,16 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_op
@@ -0,0 +1,26 @@
+"""
+Tests whether the expression command applies FixIts
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class CPP_Expression_FixIt_TestCase(TestBase):
+def test_with_
@@ -0,0 +1,27 @@
+"""
+Tests whether the do-what-I-mean (DWIM) print `po` alias applies FixIts like
`expr` does
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class CPP_DWIM_Fixit_TestCas
@@ -0,0 +1,26 @@
+"""
+Tests whether the expression command applies FixIts
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class CPP_Expression_FixIt_TestCase(TestBase):
+def test_with_
@@ -0,0 +1,27 @@
+"""
+Tests whether the do-what-I-mean (DWIM) print `po` alias applies FixIts like
`expr` does
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class CPP_DWIM_Fixit_TestCas
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff daca97216cf132d733513f992d49e3c722aabf40
1d0ac08d38a33ae70687f7b125367c39fbcf92f3 --
felipepiovezan wrote:
The code is not something I am familiar with, but I did notice that the PR
title and the commit title are quite different. Not sure which one is better,
but it is generally nice to have them match (in particular it is nice to add
the `[lldb]` tag to the commit title to ma
https://github.com/PortalPete updated
https://github.com/llvm/llvm-project/pull/68452
>From 3a17d92ccaf71bd1f04035278af7be5eb5c3 Mon Sep 17 00:00:00 2001
From: Pete Lawrence
Date: Thu, 5 Oct 2023 14:22:35 -1000
Subject: [PATCH] Modify `po` alias to match outward FixIt behavior with
`expres
@@ -173,7 +173,16 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_op
@@ -173,7 +173,16 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_op
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/68452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -43,6 +43,10 @@ class CommandObjectDWIMPrint : public CommandObjectRaw {
HandleArgumentCompletion(CompletionRequest &request,
OptionElementVector &opt_element_vector) override;
+protected:
+ /// Stores the expression after applying any Fix-Its.
@@ -0,0 +1,27 @@
+"""
+Tests whether the do-what-I-mean (DWIM) print `po` alias applies FixIts like
`expr` does
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class CPP_DWIM_Fixit_TestCas
@@ -0,0 +1,27 @@
+"""
+Tests whether the do-what-I-mean (DWIM) print `po` alias applies FixIts like
`expr` does
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class CPP_DWIM_Fixit_TestCas
https://github.com/PortalPete updated
https://github.com/llvm/llvm-project/pull/68452
>From 7def3f8e3a04ee9efbaef194bd60eec81fb32c25 Mon Sep 17 00:00:00 2001
From: Pete Lawrence
Date: Thu, 5 Oct 2023 14:22:35 -1000
Subject: [PATCH] Modify `po` alias to match outward FixIt behavior with
`expres
@@ -173,7 +173,16 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_op
@@ -0,0 +1,27 @@
+"""
+Tests whether the do-what-I-mean (DWIM) print `po` alias applies FixIts like
`expr` does
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class CPP_DWIM_Fixit_TestCas
@@ -0,0 +1,27 @@
+"""
+Tests whether the do-what-I-mean (DWIM) print `po` alias applies FixIts like
`expr` does
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class CPP_DWIM_Fixit_TestCas
@@ -172,8 +172,18 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
{
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
-ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, ev
@@ -172,8 +172,18 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
{
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
-ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, ev
@@ -172,8 +172,18 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
{
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
-ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, ev
1 - 100 of 115 matches
Mail list logo
