[Lldb-commits] [lldb] 2abf997 - [lldb] Fix assertions caused by un-checked errors in ScriptedProcess

Author: Med Ismail Bennani Date: 2023-10-25T17:31:02-07:00 New Revision: 2abf997f8272e88d1a17138da61448bac721b6c1 URL: https://github.com/llvm/llvm-project/commit/2abf997f8272e88d1a17138da61448bac721b6c1 DIFF:

[Lldb-commits] [lldb] b82c629 - Fix log format strings

Author: Adrian Prantl Date: 2023-10-25T16:42:37-07:00 New Revision: b82c62978690a8a518f22780bd13ac2b5ddcd2b8 URL: https://github.com/llvm/llvm-project/commit/b82c62978690a8a518f22780bd13ac2b5ddcd2b8 DIFF: https://github.com/llvm/llvm-project/commit/b82c62978690a8a518f22780bd13ac2b5ddcd2b8.diff

[Lldb-commits] [lldb] dfa3570 - [lldb] Add test dependency on the `runtimes` instead of the `cxx` target

Author: Jonas Devlieghere Date: 2023-10-25T16:03:51-07:00 New Revision: dfa357026be3d9ecacc910abb8d55b8fe2d8d01d URL: https://github.com/llvm/llvm-project/commit/dfa357026be3d9ecacc910abb8d55b8fe2d8d01d DIFF:

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -53,44 +49,52 @@ bool WatchpointResource::Contains(addr_t addr) { void WatchpointResource::AddOwner(const WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); - m_owners.Add(wp_sp); + m_owners.push_back(wp_sp); } void

[Lldb-commits] [lldb] [lldb] Part 1 of 2 - Refactor `CommandObject::Execute(...)` return `void` (not `bool`) (PR #69989)

https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/69989 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 463a02b - [lldb] Part 1 of 2 - Refactor `CommandObject::Execute(...)` return `void` (not `bool`) (#69989)

Author: Pete Lawrence Date: 2023-10-25T15:55:27-07:00 New Revision: 463a02bc2260d01ac9e8457792bb455e48097ce5 URL: https://github.com/llvm/llvm-project/commit/463a02bc2260d01ac9e8457792bb455e48097ce5 DIFF: https://github.com/llvm/llvm-project/commit/463a02bc2260d01ac9e8457792bb455e48097ce5.diff

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -67,18 +67,15 @@ size_t WatchpointResource::GetNumberOfOwners() { bool WatchpointResource::OwnersContains(WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); const auto = std::find(m_owners.begin(), m_owners.end(), wp_sp); - if (it != m_owners.end()) -

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/68845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/68845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -67,18 +67,15 @@ size_t WatchpointResource::GetNumberOfOwners() { bool WatchpointResource::OwnersContains(WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); const auto = std::find(m_owners.begin(), m_owners.end(), wp_sp); - if (it != m_owners.end()) -

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -67,18 +67,15 @@ size_t WatchpointResource::GetNumberOfOwners() { bool WatchpointResource::OwnersContains(WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); const auto = std::find(m_owners.begin(), m_owners.end(), wp_sp); - if (it != m_owners.end()) -

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -53,44 +49,52 @@ bool WatchpointResource::Contains(addr_t addr) { void WatchpointResource::AddOwner(const WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); - m_owners.Add(wp_sp); + m_owners.push_back(wp_sp); } void

[Lldb-commits] [lldb] [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (PR #70157)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/70157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 10508b6 - [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (#70157)

Author: Walter Erquinigo Date: 2023-10-25T18:04:25-04:00 New Revision: 10508b6db72d8ee4ef022b85fe51c671921088f3 URL: https://github.com/llvm/llvm-project/commit/10508b6db72d8ee4ef022b85fe51c671921088f3 DIFF:

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -53,44 +49,52 @@ bool WatchpointResource::Contains(addr_t addr) { void WatchpointResource::AddOwner(const WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); - m_owners.Add(wp_sp); + m_owners.push_back(wp_sp); } void

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -53,44 +49,52 @@ bool WatchpointResource::Contains(addr_t addr) { void WatchpointResource::AddOwner(const WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); - m_owners.Add(wp_sp); + m_owners.push_back(wp_sp); } void

[Lldb-commits] [lldb] [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (PR #70157)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/70157 >From 98c80871a753c58a49e8ba0d535e03e99d633109 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Tue, 24 Oct 2023 22:32:38 -0400 Subject: [PATCH 1/2] [LLDB][NFC] Remove DWARFASTParserClang as friend

[Lldb-commits] [lldb] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/6] [libc++] Implement ranges::contains_subrange ---

[Lldb-commits] [lldb] [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (PR #70157)

@@ -325,15 +323,46 @@ class SymbolFileDWARF : public SymbolFileCommon { m_file_index = file_index; } -protected: typedef llvm::DenseMap DIEToTypePtr; - typedef llvm::DenseMap - DIEToVariableSP; + + virtual DIEToTypePtr () { return m_die_to_type; } + typedef

[Lldb-commits] [lldb] [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (PR #70157)

@@ -325,15 +323,46 @@ class SymbolFileDWARF : public SymbolFileCommon { m_file_index = file_index; } -protected: typedef llvm::DenseMap DIEToTypePtr; - typedef llvm::DenseMap - DIEToVariableSP; + + virtual DIEToTypePtr () { return m_die_to_type; } + typedef

[Lldb-commits] [lldb] [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (PR #70157)

https://github.com/clayborg commented: We might want to rename anything that says "ClangType*" to be "CompilerType*". This is still left over from when we didn't think we would ever have the TypeSystem stuff. See some inline comments for examples. Since we are refactoring a bit and making

[Lldb-commits] [lldb] [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (PR #70157)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/70157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (PR #70157)

https://github.com/augusto2112 approved this pull request. https://github.com/llvm/llvm-project/pull/70157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

jeffreytan81 wrote: Sounds good. Will keep the PR alive at least half day or one day before merging in future. https://github.com/llvm/llvm-project/pull/70231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Complex range (PR #70244)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/70244 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 01/10] Revert "[clang] Support fixed point types in C++

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

https://github.com/usama54321 closed https://github.com/llvm/llvm-project/pull/69388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 77edd9b - [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (#69388)

Author: Usama Hameed Date: 2023-10-25T12:52:52-07:00 New Revision: 77edd9b77317d008b86a2543fbafdc0c3e8a3759 URL: https://github.com/llvm/llvm-project/commit/77edd9b77317d008b86a2543fbafdc0c3e8a3759 DIFF: https://github.com/llvm/llvm-project/commit/77edd9b77317d008b86a2543fbafdc0c3e8a3759.diff

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

usama54321 wrote: Thanks everyone! https://github.com/llvm/llvm-project/pull/69388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] Complex range (PR #70244)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/70244 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 1/9] Revert "[clang] Support fixed point types in C++ (#67750)"

[Lldb-commits] [lldb] Complex range (PR #70244)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0ab694754e3722f7edbd8b3ad23ac0b312515d3b 2aa766352db0c3010991b4bc53ded7a2d1693bfd --

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

@@ -129,8 +129,19 @@ void DebugNamesDWARFIndex::GetGlobalVariables( DWARFUnit , llvm::function_ref callback) { uint64_t cu_offset = cu.GetOffset(); bool found_entry_for_cu = false; - for (const DebugNames::NameIndex : *m_debug_names_up) { -for

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

@@ -129,8 +129,19 @@ void DebugNamesDWARFIndex::GetGlobalVariables( DWARFUnit , llvm::function_ref callback) { uint64_t cu_offset = cu.GetOffset(); bool found_entry_for_cu = false; - for (const DebugNames::NameIndex : *m_debug_names_up) { -for

[Lldb-commits] [lldb] [lldb] Part 2 of 2 - Refactor `CommandObject::DoExecute(...)` return `void` (not `bool`) (PR #69991)

bulbazord wrote: > > > I think I looked at every changed line, looks good to me overall. Found > > > one place with a small style issue but it's not a blocker. Thanks! > > > > > > Thanks @bulbazord! Do you know why the `code_formatter` check/bot didn't > > flag that or the other one-line

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

@@ -129,8 +129,19 @@ void DebugNamesDWARFIndex::GetGlobalVariables( DWARFUnit , llvm::function_ref callback) { uint64_t cu_offset = cu.GetOffset(); bool found_entry_for_cu = false; - for (const DebugNames::NameIndex : *m_debug_names_up) { -for

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/70231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

https://github.com/bulbazord commented: This patch looks fine to me in idea, but next time please leave your review up for longer so others have time to take a look as well. https://github.com/llvm/llvm-project/pull/70231 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

@@ -625,6 +662,18 @@ NativeRegisterContextLinux_arm64::CacheAllRegisters(uint32_t _size) { error = ReadZA(); if (error.Fail()) return error; + +// We will only be restoring ZT data if ZA is active. As writing to an +// inactive ZT enables ZA, which may

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/70205 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes While using dwarf5 `.debug_names` in internal large targets, we noticed a performance issue (around 10 seconds delay) while `lldb-vscode` tries to show `scopes` for a compile unit. Profiling shows the

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/70231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d4e6e40 - Improve debug names index fetching global variables performance (#70231)

Author: jeffreytan81 Date: 2023-10-25T11:46:11-07:00 New Revision: d4e6e403372fbc62f032d85f22fe0c1aeeb15146 URL: https://github.com/llvm/llvm-project/commit/d4e6e403372fbc62f032d85f22fe0c1aeeb15146 DIFF: https://github.com/llvm/llvm-project/commit/d4e6e403372fbc62f032d85f22fe0c1aeeb15146.diff

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/70231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/70231 >From c8d9a1f7387e3e4944d92ccb33699b6a9d0dcf89 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 25 Oct 2023 10:21:06 -0700 Subject: [PATCH 1/2] Improve debug names index fetching global variables

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

https://github.com/ZijunZhaoCCK closed https://github.com/llvm/llvm-project/pull/69649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

https://github.com/ZijunZhaoCCK edited https://github.com/llvm/llvm-project/pull/69649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/bulbazord approved this pull request. LGTM. I didn't realize lldb-server didn't use libXML, learned something new today. :) https://github.com/llvm/llvm-project/pull/69951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -0,0 +1,140 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -53,44 +49,52 @@ bool WatchpointResource::Contains(addr_t addr) { void WatchpointResource::AddOwner(const WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); - m_owners.Add(wp_sp); + m_owners.push_back(wp_sp); } void

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -53,44 +49,52 @@ bool WatchpointResource::Contains(addr_t addr) { void WatchpointResource::AddOwner(const WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); - m_owners.Add(wp_sp); + m_owners.push_back(wp_sp); } void

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -53,44 +49,52 @@ bool WatchpointResource::Contains(addr_t addr) { void WatchpointResource::AddOwner(const WatchpointSP _sp) { std::lock_guard guard(m_owners_mutex); - m_owners.Add(wp_sp); + m_owners.push_back(wp_sp); } void

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8efd6799f006000a5e3aacbb403f262db37290b6 c8d9a1f7387e3e4944d92ccb33699b6a9d0dcf89 --

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/69951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/69951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -9,10 +9,16 @@ #ifndef LLDB_TARGET_REGISTERFLAGS_H #define LLDB_TARGET_REGISTERFLAGS_H -#include "lldb/Utility/Log.h" +#include +#include +#include +#include clayborg wrote: Sorry, I hadn't expanded the full file to see being used in code that

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4264ab1e7a: [lldb][libc++] Adds chrono data formatters. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0e4264a - [lldb][libc++] Adds chrono data formatters.

Author: Mark de Wever Date: 2023-10-25T19:36:47+02:00 New Revision: 0e4264ab1e7a3d82a32d0d096d014afade1e2fae URL: https://github.com/llvm/llvm-project/commit/0e4264ab1e7a3d82a32d0d096d014afade1e2fae DIFF: https://github.com/llvm/llvm-project/commit/0e4264ab1e7a3d82a32d0d096d014afade1e2fae.diff

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/70231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

https://github.com/clayborg approved this pull request. Looks good, just rename the "has_match_cu" to "cu_matches" and this is good to go. https://github.com/llvm/llvm-project/pull/70231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

@@ -130,6 +130,17 @@ void DebugNamesDWARFIndex::GetGlobalVariables( uint64_t cu_offset = cu.GetOffset(); bool found_entry_for_cu = false; for (const DebugNames::NameIndex : *m_debug_names_up) { +// Check if this name index contains an entry for the given CU. +

[Lldb-commits] [lldb] 7b8e686 - [lldb] Fix build failure introduced by f22d82c

Author: Med Ismail Bennani Date: 2023-10-25T10:31:43-07:00 New Revision: 7b8e6861150e56198b5e477f382845439f4d1c06 URL: https://github.com/llvm/llvm-project/commit/7b8e6861150e56198b5e477f382845439f4d1c06 DIFF:

[Lldb-commits] [lldb] Improve debug names index fetching global variables performance (PR #70231)

https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/70231 While using dwarf5 `.debug_names` in internal large targets, we noticed a performance issue (around 10 seconds delay) while `lldb-vscode` tries to show `scopes` for a compile unit. Profiling shows the

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante added a comment. In D159127#4654774 , @Michael137 wrote: > Was looking at leftover reviews, would be nice to land this Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (PR #70150)

https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/70150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (PR #70150)

shafik wrote: The clang-format error is a false positive. https://github.com/llvm/llvm-project/pull/70150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f22d82c - [lldb/Interpreter] Make ScriptedInterface Object creation more generic (#68052)

Author: Med Ismail Bennani Date: 2023-10-25T10:05:54-07:00 New Revision: f22d82cef28a882cec4d242910933e9f5d7dcdce URL: https://github.com/llvm/llvm-project/commit/f22d82cef28a882cec4d242910933e9f5d7dcdce DIFF:

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #68052)

https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/68052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #68052)

https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #68052)

@@ -19,11 +19,11 @@ namespace lldb_private { class ScriptedPlatformInterface : virtual public ScriptedInterface { public: - StructuredData::GenericSP + virtual llvm::Expected CreatePluginObject(llvm::StringRef class_name, ExecutionContext _ctx,

[Lldb-commits] [lldb] 42c25fd - [lldb][docs][AArch64] Update example in SME docs

Author: David Spickett Date: 2023-10-25T13:12:37Z New Revision: 42c25fddcb1ad7407cd42cae3c15d943708fe8ad URL: https://github.com/llvm/llvm-project/commit/42c25fddcb1ad7407cd42cae3c15d943708fe8ad DIFF: https://github.com/llvm/llvm-project/commit/42c25fddcb1ad7407cd42cae3c15d943708fe8ad.diff

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

DavidSpickett wrote: I've pushed this as two commits the first is adding the register, the second updates tests, for easier review. I intend to squash both once approved. This does not cover core files, that'll be the follow up PR. https://github.com/llvm/llvm-project/pull/70205

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes SME2 is documented as part of the main SME supplement: https://developer.arm.com/documentation/ddi0616/latest/ The one change for debug is this new ZT0 register. This register contains data to be used

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/70205 SME2 is documented as part of the main SME supplement: https://developer.arm.com/documentation/ddi0616/latest/ The one change for debug is this new ZT0 register. This register contains data to be used with

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

AaronBallman wrote: > > > Is there a way to have Visual Studio change the display format of the > > > enum values? > > > > > > Sort of. You can specify you want to view values in hex and then you'll get > > `EK_ParenAggInitMember (0x0015)` instead of `EK_ParenAggInitMember > > (21)`,

[Lldb-commits] [lldb] dddd0c2 - [lldb][AArch64] Simplify AArch64SMEFA64 check

Author: David Spickett Date: 2023-10-25T11:19:37+01:00 New Revision: 0c2501beeb372252826aab71da7691d17bc2 URL: https://github.com/llvm/llvm-project/commit/0c2501beeb372252826aab71da7691d17bc2 DIFF:

[Lldb-commits] [lldb] [mlir][LLVM] Verify too many indices in GEP verifier (PR #70174)

https://github.com/zero9178 closed https://github.com/llvm/llvm-project/pull/70174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] On POSIX, check for duplicate interpreter modules without loading them (PR #69932)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69932 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ff67b68 - [lldb] On POSIX, check for duplicate interpreter modules without loading them (#69932)

Author: David Spickett Date: 2023-10-25T10:12:45+01:00 New Revision: ff67b68e43db5b4feb46670445561fab976fb0ef URL: https://github.com/llvm/llvm-project/commit/ff67b68e43db5b4feb46670445561fab976fb0ef DIFF:

[Lldb-commits] [lldb] [lldb] On POSIX, check for duplicate interpreter modules without loading them (PR #69932)

DavidSpickett wrote: I'd really like to get Arm checks going again, so I'm going to land this today and see how the bot does. Of course I'll revert if there's any sign of instability on the BSD side. https://github.com/llvm/llvm-project/pull/69932

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -9,10 +9,16 @@ #ifndef LLDB_TARGET_REGISTERFLAGS_H #define LLDB_TARGET_REGISTERFLAGS_H -#include "lldb/Utility/Log.h" +#include DavidSpickett wrote: Moved the assert into the cpp file and removed the include in the header.

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -9,10 +9,16 @@ #ifndef LLDB_TARGET_REGISTERFLAGS_H #define LLDB_TARGET_REGISTERFLAGS_H -#include "lldb/Utility/Log.h" +#include +#include +#include +#include DavidSpickett wrote: string and vector are needed, presumably because RegisterFlags is a leaf

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/69951 >From 5c8b9538e1e5646f19d5bb40ab19afaf2c68e804 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 9 Oct 2023 10:33:08 +0100 Subject: [PATCH 1/6] [lldb][lldb-server] Enable sending registerflags as

[Lldb-commits] [lldb] [lldb][AArch64] Add isAArch64SMEFA64 check to SME testing (PR #68094)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/68094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e7012ba - [lldb][AArch64] Add isAArch64SMEFA64 check to SME testing (#68094)

Author: David Spickett Date: 2023-10-25T09:56:00+01:00 New Revision: e7012ba8d36f8a38ab58edccf7267f12266218ab URL: https://github.com/llvm/llvm-project/commit/e7012ba8d36f8a38ab58edccf7267f12266218ab DIFF:

[Lldb-commits] [lldb] [lldb][AArch64] Read mte_ctrl register from core files (PR #69689)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d8abce1 - [lldb][AArch64] Read mte_ctrl register from core files (#69689)

Author: David Spickett Date: 2023-10-25T09:54:34+01:00 New Revision: d8abce1181cf089ef1161aad97072b1e53c1e941 URL: https://github.com/llvm/llvm-project/commit/d8abce1181cf089ef1161aad97072b1e53c1e941 DIFF:

[Lldb-commits] [lldb] 1d10369 - Reland "[lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (#66768)""

Author: David Spickett Date: 2023-10-25T08:40:17Z New Revision: 1d10369f534a1d8e83c847a2be86a252078f653c URL: https://github.com/llvm/llvm-project/commit/1d10369f534a1d8e83c847a2be86a252078f653c DIFF: https://github.com/llvm/llvm-project/commit/1d10369f534a1d8e83c847a2be86a252078f653c.diff

[Lldb-commits] [lldb] [mlir][LLVM] Verify too many indices in GEP verifier (PR #70174)

https://github.com/zero9178 updated https://github.com/llvm/llvm-project/pull/70174 From 03fb7aceae81227c3a64cf4b9ba1e53a69e46511 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20B=C3=B6ck?= Date: Wed, 25 Oct 2023 09:54:16 +0200 Subject: [PATCH 1/3] [mlir][LLVM] Verify too many indices in GEP

[Lldb-commits] [lldb] 8d80a45 - Revert "[lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (#66768)"

Author: David Spickett Date: 2023-10-25T08:27:27Z New Revision: 8d80a452b841a211e0f3bce01a01c9a015d287f3 URL: https://github.com/llvm/llvm-project/commit/8d80a452b841a211e0f3bce01a01c9a015d287f3 DIFF: https://github.com/llvm/llvm-project/commit/8d80a452b841a211e0f3bce01a01c9a015d287f3.diff

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f2c09e5 - [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (#66768)

Author: David Spickett Date: 2023-10-25T09:16:58+01:00 New Revision: f2c09e5e16d592303b5a1c158cdef28ef08104f0 URL: https://github.com/llvm/llvm-project/commit/f2c09e5e16d592303b5a1c158cdef28ef08104f0 DIFF:

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Correct type of 32 bit GPR RegisterValues when using core files (PR #70054)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/70054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a770098 - [lldb][AArch64] Correct type of 32 bit GPR RegisterValues when using core files (#70054)

Author: David Spickett Date: 2023-10-25T09:08:01+01:00 New Revision: a7700985577694d6cc2498833f27b4fb5eeaf252 URL: https://github.com/llvm/llvm-project/commit/a7700985577694d6cc2498833f27b4fb5eeaf252 DIFF:

[Lldb-commits] [lldb] [lldb][AArch64] Correct type of 32 bit GPR RegisterValues when using core files (PR #70054)

DavidSpickett wrote: > Please make sure there is a test that exercises this behavior in your > follow-up. This fixes a crash when trying to use cpsr field info with a core file, so this will be covered in those tests later. https://github.com/llvm/llvm-project/pull/70054