https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/72416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jordan Rupprecht
Date: 2023-11-15T17:51:25-08:00
New Revision: 212a60ec37322f853e91e171b305479b1abff2f2
URL:
https://github.com/llvm/llvm-project/commit/212a60ec37322f853e91e171b305479b1abff2f2
DIFF:
rupprecht wrote:
> Beautiful, thank you for working on this. After this change, what's left to
> get us using the python-provided `unittest`?
The giant lambda inside `_decorateTest` has one remaining `self` reference,
which is `self.getDebugInfo()` -- i.e. the debug info specific variant
@@ -184,3 +187,144 @@ def hasChattyStderr(test_case):
):
return True # The dynamic linker on the device will complain about
unknown DT entries
return False
+
+
+def builder_module():
+return get_builder(sys.platform)
+
+
+def getArchitecture():
+
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/72416
>From b3178bb93c0d414857732b08228987894df762d4 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Wed, 15 Nov 2023 08:58:17 -0800
Subject: [PATCH 1/2] [lldb][test] Move most `self` references out of
adrian-prantl wrote:
> I'm arguing it doesn't fit it particularly well. We use it for bit fields -
> which are pretty special, for instance, but it seems like this thing isn't
> quite like that - it does have a whole byte size (if you allocated an array
> of them, for instance, I'm guessing
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/71021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/6] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've
@@ -0,0 +1,142 @@
+//===-- SymbolLocatorDebuginfod.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/bulbazord approved this pull request.
Beautiful, thank you for working on this.
After this change, what's left to get us using the python-provided `unittest`?
https://github.com/llvm/llvm-project/pull/72416
___
lldb-commits mailing
@@ -0,0 +1,142 @@
+//===-- SymbolLocatorDebuginfod.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -62,15 +66,25 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
-
https://github.com/bulbazord approved this pull request.
LGTM as well. I like the name Constituents quite a bit as well!
I think most feedback at this point can probably be handled in follow-ups, esp.
since some of it pertains to existing interfaces.
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> So I guess what you are saying in this case is that it is expected and the
> value is at the location indicated by the DW_AT_location value? As long as
> the value is still available I suppose that is fine then and the test just
> needs updating.
Yup that's exactly right.
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/5] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've
kevinfrei wrote:
Looks like I missed committing some staged edits. Hold on before reviewing...
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
pogo59 wrote:
I think it is a valuable bit of information for the debugger, to know the
constant value without having to read it from memory. I think we should emit
both the location and the value.
https://github.com/llvm/llvm-project/pull/71780
___
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dyung wrote:
> > The member is const with an initializer in-class. How is the constant value
> > not available for the definition?
>
> Right, it is available, we just don't attach it if we have a location for it.
> Don't see why we couldn't put it on the definition if we have the constant on
@@ -0,0 +1,46 @@
+// REQUIRES: linux || windows
+// Default
+// RUN: %clang -o %t.normal -fprofile-instr-generate -fcoverage-mapping
-fuse-ld=lld %S/Inputs/instrprof-debug-info-correlate-main.cpp
%S/Inputs/instrprof-debug-info-correlate-foo.cpp
+// RUN: env
@@ -195,8 +195,14 @@ OPTIONS
.. option:: --debug-info=
Specify the executable or ``.dSYM`` that contains debug info for the raw
profile.
- When ``-debug-info-correlate`` was used for instrumentation, use this option
- to correlate the raw profile.
+ When
@@ -1341,20 +1344,26 @@ void
InstrProfiling::createDataVariable(InstrProfCntrInstBase *Inc,
}
auto *Data =
new GlobalVariable(*M, DataTy, false, Linkage, nullptr, DataVarName);
- // Reference the counter variable with a label difference (link-time
- // constant).
@@ -1331,6 +1336,18 @@ static int merge_main(int argc, const char *argv[]) {
"(default: 1)"));
cl::ParseCommandLineOptions(argc, argv, "LLVM profile data merger\n");
+ if (!DebugInfoFilename.empty() && !BinaryFilename.empty()) {
+
@@ -1331,6 +1336,18 @@ static int merge_main(int argc, const char *argv[]) {
"(default: 1)"));
cl::ParseCommandLineOptions(argc, argv, "LLVM profile data merger\n");
+ if (!DebugInfoFilename.empty() && !BinaryFilename.empty()) {
+
https://github.com/ZequanWu commented:
> "binary" is ambiguous. I wonder whether object file correlation is better.
> llvm-symbolizer has an option --obj=xxx.
llvm-symbolizer's `--obj` could take an pre-linking object file. But here we
need to take post-linked binary for merging.
@@ -46,14 +73,38 @@ const char *InstrProfCorrelator::NumCountersAttributeName =
"Num Counters";
llvm::Expected>
InstrProfCorrelator::Context::get(std::unique_ptr Buffer,
- const object::ObjectFile ) {
+ const
@@ -1829,6 +1833,22 @@ void CoverageMappingModuleGen::emit() {
llvm::GlobalValue::InternalLinkage, NamesArrVal,
llvm::getCoverageUnusedNamesVarName());
}
+ const StringRef
@@ -0,0 +1,46 @@
+// REQUIRES: linux || windows
ZequanWu wrote:
I think lld is not require, removed `-fuse-ld=lld`.
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -fprofile-instrument=clang -fcoverage-mapping -emit-llvm
-o - %s | FileCheck %s
+// RUN: %clang_cc1 -mllvm -profile-correlate=binary -fprofile-instrument=clang
-fcoverage-mapping -emit-llvm -o - %s | FileCheck %s
@@ -0,0 +1,11 @@
+; RUN: opt < %s -passes=instrprof -profile-correlate=binary -S | FileCheck %s
ZequanWu wrote:
Moved the test to `coverage.ll`
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> LGTM with a few nits. I like "constituents".
>
> This is a pretty big patch which makes reviewing it challenging. I know it's
> a big change that touches a lot of things but I'm sure that this could've
> been broken up into smaller patches if you keep that goal in mind
Michael137 wrote:
> The member is const with an initializer in-class. How is the constant value
> not available for the definition?
Right, it is available, we just don't attach it if we have a location for it.
Don't see why we couldn't put it on the definition if we have the constant on
hand
@@ -1787,30 +1788,48 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo(
// addresses should be provided as \a wp_addr.
StringExtractor desc_extractor(description.c_str());
addr_t wp_addr = desc_extractor.GetU64(LLDB_INVALID_ADDRESS);
-
pogo59 wrote:
The member is const with an initializer in-class. How is the constant value not
available for the definition?
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dyung wrote:
> > Hi @Michael137, we are seeing a failure in one of our internal tests that I
> > bisected back to this change. Consider the following code:
> > ```c++
> > struct X
> > {
> > static const int constant = 1;
> > int x;
> >
> > X() { x = constant; }
> > };
> > const int
Michael137 wrote:
> Hi @Michael137, we are seeing a failure in one of our internal tests that I
> bisected back to this change. Consider the following code:
>
> ```c++
> struct X
> {
> static const int constant = 1;
> int x;
>
> X() { x = constant; }
> };
> const int X::constant;
dyung wrote:
Hi @Michael137, we are seeing a failure in one of our internal tests that I
bisected back to this change. Consider the following code:
```C++
struct X
{
static const int constant = 1;
int x;
X() { x = constant; }
};
const int X::constant;
int main()
{
X x;
x.x
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/5] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've
@@ -4,7 +4,7 @@ let Definition = "modulelist" in {
def EnableExternalLookup: Property<"enable-external-lookup", "Boolean">,
Global,
DefaultTrue,
-Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -62,15 +66,25 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
-
@@ -46,6 +46,10 @@ bool canUseDebuginfod();
/// environment variable.
SmallVector getDefaultDebuginfodUrls();
+/// Sets the list of debuginfod server URLs to query. This overrides the
+/// environment variable DEBUGINFOD_URLS.
kevinfrei wrote:
Switched the
@@ -0,0 +1,8 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "symbollocatordebuginfod" in {
+ def URLs: Property<"urls", "String">,
+Global,
+DefaultStringValue<"">,
+Desc<"A space-separated, ordered list of Debuginfod server URLs to
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/72012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2023-11-15T13:32:42-08:00
New Revision: a3fe9221ab1541a88e784507433cfe7fd13688fd
URL:
https://github.com/llvm/llvm-project/commit/a3fe9221ab1541a88e784507433cfe7fd13688fd
DIFF:
https://github.com/llvm/llvm-project/commit/a3fe9221ab1541a88e784507433cfe7fd13688fd.diff
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/72416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Nice! LGTM with some nits.
https://github.com/llvm/llvm-project/pull/72416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1310,82 +1308,29 @@ def isAArch64Windows(self):
def getArchitecture(self):
"""Returns the architecture in effect the test suite is running
with."""
-module = builder_module()
-arch = module.getArchitecture()
-if arch == "amd64":
-
@@ -1310,82 +1308,29 @@ def isAArch64Windows(self):
def getArchitecture(self):
"""Returns the architecture in effect the test suite is running
with."""
-module = builder_module()
-arch = module.getArchitecture()
-if arch == "amd64":
-
@@ -184,3 +187,144 @@ def hasChattyStderr(test_case):
):
return True # The dynamic linker on the device will complain about
unknown DT entries
return False
+
+
+def builder_module():
+return get_builder(sys.platform)
+
+
+def getArchitecture():
+
https://github.com/JDevlieghere approved this pull request.
Thanks for doing this!
https://github.com/llvm/llvm-project/pull/72416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -102,10 +102,10 @@ void ProcessKDP::Terminate() {
lldb::ProcessSP ProcessKDP::CreateInstance(TargetSP target_sp,
ListenerSP listener_sp,
- const FileSpec *crash_file_path,
+
@@ -427,8 +427,17 @@ class CommandObjectTargetCreate : public
CommandObjectParsed {
core_file_dir.SetDirectory(core_file.GetDirectory());
target_sp->AppendExecutableSearchPaths(core_file_dir);
+auto file = FileSystem::Instance().Open(
+
@@ -194,11 +194,12 @@ void ProcessGDBRemote::Terminate() {
PluginManager::UnregisterPlugin(ProcessGDBRemote::CreateInstance);
}
-lldb::ProcessSP ProcessGDBRemote::CreateInstance(
-lldb::TargetSP target_sp, ListenerSP listener_sp,
-const FileSpec *crash_file_path,
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71769
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/71769
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3174,8 +3174,17 @@ class TargetCreateFormDelegate : public FormDelegate {
core_file_directory_spec.SetDirectory(core_file_spec.GetDirectory());
target_sp->AppendExecutableSearchPaths(core_file_directory_spec);
-ProcessSP process_sp(target_sp->CreateProcess(
-
@@ -627,7 +628,7 @@ class Target : public std::enable_shared_from_this,
// used.
const lldb::ProcessSP (lldb::ListenerSP listener_sp,
llvm::StringRef plugin_name,
- const FileSpec *crash_file,
+
@@ -244,9 +245,38 @@ SBProcess SBTarget::LoadCore(const char *core_file,
lldb::SBError ) {
TargetSP target_sp(GetSP());
if (target_sp) {
FileSpec filespec(core_file);
-FileSystem::Instance().Resolve(filespec);
+auto file = FileSystem::Instance().Open(
+
zmodem wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry )
{
registerLLVMDialectTranslation(registry);
registerNVVMDialectTranslation(registry);
registerROCDLDialectTranslation(registry);
+ registerSPIRVDialectTranslation(registry);
silee2
@@ -0,0 +1,235 @@
+//===-- StopPointSiteList.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,235 @@
+//===-- StopPointSiteList.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,235 @@
+//===-- StopPointSiteList.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -1787,30 +1788,48 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo(
// addresses should be provided as \a wp_addr.
StringExtractor desc_extractor(description.c_str());
addr_t wp_addr = desc_extractor.GetU64(LLDB_INVALID_ADDRESS);
-
@@ -0,0 +1,235 @@
+//===-- StopPointSiteList.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,235 @@
+//===-- StopPointSiteList.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/JDevlieghere approved this pull request.
LGTM with a few nits. I like "constituents".
This is a pretty big patch which makes reviewing it challenging. I know it's a
big change that touches a lot of things but I'm sure that this could've been
broken up into smaller patches
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/68845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/72416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jordan Rupprecht (rupprecht)
Changes
---
Patch is 22.83 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/72416.diff
3 Files Affected:
- (modified)
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/72416
None
>From b3178bb93c0d414857732b08228987894df762d4 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Wed, 15 Nov 2023 08:58:17 -0800
Subject: [PATCH] [lldb][test] Move most `self` references out of
Michael137 wrote:
@zmodem Fix pushed in `14a84510f5d07b05b348188c7dfbe54076fa1485`. Your
reproducer works fine for me now. Let me know if you're still seeing issues.
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
https://github.com/JDevlieghere approved this pull request.
LGTM. I would've preferred to return something like
`LLDB_INVALID_HARDWARE_INDEX` but as we're deprecating this, it doesn't seem
worth adding another define for.
https://github.com/llvm/llvm-project/pull/72012
Michael137 wrote:
Ok with ASAN I could trigger this quite consistently. Turns out we can't
iterate over the `StaticDataMemberDefinitionsToEmit` using a `for each` because
during `EmitGlobalVariable` we can end up adding more things to the vector,
invalidating the iterators. Will push a fix
@@ -2965,6 +2965,7 @@ void DWARFASTParserClang::ParseSingleMember(
// data members is DW_AT_declaration, so we check it instead.
// FIXME: Since DWARFv5, static data members are marked DW_AT_variable so we
// can consistently detect them on both GCC and Clang without
Michael137 wrote:
> > We're seeing crashes after this. Here is a reproducer:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=1502489#c1
> > Please consider reverting if it can't be fixed quickly (I had a look, but
> > it seems there are some dependent changes on top).
>
> Thanks for
Michael137 wrote:
> We're seeing crashes after this. Here is a reproducer:
> https://bugs.chromium.org/p/chromium/issues/detail?id=1502489#c1
>
> Please consider reverting if it can't be fixed quickly (I had a look, but it
> seems there are some dependent changes on top).
Thanks for
zmodem wrote:
We're seeing crashes after this. Here is a reproducer:
https://bugs.chromium.org/p/chromium/issues/detail?id=1502489#c1
Please consider reverting if it can't be fixed quickly (I had a look, but it
seems there are some dependent changes on top).
@@ -1116,9 +1116,9 @@ std::optional
llvm::getIConstantSplatVal(const Register Reg, const MachineRegisterInfo )
{
if (auto SplatValAndReg =
getAnyConstantSplat(Reg, MRI, /* AllowUndef */ false)) {
-std::optional ValAndVReg =
-
https://github.com/AaronBallman converted_to_draft
https://github.com/llvm/llvm-project/pull/68620
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
taalhaataahir0102 wrote:
Hi David! Thanks, we'll update the required changes. Plus we just updated the
test case:
Previously added this in the input file:
> So foo_bar would be matched twice by
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/taalhaataahir0102 updated
https://github.com/llvm/llvm-project/pull/69422
>From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 Mon Sep 17 00:00:00 2001
From:
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Guess I'm gonna take the 100th comment here :)
This is almost ready for "proper" review (people that aren't me). So first
thing is to address the few minor comments I have from this latest review round.
Then, since
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/72236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-15T11:01:52Z
New Revision: 35b10acf201ab873fab4423a37ae6dbe52591f6d
URL:
https://github.com/llvm/llvm-project/commit/35b10acf201ab873fab4423a37ae6dbe52591f6d
DIFF:
https://github.com/llvm/llvm-project/commit/35b10acf201ab873fab4423a37ae6dbe52591f6d.diff
LOG:
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -163,7 +166,10 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -231,6 +231,18 @@ class Stream {
/// The string to be output to the stream.
size_t PutCString(llvm::StringRef cstr);
+ /// Output a C string to the stream with color highlighting.
+ ///
+ /// Print a C
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -231,6 +231,18 @@ class Stream {
/// The string to be output to the stream.
size_t PutCString(llvm::StringRef cstr);
+ /// Output a C string to the stream with color highlighting.
+ ///
+ /// Print a C
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
> This is new for me. Thank you!
New to me too actually. I only went looking for it because I was going to
suggest a two stage format like `%%%ds` and I got that feeling that someone
must have solved this problem
antmox wrote:
Thanks @clayborg, the buildbot is now green again :
https://lab.llvm.org/buildbot/#/builders/219/builds/6947
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
98 matches
Mail list logo
