[Lldb-commits] [lldb] [lldb] Revive shell test after updating UnwindTable (PR #86770)

2024-03-26 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I developed & tested this on aarch64 linux, the only system I have here that runs this shell test. It's a little trickier to test on macOS, we basically only use compact_unwind and it's in the executable binary, not the dSYM SymbolFile.

[Lldb-commits] [lldb] [lldb] Revive shell test after updating UnwindTable (PR #86770)

2024-03-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes In commit 2f63718f8567413a1c596bda803663eb58d6da5a Author: Jason Molenda jmolenda@apple.com Date: Tue Mar 26 09:07:15 2024 -0700 [lldb] Don't clear a Module's UnwindTable when adding a

[Lldb-commits] [lldb] [lldb] Revive shell test after updating UnwindTable (PR #86770)

2024-03-26 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/86770 In commit 2f63718f8567413a1c596bda803663eb58d6da5a Author: Jason Molenda Date: Tue Mar 26 09:07:15 2024 -0700 [lldb] Don't clear a Module's UnwindTable when adding a SymbolFile (#86603) I

[Lldb-commits] [lldb] [lldb][nfc] Delete unused variable (PR #86740)

2024-03-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/86740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread via lldb-commits
jimingham wrote: > This patch provides the initial implementation for the "Step Into > Specific/Step In Targets" feature in VSCode DAP. > > The implementation disassembles all the call instructions in step range and > try to resolve operand name (assuming one operand) using debug info. Later,

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Greg Clayton via lldb-commits
@@ -3180,14 +3180,153 @@ void request_stepIn(const llvm::json::Object ) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments,

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Greg Clayton via lldb-commits
@@ -3180,14 +3180,153 @@ void request_stepIn(const llvm::json::Object ) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments,

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Greg Clayton via lldb-commits
@@ -811,23 +811,34 @@ def request_next(self, threadId): command_dict = {"command": "next", "type": "request", "arguments": args_dict} return self.send_recv(command_dict) -def request_stepIn(self, threadId): +def request_stepInTargets(self, frameId):

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Greg Clayton via lldb-commits
@@ -29,6 +29,9 @@ class LLDB_API SBLineEntry { lldb::SBAddress GetEndAddress() const; + lldb::SBAddress + GetSameLineContiguousAddressRangeEnd(bool include_inlined_functions) const; + clayborg wrote: We don't need this API right? We spoke about using

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Greg Clayton via lldb-commits
@@ -67,6 +67,21 @@ SBAddress SBLineEntry::GetEndAddress() const { return sb_address; } +SBAddress SBLineEntry::GetSameLineContiguousAddressRangeEnd( +bool include_inlined_functions) const { + LLDB_INSTRUMENT_VA(this); + + SBAddress sb_address; + if (m_opaque_up) { +

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Walter Erquinigo via lldb-commits
@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object ) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments,

[Lldb-commits] [lldb] [lldb][nfc] Delete unused variable (PR #86740)

2024-03-26 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/86740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread via lldb-commits
@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object ) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments,

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/86623 >From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 6 Mar 2024 12:07:03 -0800 Subject: [PATCH 1/6] Fix strcmp build error on buildbot ---

[Lldb-commits] [lldb] [lldb][nfc] Delete unused variable (PR #86740)

2024-03-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This was made unused by d9ec4b24a84addb8bd77b5d9dd990181351cf84c. --- Full diff: https://github.com/llvm/llvm-project/pull/86740.diff 1 Files Affected: - (modified)

[Lldb-commits] [lldb] [lldb][nfc] Delete unused variable (PR #86740)

2024-03-26 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/86740 This was made unused by d9ec4b24a84addb8bd77b5d9dd990181351cf84c. >From 1ab938c815d0a1d89520cd8dcc8705bf80f8f89c Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Tue, 26 Mar 2024 14:08:17

[Lldb-commits] [lldb] 156c290 - [lldb] Implement coalescing of disjoint progress events (#84854)

2024-03-26 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-03-26T12:35:34-07:00 New Revision: 156c2907462bc5e97d13d3e7d334a32a291bc787 URL: https://github.com/llvm/llvm-project/commit/156c2907462bc5e97d13d3e7d334a32a291bc787 DIFF:

[Lldb-commits] [lldb] [lldb][Dwarf] Add missing timer when parsing .debug_abbrev. (PR #86568)

2024-03-26 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/86568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 29318ab - [lldb] Remove test for add-symbol-file adds unwind source

2024-03-26 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-03-26T10:54:26-07:00 New Revision: 29318abe1d2c55e8543255d70f26ac93261b74a4 URL: https://github.com/llvm/llvm-project/commit/29318abe1d2c55e8543255d70f26ac93261b74a4 DIFF: https://github.com/llvm/llvm-project/commit/29318abe1d2c55e8543255d70f26ac93261b74a4.diff

[Lldb-commits] [lldb] [lldb] [ObjC runtime] Don't cast to signed when left shifting (PR #86605)

2024-03-26 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/86605 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [ObjC runtime] Don't cast to signed when left shifting (PR #86605)

2024-03-26 Thread Jason Molenda via lldb-commits
@@ -3154,7 +3154,7 @@ AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor( << m_objc_debug_taggedpointer_ext_payload_lshift) >> m_objc_debug_taggedpointer_ext_payload_rshift); int64_t

[Lldb-commits] [lldb] [lldb] [ObjC runtime] Don't cast to signed when left shifting (PR #86605)

2024-03-26 Thread Jason Molenda via lldb-commits
@@ -3154,7 +3154,7 @@ AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor( << m_objc_debug_taggedpointer_ext_payload_lshift) >> m_objc_debug_taggedpointer_ext_payload_rshift); int64_t

[Lldb-commits] [lldb] [lldb] [ObjC runtime] Don't cast to signed when left shifting (PR #86605)

2024-03-26 Thread Jason Molenda via lldb-commits
@@ -3154,7 +3154,7 @@ AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor( << m_objc_debug_taggedpointer_ext_payload_lshift) >> m_objc_debug_taggedpointer_ext_payload_rshift); int64_t

[Lldb-commits] [lldb] [lldb] [ObjC runtime] Don't cast to signed when left shifting (PR #86605)

2024-03-26 Thread Greg Clayton via lldb-commits
@@ -3154,7 +3154,7 @@ AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor( << m_objc_debug_taggedpointer_ext_payload_lshift) >> m_objc_debug_taggedpointer_ext_payload_rshift); int64_t

[Lldb-commits] [lldb] [lldb] [ObjC runtime] Don't cast to signed when left shifting (PR #86605)

2024-03-26 Thread Alex Langford via lldb-commits
@@ -3154,7 +3154,7 @@ AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor( << m_objc_debug_taggedpointer_ext_payload_lshift) >> m_objc_debug_taggedpointer_ext_payload_rshift); int64_t

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Walter Erquinigo via lldb-commits
@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object ) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments,

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Walter Erquinigo via lldb-commits
@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object ) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments,

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread Walter Erquinigo via lldb-commits
@@ -0,0 +1,66 @@ +""" +Test lldb-dap stepInTargets request +""" + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +import lldbdap_testcase +from lldbsuite.test import lldbutil + + +class

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/86623 >From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 6 Mar 2024 12:07:03 -0800 Subject: [PATCH 1/5] Fix strcmp build error on buildbot ---

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes This patch provides the initial implementation for the "Step Into Specific/Step In Targets" feature in VSCode DAP. The implementation disassembles all the call instructions in step range and try to resolve

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/86623 >From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 6 Mar 2024 12:07:03 -0800 Subject: [PATCH 1/4] Fix strcmp build error on buildbot ---

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread via lldb-commits
https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/86623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

2024-03-26 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/86623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 348f9e7 - [lldb] Fix warning: comparison of unsigned expression in >= 0 is always true

2024-03-26 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-03-26T09:13:51-07:00 New Revision: 348f9e73d7175f67750dc40b15cf1fc888bf60b5 URL: https://github.com/llvm/llvm-project/commit/348f9e73d7175f67750dc40b15cf1fc888bf60b5 DIFF:

[Lldb-commits] [lldb] [lldb] Don't clear a Module's UnwindTable when adding a SymbolFile (PR #86603)

2024-03-26 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/86603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2f63718 - [lldb] Don't clear a Module's UnwindTable when adding a SymbolFile (#86603)

2024-03-26 Thread via lldb-commits
Author: Jason Molenda Date: 2024-03-26T09:07:15-07:00 New Revision: 2f63718f8567413a1c596bda803663eb58d6da5a URL: https://github.com/llvm/llvm-project/commit/2f63718f8567413a1c596bda803663eb58d6da5a DIFF: https://github.com/llvm/llvm-project/commit/2f63718f8567413a1c596bda803663eb58d6da5a.diff

[Lldb-commits] [lldb] [lldb] Don't clear a Module's UnwindTable when adding a SymbolFile (PR #86603)

2024-03-26 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/86603 >From b6fcac7d6bb48b7fb665034712407c9ad7e4053a Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Mon, 25 Mar 2024 16:47:11 -0700 Subject: [PATCH] [lldb] Don't clear a Module's UnwindTable when adding a

[Lldb-commits] [lldb] [lldb] Don't clear a Module's UnwindTable when adding a SymbolFile (PR #86603)

2024-03-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks for fixing this! https://github.com/llvm/llvm-project/pull/86603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Dwarf] Add missing timer when parsing .debug_abbrev. (PR #86568)

2024-03-26 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/86568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Dwarf] Add missing timer when parsing .debug_abbrev. (PR #86568)

2024-03-26 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/86568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Dwarf] Fix dwarf parse time for line table and .debug_abbrev. (PR #86568)

2024-03-26 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/86568 >From 19dd9a13c21d70b42b9d68aed6fb0b5a5e494685 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Mon, 25 Mar 2024 15:49:42 -0400 Subject: [PATCH 1/2] [lldb][Dwarf] Fix dwarf parse time for line table and