https://github.com/kusmour approved this pull request.
https://github.com/llvm/llvm-project/pull/89113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/89110
>From e0316188d22605c670079e37855d3d8b5c944cee Mon Sep 17 00:00:00 2001
From: Jacob John Lalonde
Date: Wed, 10 Apr 2024 14:33:40 -0700
Subject: [PATCH 1/2] Fix bug where an sbvalue containing a std::string create
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/88564
>From 8877be23ad4d342e7f9b61896581707005f76d4e Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 12 Apr 2024 09:55:46 -0700
Subject: [PATCH] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam
Summary
@@ -254,13 +254,13 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
addr_of_string =
valobj.GetAddressOf(scalar_is_load_addr, &addr_type);
- if (addr_of_string != LLDB_INVALID_ADDRESS) {
+ if (addr_of_string != LLDB_INVALID_ADDRESS ||
+
Jlalond wrote:
@jimingham
What should we do if the child address type is File? I don't know how that
could ever happen, and should we support it? Because currently we didn't
support summarizing host or file.
https://github.com/llvm/llvm-project/pull/89110
@@ -254,13 +254,13 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
addr_of_string =
valobj.GetAddressOf(scalar_is_load_addr, &addr_type);
- if (addr_of_string != LLDB_INVALID_ADDRESS) {
+ if (addr_of_string != LLDB_INVALID_ADDRESS ||
+
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/88792
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-04-17T16:09:38-04:00
New Revision: 60b90b523323f8196a9e4a68b1f33358624c09eb
URL:
https://github.com/llvm/llvm-project/commit/60b90b523323f8196a9e4a68b1f33358624c09eb
DIFF:
https://github.com/llvm/llvm-project/commit/60b90b523323f8196a9e4a68b1f33358624c09eb.diff
LOG
@@ -572,9 +572,14 @@ ModuleSP DynamicLoaderPOSIXDYLD::LoadInterpreterModule() {
ModuleSpec module_spec(file, target.GetArchitecture());
if (ModuleSP module_sp = target.GetOrCreateModule(module_spec,
-true /* notify */)) {
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/88792
>From 26528cd679478448edf446e0e82e5f207ffd6113 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Mon, 15 Apr 2024 16:30:38 -0400
Subject: [PATCH 1/5] [lldb][DynamicLoader] Fix lldb unable to stop at
_dl_debug_stat
feg208 wrote:
> Yes, you'd have to put this test into a host test for a system that doesn't
> support this, like use the Posix one or make one for the Windows or Darwin
> Hosts.
Done!
https://github.com/llvm/llvm-project/pull/88995
___
lldb-commits
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/88995
>From 9b8ec4d0c31ad1b228add56bc27cd79457e515c7 Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Tue, 16 Apr 2024 14:46:37 -0700
Subject: [PATCH 1/3] adds additional information to the ProcessInfo object for
elf pro
jimingham wrote:
Most of this change makes sense. However, you are assuming that if the address
type of a ValueObject is Host, its children are necessarily going to be in the
target. But there's actually an API that answers that question:
ValueObject::GetAddressTypeOfChildren. You should con
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/88792
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -572,9 +572,14 @@ ModuleSP DynamicLoaderPOSIXDYLD::LoadInterpreterModule() {
ModuleSpec module_spec(file, target.GetArchitecture());
if (ModuleSP module_sp = target.GetOrCreateModule(module_spec,
-true /* notify */)) {
jimingham wrote:
Yes, you'd have to put this test into a host test for a system that doesn't
support this, like use the Posix one or make one for the Windows or Darwin
Hosts.
Jim
> On Apr 17, 2024, at 10:43 AM, Fred Grim ***@***.***> wrote:
>
>
> That test looks good. It seems unlikely tha
@@ -254,13 +254,13 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
addr_of_string =
valobj.GetAddressOf(scalar_is_load_addr, &addr_type);
- if (addr_of_string != LLDB_INVALID_ADDRESS) {
+ if (addr_of_string != LLDB_INVALID_ADDRESS ||
+
@@ -3857,8 +3857,8 @@ thread_result_t Process::RunPrivateStateThread(bool
is_secondary_thread) {
// case we should tell it to stop doing that. Normally, we don't NEED
// to do that because we will next close the communication to the stub
// and that wi
@@ -649,16 +651,25 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP
&process_sp,
DataBufferHeap helper_data;
std::vector mem_descriptors;
for (const auto &core_range : core_ranges) {
-// Skip empty memory regions or any regions with no permissions.
-if
@@ -649,16 +651,25 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP
&process_sp,
DataBufferHeap helper_data;
std::vector mem_descriptors;
for (const auto &core_range : core_ranges) {
-// Skip empty memory regions or any regions with no permissions.
-if
@@ -649,16 +651,25 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP
&process_sp,
DataBufferHeap helper_data;
std::vector mem_descriptors;
for (const auto &core_range : core_ranges) {
-// Skip empty memory regions or any regions with no permissions.
-if
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/89113
>From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Wed, 6 Mar 2024 12:07:03 -0800
Subject: [PATCH 1/3] Fix strcmp build error on buildbot
---
lldb/test/API/fun
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
93f9fb2c825dba48db64d5f726b54bcbd4766009...4453a9cb876fe4ed3c5a3ea57a03a428c5d847fc
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
There are users reporting saving minidump from lldb-dap does not work.
Turns out our stack trace request always evaluate a function call which caused
JIT object file like "__lldb_caller_function" to be created w
https://github.com/jeffreytan81 ready_for_review
https://github.com/llvm/llvm-project/pull/89113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/89113
There are users reporting saving minidump from lldb-dap does not work.
Turns out our stack trace request always evaluate a function call which caused
JIT object file like "__lldb_caller_function" to be crea
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/88792
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -572,9 +572,14 @@ ModuleSP DynamicLoaderPOSIXDYLD::LoadInterpreterModule() {
ModuleSpec module_spec(file, target.GetArchitecture());
if (ModuleSP module_sp = target.GetOrCreateModule(module_spec,
-true /* notify */)) {
https://github.com/tedwoodward approved this pull request.
LGTM, David. One of my guys is working on RISC-V tests, and wanted to use
LLDB_TEST_USER_ARGS, but as you said it doesn't work as documented. This will
help a lot!
https://github.com/llvm/llvm-project/pull/89042
___
feg208 wrote:
> It should never decrease, however. If you were just getting garbage values,
> then there should be a roughly even chance the second value will be less than
> the first. So this still gives some confidence this isn't totally bogus...
For sure. My concern is that it wouldn't incr
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/89110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/89110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
feg208 wrote:
> That test looks good. It seems unlikely that you would buggily always produce
> monotonically increasing times...
>
> Not to be a pest, but since this info is only provided on Linux, we should
> maybe add a test to make sure that asking for this information on systems
> that d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
std::string children are normally formatted as their summary [my_string_prop] =
"hello world". Sbvalues/ValueObjects created from data do not follow the same
summary formatter path and instead hit the value
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/89110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/89110
std::string children are normally formatted as their summary [my_string_prop] =
"hello world". Sbvalues/ValueObjects created from data do not follow the same
summary formatter path and instead hit the value obje
feg208 wrote:
> That test looks good. It seems unlikely that you would buggily always produce
> monotonically increasing times...
>
> Not to be a pest, but since this info is only provided on Linux, we should
> maybe add a test to make sure that asking for this information on systems
> that d
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/88995
>From 9b8ec4d0c31ad1b228add56bc27cd79457e515c7 Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Tue, 16 Apr 2024 14:46:37 -0700
Subject: [PATCH 1/2] adds additional information to the ProcessInfo object for
elf pro
jimingham wrote:
> > The user and system times should be monotonically increasing. So you could
> > stop at a breakpoint, fetch the times, then run your program through a
> > little spin loop to burn some CPU before hitting a second breakpoint. Then
> > get the times again and assert that they
jimingham wrote:
That test looks good. It seems unlikely that you would buggily always produce
monotonically increasing times...
Not to be a pest, but since this info is only provided on Linux, we should
maybe add a test to make sure that asking for this information on systems that
don't pro
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0287a5cc4e2a5ded1ae2e4079f91052e6a6b8d9b
7cf26285a4d75a639d4bbdbf361187c809a5569f --
feg208 wrote:
> The user and system times should be monotonically increasing. So you could
> stop at a breakpoint, fetch the times, then run your program through a little
> spin loop to burn some CPU before hitting a second breakpoint. Then get the
> times again and assert that they are > the
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c6e01627acf8591830ee1d211cff4d5388095f3d
9871016e5cae2d07455cd7857d49dd424066ca41 --
ZequanWu wrote:
> So, could the fix be as simple as passing notify=false in the first call ?
Yeah, absolutely. Updated.
https://github.com/llvm/llvm-project/pull/88792
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/88792
>From 26528cd679478448edf446e0e82e5f207ffd6113 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Mon, 15 Apr 2024 16:30:38 -0400
Subject: [PATCH 1/4] [lldb][DynamicLoader] Fix lldb unable to stop at
_dl_debug_stat
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/88995
>From 9b8ec4d0c31ad1b228add56bc27cd79457e515c7 Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Tue, 16 Apr 2024 14:46:37 -0700
Subject: [PATCH 1/2] adds additional information to the ProcessInfo object for
elf pro
labath wrote:
So, could the fix be as simple as passing notify=false in the first call ?
https://github.com/llvm/llvm-project/pull/88792
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/89042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mordante approved this pull request.
Thanks! The changes LGTM, but I haven't verified the commands work as described.
https://github.com/llvm/llvm-project/pull/89042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
feg208 wrote:
> The user and system times should be monotonically increasing. So you could
> stop at a breakpoint, fetch the times, then run your program through a little
> spin loop to burn some CPU before hitting a second breakpoint. Then get the
> times again and assert that they are > the
DavidSpickett wrote:
If it were a GDB packet it would be in
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Host-I_002fO-Packets.html#Host-I_002fO-Packets
but I see no sign of it, or in GDB's sources.
The first appearance of `vFile:MD5` is e0f8f574c7f41f5b61ec01aa290d52fc55a3f3c9
thoug
ZequanWu wrote:
> Can you check where does the second event get sent from? Is it by any chance
> when we go through
> [this](https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp#L460)
> place ?
The first event is sent when crea
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/89063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-04-17T14:33:18+02:00
New Revision: 915c84b1480bb3c6d2e44ca83822d2c2304b763a
URL:
https://github.com/llvm/llvm-project/commit/915c84b1480bb3c6d2e44ca83822d2c2304b763a
DIFF:
https://github.com/llvm/llvm-project/commit/915c84b1480bb3c6d2e44ca83822d2c2304b763a.diff
labath wrote:
> > > > why not just call ModulesDidLoad and delegate this (and possibly other
> > > > binary-just-loaded) behaviors to it?
> > >
> > >
> > > That's what I did first, but it breaks the test
> > > `TestModuleLoadedNotifys.ModuleLoadedNotifysTestCase.test_launch_notifications`
> >
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
After 281d71604f418eb952e967d9dc4b26241b7f96a, llvm generates 32-bit
relocations, which overflow when we load these objects into high memory.
Interestingly, setting the code model to "large" does not help here
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/89063
After 281d71604f418eb952e967d9dc4b26241b7f96a, llvm generates 32-bit
relocations, which overflow when we load these objects into high memory.
Interestingly, setting the code model to "large" does not help here (p
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/88494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-04-17T13:05:15+02:00
New Revision: 5f3e106de3cd5ce6d7ba37fb11f6ad740cb430c5
URL:
https://github.com/llvm/llvm-project/commit/5f3e106de3cd5ce6d7ba37fb11f6ad740cb430c5
DIFF:
https://github.com/llvm/llvm-project/commit/5f3e106de3cd5ce6d7ba37fb11f6ad740cb430c5.diff
DavidSpickett wrote:
So this PR fixes debug lldb -> release Python, but if I configured against a
debug Python then the suffix would be `_d_d`.
Debug lldb/release Python is a valid config I think, and likely what 99% of
people want anyway. So can we add a check whether the suffix already has `
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
https://discourse.llvm.org/t/running-lldb-in-a-container/76801/4 found that the
obvious way to use this variable doesn't work, despite what our docs and
examples say.
Perhaps in the past it did but n
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/89042
https://discourse.llvm.org/t/running-lldb-in-a-container/76801/4 found that the
obvious way to use this variable doesn't work, despite what our docs and
examples say.
Perhaps in the past it did but now yo
Author: David Spickett
Date: 2024-04-17T09:19:26Z
New Revision: a16bb0701409376dee3a587ae351a6019d6de4e0
URL:
https://github.com/llvm/llvm-project/commit/a16bb0701409376dee3a587ae351a6019d6de4e0
DIFF:
https://github.com/llvm/llvm-project/commit/a16bb0701409376dee3a587ae351a6019d6de4e0.diff
LOG
amordo wrote:
> Looks fine but can you just confirm what
>
> https://github.com/llvm/llvm-project/blob/d1a69e4a6ee0b04778da7728123c47eef2290564/lldb/bindings/python/get-python-config.py#L70
>
> reports?
> I assume this does not include `_d`, otherwise there would be no need for
> this fix?
``
DavidSpickett wrote:
The best docs I can find are https://peps.python.org/pep-0720/:
"Interpreter-specific Python extension (native module) suffix — generally
defined as .{SOABI}.{SHLIB_SUFFIX}."
Which is less than helpful. https://peps.python.org/pep-3149/ mentions Windows
uses a different fo
DavidSpickett wrote:
Looks fine but can you just confirm what
https://github.com/llvm/llvm-project/blob/d1a69e4a6ee0b04778da7728123c47eef2290564/lldb/bindings/python/get-python-config.py#L70
reports?
I assume this does not include `_d`, otherwise there would be no need for this
fix?
https://
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alexander M. (amordo)
Changes
ae389b2450bd604a3f3bbe5b09b333b2d99801dd change doesn't cover "_d" suffix for
Debug build on Windows.
Fixed #87381.
---
Full diff: https://github.com/llvm/llvm-project/pull/89037.diff
1 Files Affected:
- (
https://github.com/amordo created
https://github.com/llvm/llvm-project/pull/89037
ae389b2450bd604a3f3bbe5b09b333b2d99801dd change doesn't cover "_d" suffix for
Debug build on Windows.
Fixed #87381.
>From f9aa0192bb43e15ceab107b2beb0d2d50f1f8150 Mon Sep 17 00:00:00 2001
From: Alexander Mordovs
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/88494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
71 matches
Mail list logo
