GeorgeHuyubo wrote:
Gonna re-open this in a new PR
https://github.com/llvm/llvm-project/pull/92078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Thanks. Can you provide instructions to repro the failure locally?
The bot log should have the cmake line and all the commands that were run there.
https://github.com/llvm/llvm-project/pull/90663
___
lldb-commits mailing list
adrian-prantl wrote:
That's just not how the LLVM project operates.
I'd rather deal with two conflicting PRs than deal with an assigned orphaned
issue that the assignee lost interest in.
This is in the end a communication problem, and I don't mind if someone
responds to the bug to say that
https://github.com/jasonmolenda approved this pull request.
Good change, thanks for fixing this.
https://github.com/llvm/llvm-project/pull/92093
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere requested changes to this pull request.
As per Aiden's suggestion, please split this up into smaller PRs, grouped by
subproject.
https://github.com/llvm/llvm-project/pull/91856
___
lldb-commits mailing list
@@ -0,0 +1,26 @@
+# REQUIRES: (target-aarch64 || target-arm) && native
+# UNSUPPORTED: system-windows
+
+# RUN: %clang_host %S/Inputs/unaligned-pc-sigbus.c -o %t
+# RUN: %lldb -s %s -o exit %t | FileCheck %s
+
+breakpoint set -n sigbus_handler
+# CHECK: Breakpoint 1: where =
https://github.com/JDevlieghere commented:
Thanks!
https://github.com/llvm/llvm-project/pull/91688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/92187
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> Can we make this less brute force? I believe searching for the Build ID Note
> should be a completely deterministic process, without the need for
> heuristics. You start with the elf header, find the program headers, iterate
> to find the PT_NOTE segment (there could be more
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (GeorgeHuyubo)
Changes
As we have debuginfod as symbol locator available in lldb now, we want to make
full use of it.
In case of post mortem debugging, we don't always have the main executable
available.
However, the
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/92187
As we have debuginfod as symbol locator available in lldb now, we want to make
full use of it.
In case of post mortem debugging, we don't always have the main executable
available.
However, the
@@ -983,6 +999,40 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ size_t size = strlen(llvm::ELF::ElfMagic);
+ uint8_t buf[size];
MaskRay wrote:
We can allocate a buffer
@@ -983,6 +999,40 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ size_t size = strlen(llvm::ELF::ElfMagic);
+ uint8_t buf[size];
MaskRay wrote:
```
15: error: variable
walter-erquinigo wrote:
I don't think anything has changed on VSCode proper. I've just verified I have
the same experience as you. Given what you said, I'm in favor of reverting this
or at least gating this feature under a json initialization option until the
original author can look at this.
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/92137
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -762,9 +765,31 @@ void request_attach(const llvm::json::Object ) {
// Disable async events so the attach will be successful when we return
from
// the launch call and the launch will happen synchronously
g_dap.debugger.SetAsync(false);
-if
@@ -335,6 +335,37 @@ def cleanup():
response["success"], "attach failed (%s)" %
(response["message"])
)
+def attach_by_port(
walter-erquinigo wrote:
could you just extend the `def attach` function? Having a totally new entry
@@ -0,0 +1,137 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+import shutil
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (GeorgeHuyubo)
Changes
Reverts llvm/llvm-project#92078
---
Full diff: https://github.com/llvm/llvm-project/pull/92181.diff
5 Files Affected:
- (modified) lldb/include/lldb/Target/Process.h (-50)
- (modified)
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/92181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: GeorgeHuyubo
Date: 2024-05-14T14:36:17-07:00
New Revision: 5bf653ca42dceb8266a0ff70634292ccd2ad4c43
URL:
https://github.com/llvm/llvm-project/commit/5bf653ca42dceb8266a0ff70634292ccd2ad4c43
DIFF:
https://github.com/llvm/llvm-project/commit/5bf653ca42dceb8266a0ff70634292ccd2ad4c43.diff
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/92181
Reverts llvm/llvm-project#92078
>From 38c358868dfb6d22c7e27032ad910c9f4e61092f Mon Sep 17 00:00:00 2001
From: GeorgeHuyubo <113479859+georgehuy...@users.noreply.github.com>
Date: Tue, 14 May 2024 14:35:56
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/92078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: GeorgeHuyubo
Date: 2024-05-14T14:35:35-07:00
New Revision: 536abf827b481f78a0879b02202fb9a3ffe3a908
URL:
https://github.com/llvm/llvm-project/commit/536abf827b481f78a0879b02202fb9a3ffe3a908
DIFF:
https://github.com/llvm/llvm-project/commit/536abf827b481f78a0879b02202fb9a3ffe3a908.diff
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92078
>From 740683faf4a711f8d7c169cb73492657ffb47b39 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 13 May 2024 17:03:30 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92078
>From 6073a22e4da334ac744e1662e8f43abfee4be4f2 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 13 May 2024 17:03:30 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
GeorgeHuyubo wrote:
> Can we make this less brute force? I believe searching for the Build ID Note
> should be a completely deterministic process, without the need for
> heuristics. You start with the elf header, find the program headers, iterate
> to find the PT_NOTE segment (there could be
GeorgeHuyubo wrote:
> Can we make this less brute force? I believe searching for the Build ID Note
> should be a completely deterministic process, without the need for
> heuristics. You start with the elf header, find the program headers, iterate
> to find the PT_NOTE segment (there could be
@@ -0,0 +1,78 @@
+//===-- SBAddressRange.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,58 @@
+//===-- SBAddressRangeList.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
Author: Keith Smiley
Date: 2024-05-14T13:43:04-07:00
New Revision: f918c056f06968763870bc3e6b9f9d7074e1f867
URL:
https://github.com/llvm/llvm-project/commit/f918c056f06968763870bc3e6b9f9d7074e1f867
DIFF:
https://github.com/llvm/llvm-project/commit/f918c056f06968763870bc3e6b9f9d7074e1f867.diff
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/91688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,13 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
@@ -0,0 +1,13 @@
+%extend lldb::SBAddressRangeList {
clayborg wrote:
If we add a method to SBAddressRangeList:
```
bool GetDescription(lldb::SBStream );
```
Then we can add this to this file:
```
STRING_EXTENSION_OUTSIDE(SBAddressRangeList)
```
And then we can
https://github.com/clayborg commented:
We might want SBAddressRange and SBAddressRangeList to have methods:
```
bool GetDescription(lldb::SBStream );
```
Then make sure we add stuff to the .i files so python `str()` calls this.
We do this in many other classes.
@@ -0,0 +1,13 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/87815
>From cdee622a6646ba5c16a3c8156a5a50a938a14b57 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 5 Apr 2024 14:14:30 -0400
Subject: [PATCH 1/3] [lldb]POC implementation for telemetry in LLDB
---
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
@@ -977,35 +977,6 @@ class CommandObjectMemoryFind : public CommandObjectParsed
{
Options *GetOptions() override { return _option_group; }
protected:
- class ProcessMemoryIterator {
- public:
-ProcessMemoryIterator(ProcessSP process_sp, lldb::addr_t base)
-:
@@ -3191,6 +3191,33 @@ Status Process::Halt(bool clear_thread_plans, bool
use_run_lock) {
return Status();
}
+lldb::addr_t Process::FastSearch(lldb::addr_t low, lldb::addr_t high,
clayborg wrote:
rename to `FindInMemory`
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
@@ -117,6 +117,8 @@ class ProcessElfCore : public
lldb_private::PostMortemProcess {
lldb::addr_t end;
lldb::addr_t file_ofs;
std::string path;
+lldb_private::UUID
+uuid; // extracted from .note.gnu.build-id section from core file
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/92078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -158,6 +160,15 @@ class ProcessElfCore : public
lldb_private::PostMortemProcess {
// Returns number of thread contexts stored in the core file
uint32_t GetNumThreadContexts();
+ // Populate gnu uuid for each NT_FILE entry
+ void UpdateBuildIdForNTFileEntries();
+
+
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/92078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
Hmm, actually, I'm not so sure about this change anymore. I went through PEP8
again and saw this:
```
Don’t compare boolean values to True or False using ==:
# Correct:
if greeting:
# Wrong:
if greeting == True:
Worse:
#
slydiman wrote:
The problem is here
lldb\source\Plugins\Process\gdb-remote\GDBRemoteCommunicationClient.cpp, line
3235
inside GDBRemoteCommunicationClient::GetFilePermissions()
```
file_permissions = mode & (S_IRWXU | S_IRWXG | S_IRWXO);
```
But S_IRWXU, S_IRWXG and S_IRWXO are 0 on Windows.
clayborg wrote:
> > I forgot to ask, what is the motivation behind this change? Is there
> > something you can't do with the SBAPI right now or that is better expressed
> > with SBAddressRange and SBAddressRangeList?
>
> Yes, I want to add the following API:
>
> lldb::SBError
labath wrote:
> The problem is that fstat() is fake on Windows. File::GetPermissions()
> returns 0 always. The test got 'File permissions of /some/file.txt (remote):
> 0o' So any permissions manipulations are useles on Windows and these
> tests cannot be adapted.
But who is calling
slydiman wrote:
I have removed @skipIfWindows because these tests are host specific.
https://github.com/llvm/llvm-project/pull/92088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/92088
>From 7dcfe773b6eef27aabbcc7fc68cd6448bc3c2e88 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 14 May 2024 13:08:35 +0400
Subject: [PATCH 1/2] [lldb][Windows] Fixed the test
slydiman wrote:
The problem is that fstat() is fake on Windows. File::GetPermissions() returns
0 always.
The test got 'File permissions of /some/file.txt (remote): 0o' So any
permissions manipulations are useles on Windows and these tests cannot be
adapted.
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T20:05:22+04:00
New Revision: 0f17d9a28c40eebd42c83956e2a7b5186c1814d7
URL:
https://github.com/llvm/llvm-project/commit/0f17d9a28c40eebd42c83956e2a7b5186c1814d7
DIFF:
slydiman wrote:
Agreed. I have removed `@skipIfWindows`. @skipIfRemote is too much. These tests
are still usable for Linux->Linux and such.
https://github.com/llvm/llvm-project/pull/92090
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jimingham wrote:
Thanks!
Jim
> On May 13, 2024, at 6:39 PM, Zequan Wu ***@***.***> wrote:
>
>
> Can you take care of cleaning this up, this seems like a slightly complex
> patch and not in an area I'm familiar with.
>
> Yes, will do. Sorry for the mess without reverting it earlier.
>
> —
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/92090
>From b5b4b996bfa0cdba70f7935e452d6adde6b3cc15 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 14 May 2024 13:18:42 +0400
Subject: [PATCH 1/2] [lldb][Windows] Fixed tests TestPty and TestPtyServer
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
2b15c4a62be6ceab124cb2505ae8dc6a98ba6e7d...6d4df820e84e84a871a6d24a196608047470d7d7
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
ResolveCommand will not succeed for an alias command with arguments, and the
code wasn't providing any. Replace that with explicit query(ies) for the
existence of a command with the given name.
---
Full
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/92137
ResolveCommand will not succeed for an alias command with arguments, and the
code wasn't providing any. Replace that with explicit query(ies) for the
existence of a command with the given name.
>From
labath wrote:
Ah, that explains it. Ship it then.
https://github.com/llvm/llvm-project/pull/92086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> I'm pretty sure lldb was sending these events at some point, but that could
> have change since then. I slightly surprised that this wasn't caught before
> as that would mean noone is running these tests remotely.
>
> Jonas, are you running lldb tests in remote
JDevlieghere wrote:
> If this is split out from the other larger PR, should there be `clang/`
> changes in here?
+1, please unstage the `clang` and `openmp` changes.
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. TILL about `qSpeedTest`.
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath wrote:
> Ah, so the problem here is that we're missing the eh_frame instructions for
> _sigtramp on arm64 with macOS 14. `signal_generating_add` is a frameless
> function (a great stress test in this instance), and _sigtramp is called with
> enough of a faked-up stack that a stack walk
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Comparing a bit of the mock GDB server code to what was in the document I found
these:
* QLaunchArch
* qSpeedTest
* qSymbol
qSymbol is the most mysterious but it did have some examples in a comment
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/92124
Comparing a bit of the mock GDB server code to what was in the document I found
these:
* QLaunchArch
* qSpeedTest
* qSymbol
qSymbol is the most mysterious but it did have some examples in a comment so
mbucko wrote:
> I forgot to ask, what is the motivation behind this change? Is there
> something you can't do with the SBAPI right now or that is better expressed
> with SBAddressRange and SBAddressRangeList?
Yes, I want to add the following API:
lldb::SBError SBProcess::FindInMemory(const
@@ -242,6 +244,12 @@ class AddressRange {
lldb::addr_t m_byte_size = 0; ///< The size in bytes of this address range.
};
+// Forward-declarable wrapper.
+class AddressRanges : public std::vector {
+public:
+ using std::vector::vector;
+};
mbucko wrote:
I
labath wrote:
I'm currently optimizing our data formatters for some fairly complex data
structures, and I've ran into something I don't understand. My DAP packet
sequence for a hover request consists of two (mostly redundant) packets:
```
-->
Content-Length: 114
{
"arguments": {
@@ -0,0 +1,26 @@
+# REQUIRES: (target-aarch64 || target-arm) && native
+# UNSUPPORTED: system-windows
+
+# RUN: %clang_host %S/Inputs/unaligned-pc-sigbus.c -o %t
+# RUN: %lldb -s %s -o exit %t | FileCheck %s
+
+breakpoint set -n sigbus_handler
+# CHECK: Breakpoint 1: where =
@@ -0,0 +1,26 @@
+# REQUIRES: (target-aarch64 || target-arm) && native
+# UNSUPPORTED: system-windows
+
+# RUN: %clang_host %S/Inputs/unaligned-pc-sigbus.c -o %t
+# RUN: %lldb -s %s -o exit %t | FileCheck %s
+
+breakpoint set -n sigbus_handler
+# CHECK: Breakpoint 1: where =
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The stack validation heuristic is counter-productive in this case, as the
unaligned address is most likely the thing that caused the signal in the first
place.
---
Full diff:
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/92093
The stack validation heuristic is counter-productive in this case, as the
unaligned address is most likely the thing that caused the signal in the first
place.
>From 391a4129d3da4c4730e50d6ebca23a3c36c3b462 Mon
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T14:02:31+04:00
New Revision: f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe
URL:
https://github.com/llvm/llvm-project/commit/f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe
DIFF:
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T14:00:16+04:00
New Revision: ac42f7689d741feda2badc438101e7952db048f3
URL:
https://github.com/llvm/llvm-project/commit/ac42f7689d741feda2badc438101e7952db048f3
DIFF:
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T13:57:37+04:00
New Revision: 7b1b1279414217ea7f2402a03dfb5a18ea5a5367
URL:
https://github.com/llvm/llvm-project/commit/7b1b1279414217ea7f2402a03dfb5a18ea5a5367
DIFF:
labath wrote:
Maybe the `skipIfWindows` decorator can also be removed here? We haven't been
historically very good at distinguishing windows hosts and targets (nobody
cared until now), and from the looks of things, these tests could conceivably
work in a linux->windows remote scenario
labath wrote:
Given that the tests use a mock server, why is it a problem that they're
running on a windows host? What's the actual failure? Could they be adapted so
that they run everywhere?
https://github.com/llvm/llvm-project/pull/92088
___
labath wrote:
I'm pretty sure lldb was sending these events at some point, but that could
have change since then. I slightly surprised that this wasn't caught before as
that would mean noone is running these tests remotely.
Jonas, are you running lldb tests in remote configurations?
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
The tests TestPty and TestPtyServer use the Unix specific python builtin module
termios. They are failed in case of Windows host and Linux target. Disable them
for Windows host too.
---
Full diff:
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92090
The tests TestPty and TestPtyServer use the Unix specific python builtin module
termios. They are failed in case of Windows host and Linux target. Disable them
for Windows host too.
>From
https://github.com/labath approved this pull request.
I like this new version, thanks for sticking with me.
https://github.com/llvm/llvm-project/pull/91887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Dmitry Vasilyev
Date: 2024-05-14T10:15:03+01:00
New Revision: 429ce59bd0a7d93ef833939d4a92b56aae103a5a
URL:
https://github.com/llvm/llvm-project/commit/429ce59bd0a7d93ef833939d4a92b56aae103a5a
DIFF:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/92077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 133 matches
Mail list logo
