[Lldb-commits] [lldb] [lldb-dap] Automatically skip lldb-dap tests for remote platforms (PR #93169)

2024-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fa63771 - [lldb-dap] Automatically skip lldb-dap tests for remote platforms (#93169)

2024-05-23 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-24T08:52:32+02:00 New Revision: fa6377119c0624773cb698935692d46843e9f6ec URL: https://github.com/llvm/llvm-project/commit/fa6377119c0624773cb698935692d46843e9f6ec DIFF: https://github.com/llvm/llvm-project/commit/fa6377119c0624773cb698935692d46843e9f6ec.diff

[Lldb-commits] [flang] [lldb] [llvm] [flang] [lldb] [llvm] Fix 'destory' comment typos [NFC] (PR #93260)

2024-05-23 Thread Valentin Clement バレンタイン クレメン via lldb-commits
https://github.com/clementval approved this pull request. https://github.com/llvm/llvm-project/pull/93260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-23 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-23 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 1/7] Add resolvedCommand to transcript, add transcript to statistics d

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-05-23 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: This missed adding support to StructuralValue template arguments to the template differ. See https://github.com/llvm/llvm-project/pull/93265 Te support is still missing, we are just avoiding the crash for now. https://github.com/llvm/llvm-project/pull/78041 ___

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-23 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 1/6] Add resolvedCommand to transcript, add transcript to statistics d

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-23 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 1/5] Add resolvedCommand to transcript, add transcript to statistics d

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-23 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 1/4] Add resolvedCommand to transcript, add transcript to statistics d

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [mlir] [BOLT][BAT] Add entries for deleted basic blocks (PR #91906)

2024-05-23 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/91906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [mlir] [BOLT][BAT] Add entries for deleted basic blocks (PR #91906)

2024-05-23 Thread Amir Ayupov via lldb-commits
aaupov wrote: > Could you elaborate a bit better on why do we need a deleted block to be > present in the table? My memory fails me, aren't we using the translation > table just to map samples collected on the bolted binary? Where do the > deleted blocks become a problem? > > Other than the m

[Lldb-commits] [lldb] [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (PR #93262)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Augusto Noronha (augusto2112) Changes UpdateFormatsIfNeeded has hardcoded the call to GetFormat with no dynamic values. GetFormat will try to find the synthetic children of the ValueObject, and passing the wrong one can fail, which can be

[Lldb-commits] [lldb] [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (PR #93262)

2024-05-23 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/93262 UpdateFormatsIfNeeded has hardcoded the call to GetFormat with no dynamic values. GetFormat will try to find the synthetic children of the ValueObject, and passing the wrong one can fail, which can be bad fo

[Lldb-commits] [flang] [lldb] [llvm] [flang] [lldb] [llvm] Fix 'destory' comment typos [NFC] (PR #93260)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Stephan T. Lavavej (StephanTLavavej) Changes After fixing a test name typo in #93259, I noticed these comment typos. (This is a separate "nice to have" PR, so that it doesn't get mixed up with the test changes that I need.) ---

[Lldb-commits] [flang] [lldb] [llvm] [flang] [lldb] [llvm] Fix 'destory' comment typos [NFC] (PR #93260)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb @llvm/pr-subscribers-coroutines @llvm/pr-subscribers-flang-fir-hlfir Author: Stephan T. Lavavej (StephanTLavavej) Changes After fixing a test name typo in #93259, I noticed these comment typos. (This is a separate "nice to have" PR, so that it does

[Lldb-commits] [flang] [lldb] [llvm] [flang] [lldb] [llvm] Fix 'destory' comment typos [NFC] (PR #93260)

2024-05-23 Thread Stephan T. Lavavej via lldb-commits
https://github.com/StephanTLavavej created https://github.com/llvm/llvm-project/pull/93260 After fixing a test name typo in #93259, I noticed these comment typos. (This is a separate "nice to have" PR, so that it doesn't get mixed up with the test changes that I need.) >From 77ddab4fafd48

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
jimingham wrote: We should definitely put more comments in the ValueObject.h header, a lot of those interfaces are mysterious. GetAddressOf is solving a very particular problem, which is that if someone does: (lldb) expr MakeMeAFooObject() $0= {whatever} (lldb) expr CallAFunctionTakingAFooPoi

[Lldb-commits] [lldb] Reapply "[lldb/aarch64] Fix unwinding when signal interrupts a leaf f… (PR #92503)

2024-05-23 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > The way I see it, this check (at least the part about the RA register(*)) is > heuristic that's impossible to get always right. Like, I could construct a > test case using functions with non-standard ABIs where a non-leaf function > legitimately has a `lr=` rule. Such cod

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/93209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] af31883 - Add a createError variant without error code (NFC) (#93209)

2024-05-23 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-05-23T14:22:07-07:00 New Revision: af31883341a122a7285e9b4f0a034470024021eb URL: https://github.com/llvm/llvm-project/commit/af31883341a122a7285e9b4f0a034470024021eb DIFF: https://github.com/llvm/llvm-project/commit/af31883341a122a7285e9b4f0a034470024021eb.diff

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-23 Thread Alex Langford via lldb-commits
@@ -0,0 +1,65 @@ +//===-- SBAddressRange.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread David Blaikie via lldb-commits
dwblaikie wrote: But seems like this isn't a DW_IDX_parent issue, then (other than as /maybe/ an artifact of the producer) - so the description seems misleading. "ignore invalid named entries that refer to declarations" A test case/demonstration this is a real problem would be nice, though...

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread David Blaikie via lldb-commits
dwblaikie wrote: As for the original issue this patch is meant to address - I'd still like to see an example of the problem, as I'm not sure what the issue is. (but, equally, I'm not a decider in lldb - so don't have to wait on my for approval if other lldb devs reckon this is the right direct

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-23 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,65 @@ +//===-- SBAddressRange.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-23 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,28 @@ +%extend lldb::SBAddressRangeList { +#ifdef SWIGPYTHON +%pythoncode%{ +def __len__(self): + '''Return the number of address ranges in a lldb.SBAddressRangeList object.''' + return self.GetSize() + +def __iter__(self): + '''Iterate over

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-23 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,65 @@ +//===-- SBAddressRange.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread David Blaikie via lldb-commits
dwblaikie wrote: > "std::ios_base" is forward declared and it contains typedefs whose entries in > the .debug_names table will point to the DIE at offset 0x0090cdd5. These > entries cause our type lookups to try and parse a TON of forward declarations > and waste time and resources. > > This

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread Jacob Lalonde via lldb-commits
@@ -254,13 +254,17 @@ bool lldb_private::formatters::LibStdcppStringSummaryProvider( } else addr_of_string = valobj.GetAddressOf(scalar_is_load_addr, &addr_type); - if (addr_of_string != LLDB_INVALID_ADDRESS) { + + // We have to check for host address here + /

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread Jacob Lalonde via lldb-commits
@@ -17,6 +17,15 @@ def setUp(self): # Find the line number to break at. self.line = line_number("main.cpp", "// Set break point at this line.") +# This is the function to remove the custom formats in order to have a Jlalond wrote: This PR

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. This will be very useful. LGTM! https://github.com/llvm/llvm-project/pull/93209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-23 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92492 >From a9714b155a116e9b1d18434c0485ea2ad35680f3 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 14 May 2024 16:18:20 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- .../Proc

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -254,13 +254,17 @@ bool lldb_private::formatters::LibStdcppStringSummaryProvider( } else addr_of_string = valobj.GetAddressOf(scalar_is_load_addr, &addr_type); - if (addr_of_string != LLDB_INVALID_ADDRESS) { + + // We have to check for host address here + /

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/93209 >From c5738598436c7a9e1ba38ba8ffd6f67a2e524785 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 23 May 2024 08:36:48 -0700 Subject: [PATCH] Add a createError variant without error code (NFC) For the

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/93209 >From bece445681b0f810927c799cea53686cd000339b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 23 May 2024 08:36:48 -0700 Subject: [PATCH] Add a createError variant without error code (NFC) For the

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread Jacob Lalonde via lldb-commits
@@ -2763,10 +2763,10 @@ ValueObjectSP ValueObject::Cast(const CompilerType &compiler_type) { ExecutionContextScope *exe_scope = ExecutionContext(GetExecutionContextRef()) .GetBestExecutionContextScope(); - if (compiler_type.GetByteSize(exe_scope) - <= G

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/89110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -17,6 +17,15 @@ def setUp(self): # Find the line number to break at. self.line = line_number("main.cpp", "// Set break point at this line.") +# This is the function to remove the custom formats in order to have a jimingham wrote: Ah, I

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -17,6 +17,15 @@ def setUp(self): # Find the line number to break at. self.line = line_number("main.cpp", "// Set break point at this line.") +# This is the function to remove the custom formats in order to have a jimingham wrote: If you

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -0,0 +1,49 @@ +# coding=utf8 +""" +Helper formmater to verify Std::String by created via SBData jimingham wrote: formmater -> formatter https://github.com/llvm/llvm-project/pull/89110 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -2763,10 +2763,10 @@ ValueObjectSP ValueObject::Cast(const CompilerType &compiler_type) { ExecutionContextScope *exe_scope = ExecutionContext(GetExecutionContextRef()) .GetBestExecutionContextScope(); - if (compiler_type.GetByteSize(exe_scope) - <= G

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -16,9 +16,12 @@ #include "lldb/DataFormatters/VectorIterator.h" #include "lldb/Target/Target.h" #include "lldb/Utility/DataBufferHeap.h" +#include "lldb/Utility/DataExtractor.h" #include "lldb/Utility/Endian.h" #include "lldb/Utility/Status.h" #include "lldb/Utility/Strea

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: OK, thanks for detailed explanation. Will re-read few more time to fully process it. :) I'll change BOLT behavior to reflect the new clang behavior. If there is a forward delcaration (skeleton die), the parent chain won't skip it, but instead won't emit parent for it's children

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread via lldb-commits
jimingham wrote: LGTM. We do offer SBValue::GetDescription, which uses a default DumpValueObjectOptions. So it would be entirely reasonable to make an SBValueObjectDescriptionOptions (or maybe a shorter name?) and add SBValue::GetDescription(SBValueObjectDescriptionOptions) API. But peopl

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-23 Thread Petr Hosek via lldb-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/92865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-23 Thread Vlad Serebrennikov via lldb-commits
Endilll wrote: > FYI this causes a minor compile-time improvement in stage1 builds using gcc: > https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u > While that's nice, it does suggest th

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Adrian Prantl via lldb-commits
@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() { if (err == 0) { if (wsaData.wVersion < wVersion) { WSACleanup(); - return llvm::make_error( - "WSASock version is not expected.", llvm::inconvertibleErrorCode()); + return llvm::createStringErro

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Jonas Devlieghere via lldb-commits
@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() { if (err == 0) { if (wsaData.wVersion < wVersion) { WSACleanup(); - return llvm::make_error( - "WSASock version is not expected.", llvm::inconvertibleErrorCode()); + return llvm::createStringErro

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I'm in favor of this. I rarely have a meaningful error code and it makes the code needlessly verbose. I was going to ask if we wanted to make an overload of the existing `createStringError` but without the error code. But then I noticed that it uses

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/93209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread David Blaikie via lldb-commits
dwblaikie wrote: Sorry I can't quite figure out who/where to reply to, so perhaps by summarizing the situation (though it's going to be verbose, and I'm going to add some other examples/complications) I can get a grip on all this/clarify where we're at. So, history. * minimum spec-compliant

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-23 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: These types of changes touching a lot of projects at once can benefit from multiple PRs, one per project, as it makes partial reverts a lot easier and doesn't cause as much churn downstream (plus we can get more targeted comments from individual project owners) https://g

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-23 Thread Nikita Popov via lldb-commits
nikic wrote: FYI this causes a minor compile-time improvement in stage1 builds using gcc: https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u While that's nice, it does suggest that the f

[Lldb-commits] [lldb] [lldb-dap] Send terminated event only once (PR #93172)

2024-05-23 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/93172 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Send terminated event only once (PR #93172)

2024-05-23 Thread via lldb-commits
https://github.com/kusmour approved this pull request. Thanks for fixing it :) Just tested this patch from my side, worked well! https://github.com/llvm/llvm-project/pull/93172 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [lldb-dap] Automatically skip lldb-dap tests for remote platforms (PR #93169)

2024-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/93169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: The obvious downside is that it makes it easier to not even try to find a matching error code, but it looks like most incontrovertible errors are caught before the get reported as an exit status. https://github.com/llvm/llvm-project/pull/93209 _

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Adrian Prantl (adrian-prantl) Changes For the significant amount of call sites that want to create an incontrovertible error, such a wrapper function creates a significant readability improvement and lowers the cost of entry to add

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/93209 For the significant amount of call sites that want to create an incontrovertible error, such a wrapper function creates a significant readability improvement and lowers the cost of entry to add error handl

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > Current BOLT behavior is to skip that DIE and reference it's parent: This, on the other hand, is concerning. It needs to reflect the debug_info section, otherwise we can't use debug_names to answer queries like "find A::B::C::D". It would be better if the BOLT compiler

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Ohhh ok, I just inspected the debug_names/debug_info sections; there is no parent at all for the InnerState debug_names entry. In this case, the debug_names section is valid. Unfortunate, as this may cause entire CUs/TUs to be parsed (because of all the calls to Process

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: > > Since clang no longer emits entry for: > > But what does the `debug_info` section look like? In particular, what is the > _parent_ of the class DIE? If the parent of `InnerState` is not some kind of > entry for `State` (either a declaration or a definition), IMO Clang is >

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: > > Using example above, with a fix by @dwblaikie > > I see: > > ``` > > Hash: 0xE0CDC6A2 > > String: 0x0018 "InnerState" > > Entry @ 0x10b { > > Abbrev: 0x3 > > Tag: DW_TAG_class_type > > DW_IDX_type_unit: 0x01 > > DW_IDX_die_offse

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-23 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: >Since clang no longer emits entry for: But what does the `debug_info` section look like? In particular, what is the _parent_ of the class DIE? If the parent of `InnerState` is not some kind of entry for `State` (either a declaration or a definition), IMO Clang is genera

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @jimingham it turned out when created by data, the value object's address points to it's buffer which itself contains the char* of the string. I'm not sure how we can support the small string optimization if this is the case, my testing was against a small string "test2", and it

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/89110 >From 5955863f22d5048cad91f089e96b10ea15c05446 Mon Sep 17 00:00:00 2001 From: Jacob John Lalonde Date: Wed, 10 Apr 2024 14:33:40 -0700 Subject: [PATCH 1/7] Fix bug where an sbvalue containing a std::string create

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-23 Thread Vlad Serebrennikov via lldb-commits
Endilll wrote: Quite expectedly, I see buildbot failures. Working on them. https://lab.llvm.org/buildbot/#/builders/36/builds/45836 https://lab.llvm.org/buildbot/#/builders/57/builds/35200 https://github.com/llvm/llvm-project/pull/92953 ___ lldb-commit

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/93158 >From 0c6fe37563d7e7ee338a308b32cbea01d1f3808c Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 May 2024 13:08:54 + Subject: [PATCH 1/2] [lldb][Test] Add C++ tests for DumpValueObjectOptions a

[Lldb-commits] [lldb] 4feae05 - Remove some `try_compile` CMake checks for compiler flags (#92953)

2024-05-23 Thread via lldb-commits
Author: Vlad Serebrennikov Date: 2024-05-23T17:05:41+04:00 New Revision: 4feae05c6abda364a9295aecfa600d7d4e7dfeb6 URL: https://github.com/llvm/llvm-project/commit/4feae05c6abda364a9295aecfa600d7d4e7dfeb6 DIFF: https://github.com/llvm/llvm-project/commit/4feae05c6abda364a9295aecfa600d7d4e7dfeb6.

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-23 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/92953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 32c3561 - [lldb][Test] Escape | chars in enum tests

2024-05-23 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-05-23T12:28:26Z New Revision: 32c3561d44aa792ef08d72b5a4c342c9965bc4c2 URL: https://github.com/llvm/llvm-project/commit/32c3561d44aa792ef08d72b5a4c342c9965bc4c2 DIFF: https://github.com/llvm/llvm-project/commit/32c3561d44aa792ef08d72b5a4c342c9965bc4c2.diff LOG

[Lldb-commits] [lldb] [lldb-dap] Automatically skip lldb-dap tests for remote platforms (PR #93169)

2024-05-23 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/93169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Send terminated event only once (PR #93172)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This is a regression from #91591. Turns out std::mutex does not prevent code from running twice. :facepalm: --- Full diff: https://github.com/llvm/llvm-project/pull/93172.diff 2 Files Affected: - (modified)

[Lldb-commits] [lldb] [lldb-dap] Send terminated event only once (PR #93172)

2024-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/93172 This is a regression from #91591. Turns out std::mutex does not prevent code from running twice. :facepalm: >From 26611411308c9a916bc3ffdac0f38e95f8aa8c89 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 2

[Lldb-commits] [lldb] [lldb-dap] Automatically skip lldb-dap tests for remote platforms (PR #93169)

2024-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/93169 >From 7f3ed4661375ca61f4ac0fedafb57c628eca3bd0 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 23 May 2024 10:56:48 + Subject: [PATCH] [lldb-dap] Automatically skip lldb-dap tests for remote platforms

[Lldb-commits] [lldb] [lldb-dap] Automatically skip lldb-dap tests for remote platforms (PR #93169)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The don't currently work (and they're also not particularly useful, since all of the remote stuff happens inside lldb). This saves us from annotating tests one by one. --- Patch is 32.71 KiB, truncated to 20

[Lldb-commits] [lldb] [lldb-dap] Automatically skip lldb-dap tests for remote platforms (PR #93169)

2024-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/93169 The don't currently work (and they're also not particularly useful, since all of the remote stuff happens inside lldb). This saves us from annotating tests one by one. >From 0b29674bdedee83336047a3a8de8b35980853

[Lldb-commits] [lldb] [lldb] Fixed the TestDAP_repl_mode_detection test in case of a remote target (PR #93165)

2024-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath requested changes to this pull request. I'm knee-deep in lldb-dap right now. Lemme just send you a PR to skip all tests at once. https://github.com/llvm/llvm-project/pull/93165 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb] Fixed the TestDAP_repl_mode_detection test in case of a remote target (PR #93165)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This test is based on dap_server which runs locally. This test failed in case of Windows host and Linux target. --- Full diff: https://github.com/llvm/llvm-project/pull/93165.diff 1 Files Affected: - (

[Lldb-commits] [lldb] [lldb] Fixed the TestDAP_repl_mode_detection test in case of a remote target (PR #93165)

2024-05-23 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/93165 This test is based on dap_server which runs locally. This test failed in case of Windows host and Linux target. >From 2243749477714852ada7a00bb849514283655464 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Dat

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread David Spickett via lldb-commits
@@ -0,0 +1,136 @@ +//===-- DumpValueObjectOptionsTests.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/93158 >From aff2acafd911b9eb07405beb5500a487f5d4fc4e Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 May 2024 13:08:54 + Subject: [PATCH 1/2] [lldb][Test] Add C++ tests for DumpValueObjectOptions a

[Lldb-commits] [lldb] [lldb] Fixed the TestExitDuringExpression test in case of a remote target (PR #93119)

2024-05-23 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/93119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e37da2c - [lldb] Fixed the TestExitDuringExpression test in case of a remote target (#93119)

2024-05-23 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-23T14:01:10+04:00 New Revision: e37da2cef7ea44f6aa52dd37978b287a0741c39f URL: https://github.com/llvm/llvm-project/commit/e37da2cef7ea44f6aa52dd37978b287a0741c39f DIFF: https://github.com/llvm/llvm-project/commit/e37da2cef7ea44f6aa52dd37978b287a0741c39f.dif

[Lldb-commits] [lldb] [lldb][Windows] Fixed the TestBreakpointCommand test (PR #93122)

2024-05-23 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/93122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4d9e7b1 - [lldb][Windows] Fixed the TestBreakpointCommand test (#93122)

2024-05-23 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-23T13:59:02+04:00 New Revision: 4d9e7b14e45120557e57da2f00f6d23cf122dd95 URL: https://github.com/llvm/llvm-project/commit/4d9e7b14e45120557e57da2f00f6d23cf122dd95 DIFF: https://github.com/llvm/llvm-project/commit/4d9e7b14e45120557e57da2f00f6d23cf122dd95.dif

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread David Spickett via lldb-commits
@@ -0,0 +1,136 @@ +//===-- DumpValueObjectOptionsTests.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread David Spickett via lldb-commits
@@ -0,0 +1,136 @@ +//===-- DumpValueObjectOptionsTests.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes DumpValueObjectOptions can only be created and modified from C++. This means it's currently only testable from Python by calling some command that happens to use one, and even so, you can't pick which

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/93158 DumpValueObjectOptions can only be created and modified from C++. This means it's currently only testable from Python by calling some command that happens to use one, and even so, you can't pick which opti

[Lldb-commits] [lldb] [lldb/DWARF] Make sure bad abbreviation codes do not crash lldb (PR #93006)

2024-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a282463 - [lldb/DWARF] Make sure bad abbreviation codes do not crash lldb (#93006)

2024-05-23 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-23T11:23:07+02:00 New Revision: a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb URL: https://github.com/llvm/llvm-project/commit/a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb DIFF: https://github.com/llvm/llvm-project/commit/a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb.diff

[Lldb-commits] [lldb] [lldb/DWARF] Make sure bad abbreviation codes do not crash lldb (PR #93006)

2024-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/93006 >From 03ab6febc0f40d0f39f533a5b4fd7c33a6728ae1 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 21 May 2024 15:31:23 + Subject: [PATCH 1/2] [lldb/DWARF] Make sure bad abbreviation codes do not crash lld

[Lldb-commits] [lldb] [lldb/DWARF] Make sure bad abbreviation codes do not crash lldb (PR #93006)

2024-05-23 Thread Pavel Labath via lldb-commits
labath wrote: > We have to back out the PeekDieName() patch locally at Meta because it was > crashing us due to this assertion due to .debug_names tables having incorrect > values for type units. Only one type unit will appear in the final file and > type units can have differing contents for

[Lldb-commits] [lldb] [lldb/DWARF] Make sure bad abbreviation codes do not crash lldb (PR #93006)

2024-05-23 Thread Pavel Labath via lldb-commits
@@ -44,10 +45,20 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor &data, const DWARFUnit *cu, lldb::offset_t *offset_ptr) { m_offset = *offset_ptr; + auto report_error = [&](const char *fmt, co

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-05-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'm currently assuming that the process classes will check those HWCAPs and only add those registers to the register info if they exist. This code only patches registers that are already in the info, it doesn't add any new ones. That said, explicit is better than implicit,

[Lldb-commits] [lldb] [lldb] Remove DWARFDebugInfo DIERef footguns (PR #92894)

2024-05-23 Thread Pavel Labath via lldb-commits
@@ -195,17 +195,17 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( if (!ref) continue; -DWARFUnit *cu = m_debug_info.GetUnit(*ref); -if (!cu || !cu->Supports_DW_AT_APPLE_objc_complete_type()) { - incomplete_types.push_back(*ref); - continue; -

[Lldb-commits] [lldb] Revert "[lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (Reland #70392)" (PR #93153)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes Reverts llvm/llvm-project#93149 since it breaks https://lab.llvm.org/buildbot/#/builders/68/builds/74799 --- Patch is 60.44 KiB, truncated to 20.00 KiB below, full version: https://github.com/llv

[Lldb-commits] [lldb] Revert "[lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (Reland #70392)" (PR #93153)

2024-05-23 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/93153 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ae3f680 - Revert "[lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (Reland #70392)" (#93153)

2024-05-23 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-05-23T01:46:29-07:00 New Revision: ae3f68066c8f282145435880107c1d3dc26ec3b8 URL: https://github.com/llvm/llvm-project/commit/ae3f68066c8f282145435880107c1d3dc26ec3b8 DIFF: https://github.com/llvm/llvm-project/commit/ae3f68066c8f282145435880107c1d3dc26ec3b8.

[Lldb-commits] [lldb] Revert "[lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (Reland #70392)" (PR #93153)

2024-05-23 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/93153 Reverts llvm/llvm-project#93149 since it breaks https://lab.llvm.org/buildbot/#/builders/68/builds/74799 >From 788e65c8171e233d399f3f1df645d6f9fb8f66bc Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Dat

  1   2   >