[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -1603,41 +1633,76 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const DWARFDIE &die) { TypeSP DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, - const DWARFDIE &decl_die, +

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const DWARFDIE &die) { return {}; } +void DWARFASTParserClang::MappingDeclDIEToDefDIE( +const lldb_private::plugin::dwarf::DWARFDIE &decl_die, +const lldb_private::plugin::dwarf::DWARFDIE &def_die)

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -4,8 +4,8 @@ // REQUIRES: lld -// RUN: %clang --target=x86_64-pc-linux -c %s -o %t-a.o -g -gsimple-template-names -DFILE_A -// RUN: %clang --target=x86_64-pc-linux -c %s -o %t-b.o -g -gsimple-template-names -DFILE_B labath wrote: We should keep the exis

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const DWARFDIE &die) { return {}; } +void DWARFASTParserClang::MappingDeclDIEToDefDIE( labath wrote: nit: Maybe you're reading this another way, but this name does not sound like a verb p

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

https://github.com/labath commented: Thanks. I think this looks pretty good now, just a couple of details to sort out. https://github.com/llvm/llvm-project/pull/98361 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const DWARFDIE &die) { return {}; } +void DWARFASTParserClang::MappingDeclDIEToDefDIE( +const lldb_private::plugin::dwarf::DWARFDIE &decl_die, +const lldb_private::plugin::dwarf::DWARFDIE &def_die)

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -1631,27 +1638,49 @@ bool SymbolFileDWARF::CompleteType(CompilerType &compiler_type) { return true; } - DWARFDIE dwarf_die = GetDIE(die_it->getSecond()); - if (dwarf_die) { -// Once we start resolving this type, remove it from the forward -// declaration ma

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98361 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

beetrees wrote: (I've fixed the CI failure.) https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

https://github.com/beetrees updated https://github.com/llvm/llvm-project/pull/98369 >From 5e29db435c239a4817256d308727d772dca1a7e8 Mon Sep 17 00:00:00 2001 From: beetrees Date: Thu, 11 Jul 2024 19:56:45 +0100 Subject: [PATCH 1/2] [lldb] Format `lldb-enumerations.h` (NFC) --- lldb/include/lldb

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a853fe25df1cda0117055c0d836e7b107d98c791 8602d97a8a9b1f81b6776bede708eeb54bc3 --e

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazuki Sakamoto (splhack) Changes # Goal Fix Android debugging # What This pull request reverts these two commits because it broke Android debugging as explained below. - https://github.com/llvm/llvm-project/commit/bf3e3289d67cb0fe136b

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

https://github.com/splhack created https://github.com/llvm/llvm-project/pull/98581 # Goal Fix Android debugging # What This pull request reverts these two commits because it broke Android debugging as explained below. - https://github.com/llvm/llvm-project/commit/bf3e3289d67cb0fe136b0660ca

[Lldb-commits] [lldb] [lldb] Unify Platform::ResolveExecutable (PR #96256)

clayborg wrote: This did indeed break Android debugging. We reverted this in our repo and functionality was restored https://github.com/llvm/llvm-project/pull/96256 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] Unify Platform::ResolveExecutable (PR #96256)

clayborg wrote: We think this broke Android debugging on our end. We are investigating. https://github.com/llvm/llvm-project/pull/96256 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

@@ -46,6 +46,7 @@ static constexpr FormatInfo g_format_infos[] = { {eFormatHex, 'x', "hex"}, {eFormatHexUppercase, 'X', "uppercase hex"}, {eFormatFloat, 'f', "float"}, +{eFormatFloat128, '\0', "float128"}, beetrees wrote: There's a static asser

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 7b604cdf75fd1c741a15138684ea0e98dca5e46f...fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 lldb/

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7b604cdf75fd1c741a15138684ea0e98dca5e46f fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 --e

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

jimingham wrote: This test was marked as flakey on some Linux systems, but so were other of the process event tests in this file, which should not have been affected by this patch. So I don't think this is going to fix whatever was flakey in general, though it should help this test. https://

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes This fixes a bug where Process events were being delivered to secondary listeners when the Private state thread listener was processing the event. That meant the secondary listener could get an event before the Pr

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/98571 This fixes a bug where Process events were being delivered to secondary listeners when the Private state thread listener was processing the event. That meant the secondary listener could get an event before t

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

@@ -46,6 +46,7 @@ static constexpr FormatInfo g_format_infos[] = { {eFormatHex, 'x', "hex"}, {eFormatHexUppercase, 'X', "uppercase hex"}, {eFormatFloat, 'f', "float"}, +{eFormatFloat128, '\0', "float128"}, jasonmolenda wrote: I'm not familiar w

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/98568 >From 13af0ff31688ca0a23f1fec65ca2d5797b65e31f Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 11 Jul 2024 17:24:41 -0700 Subject: [PATCH 1/2] Support single stopped event in lldb-dap --- .../test/t

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b81fcd01bde51eb8976b81a2c0c19fc0645cd2ff...13af0ff31688ca0a23f1fec65ca2d5797b65e31f lldb/

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes Some targets have non-trivial amount of threads, when stopping, multiple stopped events can be sent causing VSCode to show multiple yellow lines in code editor which can be confusing to end users. This PR intr

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/98568 Some targets have non-trivial amount of threads, when stopping, multiple stopped events can be sent causing VSCode to show multiple yellow lines in code editor which can be confusing to end users. This PR

[Lldb-commits] [lldb] [lldb] Allow fetching of RA register when above fault handler (PR #98566)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes In RegisterContextUnwind::SavedLocationForRegister we have special logic for retrieving the Return Address register when it has the caller's return address in it. An example would be the lr register on

[Lldb-commits] [lldb] [lldb] Allow fetching of RA register when above fault handler (PR #98566)

https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/98566 In RegisterContextUnwind::SavedLocationForRegister we have special logic for retrieving the Return Address register when it has the caller's return address in it. An example would be the lr register on AArc

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7021e44b2f0e11717c0d82456bad0fed4a0b48f9 1e86ac615e751f0c98836690a1a8ca2b007be03b --e

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -1631,26 +1638,48 @@ bool SymbolFileDWARF::CompleteType(CompilerType &compiler_type) { return true; } - DWARFDIE dwarf_die = GetDIE(die_it->getSecond()); - if (dwarf_die) { -// Once we start resolving this type, remove it from the forward -// declaration ma

[Lldb-commits] [lldb] 1988c27 - [lldb] [NFC] Update TestEarlyProcessLaunch to work on macOS 15

Author: Jason Molenda Date: 2024-07-11T16:51:28-07:00 New Revision: 1988c27e5f4dbcf42c9a80f44bdee7ccd208a0ac URL: https://github.com/llvm/llvm-project/commit/1988c27e5f4dbcf42c9a80f44bdee7ccd208a0ac DIFF: https://github.com/llvm/llvm-project/commit/1988c27e5f4dbcf42c9a80f44bdee7ccd208a0ac.diff

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/98361 >From 37b6878b9125c314c75053f7d5b0ba520111e9a3 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Tue, 9 Jul 2024 15:28:19 -0700 Subject: [PATCH 1/2] Reapply [lldb][DWARF] Delay struct/class/union definition DIE se

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

https://github.com/beetrees edited https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (PR #98464)

https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (PR #98464)

https://github.com/JDevlieghere approved this pull request. This is more robust and I like that it doesn't risk breaking the clang resource directory path. LGTM. https://github.com/llvm/llvm-project/pull/98464 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -1631,26 +1638,48 @@ bool SymbolFileDWARF::CompleteType(CompilerType &compiler_type) { return true; } - DWARFDIE dwarf_die = GetDIE(die_it->getSecond()); - if (dwarf_die) { -// Once we start resolving this type, remove it from the forward -// declaration ma

[Lldb-commits] [lldb] [lldb] Fix section printing to always align. (PR #98521)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/98521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DRAFT][llvm]Added lib/Telemetry (PR #98528)

nikic wrote: Why does any part of this need to be in llvm/ at all? https://github.com/llvm/llvm-project/pull/98528 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ea4ae25 - [lldb] Fix section printing to always align. (#98521)

Author: Greg Clayton Date: 2024-07-11T12:58:24-07:00 New Revision: ea4ae2590dea6ab5acf790a6098863d4ba63300f URL: https://github.com/llvm/llvm-project/commit/ea4ae2590dea6ab5acf790a6098863d4ba63300f DIFF: https://github.com/llvm/llvm-project/commit/ea4ae2590dea6ab5acf790a6098863d4ba63300f.diff

[Lldb-commits] [lldb] [lldb][man][nfc] Don't register a markdown parser when building man packages (PR #98420)

https://github.com/alanzhao1 closed https://github.com/llvm/llvm-project/pull/98420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 43024a4 - [lldb][man][nfc] Don't register a markdown parser when building man packages (#98420)

Author: Alan Zhao Date: 2024-07-11T12:54:26-07:00 New Revision: 43024a465120315464490ca9c6074553cd968089 URL: https://github.com/llvm/llvm-project/commit/43024a465120315464490ca9c6074553cd968089 DIFF: https://github.com/llvm/llvm-project/commit/43024a465120315464490ca9c6074553cd968089.diff LOG

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

chelcassanova wrote: Just making sure, a setting for changing the prefix/suffix would be in `CoreProperties.td` right? https://github.com/llvm/llvm-project/pull/91404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb] Fix section printing to always align. (PR #98521)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes Section IDs are 64 bit and if a section ID was over 4GB, then the tabular output of the "target modules dump sections" command would not align to the column headers. Also if the section type's name was too l

[Lldb-commits] [lldb] [lldb] Fix section printing to always align. (PR #98521)

https://github.com/clayborg created https://github.com/llvm/llvm-project/pull/98521 Section IDs are 64 bit and if a section ID was over 4GB, then the tabular output of the "target modules dump sections" command would not align to the column headers. Also if the section type's name was too long

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

@@ -55,14 +55,23 @@ def test_basic(self): self.assertEqual(len(step_in_targets), 3, "expect 3 step in targets") # Verify the target names are correct. -self.assertEqual(step_in_targets[0]["label"], "bar()", "expect bar()") -self.assertEqual(step

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

https://github.com/kendalharland updated https://github.com/llvm/llvm-project/pull/96687 >From 02f06f90a40cc7ed18a9744918acf4daf6212486 Mon Sep 17 00:00:00 2001 From: kendal Date: Mon, 24 Jun 2024 14:01:31 -0700 Subject: [PATCH 1/2] Fix test assertions in TestDAP_stepInTargets.py --- .../step

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

https://github.com/JDevlieghere commented: This is looking good, but needs a (pexpect) test. I would also like to add a setting to make the prefix and suffix configurable, like we do for things like `show-progress-ansi-prefix` and `show-autosuggestion-ansi-prefix`. That way user can pick their

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

@@ -1631,26 +1638,48 @@ bool SymbolFileDWARF::CompleteType(CompilerType &compiler_type) { return true; } - DWARFDIE dwarf_die = GetDIE(die_it->getSecond()); - if (dwarf_die) { -// Once we start resolving this type, remove it from the forward -// declaration ma

[Lldb-commits] [lldb] [lldb][man][nfc] Don't register a markdown parser when building man packages (PR #98420)

https://github.com/alanzhao1 updated https://github.com/llvm/llvm-project/pull/98420 >From fab10fb2efe8265d1b403a650dbd2d3348f29b73 Mon Sep 17 00:00:00 2001 From: Alan Zhao Date: Wed, 10 Jul 2024 15:56:39 -0700 Subject: [PATCH 1/3] [lldb][man][nfc] Don't register a markdown parser when buildin

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

jimingham wrote: > On Jul 10, 2024, at 9:22 PM, cmtice ***@***.***> wrote: > > > @cmtice commented on this pull request. > > In lldb/include/lldb/Core/DILAST.h > : > > > +/// Checks to see if the CompilerType is a Smar

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

@@ -55,14 +55,23 @@ def test_basic(self): self.assertEqual(len(step_in_targets), 3, "expect 3 step in targets") # Verify the target names are correct. -self.assertEqual(step_in_targets[0]["label"], "bar()", "expect bar()") -self.assertEqual(step

[Lldb-commits] [lldb] [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (PR #98432)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/98432 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 55b1410 - [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (#98432)

Author: Greg Clayton Date: 2024-07-11T09:18:43-07:00 New Revision: 55b1410895b69d8e4517f6a2a2978b414b4ecac3 URL: https://github.com/llvm/llvm-project/commit/55b1410895b69d8e4517f6a2a2978b414b4ecac3 DIFF: https://github.com/llvm/llvm-project/commit/55b1410895b69d8e4517f6a2a2978b414b4ecac3.diff

[Lldb-commits] [lldb] [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (PR #98432)

https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/98432 >From ede6fc3939cbdf3a5744ff5e6919551a4b5dd438 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 10 Jul 2024 21:49:04 -0700 Subject: [PATCH 1/2] Fix a bug for PT_TLS segments getting loaded when they shoul

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/96687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

@@ -55,14 +55,23 @@ def test_basic(self): self.assertEqual(len(step_in_targets), 3, "expect 3 step in targets") # Verify the target names are correct. -self.assertEqual(step_in_targets[0]["label"], "bar()", "expect bar()") -self.assertEqual(step

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

@@ -0,0 +1,89 @@ +#ifndef STD_LLDB_COMPRESSED_PAIR_H +#define STD_LLDB_COMPRESSED_PAIR_H + +#include + +namespace std { +namespace __lldb { + +#if COMPRESSED_PAIR_REV == 0 // Post-c88580c layout +struct __value_init_tag {}; +struct __default_init_tag {}; + +template ::value && !s

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/98330 >From a25b3c8a6a36326730d00d1060ff84181bece26e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 10 Jul 2024 15:37:45 +0100 Subject: [PATCH 1/3] [WIP][lldb][test] Add a layout simulator test for std::uni

[Lldb-commits] [lldb] [lldb] Fix ThreadList assignment race (PR #98293)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/98293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e1bd337 - [lldb] Fix ThreadList assignment race (#98293)

Author: Pavel Labath Date: 2024-07-11T14:04:19+02:00 New Revision: e1bd337865fca9f455225ba37b76595d37bad213 URL: https://github.com/llvm/llvm-project/commit/e1bd337865fca9f455225ba37b76595d37bad213 DIFF: https://github.com/llvm/llvm-project/commit/e1bd337865fca9f455225ba37b76595d37bad213.diff

[Lldb-commits] [lldb] [lldb] Fix ThreadList assignment race (PR #98293)

labath wrote: > LGTM. > > As a nice to have, maybe add a short explanation to the first mutex > explaining that these operations are only allowed between thread lists > belonging to the same process. Your current comment makes it sound as if that > only applies _if_ the processes are the same

[Lldb-commits] [lldb] [lldb] Fix ThreadList assignment race (PR #98293)

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/98293 >From 0a594fea0a5db3ebc8de74edbcd051cbac911697 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 10 Jul 2024 04:06:42 +0200 Subject: [PATCH 1/2] [lldb] Fix ThreadList assignment race ThreadList uses the Proc

[Lldb-commits] [lldb] [lldb] Support new libc++ __compressed_pair layout (PR #96538)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/96538 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support new libc++ __compressed_pair layout (PR #96538)

@@ -254,6 +256,29 @@ lldb_private::formatters::LibcxxStdMapSyntheticFrontEnd:: Update(); } +llvm::Expected +lldb_private::formatters::LibcxxStdMapSyntheticFrontEnd:: +CalculateNumChildrenForOldCompressedPairLayout() { + ValueObjectSP node_sp(m_tree->GetChildMemberWith

[Lldb-commits] [lldb] [lldb] Support new libc++ __compressed_pair layout (PR #96538)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/96538 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

ita-sc wrote: Gentle ping https://github.com/llvm/llvm-project/pull/90075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (PR #98464)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This was found during testing of llvm snapshots for Fedora. This test was looking for an exact string match of the path calculated by starting with lib/liblldb and with bin/lldb. However when CLANG_RE

[Lldb-commits] [lldb] [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (PR #98464)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/98464 This was found during testing of llvm snapshots for Fedora. This test was looking for an exact string match of the path calculated by starting with lib/liblldb and with bin/lldb. However when CLANG_RESOURC

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

@@ -0,0 +1,89 @@ +#ifndef STD_LLDB_COMPRESSED_PAIR_H +#define STD_LLDB_COMPRESSED_PAIR_H + +#include <__memory/compressed_pair.h> +#include + +namespace std { +namespace __lldb { + +#if COMPRESSED_PAIR_REV == 0 // Post-c88580c layout +struct __value_init_tag {}; +struct __default

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

@@ -0,0 +1,89 @@ +#ifndef STD_LLDB_COMPRESSED_PAIR_H +#define STD_LLDB_COMPRESSED_PAIR_H + +#include <__memory/compressed_pair.h> +#include + +namespace std { +namespace __lldb { + +#if COMPRESSED_PAIR_REV == 0 // Post-c88580c layout +struct __value_init_tag {}; +struct __default

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

@@ -0,0 +1,43 @@ +#include "../compressed_pair.h" labath wrote: We have some common includes in `packages/Python/lldbsuite/test/make/`. I think it'd be better to put this there (probably in a subdirectory) https://github.com/llvm/llvm-project/pull/98330 ___

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

https://github.com/labath commented: I'm like this approach. It can be a lot of work, so we may not be able to get every contributor to do this, but I'd certainly encourage everyone to try. https://github.com/llvm/llvm-project/pull/98330 ___ lldb-comm

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

@@ -170,6 +170,10 @@ enum Format { eFormatHex, eFormatHexUppercase, eFormatFloat, + eFormatFloat128, //< Disambiguate between 128-bit `long double` (which uses labath wrote: This list should be appended to at the end to preserve the values of existing

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

@@ -334,6 +334,8 @@ static const llvm::fltSemantics &GetFloatSemantics(const TargetSP &target_sp, return llvm::APFloat::IEEEsingle(); case 8: return llvm::APFloat::IEEEdouble(); +case 16: + return llvm::APFloat::IEEEquad(); labath wrot

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

@@ -819,6 +823,7 @@ enum BasicType { eBasicTypeFloat, eBasicTypeDouble, eBasicTypeLongDouble, + eBasicTypeFloat128, labath wrote: The same goes here, although apparently https://reviews.llvm.org/D120690 has snuck through and nobody noticed. https://gi

[Lldb-commits] [lldb] [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (PR #98432)

@@ -1,8 +1,25 @@ # Overlapping PT_LOAD and PT_TLS segments should be able to exist side by side. +# When an ELF file contains both PT_LOAD and PT_TLS segmentsq where the PT_TLS DavidSpickett wrote: "PT_TLS segments" remove the "q" typo. https://github.com/llv

[Lldb-commits] [lldb] [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (PR #98432)

@@ -1,8 +1,25 @@ # Overlapping PT_LOAD and PT_TLS segments should be able to exist side by side. +# When an ELF file contains both PT_LOAD and PT_TLS segmentsq where the PT_TLS +# segment has the same p_vaddr and p_paddr as a PT_LOAD segment, this +# was causing LLDB, when load

[Lldb-commits] [lldb] [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (PR #98432)

@@ -1,8 +1,25 @@ # Overlapping PT_LOAD and PT_TLS segments should be able to exist side by side. DavidSpickett wrote: Maybe clarify this by adding "in an object file." on the end. So it's clear that lldb is not making use of them, just able to ignore them as th

[Lldb-commits] [lldb] [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (PR #98432)

https://github.com/labath approved this pull request. LGTM. Coincidentally, I was just working on a bug where this was (a part of) the problem. :) https://github.com/llvm/llvm-project/pull/98432 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb] Fix ThreadList assignment race (PR #98293)

@@ -27,12 +27,13 @@ class ThreadList : public ThreadCollection { friend class Process; public: - ThreadList(Process *process); + ThreadList(Process &process); ThreadList(const ThreadList &rhs); ~ThreadList() override; + // Precondition: both thread lists must

[Lldb-commits] [lldb] [lldb] Fix ThreadList assignment race (PR #98293)

@@ -736,11 +734,12 @@ void ThreadList::NotifySelectedThreadChanged(lldb::tid_t tid) { void ThreadList::Update(ThreadList &rhs) { if (this != &rhs) { -// Lock both mutexes to make sure neither side changes anyone on us while -// the assignment occurs -std::scoped

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/97824 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 18e70a4 - [llvm][TargetParser] Return StringMap from getHostCPUFeatures (#97824)

Author: David Spickett Date: 2024-07-11T10:32:43+01:00 New Revision: 18e70a4d5042299054dae7d3995f6ccd8f4112b3 URL: https://github.com/llvm/llvm-project/commit/18e70a4d5042299054dae7d3995f6ccd8f4112b3 DIFF: https://github.com/llvm/llvm-project/commit/18e70a4d5042299054dae7d3995f6ccd8f4112b3.diff

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

@@ -20,16 +20,15 @@ using namespace llvm; int main(int argc, char **argv) { #if defined(__i386__) || defined(_M_IX86) || \ defined(__x86_64__) || defined(_M_X64) - StringMap features; - - if (!sys::getHostCPUFeatures(features)) + const StringMap features = sys::getHostCP

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/97824 >From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 5 Jul 2024 08:42:22 + Subject: [PATCH 1/9] [llvm][TargetParser] Return optional from getHostCPUFe

[Lldb-commits] [lldb] [lldb][man][nfc] Don't register a markdown parser when building man packages (PR #98420)

https://github.com/DavidSpickett commented: Looks fine to me just a minor comment on placement. https://github.com/llvm/llvm-project/pull/98420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb][man][nfc] Don't register a markdown parser when building man packages (PR #98420)

@@ -89,9 +89,13 @@ # The suffix of source filenames. source_suffix = { ".rst": "restructuredtext", -".md": "markdown", } +# Man pages do not use markdown pages, so we don't need to register a markdown +# parser. +if not building_man_page: +source_suffix[".md"] =

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

https://github.com/tmatheson-arm approved this pull request. https://github.com/llvm/llvm-project/pull/97824 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct format specifier for sscanf to prevent buffer overflow (NFC) (PR #94783)

https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/94783 >From 17d39d89ee723881063ecbea19caaa6806e4e095 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sat, 15 Jun 2024 23:57:03 +0530 Subject: [PATCH 1/2] Resolved merge conflict --- lldb/source/Host/linux/Host.cpp |

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a18f45f - [lldb] Fix string truncation method when substring is the prefix of string (NFC) (#94785)

Author: Shivam Gupta Date: 2024-07-11T12:57:50+05:30 New Revision: a18f45f556c781d711f82043bf451fcce8324163 URL: https://github.com/llvm/llvm-project/commit/a18f45f556c781d711f82043bf451fcce8324163 DIFF: https://github.com/llvm/llvm-project/commit/a18f45f556c781d711f82043bf451fcce8324163.diff