https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/110543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I'm closing this because I figure out a way for my language to be compliant
with what LLDB expects, following the same path of Rust. I know we should make
LLDB more generic, but I ended up finding so many little broken things if I
don't follow C++'s style, and that's to
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/109477
>From f432d21587c32ca5e6dc96fc77fbc53a3ae5eeb8 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Sep 2024 13:02:59 -0700
Subject: [PATCH 01/11] Add Process code to get the fs_base region and the
.tdata
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/4894
Here is the relevant piece of the build log
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From 288acdfef1126c5652bac126c80f4d36df5e40b2 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/6] [lldb][CMake] Add single target that runs libc++ tests
---
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/109477
>From f432d21587c32ca5e6dc96fc77fbc53a3ae5eeb8 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Sep 2024 13:02:59 -0700
Subject: [PATCH 01/10] Add Process code to get the fs_base region and the
.tdata
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/109477
>From f432d21587c32ca5e6dc96fc77fbc53a3ae5eeb8 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Sep 2024 13:02:59 -0700
Subject: [PATCH 1/9] Add Process code to get the fs_base region and the .tdata
s
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/110943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-10-03T15:08:01-07:00
New Revision: c20b90ab8557b38efe8e8e993d41d8c08b798267
URL:
https://github.com/llvm/llvm-project/commit/c20b90ab8557b38efe8e8e993d41d8c08b798267
DIFF:
https://github.com/llvm/llvm-project/commit/c20b90ab8557b38efe8e8e993d41d8c08b798267.diff
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/110943
>From e1ea95287aeaa216e332aa221039247feaeb48e1 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 2 Oct 2024 17:45:36 -0700
Subject: [PATCH 1/2] [lldb][debugserver] Check if Rosetta debugserver exists
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4123050b965f685e8e56c74d413e99f64f35d38b
391a5ae4b378d5ced975bc8752651eae118dc573 --e
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/109477
>From f432d21587c32ca5e6dc96fc77fbc53a3ae5eeb8 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Sep 2024 13:02:59 -0700
Subject: [PATCH 1/8] Add Process code to get the fs_base region and the .tdata
s
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
000e790be35b77a01872851646d54432a203542c...9f64a452745b070b610e583436f074b3f9a24f4f
lldb/
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/111063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Augusto Noronha
Date: 2024-10-03T13:47:26-07:00
New Revision: 47ff13b45b52a2b0372aa47d5a0f4035ecdcfa86
URL:
https://github.com/llvm/llvm-project/commit/47ff13b45b52a2b0372aa47d5a0f4035ecdcfa86
DIFF:
https://github.com/llvm/llvm-project/commit/47ff13b45b52a2b0372aa47d5a0f4035ecdcfa86.dif
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/111063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/111063
>From 9f64a452745b070b610e583436f074b3f9a24f4f Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 3 Oct 2024 13:43:06 -0700
Subject: [PATCH] [lldb-dap] Disable TestDAP_optimized under ASAN
This test
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/111063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/111063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/111063
>From 61c25e59fa472bf00b870a886dd63d9dfba28926 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 3 Oct 2024 13:43:06 -0700
Subject: [PATCH] [lldb-dap] Disable TestDAP_optimized under ASAN
This test
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/111063.diff
1 Files Affected:
- (modified) lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py (+1)
``diff
diff --git a/ll
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/111063
None
>From bf8750bf55cc20f6596255ec7ed032a12ea7ea88 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 3 Oct 2024 13:43:06 -0700
Subject: [PATCH] Disable TestDAP_optimized under ASAN
---
lldb/test/
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110065
>From 0e31c0ad2b9db1ba9055bb4b984557100c0a9feb Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 24 Sep 2024 17:42:49 -0700
Subject: [PATCH 1/8] Add the addr info when appropriate for NIX' crash signals
-
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110065
>From 0e31c0ad2b9db1ba9055bb4b984557100c0a9feb Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 24 Sep 2024 17:42:49 -0700
Subject: [PATCH 1/8] Add the addr info when appropriate for NIX' crash signals
-
@@ -785,38 +785,50 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
+ // We'll process module_sp separately, before the other modules.
+ images.Remove(sc.module_sp);
+
LoadAddress
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/111033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-10-03T22:23:12+04:00
New Revision: 000e790be35b77a01872851646d54432a203542c
URL:
https://github.com/llvm/llvm-project/commit/000e790be35b77a01872851646d54432a203542c
DIFF:
https://github.com/llvm/llvm-project/commit/000e790be35b77a01872851646d54432a203542c.dif
https://github.com/dzhidzhoev approved this pull request.
https://github.com/llvm/llvm-project/pull/111033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
I find this API confusing, and it seems very focused on pointing out errors in
commands that have some part of their text that gets submitted to a compiler.
The other obvious candidate for this feature is a general command parser
implementation that handles:
(lldb) process la
@@ -112,8 +113,46 @@ void CommandReturnObject::SetError(Status error) {
}
void CommandReturnObject::SetError(llvm::Error error) {
- if (error)
+ // Retrieve any diagnostics.
+ error = llvm::handleErrors(std::move(error), [&](ExpressionErrorBase &error)
{
+SetStatus(eRe
@@ -112,8 +113,46 @@ void CommandReturnObject::SetError(Status error) {
}
void CommandReturnObject::SetError(llvm::Error error) {
- if (error)
+ // Retrieve any diagnostics.
+ error = llvm::handleErrors(std::move(error), [&](ExpressionErrorBase &error)
{
j
@@ -3180,15 +3180,24 @@ void
CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler,
if ((result.Succeeded() &&
io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) ||
io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) {
-// Display a
slydiman wrote:
#111033
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
This patch fixes the following problems
https://lab.llvm.org/buildbot/#/builders/162/builds/7720
---
Full diff: https://github.com/llvm/llvm-project/pull/111033.diff
1 Files Affected:
- (modified) lldb
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/111033
This patch fixes the following problems
https://lab.llvm.org/buildbot/#/builders/162/builds/7720
>From c8923c79dea379a4b5a8aaf2f3bfaf0f056597e3 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 3 Oct
@@ -3180,15 +3180,24 @@ void
CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler,
if ((result.Succeeded() &&
io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) ||
io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) {
-// Display a
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/110987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2024-10-03T19:51:34+02:00
New Revision: 6c137b75f3f62c97678efced23943fee1081fb2f
URL:
https://github.com/llvm/llvm-project/commit/6c137b75f3f62c97678efced23943fee1081fb2f
DIFF:
https://github.com/llvm/llvm-project/commit/6c137b75f3f62c97678efced23943fee1081fb2f
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/110987
>From 45c3f13947e7c7db42f71797df255ee01eb97ae9 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 2 Oct 2024 21:45:46 +
Subject: [PATCH 1/2] [lldb-dap][docs] Improve documentation for contrib
@@ -188,12 +188,14 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
ValueObjectSP valobj_sp;
std::string fixed_expression;
+result.SetUserInput(expr);
jimingham wrote:
This is at least an oddly named API, since it's not at all what the
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/4885
Here is the relevant piece of the build log
@@ -26,6 +27,35 @@ class raw_ostream;
namespace lldb_private {
+/// A compiler-independent representation of a Diagnostic. Expression
+/// evaluation failures often have more than one diagnostic that a UI
+/// layer might want to render differently, for example to colorize
+/
https://github.com/jimingham deleted
https://github.com/llvm/llvm-project/pull/110901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham deleted
https://github.com/llvm/llvm-project/pull/110901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -23,35 +23,6 @@
namespace lldb_private {
-/// A compiler-independent representation of a Diagnostic. Expression
-/// evaluation failures often have more than one diagnostic that a UI
-/// layer might want to render differently, for example to colorize
-/// it.
-///
-/// Ru
@@ -327,8 +327,6 @@ def test_relative_module_name(self):
old_cwd = os.getcwd()
self.addTearDownHook(lambda: os.chdir(old_cwd))
os.chdir(self.getBuildDir())
-name = "file-with-a-name-unlikely-to-exist-in-the-current-directory.so"
@@ -23,35 +23,6 @@
namespace lldb_private {
-/// A compiler-independent representation of a Diagnostic. Expression
-/// evaluation failures often have more than one diagnostic that a UI
-/// layer might want to render differently, for example to colorize
-/// it.
-///
-/// Ru
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110885
>From 5ed6e20b50f70754efbaa157720a7ef120bb6b1e Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 2 Oct 2024 09:50:26 -0700
Subject: [PATCH 1/4] Remove additional logic to disable the dynamic loader
when t
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/110982
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2024-10-03T19:33:30+02:00
New Revision: 9c99e07175c946e989b481a2a1342f0a395f10ca
URL:
https://github.com/llvm/llvm-project/commit/9c99e07175c946e989b481a2a1342f0a395f10ca
DIFF:
https://github.com/llvm/llvm-project/commit/9c99e07175c946e989b481a2a1342f0a395f10ca
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/7720
Here is the relevant piece of the build log
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-10-03T21:00:47+04:00
New Revision: 2e89312419c5f7875c947fcf79ea0446cf65a287
URL:
https://github.com/llvm/llvm-project/commit/2e89312419c5f7875c947fcf79ea0446cf65a287
DIFF:
https://github.com/llvm/llvm-project/commit/2e89312419c5f7875c947fcf79ea0446cf65a287.dif
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/110965
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-10-03T09:59:37-07:00
New Revision: 00c1989a01f4dfdaa118bbfc300165b6507712e6
URL:
https://github.com/llvm/llvm-project/commit/00c1989a01f4dfdaa118bbfc300165b6507712e6
DIFF:
https://github.com/llvm/llvm-project/commit/00c1989a01f4dfdaa118bbfc300165b6507712e6.diff
https://github.com/felipepiovezan approved this pull request.
This LGTM! Thanks a lot of fixing it.
Your comments match my observations and I tested this patch with a test case
where we stop on every instruction of a few functions and assert we can unwind
correctly.
https://github.com/llvm/llv
@@ -1,16 +1,95 @@
-# LLDB-DAP
-
-The `lldb-dap` tool (formerly `lldb-vscode`) is a command line tool that
-implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-adapter-protocol/). It can be
-installed as an extension for Visual Studio Code and other IDEs supp
@@ -1,16 +1,95 @@
-# LLDB-DAP
-
-The `lldb-dap` tool (formerly `lldb-vscode`) is a command line tool that
-implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-adapter-protocol/). It can be
-installed as an extension for Visual Studio Code and other IDEs supp
@@ -1,16 +1,95 @@
-# LLDB-DAP
-
-The `lldb-dap` tool (formerly `lldb-vscode`) is a command line tool that
-implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-adapter-protocol/). It can be
-installed as an extension for Visual Studio Code and other IDEs supp
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/110987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/110982
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
beautiful
https://github.com/llvm/llvm-project/pull/110987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,16 +1,95 @@
-# LLDB-DAP
-
-The `lldb-dap` tool (formerly `lldb-vscode`) is a command line tool that
-implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-adapter-protocol/). It can be
-installed as an extension for Visual Studio Code and other IDEs supp
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/110987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/110982
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/110856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kamleshbhalui wrote:
> The implementation of Variable::IsThreadLocal is most likely a non-starter,
> as it introduces a relatively expensive operation on the common variable
> update path for all variables. Doing this (once) at variable creation would
> be better, but I still have very big res
@@ -0,0 +1 @@
+libc++
Michael137 wrote:
Yea that's fair. We still include headers in those tests to get type_traits etc.
But yea they shouldn't be libc++ dependent (at least not on the layout of the
types).
https://github.com/llvm/llvm-project/pull/110856
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From 288acdfef1126c5652bac126c80f4d36df5e40b2 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/6] [lldb][CMake] Add single target that runs libc++ tests
---
@@ -0,0 +1 @@
+libc++
labath wrote:
We don't want this, as one of the biggest advantages of these tests is that
they don't require an actual libc++ library. Given that, it may not even be
very useful to run them as a part of the libc++ suite, but if you really
@@ -785,38 +785,50 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
+ // We'll process module_sp separately, before the other modules.
+ images.Remove(sc.module_sp);
+
LoadAddress
https://github.com/DmT021 updated
https://github.com/llvm/llvm-project/pull/102835
>From aad4d1c669f84db462454b96e42fd682ea818720 Mon Sep 17 00:00:00 2001
From: Dmitrii Galimzianov
Date: Tue, 24 Sep 2024 00:33:43 +0200
Subject: [PATCH] Remove redundant symbol lookups in
IRExecutionUnit::FindIn
Author: Michael Buch
Date: 2024-10-03T14:59:47+01:00
New Revision: ee4dd147baff8f971f3ec5aad5a216ca9837a732
URL:
https://github.com/llvm/llvm-project/commit/ee4dd147baff8f971f3ec5aad5a216ca9837a732
DIFF:
https://github.com/llvm/llvm-project/commit/ee4dd147baff8f971f3ec5aad5a216ca9837a732.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From ee28f91822ca449b7b4bb84293cae2aee6803da4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/5] [lldb][CMake] Add single target that runs libc++ tests
---
Michael137 wrote:
Broke the
[lldb-aarch64-windows](https://lab.llvm.org/buildbot/#/builders/141)[2921](https://lab.llvm.org/buildbot/#/builders/141/builds/2921)
bot
https://github.com/llvm/llvm-project/pull/108375
___
lldb-commits mailing list
lldb-c
DmT021 wrote:
> Why is it so expensive to perform consecutive lookups into the same module
> for the same name?
It depends on circumstances but basically, the worst-case scenario is when you:
1) lookup a symbol in the context of a huge module
2) the symbol is in another module
3) the huge module
Michael137 wrote:
> Just for my understanding, is `--category` a Lit argument? I have never seen
> this before and I can't find documentation about it.
That's an option to LLDB's `dotest.py` testing framework (there's some
documentation for it in https://lldb.llvm.org/resources/test.html, thou
ldionne wrote:
Just for my understanding, is `--category` a Lit argument? I have never seen
this before and I can't find documentation about tit.
https://github.com/llvm/llvm-project/pull/110856
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From ee28f91822ca449b7b4bb84293cae2aee6803da4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/5] [lldb][CMake] Add single target that runs libc++ tests
---
@@ -785,38 +785,50 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
Michael137 wrote:
Nit, maybe call it something like:
```suggestion
ModuleList non_local_images =
@@ -785,38 +785,50 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
+ // We'll process module_sp separately, before the other modules.
+ images.Remove(sc.module_sp);
+
LoadAddress
https://github.com/Michael137 commented:
I guess we're paying the cost of copying the entire list of module pointers
(and removing an element) for one less
`FindFunctions`/`FindSymbolsWithNameAndType` call. Probably fine? But it still
feels a bit off having to do this (though as you demonstrat
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From ee28f91822ca449b7b4bb84293cae2aee6803da4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/4] [lldb][CMake] Add single target that runs libc++ tests
---
labath wrote:
If that works, then I guess the answer is "yes".
https://github.com/llvm/llvm-project/pull/110856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Vogelsgesang (vogelsgesang)
Changes
This commit extends the developer docs for `lldb-dap`. It also adds a short
"Contributing" section to the user-facing README.
Last but not least, it updates the `repository` in the package.json to
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/110987
This commit extends the developer docs for `lldb-dap`. It also adds a short
"Contributing" section to the user-facing README.
Last but not least, it updates the `repository` in the package.json to point to
Michael137 wrote:
> I'd probably use a test category for this (either the existing libc++
> category, or if that doesn't fit your use case for some reason, then a new
> category created specifically for this purpose).
Agreed, that would be preferable. Is the suggestion to run something like:
`
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/108375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-10-03T12:53:28+01:00
New Revision: d5f6e886ff0df8265d44ab0646afcb4a06e6475a
URL:
https://github.com/llvm/llvm-project/commit/d5f6e886ff0df8265d44ab0646afcb4a06e6475a
DIFF:
https://github.com/llvm/llvm-project/commit/d5f6e886ff0df8265d44ab0646afcb4a06e6475a.diff
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > I am still looking for an answer to this one. If it's only the
> > Handle_qLaunchGDBServer that needs to not launch an lldb-server then I
> > don't see why the check couldn't/shouldn't be performed there.
>
> I cannot answer in the thread, no idea why. The answer is here [#10
labath wrote:
I'd probably use a test category for this (either the existing libc++ category,
or if that doesn't fit your use case for some reason, then a new category
created specifically for this purpose).
https://github.com/llvm/llvm-project/pull/110856
_
Michael137 wrote:
(this libc++-side change was relanded in:
https://github.com/llvm/llvm-project/pull/108867)
https://github.com/llvm/llvm-project/pull/108375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108375
>From 76d99481604ffefa7a1f438cbe65966a45c63a26 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 12:55:17 +0100
Subject: [PATCH 1/3] [lldb][test] TestDataFormatterLibcxxStringSimulator.py:
a
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108375
>From 76d99481604ffefa7a1f438cbe65966a45c63a26 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 12:55:17 +0100
Subject: [PATCH 1/2] [lldb][test] TestDataFormatterLibcxxStringSimulator.py:
a
@@ -327,8 +327,6 @@ def test_relative_module_name(self):
old_cwd = os.getcwd()
self.addTearDownHook(lambda: os.chdir(old_cwd))
os.chdir(self.getBuildDir())
-name = "file-with-a-name-unlikely-to-exist-in-the-current-directory.so"
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/110982
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Vogelsgesang (vogelsgesang)
Changes
Apparently, the markdown parser used by the VSCode Marketplace does not support
escaped backticks the same way that Github does. This lead to the table of
launch / attach options to be rendered as
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From ee28f91822ca449b7b4bb84293cae2aee6803da4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/3] [lldb][CMake] Add single target that runs libc++ tests
---
1 - 100 of 112 matches
Mail list logo
