[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM. Some changes for grammar to the title -- "[lldb/Process/Windows] Attempting to kill an exited/detached process is not an error" A little more description would be helpful for others. He

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

asmith added a comment. Herald added a subscriber: JDevlieghere. Curious what the status of this is? Looks like its been ready for almost one year :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 __

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith abandoned this revision. asmith added a comment. This was split into separate patches and committed. No longer need this review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56233/new/ https://reviews.llvm.org/D56233 ___ lldb-commit

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368776: Update Python tests for lldb-server on Windows (authored by asmith, committed by ). Herald added a project: LLVM.

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith added a comment. Any more comments on the tests for Windows? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith updated this revision to Diff 214985. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRe

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 214979. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61686/new/ https://reviews.llvm.org/D61686 Files: cmake/modules/LLDBConfig.cmake source/Host/windows/Host.cpp source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added a comment. This is done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63165/new/ https://reviews.llvm.org/D63165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added a comment. Any last comments before this is committed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63165/new/ https://reviews.llvm.org/D63165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. Do you need some help fixing the build? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D62213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added a comment. I can make the one simplification but Im not sure what you are asking as far as the refactoring. Provide an example and I will try to accommodate your request. I'm not going to be able to spend much more time on lldb patches though. CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked an inline comment as done. asmith added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141 +GetRegisterInfo_WoW64(const lldb_private::ArchSpec &arch) { + // A WoW64 register info is the same as the i386's. + std

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked 2 inline comments as done. asmith added a comment. I don't see anything else to address in this review. Comments? Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141 +GetRegisterInfo_WoW64(const lldb_private::ArchSpec &arch) { +

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. I can confirm this is reproducible with the master branch of llvm-project cloned from GitHub. You can reproduce the build failure from an x64 command prompt with this cmake command line: cmake path-to-llvm-project/llvm -Thost=x64 -DLLVM_ENABLE_PROJECTS="clang;lld;lld

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked 11 inline comments as done. asmith added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:95 + +// Resume the debug loop. +ExceptionRecordSP active_exception = amccarth wrote: > This code appe

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. I think this change has introduced a dependence on x64. I tried building with the 32b Visual Studio compiler and there are a number of undefined registers in registercontextwindows_x64.cpp. This is because the version of _CONTEXT included by winnt.h is for x32 and not x6

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp:31-36 + if (!data_sp) { +error.SetErrorStringWithFormat( +"failed to allocate DataBufferHeap instance of size %" PRIu64, +data_size); +r

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

asmith updated this revision to Diff 205178. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63166/new/ https://reviews.llvm.org/D63166 Files: source/Plugins/Process/Windows/Common/CMakeLists.txt source/Plugins/Process/Windows/Common/ProcessDebugger.cpp source/Plugins/Process/Windows

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

asmith created this revision. asmith added reviewers: labath, Hui. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. asmith added reviewers: jfb, clayborg. Herald added a subscriber: dexonsmith. This change extracts functionalities from processwindows into a introduced

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith updated this revision to Diff 200160. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteAuxvSupport.py packages/Python/lldbsui

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 199555. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61686/new/ https://reviews.llvm.org/D61686 Files: cmake/modules/LLDBConfig.cmake source/Host/windows/Host.cpp source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith updated this revision to Diff 199554. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteAuxvSupport.py packages/Python/lldbsui

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 198675. asmith retitled this revision from "Disable pty redirection on Windows and add a method to get the parent pid" to "Enable lldb-server on Windows". asmith edited the summary of this revision. Herald added subscribers: mgorny, srhines. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith created this revision. asmith added reviewers: labath, rnk. Herald added a reviewer: jfb. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lld

[Lldb-commits] [PATCH] D61686: Disable pty redirection on Windows and add a method to get the parent pid

asmith created this revision. asmith added reviewers: labath, rnk. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. More changes for lldb-server on Windows - Disable pty redirection for Windows since there is no pty support currently - Add a method to get the parent pid for

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 197239. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/Ob

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 196874. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/Ob

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 195504. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PEC

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 195282. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp sour

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith marked an inline comment as done. asmith added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:74-78 +#if defined(_WIN32) + fprintf(stderr, "PID: %d\n", ::GetCurrentProcessId()); +#else fprintf(stderr, "PID: %d\n", getpid()); +#en

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith marked an inline comment as done. asmith added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:188-192 +g_print_mutex.lock(); printf("thread %d id: ", this_thread_index); print_thread_id(); printf("\n"); +g_prin

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith updated this revision to Diff 194751. asmith added a comment. Address reviewer comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60496/new/ https://reviews.llvm.org/D60496 Files: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp Index: packages/Python/lldbsuite/t

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 2 inline comments as done. asmith added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:1 //===-- main.cpp *- C++ -*-===// // labath wrote: > Could you (as a s

[Lldb-commits] [PATCH] D60496: [lldb-server] Use std::thread/mutex for all platforms

asmith created this revision. asmith added reviewers: zturner, labath, jfb, Hui. Herald added subscribers: lldb-commits, dexonsmith. Herald added a project: LLDB. Some cleanup suggested when bringing up lldb-server on Windows. Thanks to Hui Huang for the patch. Repository: rLLDB LLDB https:/

[Lldb-commits] [PATCH] D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup

asmith updated this revision to Diff 194443. asmith added a comment. Addressed the review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60440/new/ https://reviews.llvm.org/D60440 Files: include/lldb/Host/Socket.h source/Host/common/Socket.cpp source/Initialization/System

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 4 inline comments as done. asmith added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h:294 + + lldb_private::UUID m_uuid; }; labath wrote: > Move UUID handling into a separate patch. The UUID change is being discu

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 4 inline comments as done. asmith added inline comments. Comment at: source/Plugins/Process/Windows/Common/NativeProcessWindows.h:16 + +#include "IDebugDelegate.h" +#include "ProcessDebugger.h" labath wrote: > It looks like IDebugDelegate.h is missi

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 6 inline comments as done. asmith added inline comments. Comment at: tools/lldb-server/SystemInitializerLLGS.cpp:37-52 +#if defined(_WIN32) + if (g_ref_count++ == 0) { +// Require Windows Sockets version 2.2. +auto wVersion = MAKEWORD(2, 2); +WSADATA ws

[Lldb-commits] [PATCH] D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup

asmith created this revision. asmith added reviewers: zturner, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D60440 Files: include/lldb/Host/Socket.h source/Host/common/Socket.cpp source/Initialization/Syste

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 5 inline comments as done. asmith added a comment. Committed a few NFC changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56233/new/ https://reviews.llvm.org/D56233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354099: Implement GetLoadAddress for the Windows process plugin (authored by asmith, committed by ). Herald added a projec

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186799. Herald added a subscriber: mgorny. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp source/Plugins/DynamicLoader/Windows-

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186796. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.h s

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

asmith updated this revision to Diff 186591. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56232/new/ https://reviews.llvm.org/D56232 Files: include/lldb/Target/RemoteAwarePlatform.h source/Plugins/Platform/POSIX/PlatformPOSIX.cpp source/Plugins/Platform/POSIX/PlatformPOSIX.h sou

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

asmith updated this revision to Diff 186580. Herald added subscribers: jdoerfert, emaste. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56232/new/ https://reviews.llvm.org/D56232 Files: include/lldb/Target/RemoteAwarePlatform.h source/Plugins/Platform/POSIX/PlatformPOSIX.cpp source

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186401. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: include/lldb/Host/Host.h source/Host/common/Host.cpp source/Host/windows/Host.cpp source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWi

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith updated this revision to Diff 185817. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 Files: include/lldb/Host/File.h include/lldb/Host/FileSystem.h source/Host/common/File.cpp source/Host/common/FileSystem.cpp source/Plugins/Proc

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith added a comment. Any other comments on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 185784. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: packages/Python/lldbsuite/test/functionalities/platform/TestPlatformCommand.py packages/Python/lldbsuite/test/settings/quoting/TestQuoting.py

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 185783. Herald added a reviewer: serge-sans-paille. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: packages/Python/lldbsuite/test/functionalities/platform/TestPlatformCommand.py packages/Python/lldb

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith added a comment. Thanks for the feedback and interesting discussion! If no more comments, let's go with this version for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 ___ lldb-commits

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 184325. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: source/Host/windows/ProcessLauncherWindows.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 184323. asmith retitled this revision from "Implement GetFileLoadAddress for the Windows process plugin" to "Implement GetLoadAddress for the Windows process plugin". asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 182704. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: include/lldb/Utility/Args.h source/Host/windows/ProcessLauncherWindows.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp sou

[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

asmith marked an inline comment as done. asmith added a comment. @clayborg Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:858 +Status ProcessWindows::GetFileLoadAddress(const FileSpec &file, bool &is_loaded, + ll

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 181377. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp ===

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith updated this revision to Diff 180992. asmith added a comment. Added lock suggested in review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 Files: include/lldb/Host/File.h include/lldb/Host/FileSystem.h source/Host/common/File.cpp

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

asmith updated this revision to Diff 180965. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56234/new/ https://reviews.llvm.org/D56234 Files: include/lldb/Host/PipeBase.h include/lldb/Host/posix/PipePosix.h include/lldb/Host/windows/PipeWindows.h include/lldb/lldb-types.h source

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

asmith updated this revision to Diff 180939. asmith added a comment. Add lldb::pipe_t type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56234/new/ https://reviews.llvm.org/D56234 Files: include/lldb/Host/PipeBase.h include/lldb/Host/posix/PipePosix.h include/lldb/Host/windows/Pi

[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. When a process is loaded, update its sections with the load address to resolve any created breakpoints. For the remote debugging case, the debugged process is launched remotely s

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. This adds unnamed pipe support in PipeWindows to support communication between a debug server and child process. Modify PipeWindows::CreateNew to support the creation of an unname

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for building lldb-server on Windows

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added subscribers: lldb-commits, abidh, mgorny, srhines. This is intended as a first step to make lldb-server work on Windows. Follow-up changes to implement remote capabilities in PlatformWindows, launch gdbserve

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. Implement a few routines for Windows to support some basic process interaction and file system operations. Repository: rLLDB LLDB https://reviews.llvm.org/D56232 Files: so

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added subscribers: lldb-commits, abidh. This commit contains the following changes: - Rewrite vfile close/read/write packet handlers with portable routines from lldb. This removes #if(s) and allows the handlers t

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D56230 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-remote/GDBRemote

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added a subscriber: lldb-commits. Provide an implementation of GetUUID() for remote debugging scenarios based on the md5 of the object's path. Include a simple lit test that checks the first 8 bytes of the UUID i

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 177038. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53094/new/ https://reviews.llvm.org/D53094 Files: lit/Modules/PECOFF/dep-modules.yaml lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/lit.local.cfg source/Plugins/ObjectFile/PECOF

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 177036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53094/new/ https://reviews.llvm.org/D53094 Files: lit/Modules/PECOFF/dep-modules.yaml lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/lit.local.cfg source/Plugins/ObjectFile/PECOF

[Lldb-commits] [PATCH] D53096: [lldb-test] Add a lit test for dependent modules in PECOFF

asmith abandoned this revision. asmith added a comment. Changes from this CR were added to D53094 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53096/new/ https://reviews.llvm.org/D53096 _

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 176259. asmith added a comment. Add changes from D53096 as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53094/new/ https://reviews.llvm.org/D53094 Files: lit/Modules/PECOFF/dep-modules.yaml lit/Modul

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

asmith accepted this revision. asmith added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53759/new/ https://reviews.llvm.org/D53759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith added a comment. The ability to dump dependent modules is in another review that is waiting on this one. https://reviews.llvm.org/D53096 https://reviews.llvm.org/D53094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 170781. https://reviews.llvm.org/D53094 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h unittests/ObjectFile/CMakeLists.txt unittests/ObjectFile/PECOFF/CMakeLists.txt unittests/ObjectFi

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith added a comment. I think this addresses all the previous comments. https://reviews.llvm.org/D53094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53375: [PDB] Improve performance of the PDB DIA plugin

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. Thanks for adding the cache. We noticed the slowdown also and were discussing the same thing. This LGTM if the other reviewers done have any comments. Repository: rLLDB LLDB https://review

[Lldb-commits] [PATCH] D53092: [lldb] Add support in Status::AsCString to retrieve win32 system error strings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344798: [lldb] Add support in Status::AsCString to retrieve win32 system error strings (authored by asmith, committed b

[Lldb-commits] [PATCH] D53092: [lldb] Add support in Status::AsCString to retrieve win32 system error strings

asmith added inline comments. Comment at: unittests/Utility/StatusTest.cpp:68-74 + EXPECT_STREQ("Access is denied. ", s.AsCString()); + + s.SetError(ERROR_IPSEC_IKE_TIMED_OUT, ErrorType::eErrorTypeWin32); + EXPECT_STREQ("Negotiation timed out ", s.AsCString()); + + s.SetError

[Lldb-commits] [PATCH] D53096: [lldb-test] Add a lit test for dependent modules in PECOFF

asmith created this revision. asmith added reviewers: rnk, zturner, aleksandr.urakov. Herald added a subscriber: lldb-commits. Add a new subcommand to lldb-test called 'dep-modules' to test dependent modules in PECOFF. Repository: rLLDB LLDB https://reviews.llvm.org/D53096 Files:

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith created this revision. asmith added reviewers: rnk, zturner, aleksandr.urakov, lldb-commits. Herald added subscribers: teemperor, mgrang, mgorny. This parses entries in pecoff import tables for imported DLLs and is intended as the first step to allow LLDB to load a PE's shared modules when

[Lldb-commits] [PATCH] D53092: [lldb] Add support in Status::AsCString to retrieve win32 system error strings

asmith created this revision. asmith added reviewers: rnk, zturner, aleksandr.urakov. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D53092 Files: source/Utility/Status.cpp unittests/Utility/StatusTest.cpp Index: unittests/Utility/StatusTest.cpp

[Lldb-commits] [PATCH] D53090: [ProcessWindows] Fix a bug that causes lldb to freeze

asmith created this revision. asmith added reviewers: rnk, zturner, aleksandr.urakov. Herald added a subscriber: lldb-commits. If the process exits before any initial stop then notify the debugger of the error otherwise WaitForDebuggerConnection() will be blocked. An example of this issue is when

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL343497: [lldb] Start a new line for the next output if there are no symbols in the… (authored by asmith, committed by ). H

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

asmith updated this revision to Diff 167670. https://reviews.llvm.org/D52627 Files: source/Symbol/Symtab.cpp Index: source/Symbol/Symtab.cpp === --- source/Symbol/Symtab.cpp +++ source/Symbol/Symtab.cpp @@ -139,6 +139,8 @@

[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D52468 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

asmith created this revision. asmith added reviewers: zturner, aleksandr.urakov, lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D52627 Files: source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp source/Plugins/ExpressionParser/Clang/ClangUserExpression.h source/Sy

[Lldb-commits] [PATCH] D52626: [lldb] Remove an assertion in RichManglingContext::GetBufferRef() hit when debugging a native x86 Windows process

asmith created this revision. asmith added reviewers: aleksandr.urakov, zturner, lldb-commits. Herald added a subscriber: erik.pilkington. A RichManglingContext constructed with an invalid demangled name or with a demangled function name without any context will have an empty context. This trigg

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D51162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D51104: [PDB] Resolve a symbol context block info correctly

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D51104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

asmith updated this revision to Diff 155904. asmith added a comment. Adding missing inputs https://reviews.llvm.org/D49410 Files: lit/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp lit/SymbolFile/PDB/Inputs/PointerTypeTest.cpp lit/SymbolFile/PDB/class-layout.test lit/SymbolFile/PDB/pointers.

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

asmith created this revision. asmith added reviewers: lldb-commits, aleksandr.urakov, rnk, zturner. Herald added a subscriber: llvm-commits. This is an alternative to https://reviews.llvm.org/D49368 Repository: rL LLVM https://reviews.llvm.org/D49410 Files: lit/SymbolFile/PDB/class-layout.

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

asmith added a subscriber: aleksandr.urakov. asmith added a comment. Sure, I will do it Monday if someone hasn’t done it already. https://reviews.llvm.org/D49018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. Except for minor formatting LGTM Comment at: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp:7 + + return; +} Please remove the return ==

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith added a comment. Thanks! Much better without the binaries. https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith added a comment. In https://reviews.llvm.org/D47708#1123334, @labath wrote: > I have reverted this because of the broken tests. > > However, I have to also ask: isn't there better way to test this? (one that > does not depend on opaque checked-in binaries). On linux, I could check-in a >

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith added a comment. In https://reviews.llvm.org/D47708#1123286, @aleksandr.urakov wrote: > Thank you! > > But it looks like the binary files (*.pdb and *.exe) have not been committed > properly (they have zero size). I've seen that issue before. I think you have to specify --binary when g

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM - will commit for you https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D45224: [SymbolFilePDB] Add support for resolving variable symbols

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL333049: [SymbolFilePDB] Add support for resolving variable symbols (authored by asmith, committed by ). Changed prior to

[Lldb-commits] [PATCH] D45224: [SymbolFilePDB] Add support for resolving variable symbols

asmith created this revision. asmith added reviewers: rnk, zturner, lldb-commits. Herald added subscribers: llvm-commits, JDevlieghere, aprantl. Implement FindGlobalVariables and ParseVariableContext methods. Compile unit information is necessary for resolving variable context, however some PDB

[Lldb-commits] [PATCH] D44456: [SymbolFilePDB] Simplify getting the source file path

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL327925: [SymbolFilePDB] Simplify getting the source file path (authored by asmith, committed by ). Changed prior to commi

[Lldb-commits] [PATCH] D44456: [SymbolFilePDB] Simplify getting the source file path

asmith added a comment. Has a dependence on https://reviews.llvm.org/D44458 Repository: rL LLVM https://reviews.llvm.org/D44456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >