[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

akyrtzi added a subscriber: bnbarham. akyrtzi added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; erichkeane wrote: > bolshakov-a wrote: > > aaron.ballman

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. In D141910#4112144 , @domada wrote: > @akyrtzi Thank you for your feedback. Can I land the patch? Fine be me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. In D141910#4111048 , @domada wrote: > Added changes in `clang/lib/AST/CMakeLists.txt` to address build issue > reported by @akyrtzi . > > I modified CMakeLists.txt so that it requires generation of missing > `Attributes.inc`. >

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. I've reverted this change from `main` branch, let me know if there's anything I can do to help with addressing the build issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. Hi @domada, these changes break compilation of clang, with such build error: FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o In file included from /llvm-project/clang/lib/AST/ASTContext.cpp:81: In file included from

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG3ed6311b1b7d: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with… (authored by akyrtzi).

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

akyrtzi added a comment. I prefer my original version because: - `eSymbolContextLastItem` is not an appropriate name for collection of bits, it should be named like `eSymbolContextReallyEverything` or something, which then makes things a bit confusing due to having multiple "everything" enums.

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

akyrtzi added a comment. In D139066#3964435 , @akyrtzi wrote: > In D139066#3964353 , @jasonmolenda > wrote: > >> FWIW I think the only change needed to the original patch is to keep using >> `#define

[Lldb-commits] [PATCH] D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9e24afdc706: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139061: [lldb] Fix the `dwarf` log descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG36bea8759d1f: [lldb] Fix the `dwarf` log descriptions (authored by akyrtzi). Changed prior to commit: https://reviews.llvm.org/D139061?vs=479099=479672#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

akyrtzi added a comment. In D139066#3964353 , @jasonmolenda wrote: > FWIW I think the only change needed to the original patch is to keep using > `#define RESOLVED_FRAME_CODE_ADDR (uint32_t(eSymbolContextEverything + 1))` > but switch to the new

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139066 Files: lldb/include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D139061: [lldb] Fix the `dwarf` log descriptions

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139061 Files:

[Lldb-commits] [PATCH] D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This doesn't seem to be necessary anymore so remove it to be more consistent with rest of the LLVM projects that don't use