[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

cassanova added a comment. The wording is good, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133546/new/ https://reviews.llvm.org/D133546 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:66 ReportError( "no target path specified in with the LLDB_FUZZER_TARGET variable"); I think having a flag for the fuzzer

[Lldb-commits] [PATCH] D132775: [lldb][docs] Fix formatting in fuzzing doc

This revision was automatically updated to reflect the committed changes. Closed by commit rG53f1cc85e3de: [lldb][docs] Fix formatting in fuzzing doc (authored by cassanova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132775/new/

[Lldb-commits] [PATCH] D132775: [lldb][docs] Fix formatting in fuzzing doc

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. Herald added a project: All. cassanova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The page for fuzzing LLDB had incorrectly formatted code, this commit

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

This revision was automatically updated to reflect the committed changes. Closed by commit rG43d7320e7111: [lldb][docs] Add documentation for LLDB fuzzers (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D132148?vs=453808=456058#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

cassanova updated this revision to Diff 453808. cassanova added a comment. Removed the full CMake invocation for the fuzzer build configuration. Added the information on OSS Fuzz to its own section. Changed build directory in fuzzer execution command to use a relative path. Removed reference

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

cassanova added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:12 + +Building the LLDB fuzzers requires a build configuration that has the address sanitizer and sanitizer coverage. This CMake invocation will configure a build directory that can be used to build

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: arphaman. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This commit adds a new page to

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG9525015c1bed: [lldb][tests] Test queue-specific breakpoints (authored by cassanova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread = queue1.GetThreadAtIndex(0) JDevlieghere wrote: > Any reason this

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452853. cassanova added a comment. Added the queue-specific breakpoints to their own test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://reviews.llvm.org/D131605 Files:

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:201-206 +# Run the executable until the stopper function and get the breakpoint +# that's created from that. Then set the queue name of the breakpoint +# to be the name

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452302. cassanova added a comment. Changed an `assertTrue` to `assertEqual`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://reviews.llvm.org/D131605 Files:

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 + "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(), queue1.GetName())) +

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:204-206 +process_info = lldbutil.run_to_name_breakpoint(self, "stopper", only_one_thread=False) +main_thread = process_info[2] +queue_breakpoint = process_info[3]

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452275. cassanova added a comment. All variables needed from `run_to_name_breakpoint` are obtained in one line rather than getting them by index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452267. cassanova added a comment. Use the enum name for the stop reason when asserting that the queues hit their breakpoints instead of just the raw number. Also, get the main thread from `run_to_name_breakpoint` instead of getting it from

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoint.GetQueueName())) +self.assertEqual(queue1_thread.GetStopReason(), 3, +

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib, jingham. cassanova added a project: LLDB. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This commit adds tests to ensure that queue-specific

[Lldb-commits] [PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

cassanova updated this revision to Diff 449729. cassanova added a comment. Set the LLDB_FUZZER_TARGET environment variable in the CMake file for the source code to use. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131020/new/ https://reviews.llvm.org/D131020 Files:

[Lldb-commits] [PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a project: clang. Herald added subscribers: lldb-commits,

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rGb797834748f1: [lldb/Fuzzer] Add fuzzer for expression evaluator (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D129377?vs=444761=446982#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444761. cassanova edited the summary of this revision. cassanova added a comment. Removed the cxx_proto.proto file since we include the headers that it generates from the clang side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129377/new/

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova marked an inline comment as done. cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/cxx_proto.proto:1 +//===-- cxx_proto.proto - Protobuf description of C++ -===// +// JDevlieghere wrote: >

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444361. cassanova added a comment. Updated the ProtobufMutator CMake module and expression fuzzer CMakeLists file so that the expression fuzzer will create its own target name in its CMake file, and the ProtobufMutator will not attempt to create another

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() mib wrote: > If feels

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444074. cassanova added a comment. The ProtobufMutator CMake module will build targets for clang and lldb individually depending on which project is building the mutator, instead of both fuzzers trying to build the same target. The expression fuzzer's

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/CMakeLists.txt:21 + +include(ProtobufMutator) +include_directories(${ProtobufMutator_INCLUDE_DIRS}) Commenting out this line causes the project to generate, but I

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 443768. cassanova added a comment. Shows top-of-tree changes, however CMake generation fails that the ProtobufMutator target already exists for clang-fuzzer: CMake Error at

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 443362. cassanova edited the summary of this revision. cassanova added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building the expression evaluator fuzzer is now conditional on the CLANG_ENABLE_PROTO_FUZZER CMake

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This commit adds a fuzzer for

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG40aace59cc58: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory (authored by cassanova). Repository: rG

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory

cassanova updated this revision to Diff 439454. cassanova retitled this revision from "[lldb/Fuzzer] Have target fuzzer write artifacts to specific directory" to "[lldb/Fuzzer] Have fuzzers write artifacts to specific directory". cassanova edited the summary of this revision. cassanova added a

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

cassanova added a comment. Yes, I can include the command interpreter's cmake file in the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128450/new/ https://reviews.llvm.org/D128450 ___

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

cassanova added a comment. This is a lot cleaner than chaining shell commands, I just implemented the second solution on my end. To clarify, it would create the directory before running the `fuzz-lldb-target` and within the `fuzz-lldb-target` we would just change the working directory to the

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This makes the LLDB target fuzzer

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG46be5faaf034: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D128292?vs=439158=439163#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 439158. cassanova added a comment. Added a subdirectory to the top-level build directory. This directory will hold directories for the artifacts of various fuzzers. Also corrected a typo in the command interpreter CMakeLists file. Repository: rG LLVM

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 439111. cassanova added a comment. Updated CMakeLists file to save fuzzer artifacts (the files that the fuzzer writes when an input causes the program being fuzzed to fail) to a directory in the user's build directory, instead of saving them in the user's

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 439021. cassanova added a comment. Updated ASCII header to work with 80-column limit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128292/new/ https://reviews.llvm.org/D128292 Files:

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39 + SBCommandReturnObject ro = SBCommandReturnObject(); + SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter(); +

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 438839. cassanova added a comment. Sorted subdirectories alphabetically in top-level CMakeLists file. Removed lldbfuzzer link library in command interpreter CMakeLists file. Fixed ASCII art in command interpreter source file, renamed `thisinterpreter` to

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:15 +liblldb +lldbFuzzerUtils +) JDevlieghere wrote: > I don't think this used any longer. Ok, I can remove this library.

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 438810. cassanova added a comment. Removed ObjectYAML link component from CMakeLists file, changed fuzzer invocation to use a relative path for the dictionary file, removed line that sets a breakpoint in the fuzzer's LLDB process. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:3 + Support + ObjectYAML + ) JDevlieghere wrote: > I assume we don't need this anymore if we're using the dummy target? Yes this isn't necessary

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This adds a command interpreter

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3250da1b94f: [lldb/Fuzzer] Create ninja target for target fuzzer (authored by cassanova). Changed prior to commit:

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

cassanova updated this revision to Diff 437266. cassanova added a comment. Moved changes to lldb-target-fuzzer/CMakeLists.txt file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 Files: lldb/tools/lldb-fuzzer/CMakeLists.txt

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

cassanova added a comment. Yes it can, updating the diff to reflect that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added subscribers: Michael137, mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. Create a ninja target

[Lldb-commits] [PATCH] D127016: [lldb] Prevent crash due to reading memory from page zero.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f02dd34f226: [lldb/Commands] Prevent crash due to reading memory from page zero. (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D127016?vs=434172=435359#toc Repository:

[Lldb-commits] [PATCH] D127016: [lldb] Prevent crash due to reading memory from page zero.

cassanova added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:597-598 +ABISP abi; +if (Process * proc = m_exe_ctx.GetProcessPtr()) + abi = proc->GetABI(); + kastiglione wrote: > Should `memory read` emit an error if

[Lldb-commits] [PATCH] D127016: [lldb] Prevent crash due to reading memory from page zero.

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. Adds a check to ensure that a process exists before attempting to get

[Lldb-commits] [PATCH] D126507: [lldb/fuzzer] Moving target fuzzer into separate subdirectory

cassanova created this revision. cassanova added reviewers: mib, JDevlieghere. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. Moving lldb-target-fuzzer into its