[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

2023-05-26 Thread Daniel Thornburgh via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb22965df1304: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

2023-05-26 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath updated this revision to Diff 526140. mysterymath added a comment. Apply black formatting to resolve merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/new/ https://reviews.llvm.org/D151269 Files:

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

2023-05-24 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath updated this revision to Diff 525283. mysterymath added a comment. Fixed commit message typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/new/ https://reviews.llvm.org/D151269 Files: lldb/test/Shell/helper/build.py

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to lldb tests

2023-05-24 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath updated this revision to Diff 525282. mysterymath added a comment. Restrict description to Shell tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/new/ https://reviews.llvm.org/D151269 Files:

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to lldb tests

2023-05-24 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath added a comment. In D151269#4366484 , @JDevlieghere wrote: > The change itself looks fine, but isn't this an issue for the API tests too? > If so, how is the sys root passed to `dotest.py` and can the shell tests do > the same? Ah, thanks

[Lldb-commits] [PATCH] D151269: Pass CMAKE_SYSROOT through to lldb tests.

2023-05-23 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath created this revision. Herald added a project: All. mysterymath updated this revision to Diff 524935. mysterymath added a comment. mysterymath updated this revision to Diff 524937. mysterymath added a project: LLDB. Herald added a subscriber: JDevlieghere. mysterymath added a reviewer:

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

2023-03-16 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath added a comment. Hey, it looks like the reland of this is causing issues with the Fuchsia toolchain build: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8786444992328058977/overview Seems that it's only legal to call AppendBounds if you first