[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

gut added a subscriber: eugene. gut added a comment. In https://reviews.llvm.org/D38897#908283, @gut wrote: > In https://reviews.llvm.org/D38897#903581, @clayborg wrote: > > > Looks fine. Thanks for doing the changes. > > > Hi, it's been already 4 days since this patch was accepted but not

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

gut added a comment. In https://reviews.llvm.org/D38897#903581, @clayborg wrote: > Looks fine. Thanks for doing the changes. Hi, it's been already 4 days since this patch was accepted but not merged. Did something happen internally or we just need to wait a little longer?

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

gut added a comment. Thanks for supporting this change. I guess @anajuliapc will add you both as reviewer as soon as she updates this patch. BTW, I agree that patches should be improving code quality but I wanted to highlight that these changes were actually based on the current ARM64

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut added a comment. ok... now it looks fine! Thanks @labath https://reviews.llvm.org/D36804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut updated this revision to Diff 113237. gut added a comment. Remove unused MachO detection for ppc64le (now sending all my changes on this update) https://reviews.llvm.org/D36804 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp Index: source/Core/ArchSpec.cpp

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut added a comment. Ops, wrong diff. Sorry (first time using archanist...) https://reviews.llvm.org/D36804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut updated this revision to Diff 113236. gut added a comment. Remove unused MachO detection for ppc64le https://reviews.llvm.org/D36804 Files: source/Core/ArchSpec.cpp Index: source/Core/ArchSpec.cpp === ---

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut added a comment. In https://reviews.llvm.org/D36804#856362, @labath wrote: > IIUC, the conclusion was that we don't need the mach-o entry. Could you > submit a version of the patch without it. I can't commit this right now, but > @eugene should be able to do that for you. Yes, I can.

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut added a comment. @labath could you please commit this? I don't have commit access. Thanks everyone for the review. https://reviews.llvm.org/D36804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut added inline comments. Comment at: source/Core/ArchSpec.cpp:375 SUBTYPE_MASK}, +{ArchSpec::eCore_ppc64le_generic, llvm::MachO::CPU_TYPE_POWERPC64, CPU_ANY, + UINT32_MAX, SUBTYPE_MASK}, hfinkel wrote: > I doubt this is needed. There's no Darwin

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut added a comment. In https://reviews.llvm.org/D36804#845286, @gut wrote: > Can I please get some review on this? > > ps: check comments on phabricator as it was not being published on > lldb-commits mailing list. Nobody? It's a very small change. We hope to port LLDB to PowerPC64le if

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

gut added a comment. Can I please get some review on this? ps: check comments on phabricator as it was not being published on lldb-commits mailing list. https://reviews.llvm.org/D36804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org