Author: abidh
Date: Mon Mar 25 02:41:49 2019
New Revision: 356876
URL: http://llvm.org/viewvc/llvm-project?rev=356876&view=rev
Log:
Fix a broken comment line. NFC.
Just checking that commit access is working after licensing changes.
Modified:
lldb/trunk/tools/lldb-mi/MICmdCmdMiscellanous.cp
Author: abidh
Date: Thu Jun 1 05:33:13 2017
New Revision: 304400
URL: http://llvm.org/viewvc/llvm-project?rev=304400&view=rev
Log:
Fix a small issue with -var-update.
If the variable was a pointer, code was ignoring the change in the
pointee.
Discussed in
http://lists.llvm.org/pipermail/lldb-de
Author: abidh
Date: Thu May 25 05:21:29 2017
New Revision: 303847
URL: http://llvm.org/viewvc/llvm-project?rev=303847&view=rev
Log:
Fix FDE indexing while scan debug_info section.
There are some differences between eh_frame and debug_frame formats that
are not considered by DWARFCallFrameInfo::Ge
Author: abidh
Date: Tue Jan 24 17:07:27 2017
New Revision: 292989
URL: http://llvm.org/viewvc/llvm-project?rev=292989&view=rev
Log:
Provide option to set pc of the file loaded in memory.
Summary: This commit adds an option to set PC to the entry point of the file
loaded using "target module load
Author: abidh
Date: Tue Jan 24 16:55:36 2017
New Revision: 292987
URL: http://llvm.org/viewvc/llvm-project?rev=292987&view=rev
Log:
Fix a bug where lldb does not respect the packet size.
Summary: LLDB was using packet size advertised by the target as the max memory
size to write in one go. It is
Author: abidh
Date: Fri Jan 20 04:24:03 2017
New Revision: 292598
URL: http://llvm.org/viewvc/llvm-project?rev=292598&view=rev
Log:
Fix more unused variable warnings when asserts are disabled.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Author: abidh
Date: Thu Jan 19 11:32:50 2017
New Revision: 292499
URL: http://llvm.org/viewvc/llvm-project?rev=292499&view=rev
Log:
Provide a substitute to load command of gdb.
For bare-metal targets, lldb was missing a command like 'load' in gdb
which can be used to create executable image on th
Author: abidh
Date: Thu Jan 19 09:11:01 2017
New Revision: 292488
URL: http://llvm.org/viewvc/llvm-project?rev=292488&view=rev
Log:
Avoid unused variable warning when assert is disabled.
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Modified: lldb/trunk/source/
Author: abidh
Date: Thu Jan 5 09:09:07 2017
New Revision: 291118
URL: http://llvm.org/viewvc/llvm-project?rev=291118&view=rev
Log:
Skip a test on darwin.
My earlier commit today seem to cause a failure on a darwin buildbot.
I am skipping the test while I investigate the failure.
Modified:
Author: abidh
Date: Thu Jan 5 07:23:47 2017
New Revision: 291104
URL: http://llvm.org/viewvc/llvm-project?rev=291104&view=rev
Log:
[lldb-mi] Fix implementation for a few mi commands
Summary:
Some of the mi commands implemented in lldb-mi are incomplete/not confirming to
the spec.
- `gdb-show` a
Author: abidh
Date: Fri Dec 16 08:44:34 2016
New Revision: 289947
URL: http://llvm.org/viewvc/llvm-project?rev=289947&view=rev
Log:
Remove an unused type declaration.
Modified:
lldb/trunk/tools/lldb-mi/Platform.h
Modified: lldb/trunk/tools/lldb-mi/Platform.h
URL:
http://llvm.org/viewvc/llv
Author: abidh
Date: Thu Dec 15 09:00:41 2016
New Revision: 289821
URL: http://llvm.org/viewvc/llvm-project?rev=289821&view=rev
Log:
Fix build for mingw.
Summary: I was building lldb using cross mingw-w64 toolchain on Linux and
observed some issues. This is first patch in the series to fix that b
Author: abidh
Date: Wed Dec 14 05:13:03 2016
New Revision: 289644
URL: http://llvm.org/viewvc/llvm-project?rev=289644&view=rev
Log:
Remove code needed for supporting old VS versions.
Summary: This code was probably needed to support VS2013 and is not needed now.
I have built it with VS and mingw
Author: abidh
Date: Tue Nov 29 03:31:57 2016
New Revision: 288118
URL: http://llvm.org/viewvc/llvm-project?rev=288118&view=rev
Log:
Fix a typo.
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/Targ
abidh added subscribers: clayborg, abidh.
abidh added a comment.
Please add @clayborg as reviewer. Also paste the dwarf generated for this case
from both gcc and clang.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3911
+is_static_lifetime |= has_expl
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
I have a quick look and it seems ok. Apart from fixing the issue, it is a
useful clean up too. If testcases are ok then please free to commit.
If you have noted that a function (AddSlashes?) is
abidh added a comment.
Changes looks mostly Ok to me apart from some comments. Please address them and
add testcases as mentioned by ilia. Also try to do one review for one fix. This
review is for 3 fixes. When the changes are approved, please commit them in 3
separate commits (one per fix).
abidh added a comment.
In http://reviews.llvm.org/D18880#395530, @zturner wrote:
> Looks fine to me. TBH I haven't seen any of the lldb-mi owners around in
> months, so I'm not sure if they're still active
Sorry for late reply. I have been busy lately but keep an eye on lldb-mi
patches.
ht
Author: abidh
Date: Mon Nov 2 05:43:40 2015
New Revision: 251793
URL: http://llvm.org/viewvc/llvm-project?rev=251793&view=rev
Log:
Handle the options and parameters separator in every MI command
Summary:
As per the following link, the "--" separator can appear between the options
and parameters
abidh marked an inline comment as done.
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+m_setCmdArgs.Add(new CMICmdAr
abidh added inline comments.
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+m_setCmdArgs.Add(new CMICmdArgValConsume
abidh updated this revision to Diff 38879.
abidh added a comment.
Handled review comment.
Added a test for -data-disassemble without "--" separator.
http://reviews.llvm.org/D14197
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py
tools/lldb-mi/MICmdBase.cpp
tools/lld
Author: abidh
Date: Fri Oct 30 11:20:40 2015
New Revision: 251704
URL: http://llvm.org/viewvc/llvm-project?rev=251704&view=rev
Log:
Remove 2 lines missed in earlier commit (r251636).
Modified:
lldb/trunk/tools/lldb-mi/MICmdCmdStack.cpp
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdStack.cpp
UR
abidh created this revision.
abidh added a reviewer: ki.stfu.
abidh added a subscriber: lldb-commits.
As per the following link, the "--" as separator between options and
parameter can come in any command. Currently, it was being handled in
only one command. I have moved into the base so that any
Author: abidh
Date: Thu Oct 29 11:30:47 2015
New Revision: 251636
URL: http://llvm.org/viewvc/llvm-project?rev=251636&view=rev
Log:
Better handle the arguments common to all MI commands.
Summary:
I observed that eclipse was passing --thread-group for many other commands
then we are currently hand
abidh marked an inline comment as done.
Comment at: tools/lldb-mi/MICmdBase.h:68
@@ -67,2 +67,3 @@
virtual MIuint GetGUID();
+void AddCommonArgs();
Changed name. But it cant be protected as it is called from the outside.
Comment at: to
abidh updated this revision to Diff 38741.
abidh added a comment.
Handled review comments.
http://reviews.llvm.org/D14177
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/stack/TestMiStack.py
tools/lldb-mi/MICmdBase.cpp
tools/lldb-mi/MICmdBase.h
tools/lldb-mi/MICmdCmdBreak.cpp
tool
abidh created this revision.
abidh added a reviewer: ki.stfu.
abidh added a subscriber: lldb-commits.
I observed that eclipse was passing --thread-group for many other commands
then we are currently handling. Looking at the MI documentation, the
following link states that each MI command accept th
Author: abidh
Date: Tue Oct 27 12:56:23 2015
New Revision: 251426
URL: http://llvm.org/viewvc/llvm-project?rev=251426&view=rev
Log:
Include to fix build errors.
This file uses things like fprintf and stderr and is the right
header to include. I was getting build errors without it.
Modified:
Author: abidh
Date: Tue Oct 27 12:39:22 2015
New Revision: 251421
URL: http://llvm.org/viewvc/llvm-project?rev=251421&view=rev
Log:
Add a file in Makefile build which is present in CMake build.
Since 219143, this file is missing from Makefile build. Committed as
obvious.
Modified:
lldb/trun
abidh accepted this revision.
abidh added a comment.
LGTM. Thanks for doing it. For this case, the output of the lldb-mi looks more
sensible then gdb.
http://reviews.llvm.org/D13947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
Apart from some inline comments, looks ok to me.
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:839
@@ +838,3 @@
+// Return: MIstatus::success - Functionality succeeded.
+//
abidh created this revision.
abidh added a reviewer: clayborg.
abidh added a subscriber: lldb-commits.
I saw following gcc warnings in 3 places and they seem to make sense.
"comparison of unsigned expression >= 0 is always true [-Wtype-limits]"
To fix the warnings, I have removed the offending c
abidh added a comment.
Please also indicate if a revision is dependent on some other revisions that
has not yet been committed as this one is on http://reviews.llvm.org/D13657.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:126
@@ -125,12 +125,3 @@
{
-if (m_bHa
Author: abidh
Date: Thu Oct 15 03:27:01 2015
New Revision: 250380
URL: http://llvm.org/viewvc/llvm-project?rev=250380&view=rev
Log:
Fix warnings in LLDBWrapPython.cpp with gcc 4.9.
Summary:
I see a lot of following warnings in LLDBWrapPython.cpp while building with gcc
4.9 on Linux.
"warning: ca
abidh created this revision.
abidh added reviewers: zturner, clayborg.
abidh added a subscriber: lldb-commits.
I see a lot of following warnings in LLDBWrapPython.cpp while building with gcc
4.9 on Linux.
"warning: cast from type ‘const char*’ to type ‘char*’ casts away qualifiers
[-Wcast-qual]"
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D12879
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
abidh requested changes to this revision.
abidh added a comment.
This revision now requires changes to proceed.
You forgot to add the MIUtilParse.cpp to CMakeLists.txt. Please add it and then
it is good to go. Thanks for doing it.
Repository:
rL LLVM
http://reviews.llvm.org/D12115
___
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
Look good.
http://reviews.llvm.org/D12796
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
abidh requested changes to this revision.
abidh added a comment.
This revision now requires changes to proceed.
There is a check on m_strMediumFileDirectory in
CMICmnLogMediumFile::FileFormFileNamePath which may needs to be updated.
Otherwise looks ok to me.
http://reviews.llvm.org/D12764
_
abidh requested changes to this revision.
abidh added a comment.
This revision now requires changes to proceed.
We dont use the lldb_private stuff inside lldb-mi. Please see the discussion in
the following thread.
http://lists.llvm.org/pipermail/lldb-dev/2015-March/007047.html
Repository:
rL
Author: abidh
Date: Wed Sep 9 04:06:05 2015
New Revision: 247124
URL: http://llvm.org/viewvc/llvm-project?rev=247124&view=rev
Log:
Remove an invalid check in DW_OP_piece processing.
Summary:
When lldb is processing a location containing DW_OP_piece, the result is being
stored in the 'pieces' var
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247124: Remove an invalid check in DW_OP_piece processing.
(authored by abidh).
Changed prior to commit:
http://reviews.llvm.org/D12674?vs=34154&id=34301#toc
Repository:
rL LLVM
http://reviews.llvm.
abidh created this revision.
abidh added reviewers: aprantl, clayborg.
abidh added a subscriber: lldb-commits.
When lldb is processing a location containing DW_OP_piece, the result is being
stored in the 'pieces' variable. The location is popped from the 'stack'
variable.
So this check to see tha
Author: abidh
Date: Mon Sep 7 07:00:51 2015
New Revision: 246965
URL: http://llvm.org/viewvc/llvm-project?rev=246965&view=rev
Log:
Fix -data-evaluate-expression for array.
Summary:
For an array declared like "blk[2][3]", this command was showing:
-data-evaluate-expression blk
^done,value="{[0] =
abidh updated this revision to Diff 34136.
abidh added a comment.
Handle review comments.
Moved the test to data directory and put it in a separate function.
http://reviews.llvm.org/D12634
Files:
test/tools/lldb-mi/data/TestMiData.py
test/tools/lldb-mi/data/main.cpp
tools/lldb-mi/MICmdCmd
Author: abidh
Date: Fri Sep 4 11:34:19 2015
New Revision: 246859
URL: http://llvm.org/viewvc/llvm-project?rev=246859&view=rev
Log:
Use correct #ifdef check for ProcessWindowsLog::Terminate() call.
The call to ProcessWindowsLog::Initialize() is protected by #if
defined(_MSC_VER).
But the call to
Author: abidh
Date: Fri Sep 4 11:10:48 2015
New Revision: 246858
URL: http://llvm.org/viewvc/llvm-project?rev=246858&view=rev
Log:
Fix CMICmdArgValConsume to correctly handle "--".
CMICmdArgValConsume::Validate was not removing it from the input stream.
Modified:
lldb/trunk/tools/lldb-mi/M
abidh created this revision.
abidh added a reviewer: ki.stfu.
abidh added a subscriber: lldb-commits.
For an array declared like "blk[2][3]", this command was showing:
-data-evaluate-expression blk
^done,value="{[0] = [3], [1] = [3]}"
After this fix, it shows:
-data-evaluate-expression blk
^done,
Author: abidh
Date: Fri Sep 4 06:26:53 2015
New Revision: 246847
URL: http://llvm.org/viewvc/llvm-project?rev=246847&view=rev
Log:
Fix multiple problems in -break-condition command.
1. To handle the expression with spaces, this command uses 2 arguments. For a
case
like -break-condition 1 i =
abidh added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:348
@@ -292,1 +347,3 @@
+}
+}
You are not using the DW_AT_GNU_dwo_id. Is this intentional or an oversight?
http://reviews.llvm.org/D12291
_
abidh added a comment.
This command uses "target modules lookup" to obtain the information while
-symbol-list-lines uses "target modules dump line-table". Although there is
difference in the format of the output of these 2 commands, the format for path
and line is same. I think we should have o
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D12113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
abidh added a comment.
In http://reviews.llvm.org/D11574#219248, @paulmaybee wrote:
> I'm not sure what the misunderstanding is, so I'll rephrase our desire. The
> VS debugger decorates code addresses with the name of the shared library from
> which the code originated (example above). We wish
abidh added a comment.
I asked this question in the other revision too. Can you give a reason why this
field is needed. The following description you gave in this revision does not
make much sense to me. I am not opposed to adding this field but would like to
know what problem it solves before
55 matches
Mail list logo
