[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. Asking LLDB community whether to continue with this patchset upstreaming: Its advantage is sure compatibility with DWZ being used by {RHEL,CentOS}-{7,8}. The next version of {RHEL,CentOS} will use it as well. By my quick check Debian 12=Bookworm=testing is not usin

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96236/new/ https://reviews.llvm.org/D96236 ___

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 09/17: Pass main DWARFUnit * along DWARFDIEs

jankratochvil updated this revision to Diff 374770. jankratochvil retitled this revision from "[lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs" to "[lldb] DWZ 09/17: Pass main DWARFUnit * along DWARFDIEs". Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D96243: [lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96243/new/ https://reviews.llvm.org/D96243 ___

[Lldb-commits] [PATCH] D96242: [lldb] DWZ 16/17: New testcases

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96242/new/ https://reviews.llvm.org/D96242 ___

[Lldb-commits] [PATCH] D96241: [lldb] DWZ 15/17: New testsuite category 'dwz'

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96241/new/ https://reviews.llvm.org/D96241 ___

[Lldb-commits] [PATCH] D98826: [lldb] DWZ 14/17: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98826/new/ https://reviews.llvm.org/D98826 ___

[Lldb-commits] [PATCH] D96240: [lldb] DWZ 13/17: Main functionality

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96240/new/ https://reviews.llvm.org/D96240 ___

[Lldb-commits] [PATCH] D96239: [lldb] DWZ 12/17: DIERef support

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96239/new/ https://reviews.llvm.org/D96239 ___

[Lldb-commits] [PATCH] D96238: [nfc] [lldb] DWZ 11/17: Rename TypeUnitSupportFiles -> SharedUnitSupportFiles

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96238/new/ https://reviews.llvm.org/D96238 ___

[Lldb-commits] [PATCH] D96237: [lldb] DWZ 10/17: More support for .gnu_debugaltlink

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96237/new/ https://reviews.llvm.org/D96237 ___

[Lldb-commits] [PATCH] D110404: [nfc] [lldb] DWZ 08/17: Use DIERef for DIEToClangType m_forward_decl_die_to_clang_type and GetForwardDeclDieToClangType()

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110404/new/ https://reviews.llvm.org/D110404 _

[Lldb-commits] [PATCH] D110403: [nfc] [lldb] DWZ 07/17: Use DIERef for DIEToVariableSP m_die_to_variable_sp and GetDIEToVariable()

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110403/new/ https://reviews.llvm.org/D110403 _

[Lldb-commits] [PATCH] D110402: [nfc] [lldb] DWZ 06/17: Use DIERef for DIEToTypePtr m_die_to_type and GetDIEToType()

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110402/new/ https://reviews.llvm.org/D110402 _

[Lldb-commits] [PATCH] D110401: [nfc] [lldb] DWZ 05/17: Use DIERef for DIEToDeclMap m_die_to_decl

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110401/new/ https://reviews.llvm.org/D110401 _

[Lldb-commits] [PATCH] D110400: [nfc] [lldb] DWZ 04/17: Use DIERef for DIEToModuleMap m_die_to_module

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110400/new/ https://reviews.llvm.org/D110400 _

[Lldb-commits] [PATCH] D110399: [nfc] [lldb] DWZ 03/17: Use DIERef for DIEToDeclContextMap m_die_to_decl_ctx

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110399/new/ https://reviews.llvm.org/D110399 _

[Lldb-commits] [PATCH] D110397: [nfc] [lldb] DWZ 02/17: Refactor DIERef for a key in llvm::DenseMap

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110397/new/ https://reviews.llvm.org/D110397 _

[Lldb-commits] [PATCH] D110396: [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToDIEMap m_decl_ctx_to_die

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110396/new/ https://reviews.llvm.org/D110396 _

[Lldb-commits] [PATCH] D110404: [nfc] [lldb] DWZ 08/17: Use DIERef for DIEToClangType m_forward_decl_die_to_clang_type and GetForwardDeclDieToClangType()

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110403: [nfc] [lldb] DWZ 07/17: Use DIERef for DIEToVariableSP m_die_to_variable_sp and GetDIEToVariable()

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. After D96236 using just `DWARFDebugInfoEntry *` is

[Lldb-commits] [PATCH] D110402: [nfc] [lldb] DWZ 06/17: Use DIERef for DIEToTypePtr m_die_to_type and GetDIEToType()

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110401: [nfc] [lldb] DWZ 05/17: Use DIERef for DIEToDeclMap m_die_to_decl

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110400: [nfc] [lldb] DWZ 04/17: Use DIERef for DIEToModuleMap m_die_to_module

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110399: [nfc] [lldb] DWZ 03/17: Use DIERef for DIEToDeclContextMap m_die_to_decl_ctx

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110397: [nfc] [lldb] DWZ 02/17: Refactor DIERef for a key in llvm::DenseMap

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Next patch XXX will use DIERef as a key in `llvm::DenseMap`, therefore we need to be

[Lldb-commits] [PATCH] D110396: [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToFileDIERefMap m_decl_ctx_to_filedieref

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. Replace `DWARFDIE` by `std::pair`. Currently it has

[Lldb-commits] [PATCH] D96243: [lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files

jankratochvil updated this revision to Diff 374781. jankratochvil retitled this revision from "[lldb] DWZ 9/9: Fix symlinked /usr/lib/debug/.build-id/**.debug files" to "[lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files". jankratochvil edited the summary of this revision. ja

[Lldb-commits] [PATCH] D96242: [lldb] DWZ 16/17: New testcases

jankratochvil updated this revision to Diff 374779. jankratochvil retitled this revision from "[lldb] DWZ 8/9: New testcases" to "[lldb] DWZ 16/17: New testcases". jankratochvil edited the summary of this revision. jankratochvil added a comment. My question about upstreaming of this patchset.

[Lldb-commits] [PATCH] D96241: [lldb] DWZ 15/17: New testsuite category 'dwz'

jankratochvil updated this revision to Diff 374778. jankratochvil retitled this revision from "[lldb] DWZ 7/9: New testsuite category 'dwz'" to "[lldb] DWZ 15/17: New testsuite category 'dwz'". jankratochvil edited the summary of this revision. jankratochvil added a comment. My question about ups

[Lldb-commits] [PATCH] D98826: [lldb] DWZ 14/17: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols

jankratochvil updated this revision to Diff 374776. jankratochvil retitled this revision from "[lldb] DWZ 6/9: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols" to "[lldb] DWZ 14/17: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols". jankratochvil edited the su

[Lldb-commits] [PATCH] D96240: [lldb] DWZ 13/17: Main functionality

jankratochvil updated this revision to Diff 374775. jankratochvil retitled this revision from "[lldb] DWZ 5/9: Main functionality" to "[lldb] DWZ 13/17: Main functionality". jankratochvil edited the summary of this revision. jankratochvil added a comment. Herald added a reviewer: jdoerfert. Herald

[Lldb-commits] [PATCH] D96239: [lldb] DWZ 12/17: DIERef support

jankratochvil updated this revision to Diff 374774. jankratochvil retitled this revision from "[lldb] DWZ 4/9: DIERef support" to "[lldb] DWZ 12/17: DIERef support". jankratochvil edited the summary of this revision. jankratochvil added a comment. My question about upstreaming of this patchset.

[Lldb-commits] [PATCH] D96238: [lldb] [nfc] DWZ 11/17: rename TypeUnitSupportFiles -> SharedUnitSupportFiles

jankratochvil updated this revision to Diff 374773. jankratochvil retitled this revision from "[lldb] [nfc] DWZ 3/9: rename TypeUnitSupportFiles -> SharedUnitSupportFiles" to "[lldb] [nfc] DWZ 11/17: rename TypeUnitSupportFiles -> SharedUnitSupportFiles". jankratochvil edited the summary of this

[Lldb-commits] [PATCH] D96237: [lldb] DWZ 10/17: More support for .gnu_debugaltlink

jankratochvil updated this revision to Diff 374772. jankratochvil retitled this revision from "[lldb] DWZ 2/9: More support for .gnu_debugaltlink" to "[lldb] DWZ 10/17: More support for .gnu_debugaltlink". jankratochvil edited the summary of this revision. jankratochvil added a comment. My questi

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

jankratochvil added a comment. It broke Fedora 34 x86_64 buildbot (using gcc) lldb-x86_64-fedora = https://lab.llvm.org/staging/#/builders/16 https://lab.llvm.org/staging/#/builders/16/builds/10450 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1075

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

jankratochvil added a comment. The new test is failing on all Linux buildbots such as: lldb-x86_64-fedora = https://lab.llvm.org/staging/#/builders/16 lldb-x86_64-debian = https://lab.llvm.org/buildbot/#/builders/68 https://lab.llvm.org/buildbot/#/builders?tags=lldb Repository: rG LLVM Github

[Lldb-commits] [PATCH] D107470: 2/4: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil created this revision. jankratochvil added reviewers: ikudrin, dblaikie, labath, clayborg. jankratochvil added projects: LLDB, LLVM. Herald added subscribers: JDevlieghere, hiraditya. jankratochvil requested review of this revision. @ikudrin has correctly noticed

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:556 + " (ranges list base: 0x%" PRIx64 "): %s", + offset, m_ranges_base, to

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe21a21a977b4: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base… (authored by jankratochvil). Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. In D106466#2947710 , @dblaikie wrote: > I assume there's already test coverage for rnglistx in debug_info.dwo/split > unit? (because in that case there's no rnglists_base, but rnglistx is usable) I admit I did not check it

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366684. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107470/new/ https://reviews.llvm.org/D107470 Files: lldb/unittests/SymbolFile/DWARF/DWARFUnitTest.cpp llvm/include/llvm/DebugInfo/DWARF/DWARFListTa

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil marked 3 inline comments as done. jankratochvil added a comment. In D107470#2946689 , @ikudrin wrote: > `DWARFDebugInfo.TestRnglistsAddressSize`, > `DWARFListTableHeader.AddressSize64Offset`, and > `DWARFListTableHeader.AddressSize32Offset

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 366676. jankratochvil edited the summary of this revision. jankratochvil added a comment. @dblaikie do you think it is OK for check-in now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106466/new/ https:

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. In D106466#2939551 , @ikudrin wrote: > In D106466#2926185 , @jankratochvil > wrote: > >> One needs to set at least `AddrSize` and `OffsetEntryCount` as callers do >> use it. > > Co

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 366449. jankratochvil retitled this revision from "3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)" to "[llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GC

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:289-291 if (Header.length()) Data = DWARFDataExtractor(Data, getHeaderOffset() + Header.length()); + Data.setAddressSize(ge

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366448. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107470/new/ https://reviews.llvm.org/D107470 Files: lldb/unittests/SymbolFile/DWARF/DWARFUnitTest.cpp llvm/include/llvm/DebugInfo/DWARF/DWARFListTa

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366446. jankratochvil marked an inline comment as done. jankratochvil retitled this revision from "2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor" to "[llvm+lldb] Remove dead-code in DWARFListTableHeader:

[Lldb-commits] [PATCH] D107470: 2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: llvm/unittests/DebugInfo/DWARF/DWARFListTableTest.cpp:128 + EXPECT_EQ(Table.getAddrSize(), 8U); + Extractor.setAddressSize(Table.getAddrSize()); + Expected List = Table.findList(Ex

[Lldb-commits] [PATCH] D107470: 2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366017. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107470/new/ https://reviews.llvm.org/D107470 Files: lldb/unittests/SymbolFile/DWARF/DWARFUnitTest.cpp llvm/include/llvm/DebugInfo/DWARF/DWARFListTa

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:519 +contribution->Length); +return DWARFDataExtractor(); + } Here could be an error message. Comment at: l

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3932b9a0b0b: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using . (authored by jankratochvil). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

jankratochvil added a comment. Thanks for checking it but ... In D107659#2931836 , @clayborg wrote: > Can we not just grab the skeleton unit when/if needed instead of asserting in > many places? ... I am not sure @clayborg likes the assertions. Repos

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

jankratochvil updated this revision to Diff 364861. jankratochvil added a comment. In D107659#2931836 , @clayborg wrote: > Can we not just grab the skeleton unit when/if needed instead of asserting in > many places? I agree it could be unified for API s

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/find-variable-file.cpp:34 +// RUN: %clang -c -o %t-2.o --target=x86_64-pc-linux -gdwarf-5 -gsplit-dwarf -

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

jankratochvil created this revision. jankratochvil added reviewers: kimanh, labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, arphaman. jankratochvil requested review of this revision. As this issue is a bit difficult to debug it is better to make it sa

[Lldb-commits] [PATCH] D107485: [nfc] [lldb] Prevent needless copies of DataExtractor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14f443030c1a: [nfc] [lldb] Prevent needless copies of DataExtractor (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D106466: 3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 364190. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106466/new/ https://reviews.llvm.org/D106466 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cp

[Lldb-commits] [PATCH] D106466: 3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added a comment. In D106466#2922549 , @ikudrin wrote: > As far as I understand it, you need a specially constructed > `llvm::DWARFDebugRnglistTable` object so that > `DWARFUnit::FindRnglistFr

[Lldb-commits] [PATCH] D107485: [nfc] [lldb] Prevent needless copies of DataExtractor

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, teemperor. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. This patch was created accidentally but I find it useful when I already wr

[Lldb-commits] [PATCH] D107165: Support moving support files instead of copy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG437e37dd5539: [nfc] [lldb] Support moving support files instead of copy (authored by Eric, committed by jankratochvil). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D107300: Use filename instead of index in test

This revision was automatically updated to reflect the committed changes. Closed by commit rGea9706626ce3: [test] [lldb] Use filename instead of index in test (authored by Eric, committed by jankratochvil). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LL

[Lldb-commits] [PATCH] D107161: [lldb] Fix lookup of .debug_loclists with split-dwarf

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. LGTM with some those adjustments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:450 +if (!contribution) + return; +offset += contr

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2917768 , @stella.stamenova wrote: > This also fails on the Windows lldb bot: Sorry I did not check (probably it sends messages to Author and not Commiter). Added there: // -gsplit-dwarf is supported only on

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2917467 , @Eric wrote: > Is arm hardware necessary to test this, In this case it is not as it does not require linking. Usually I find easier to run it natively than to setup all the cross-compilation libraries

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2917250 , @Eric wrote: > Would it make sense to turn the split-optimized test back into an x86 only > test, or just leave it out of the change as it's not actually testing a code > path that this changed? The q

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2916203 , @omjavaid wrote: > This fails on 32 bit Arm > https://lab.llvm.org/buildbot/#/builders/17/builds/9595 I have reverted it as it takes some time to build on arm32 to investigate it. Repository: rG LL

[Lldb-commits] [PATCH] D107153: [nfc] [osx] [lldb] Simplify code using GetDebugMapSymfile()

jankratochvil created this revision. jankratochvil added reviewers: clayborg, Eric, dblaikie. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. In D100299 I was not sure what can happen

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7b8ba103a84: [lldb] [DWARF-5] Be lazier about loading .dwo files (authored by Eric, committed by jankratochvil). Herald added a project: LLDB. Heral

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

jankratochvil added a comment. It broke some Linux buildbots and it also broke testsuite on my Fedora machine: `functionalities/gdb_remote_client/TestTargetXMLArch.py` - lldb-x86_64-fedora: https://lab.llvm.org/staging/#/builders/16/builds/8988 - lldb-aarch64-ubuntu: https://lab.llvm.org/buildbot

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. You can also consider coding `lldb-add-index` for better performance as that is too much for my available time. In D106355#2909462 , @kimanh wrote: > Otherwise, could you help me to land this change (since I do not have >

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e9853e0e9ff: [DWARF5] Only fallback to manual index if no entry was found (authored by kimanh, committed by jankratochvil). Repository: rG LLVM G

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. Approved after removing the curly brackets. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:136 continue; if (entr

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. In D106355#2903655 , @kimanh wrote: > Ah, to make sure that I understand it correctly: using `gdb-add-index` would > help `ManualDWARFIndex` to generate a `.debug_names`? No. One could write hypothetical `lldb-add-index` t

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil abandoned this revision. jankratochvil added a comment. It has been merged to D100299 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106194/new/ https://reviews.llvm.org/D106194

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil added a comment. @Eric yes, it would be better to merge it with your D100299 . In D106194#2894795 , @Eric wrote: > Instead of echoing into .c files, can we write the tests as .c files? It > seems to be a

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. In D106355#2896117 , @kimanh wrote: > In our case we have some third-party libraries that were not built by us, and > therefore they don't have any name index. Our main focus, is however, not to > debug those third party l

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. Is it really just a microoptimization or can you measure any improvement? That `ManualDWARFIndex::Index` will be called is expected. But there should be `m_units_to_avoid` covering all the units so it will quickly return without indexing anything: if (units_to_

[Lldb-commits] [PATCH] D106466: [llvm+lldb] 2/2: Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: dblaikie, labath, clayborg. jankratochvil added projects: LLDB, LLVM. Herald added subscribers: JDevlieghere, hiraditya. jankratochvil requested review of this revision. Fix D98289 so that it work

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil updated this revision to Diff 359458. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106194/new/ https://reviews.llvm.org/D106194 Files: lldb/test/Shell/ObjectFile/ELF/split-lazy-load.test lldb/test/Shell/ObjectFile/ELF/split-optimi

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil created this revision. jankratochvil added reviewers: Eric, dblaikie. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, emaste. jankratochvil requested review of this revision. Herald added a subscriber: MaskRay. D100299

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rG72748488addd: [lldb] Fix editline unicode on Linux (authored by jankratochvil). Repository: rG LLV

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/tools/driver/Driver.cpp:871 int main(int argc, char const *argv[]) { + ::setlocale(LC_ALL, ""); + ::setlocale(LC_CTYPE, ""); teemperor wrote: > Can you make t

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil updated this revision to Diff 358047. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105779/new/ https://reviews.llvm.org/D105779 Files: lldb/source/Core/IOHandlerCursesGUI.cpp lldb/tools/driver/Driver.cpp Index: lldb/tools/driver

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil updated this revision to Diff 357799. jankratochvil edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105779/new/ https://reviews.llvm.org/D105779 Files: lldb/source/Core/IOHandlerCursesGUI.cpp lldb

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil created this revision. jankratochvil added reviewers: teemperor, nealsid, labath. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. [[ https://lists.llvm.org/pipermail/lldb-dev/2021-July/016961.html | [lldb-

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105133/new/ https://reviews.llvm.org/D105133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe825c244b606: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64 (authored by jankratochvil). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil updated this revision to Diff 355333. jankratochvil added a comment. This revision is now accepted and ready to land. Unfortunately `AddRecognizer` requires both or none `module` and `symbols` as regexes. And we cannot make `module` a regex as `GetFileSpec().FileEquals` would not w

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:115 +regex += it->GetStringRef(); + } + // Strip the trailing @VER symbol version. There would be nice `llvm::join`. But it wants `Elem.size()` while `ConstString

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil updated this revision to Diff 355327. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105133/new/ https://reviews.llvm.org/D105133 Files: lldb/source/Target/AssertFrameRecognizer.cpp Index: lldb/source/Target/AssertFrameRecognizer.cp

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil created this revision. jankratochvil added reviewers: teemperor, mib. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. While on regular Linux system (Fedora 34 GA, not updated): * thread #1, name = '1',

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. On OSX with `-DLLDB_USE_SYSTEM_DEBUGSERVER=OFF` I have built: -rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver It uses `lldb/tools/debugserver/source/RNBSocket.cpp` (if I mess up the source file it does not build). The build does not need this `Reso

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added inline comments. Comment at: lldb/tools/debugserver/source/RNBSocket.cpp:44 } else if (strcmp(hostname, "*") == 0) { addr = htonl(INADDR_ANY); return true; Here it should use `AI_PASSIVE` instead. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. In D104856#2838571 , @teemperor wrote: > The file is part of `debugserver` which is Darwin exclusive and is also only > compiled/used when you're on Darwin. It's also kind of its own thing: it > isn't using LLVM libraries

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. In D104856#2838515 , @teemperor wrote: > (Nit: this is from the Linux manpage but this code is only compiled on > Darwin). Why do you think so? I haven't tried to build it on OSX but according to GIT the last use of this

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfffb97509511: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite… (authored by jankratochvil). Changed prior to commit: https://re

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

jankratochvil added a comment. In D104283#2818897 , @teemperor wrote: > - We should hide the deleter if it's stateless (default_delete or a > user-specified deleter that is empty) as the less verbose output is more > useful for command line users. My p

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

jankratochvil added a comment. In D104283#2818693 , @teemperor wrote: > (Technically that would hide the deleter if the user specifies a > default-deleter that just happens to be compatible, but that seems like an > obscure corner case so this seems "go

  1   2   3   4   5   6   7   8   9   >