Re: [Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D21064 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

jaydeep added a comment. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53 @@ -22,2 +52,3 @@ + NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol _thread, uint32_t

Re: [Lldb-commits] [PATCH] D17597: [LLDB][MIPS] Fix TestDisassembleBreakpoint

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D17597 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rL LLVM http://reviews.llvm.org/D16840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15488: [LLDB][MIPS] Mark TestConcurrentEvents.py expected failure, as MIPS atomic sequences are yet to be supported in LLDB

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D15488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15487: [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D15487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL254710 Repository: rL LLVM http://reviews.llvm.org/D15182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r254710 - [LLDB][MIPS] XFAIL TestCrashDuringStep.py for MIPS

Author: jaydeep Date: Fri Dec 4 03:56:36 2015 New Revision: 254710 URL: http://llvm.org/viewvc/llvm-project?rev=254710=rev Log: [LLDB][MIPS] XFAIL TestCrashDuringStep.py for MIPS SUMMARY: Marked TestCrashDuringStep.py as XFAIL for MIPS. The test generates IO error due to breakpoint at

Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

jaydeep updated this revision to Diff 41840. jaydeep added a comment. Marked as XFAIL Repository: rL LLVM http://reviews.llvm.org/D15182 Files: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py Index:

[Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: bhushan, sagar, mohit.bhakkad, nitesh.jain, lldb-commits. jaydeep set the repository for this revision to rL LLVM. Single stepping requires setting software breakpoint at address 0x0. This results in

[Lldb-commits] [lldb] r254590 - [LLDB][MIPS] Using enum instead of a constant to fetch PC and CAUSE registers.

Author: jaydeep Date: Thu Dec 3 00:41:24 2015 New Revision: 254590 URL: http://llvm.org/viewvc/llvm-project?rev=254590=rev Log: [LLDB][MIPS] Using enum instead of a constant to fetch PC and CAUSE registers. SUMMARY: Using enum instead of a constant to fetch PC and CAUSE registers.

[Lldb-commits] [lldb] r254376 - [LLDB][MIPS] Change ARCHFLAG for MIPS

Author: jaydeep Date: Mon Nov 30 23:24:17 2015 New Revision: 254376 URL: http://llvm.org/viewvc/llvm-project?rev=254376=rev Log: [LLDB][MIPS] Change ARCHFLAG for MIPS SUMMARY: For MIPS, ARCH is specified without m. Reviewers: clayborg Subscribers: nitesh.jain, mohit.bhakkad,

[Lldb-commits] [PATCH] D14978: [MIPS] Change ARCHFLAG for MIPS

jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: lldb-commits, bhushan, mohit.bhakkad, sagar, nitesh.jain. jaydeep set the repository for this revision to rL LLVM. For MIPS, ARCH is specified without 'm'. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14860: [LLDB][MIPS] Getting 0 index for h/w watchpoint is not necessarily an error

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D14860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [Diffusion] rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep added a comment. Hi Dwan, Could you please try http://reviews.llvm.org/rL247968 and let me know if the issue persist? Thanks, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247773 ___ lldb-commits mailing

Re: [Lldb-commits] [Diffusion] rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep added a comment. Hi Dawn, Could you please provide more details on this? Thanks, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [Diffusion] rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep added a comment. Hi Dawn, Could you please provide more details on this? Thanks, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [Diffusion] rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep added a comment. Hi Dawn, Let me check and get back to you. Regards, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248248 - [LLDB][MIPS] microMIPS breakpoints, disassembly and compressed addresses

Author: jaydeep Date: Tue Sep 22 01:36:56 2015 New Revision: 248248 URL: http://llvm.org/viewvc/llvm-project?rev=248248=rev Log: [LLDB][MIPS] microMIPS breakpoints, disassembly and compressed addresses SUMMARY: This patch detects microMIPS symbols, sets breakpoints using un-compressed

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL248248 Repository: rL LLVM http://reviews.llvm.org/D12079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 35059. jaydeep added a comment. Addressed review comments. Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/Address.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [lldb] r247968 - [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

Author: jaydeep Date: Fri Sep 18 00:32:54 2015 New Revision: 247968 URL: http://llvm.org/viewvc/llvm-project?rev=247968=rev Log: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo SUMMARY: Using response.IsUnsupportedResponse instead of

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep added a comment. Changed "!response.IsNormalResponse()" to "response.IsUnsupportedResponse()" by commit http://reviews.llvm.org/rL247968 Repository: rL LLVM http://reviews.llvm.org/D12876 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL247773 Repository: rL LLVM http://reviews.llvm.org/D12876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 34873. jaydeep added a comment. Addressed review comments Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/Address.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [lldb] r247773 - [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

Author: jaydeep Date: Tue Sep 15 23:04:01 2015 New Revision: 247773 URL: http://llvm.org/viewvc/llvm-project?rev=247773=rev Log: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo SUMMARY: Refer to http://lists.llvm.org/pipermail/lldb-dev/2015-August/008024.html

[Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: lldb-commits, bhushan, sagar, mohit.bhakkad, nitesh.jain. jaydeep set the repository for this revision to rL LLVM. Refer to for

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 34782. jaydeep added a comment. Addressed review comments Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/Address.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added a comment. Hi Greg, Could you please find some time to review this? Thanks Repository: rL LLVM http://reviews.llvm.org/D12079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added a comment. In http://reviews.llvm.org/D12079#244059, @jaydeep wrote: > In http://reviews.llvm.org/D12079#243390, @clayborg wrote: > > > In http://reviews.llvm.org/D12079#242998, @jaydeep wrote: > > > > > In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > > > > > > > So

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 34532. jaydeep added a comment. In this patch: Modified DumpAddress() to print compressed address for microMIPS. Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/FormatEntity.cpp

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added a comment. In http://reviews.llvm.org/D12079#243390, @clayborg wrote: > In http://reviews.llvm.org/D12079#242998, @jaydeep wrote: > > > In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > > > > > So DumpAddress() in FormatEntity.cpp is a generic "dump any address by > > >

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added a comment. In http://reviews.llvm.org/D12079#242751, @clayborg wrote: > Actually not a new format type, but an extra arg will need to be passed to > DumpAddress like "bool addr_is_callable". > > Can you explain something to me? In the following example: > > 0x8020067d <+0>:

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 34199. jaydeep added a comment. In this patch: The bit #0 has been cleared from addresses in the line tables. However we are relying upon ArchSpec instead of Target while clearing this bit in ParseDWARFLineTableCallback because SymbolContext may not have a

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added inline comments. Comment at: source/Target/RegisterContext.cpp:106-116 @@ -105,3 +105,13 @@ uint32_t reg = ConvertRegisterKindToRegisterNumber (eRegisterKindGeneric, LLDB_REGNUM_GENERIC_PC); -return ReadRegisterAsUnsigned (reg, fail_value); +uint64_t

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 33793. jaydeep added a comment. Added GetCallableFileAddress for MIPS Repository: rL LLVM http://reviews.llvm.org/D12079 Files: include/lldb/Core/Address.h include/lldb/Symbol/Function.h include/lldb/Target/Target.h

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rL LLVM http://reviews.llvm.org/D12356 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D11519: [MIPS] Use qfThreadID if qC packet is not supported by target

jaydeep updated this revision to Diff 31908. jaydeep added a comment. Addressed review comments. Repository: rL LLVM http://reviews.llvm.org/D11519 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Index: