@@ -145,10 +194,12 @@ class Status {
bool Success() const;
protected:
- /// Status code as an integer value.
- ValueType m_code = 0;
- /// The type of the above error code.
- lldb::ErrorType m_type = lldb::eErrorTypeInvalid;
+ Status(llvm::Error &&error) : m_error(std::
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -37,49 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGeneric.
+class GenericCateg
@@ -91,10 +136,14 @@ class Status {
~Status();
- // llvm::Error support
- explicit Status(llvm::Error error) { *this = std::move(error); }
+ /// Try not to use this in new code. Migrate APIs to llvm::Expected instead.
JDevlieghere wrote:
[nit] I'd word
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106773
>From a73b63a4b3e74b92b9ef5f913c75b4710859bca6 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 11:07:50 -0700
Subject: [PATCH 1/2] [lldb] Include checksum in source cache dump
This
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106773
This patch updates the source cache dump command to print both the actual
(on-disk) checksum and the expected (line table) checksum. To achieve that we
now read and store the on-disk checksum in the cached
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/106740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106740
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 07:20:26 -0700
Subject: [PATCH 1/3] [lldb] Deal with SupportFiles in SourceManager (NFC
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106740
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 07:20:26 -0700
Subject: [PATCH 1/2] [lldb] Deal with SupportFiles in SourceManager (NFC
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106740
To support detecting MD5 checksum mismatches, deal with SupportFiles rather
than a plain FileSpecs in the SourceManager.
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas
Author: Jonas Devlieghere
Date: 2024-08-30T07:21:45-07:00
New Revision: b0eefb4c4e5136fd606cf4cff566df9dbc0fa051
URL:
https://github.com/llvm/llvm-project/commit/b0eefb4c4e5136fd606cf4cff566df9dbc0fa051
DIFF:
https://github.com/llvm/llvm-project/commit/b0eefb4c4e5136fd606cf4cff566df9dbc0fa051.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/106639
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106639
To support detecting MD5 checksum mismatches, store a SupportFile rather than a
plain FileSpec in SourceManager::File.
>From 64b6c6419722ecd5865cdf3e734b63ed51763174 Mon Sep 17 00:00:00 2001
From: Jonas De
JDevlieghere wrote:
Looks like this is ready to go. @Da-Viper do you need someone to merge this for
you?
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/106034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/105890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
This is great. It's something I've wanted since the first day I started working
on LLDB. We've made a lot of progress in this direction so it's great to see
that we've reached a point where we can make this actually happen.
https://g
JDevlieghere wrote:
There's a few things I don't really like about this patch:
- It's very specific to a single plugin.
- It sidesteps the plugin's `Initialize/Terminate` paradigm. It happens to
work because `ScriptInterpreterPython::Terminate` is a NOOP (see the comment
for `ScriptInterpr
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/105715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
The change itself looks fine, but can you please update the PR description with
a meaningful message, preferably with a reference that shows that this was
added in 4.3?
https://github.com/llvm/llvm-project/pull/105715
_
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/105576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/105576
In f9f3316, Adrian fixed an issue where LLDB wouldn't update the target's
architecture when the process reported a different triple that only differed in
its sub-architecture.
This unintentionally regress
https://github.com/JDevlieghere approved this pull request.
Sorry for breaking this & thanks for fixing it.
https://github.com/llvm/llvm-project/pull/105460
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/105457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
This looks like a nice improvement! Can we add a test for this?
https://github.com/llvm/llvm-project/pull/105457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -137,12 +137,28 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
llvm::Expected expected_return_object =
create_error("Resulting object is not initialized.");
- std::apply(
- [&init, &expected_return_object](auto &&...args
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
@@ -1208,7 +1208,8 @@ bool SBThread::GetStatus(SBStream &status) const {
ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
if (exe_ctx.HasThreadScope()) {
-exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, true);
+exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, tr
@@ -17,6 +17,7 @@
#include "lldb/lldb-private-forward.h"
#include "lldb/lldb-public.h"
+#include <_types/_uint16_t.h>
JDevlieghere wrote:
+1, this looks fishy. `cstdint` or `cinttypes` should do.
https://github.com/llvm/llvm-project/pull/104523
@@ -518,33 +523,33 @@ class StackFrame : public ExecutionContextScope,
bool HasCachedData() const;
private:
- // For StackFrame only
+ /// For StackFrame only.
lldb::ThreadWP m_thread_wp;
uint32_t m_frame_index;
uint32_t m_concrete_frame_index;
lldb::RegisterCo
@@ -1202,6 +1202,19 @@ bool SBFrame::IsArtificial() const {
return false;
}
+bool SBFrame::IsHidden() const {
+ LLDB_INSTRUMENT_VA(this);
+
+ std::unique_lock lock;
+ ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
+
+ StackFrame *frame = exe_ctx.GetFramePtr();
+ if
@@ -123,8 +126,13 @@ class StackFrameRecognizerManager {
lldb::StackFrameRecognizerSP GetRecognizerForFrame(lldb::StackFrameSP frame);
lldb::RecognizedStackFrameSP RecognizeFrame(lldb::StackFrameSP frame);
+ /// This number changes whenever the list of recognizers has bee
@@ -38,13 +42,21 @@
ScriptedStackFrameRecognizer::RecognizeFrame(lldb::StackFrameSP frame) {
ValueObjectListSP args =
m_interpreter->GetRecognizedArguments(m_python_object_sp, frame);
auto args_synthesized = ValueObjectListSP(new ValueObjectList());
- for (const aut
@@ -518,33 +523,33 @@ class StackFrame : public ExecutionContextScope,
bool HasCachedData() const;
private:
- // For StackFrame only
+ /// For StackFrame only.
JDevlieghere wrote:
Since you're touching this comment...
https://github.com/llvm/llvm-projec
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Mostly nits.
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/104831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
@DavidSpickett nailed it.
PS: I'm around but I've been busy with other stuff. If people start to think
I'm on vacation I really gotta step it up again :D
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/105037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/104896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
I'm not a TS expert but functionally this is a great improvement. LGTM.
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
const path = vscode.workspace
.getConfiguration("lldb-dap", session.workspaceFolder)
.get("executable-path");
- if (path) {
-return new vscode.DebugAdapterExecutable(
@@ -54,7 +53,7 @@ RealpathPrefixes::ResolveSymlinks(const FileSpec &file_spec) {
LLDB_LOGF(log, "Realpath'ing support file %s", file_spec_path.c_str());
// One prefix matched. Try to realpath.
- llvm::SmallString buff;
+ llvm::SmallString<1024> buff;
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/102590
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -174,6 +177,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name,
+
@@ -174,6 +177,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name,
+
@@ -145,15 +148,34 @@ std::string CXXFunctionSummaryFormat::GetDescription() {
return std::string(sstr.GetString());
}
+std::string CXXFunctionSummaryFormat::GetName() {
+ return m_description;
+}
+
+std::string CXXFunctionSummaryFormat::GetSummaryKindName() {
+ return "c+
@@ -174,6 +177,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name,
+
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/103458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -144,16 +150,22 @@ static void ParseOSVersion(llvm::VersionTuple &version,
NSString *Key) {
#endif
} else {
// Find the bin path relative to the lib path where the cmake-based
-// OS X .dylib lives. This is not going to work if the bin and lib
-// dir are not
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/103458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/102488
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Thanks @royitaqi! Once the formatting is fixed this is ready to be merged.
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
JDevlieghere wrote:
I haven't had a chance to review this, but I would appreciate if we can keep in
mind how this might affect breaking up the platforms. Right now, the Platform
abstraction covers two concepts:
1. How you connect to a platform and do things like transfer files, list
processe
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/99362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/99362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler,
lang_opts.NoBuiltin = true;
}
-static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) {
+// NOTE: should be kept in sync with sdkSupportsBuiltinModules in
+// Toolchains/Darwin.cpp
+stat
https://github.com/JDevlieghere approved this pull request.
LGTM. Could we cover this scenario by the existing unit test?
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/JDevlieghere approved this pull request.
Makes sense.
https://github.com/llvm/llvm-project/pull/102161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -219,9 +219,9 @@ void ClangUserExpression::ScanContext(ExecutionContext
&exe_ctx, Status &err) {
// whatever runtime the debug info says the object pointer belongs to. Do
// that here.
-ClangASTMetadata *metadata =
-TypeSystemClang::DeclContextGetMetaD
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/102161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Matej =?utf-8?q?Košík?=
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/101981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM, this looks completely unused.
https://github.com/llvm/llvm-project/pull/101981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -0,0 +1,42 @@
+# REQUIRES: python
+# RUN: %lldb -s %s -o exit | FileCheck %s
+
+scripting template list
+# CHECK:Available scripted extension templates:
+
+# CHECK: Name: OperatingSystemPythonInterface
+# CHECK-NEXT: Language: Python
+# CHECK-NEXT: Description: Mock thread s
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-08-02T09:53:34-07:00
New Revision: c6ce324fa7fb2438b945fa1205b2a23138327e83
URL:
https://github.com/llvm/llvm-project/commit/c6ce324fa7fb2438b945fa1205b2a23138327e83
DIFF:
https://github.com/llvm/llvm-project/commit/c6ce324fa7fb2438b945fa1205b2a23138327e83.d
https://github.com/JDevlieghere approved this pull request.
LGTM if @medismailben is happy!
https://github.com/llvm/llvm-project/pull/101365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
@@ -2570,6 +2570,18 @@ void PruneThreadPlans();
/// information related to the process.
virtual StructuredData::DictionarySP GetMetadata() { return nullptr; }
+ /// Fetch extended crash information held by the process. This will never be
+ /// an empty shared pointe
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/101365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-07-31T18:06:32-07:00
New Revision: 5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704
URL:
https://github.com/llvm/llvm-project/commit/5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704
DIFF:
https://github.com/llvm/llvm-project/commit/5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704.d
JDevlieghere wrote:
> Thanks @JDevlieghere! Could you add this special case?
I'm happy to help but I wouldn't feel comfortable making such a change without
being able to reproduce and test it.
> The authoritatively established and supported way to link with `ncurses` on
> most Linux platfor
JDevlieghere wrote:
What I said was that, to the best of my knowledge, we don't have places in LLDB
that rely on `terminfo` but not on `ncruses`. I think that statement still
holds true. The assumption behind it was that `ncurses` provides a superset of
the functionality provided by `terminfo`
https://github.com/JDevlieghere approved this pull request.
This makes sense to me. LGTM if Jim is happy.
https://github.com/llvm/llvm-project/pull/101130
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/101208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/101243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> I was hoping to fix everything in one Pull Request so that it at least
> becomes usable once this merges.
The LLVM project generally
[prefers](https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity)
smaller patches as they're easier to review. We'll def
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/101208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/101208
>From 515525357026eb49508b1322b3b9ee40840f7b5e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 29 Jul 2024 16:32:45 -0700
Subject: [PATCH 1/2] [lldb] Unify the way we get the Target in CommandOb
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/101208
Currently, CommandObjects are obtaining a target in a variety of ways. Often
the command incorrectly operates on the selected target. As an example, when a
breakpoint command is running, the current target
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
This patch fixes the deserialization of the "address" field which surely can be
tested in isolation. The existing test (`TestObjectFileJSON.py`) has `address`
set to zero, which is why this happens to work today. It should be possible to
either update the test or add a new
JDevlieghere wrote:
The change itself looks good modulo formatting. Can you please update one of
the existing tests to cover this use case?
https://github.com/llvm/llvm-project/pull/101062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/100836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
Please don't use environment variables to pass options to the `make`
invocation. It makes it really hard to reproduce build failures because you
can't just copy-paste the failing invocation to debug the build. I went throug
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/100660
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/100660
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/100674
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t
byte_size) {
return llvm::APFloatBase::Bogus();
}
+std::optional
+TypeSystemClang::GetObjCBitSize(QualType qual_type,
+ExecutionContextScope *exe_scope) {
+ assert(qual_ty
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t
byte_size) {
return llvm::APFloatBase::Bogus();
}
+std::optional
+TypeSystemClang::GetObjCBitSize(QualType qual_type,
+ExecutionContextScope *exe_scope) {
+ assert(qual_ty
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t
byte_size) {
return llvm::APFloatBase::Bogus();
}
+std::optional
+TypeSystemClang::GetObjCBitSize(QualType qual_type,
+ExecutionContextScope *exe_scope) {
+ assert(qual_ty
101 - 200 of 1059 matches
Mail list logo
