jroelofs updated this revision to Diff 97842.
https://reviews.llvm.org/D32866
Files:
source/Core/CMakeLists.txt
source/Host/CMakeLists.txt
Index: source/Host/CMakeLists.txt
===
--- source/Host/CMakeLists.txt
+++
jroelofs planned changes to this revision.
jroelofs added a comment.
hmm. I'm getting more libpanel link issues in another build.
https://reviews.llvm.org/D32866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jroelofs created this revision.
Herald added a subscriber: mgorny.
There are two issues here. The first:
liblldbHost.a(Editline.cpp.o):(.debug_addr+0x238): undefined reference to
`el_get'
when linking InterpreterTests, is caused by -ledit coming after liblldbHost.a
in the link line.
The
jroelofs closed this revision.
jroelofs added a comment.
r297626
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jroelofs updated this revision to Diff 91566.
jroelofs added a comment.
It builds, so the code was dead anyway. Didn't re-run the tests.
https://reviews.llvm.org/D30844
Files:
include/lldb/Host/linux/HostThreadLinux.h
source/Host/linux/HostThreadLinux.cpp
Index:
jroelofs added a comment.
> If you want to get your build working, I suggest you just remove the setting
> code.
@labath I have my local build working, but I don't want to carry local patches
if possible. How about the original patch, which adds the glibc 2.12 check:
void
jroelofs added a comment.
In https://reviews.llvm.org/D30844#698294, @zturner wrote:
> The test suite is full of flakiness, but as long as it's the same before and
> after your change, it doesn't seem like anything is broken.
Results are pretty much the same, with 1 or 2 twinkling tests
jroelofs added a subscriber: labath.
jroelofs added a comment.
@labath thoughts?
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jroelofs updated this revision to Diff 91419.
jroelofs added a comment.
Herald added a subscriber: emaste.
Built successfully on linux (lots of tests fail, not sure if that's expected or
not?). I don't have a FreeBSD machine, but it looks "obviously" the same.
https://reviews.llvm.org/D30844
jroelofs added a comment.
erm, nevermind, I misread.
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jroelofs added a comment.
looks like lldb.xcodeproj refers to the files which I'll be deleting... do I
need to worry about that?
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jroelofs added a comment.
sure
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jroelofs added a comment.
Yeah, I'm on tip of trunk as of a few minutes ago.
`llvm::set_thread_name()` exists, but it doesn't take a thread parameter like
this one does (no idea if that's (still?) used or not in lldb).
https://reviews.llvm.org/D30844
jroelofs created this revision.
Herald added a subscriber: srhines.
Alternatively, I could teach llvm:set_thread_name() how to take a thread
parameter, and use that here instead.
https://reviews.llvm.org/D30844
Files:
source/Host/linux/HostThreadLinux.cpp
Index:
14 matches
Mail list logo
