[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd25fb4e90c96: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

jgorbe added a comment. See also https://github.com/llvm/llvm-project/issues/62684 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150470/new/ https://reviews.llvm.org/D150470 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

jgorbe created this revision. jgorbe added reviewers: ted, luporl, wallace. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. After https://reviews.llvm.org/D147831, lldb-vscode doesn't send a process event

[Lldb-commits] [PATCH] D150392: [lldb-vscode] Fix handling of RestartRequest arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b11034c672f: [lldb-vscode] Fix handling of RestartRequest arguments. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150392/new/ https:

[Lldb-commits] [PATCH] D150392: [lldb-vscode] Fix handling of RestartRequest arguments.

jgorbe updated this revision to Diff 521412. jgorbe added a comment. Added test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150392/new/ https://reviews.llvm.org/D150392 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py lldb/test/API/tools/lldb-vscode/re

[Lldb-commits] [PATCH] D150392: [lldb-vscode] Fix handling of RestartRequest arguments.

jgorbe created this revision. jgorbe added reviewers: clayborg, wallace, labath, rupprecht. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. According to the spec, RestartRequest has an optional "arguments

[Lldb-commits] [PATCH] D149774: [lldb] Use templates to simplify {Get, Set}PropertyAtIndex (NFC)

jgorbe added inline comments. Comment at: lldb/source/Target/Target.cpp:4520 const uint32_t idx = ePropertyMaxSummaryLength; - return m_collection_sp->GetPropertyAtIndexAsSInt64(idx).value_or( - g_target_properties[idx].default_uint_value); + return GetPropertyAtIndexAs

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b6c5bb995be: [lldb-vscode] Implement RestartRequest (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D147831?vs=512305&id=518866#toc Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:152 bool is_attach; + // The process event thread normally responds to process exited events by + // shutting down the entire adapter. When we're restarting, we keep the id of labath w

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe added a comment. Landed again, with a fix for the test that was failing on Darwin, as https://github.com/llvm/llvm-project/commit/d69518b4e52d527b3f8fcc41e90ae21f1f234555. I'll keep an eye on the build bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe added a comment. Sure, I'll revert. Thanks for notifying me of the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148662/new/ https://reviews.llvm.org/D148662 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd366da97bd24: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters. (authored by jgorbe). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe updated this revision to Diff 518540. jgorbe added a comment. Addressed review comments: - Check pair values before attempting to call `GetChildMemberWithName` on them - Rename first child from `__value_` to `pointer`. This is friendlier and also matches the name used by the libstdcxx uni

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148662/new/ https://reviews.llvm.org/D148662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147831/new/ https://reviews.llvm.org/D147831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe created this revision. jgorbe added reviewers: shafik, kastiglione. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The unique_ptr prettyprinter calls `GetValueOfLibCXXCompressedPair`, which looks

[Lldb-commits] [PATCH] D148582: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c91d016349a: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb. (authored by jgorbe). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D148582: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb.

jgorbe created this revision. jgorbe added reviewers: Michael137, dblaikie, aprantl. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The functionality added by https://reviews.llvm.org/D145803 is gated by

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe marked 2 inline comments as done. jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:146 + // arguments if we get a RestartRequest. + llvm::json::Object last_launch_or_attach_request; lldb::tid_t focus_tid; rupprecht wrote: > st

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe updated this revision to Diff 512305. jgorbe added a comment. Addressed review comments. - Changed `last_launch_or_attach_request` to be a `std::optional` so we can check if it has been set. Also check for `nullopt` in request_restart. - Made `request_attach` also set `last_launch_or_att

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53aa22cd9ac4: [lldb-vscode] Fix two issues with runInTerminal test. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147805/new/ https://

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:1120 debug_adaptor_path.str(), "--comm-file", comm_file.str(), + "--debugger-pid", std::to_string(debugger_pid), "--launch-target", GetString(launch_request_arguments, "program").str

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

jgorbe updated this revision to Diff 512272. jgorbe marked 3 inline comments as done. jgorbe added a comment. Addressed review comments. - Use `lldb::pid_t` instead of unsigned long, and `LLDB_INVALID_PROCESS_ID` instead of `0` in the cases where the PID is missing. - Only pass the `--debugger-p

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe created this revision. jgorbe added reviewers: clayborg, wallace, labath, rupprecht. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This is an optional request, but supporting it makes the experie

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

jgorbe updated this revision to Diff 511818. jgorbe added a comment. Added a `--debugger-pid` flag that needs to be passed with `--launch-target` so that we can restrict `PR_SET_PTRACER` to the main lldb-vscode instance instead of using `PR_SET_PTRACER_ANY`. CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

jgorbe created this revision. jgorbe added reviewers: clayborg, wallace. jgorbe added a project: LLDB. Herald added subscribers: JDevlieghere, krytarowski. Herald added a project: All. jgorbe requested review of this revision. With ptrace_scope = 1 the kernel only allows tracing descendants of a p

[Lldb-commits] [PATCH] D147006: [lldb] Fix value printing for a specific case

jgorbe accepted this revision. jgorbe added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147006/new/ https://reviews.llvm.org/D147006

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

jgorbe added a comment. In D147007#4225762 , @JDevlieghere wrote: > LGTM. I think it would be worth adding that information to the top of the > file to prevent similar mistakes in the future. Good idea, thanks. I added a note at the top before committi

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a38d3326895: [lldb] Fix double free in python bindings error handling. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D147007?vs=508811&id=508827#toc Repository: rG LLVM Git

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

jgorbe added a comment. In D146590#4225500 , @bulbazord wrote: > Yea, after reading the SWIG documentation, this diagnosis looks correct. If > you'd like to fix this feel free to upload a patch and list myself and @mib > as reviewers. Otherwise let me k

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

jgorbe created this revision. jgorbe added reviewers: bulbazord, mib, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. If we have a `%typemap(freearg)` that frees the argument, we shouldn't free it

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

jgorbe added a comment. I just noticed a minor aesthetic problem with the input of `dwim-print` when using data formatters. There are some spacing adjustments in this commit but I'm not sure if they are the actual cause (please let me know if you'd prefer me to file a bug instead). You can rep

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

jgorbe added a comment. I found the actual reason for the crash I was talking about. This patch only addressed the incorrect `OverflowError`, but the crash comes from a double free (as @rupprecht mentioned) in the error handling logic. The error path here

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

jgorbe added a comment. I've tried building lldb with this patch applied and it fixes the problem I saw. Thanks for the quick fix! I'm not very familiar with the code so I'd appreciate if someone else gives their LGTM too but the changes look reasonable to me (just one small nit I've mentioned

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

jgorbe added a comment. By the way, I just bisected another problem to this commit: I'm seeing in some cases that prettyprinted values with synthetic children don't show child names when using `dwim-print`. So print used to show: (lldb) p c (MyClass) $0 = MyClass object with children: {

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

jgorbe added a comment. > Are you using persistent results? If not, how much effort is it to either 1) > change the tools/code that examine the output to not look for $\d+, or 2) use > a custom print/p alias? Honest question. I'm not using them myself, and it's not much effort to fix the proble

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

jgorbe added a comment. What was the rationale for this change? It changes the output format of a common command (given that `print` is now an alias for `dwim-print`) and it breaks basically anything that examines debugger output. Also `--persistent-result on` can't be passed to `print`, it onl

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG984354fbbe4e: [lldb] Update some uses of Python2 API in typemaps. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

jgorbe updated this revision to Diff 507442. jgorbe added a comment. Modified one of the existing test cases for `SBData.SetDataFromUInt64Array` to add a 2**63 to actually exercise the uint64 range. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146590/new/ https://reviews.llvm.org/D146

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

jgorbe created this revision. jgorbe added reviewers: labath, rupprecht. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. Python 3 doesn't have a distinction between PyInt and PyLong, it's all PyLong now.

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

This revision was automatically updated to reflect the committed changes. jgorbe marked an inline comment as done. Closed by commit rG805600c7d573: [lldb] Make SBSection::GetSectionData call Section::GetSectionData. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

jgorbe marked an inline comment as done. jgorbe added inline comments. Comment at: lldb/source/API/SBSection.cpp:187-189 +DataExtractorSP result_data_sp = +std::make_shared(section_data, offset, size); +sb_data.SetOpaque(result_data_sp); dblaikie

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

jgorbe updated this revision to Diff 492602. jgorbe added a comment. Addressing review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142672/new/ https://reviews.llvm.org/D142672 Files: lldb/source/API/SBSection.cpp lldb/test/API/python_api/section/TestSectionAPI.py lldb/

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

jgorbe created this revision. jgorbe added a reviewer: labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. `SBSection::GetSectionData` and `Section::GetSectionData` are implemented differently, and th

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG868186cf6cb7: [lldb] Make callback-based formatter matching available from the CLI. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe updated this revision to Diff 474573. jgorbe added a comment. - Clarified help text for `--recognizer-function` as suggested by reviewer. Instead of "Incompatible with --regex (-x)." now it says "Cannot be specified at the same time as --regex (-x)." - Rebased on top of current HEAD. CH

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. In D137000#3915943 , @jingham wrote: > It is a bit odd to follow the what the help summary says is a valid option > set and then get an error. But this is a corner case, and since you say > explicitly that you can't provide bot

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. @jingham any comments on https://reviews.llvm.org/D137000#3897162? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137000/new/ https://reviews.llvm.org/D137000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe updated this revision to Diff 472185. jgorbe added a comment. - Removed `-R` short option to avoid confusion with regex. Updated doc, test case, and example. - Added some logic to make `--recognizer-function` and `--regex` mutually exclusive. Specifying both now results in an error being

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. I'm looking at the option of using a non-printable character for the short flag, and at the same time make `--regex` and `--recognizer-function` mutually exclusive using option groups. One problem I see is that the command help gets pretty confusing. Using a non-printabl

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. > You can't provide the --regex option and this matcher at the same time Thanks for spotting this. I'll get to it. > it is also an error to have both this matcher function and any arguments in > the argument list Not with the code as it is. I've made the new flag have s

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This change adds a `--recognizer-function` (`-R`) to `type summary add` and `type syn

[Lldb-commits] [PATCH] D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4d25c42a68: [lldb-vscode] Don't call SBValue.GetError after generating a summary. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13689

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:136-156 llvm::StringRef value = v.GetValue(); llvm::StringRef summary = v.GetSummary(); llvm::StringRef type_name = v.GetType().GetDisplayTypeName(); + lldb::SBError error = v.GetError();

[Lldb-commits] [PATCH] D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary.

jgorbe created this revision. jgorbe added reviewers: yinghuitan, clayborg. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. In some occasions, SBValue::GetError can invalidate its cached `m_summary_str` m

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

jgorbe added a comment. Hi! I've just debugged an issue that brought me to this commit. I'll start preparing a patch tomorrow (not sure how to test it yet) but since it's a recent-ish change I figured I'd ping the commit thread to give you a heads up. `v.GetSummary()` returns a char* that is ba

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

This revision was automatically updated to reflect the committed changes. jgorbe marked 2 inline comments as done. Closed by commit rGd76566417e59: [lldb] Add matching based on Python callbacks for data formatters. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe marked 2 inline comments as done. jgorbe added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2306 if (type == eRegularSynth) { -if (category->AnyMatches(type_name, eFormatCategoryItemFilter, false)) { +// TODO: Get a suitable type objec

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe updated this revision to Diff 467987. jgorbe added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135648/new/ https://reviews.llvm.org/D135648 Files: lldb/bindings/python/python-swigsafecast.swig lldb/bindings/python/python-wrapper.swig l

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This patch adds a new matching method for data formatters, in addition to the existin

[Lldb-commits] [PATCH] D135399: [NFCI] More TypeCategoryImpl refactoring.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5fd507f9b6f: [NFCI] More TypeCategoryImpl refactoring. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135399/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D135399: [NFCI] More TypeCategoryImpl refactoring.

jgorbe created this revision. jgorbe added reviewers: labath, jingham. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The main aim of this patch is to delete the remaining instances of code reaching into

[Lldb-commits] [PATCH] D134570: [lldb] Skip check for conflicting filter/synth when adding a new regex.

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c661a65ff8: [lldb] Skip check for conflicting filter/synth when adding a new regex. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdee9c7f5d7e5: [NFCI] Simplify TypeCategoryImpl for-each callbacks. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D134771?vs=463624&id=465824#toc Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

jgorbe added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134771/new/ https://reviews.llvm.org/D134771 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D134570: [lldb] Skip check for conflicting filter/synth when adding a new regex.

jgorbe added a comment. Ping? If anyone has other suggestions for reviewers I'd appreciate them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134570/new/ https://reviews.llvm.org/D134570 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

jgorbe marked an inline comment as done. jgorbe added inline comments. Comment at: lldb/include/lldb/DataFormatters/TypeCategory.h:136 + void ForEach(std::function)> + callback) { labath wrote: > did you want to add a reference here? A const by

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

jgorbe updated this revision to Diff 463624. jgorbe added a comment. Fixed callback argument type (from `const std::shared_ptr` to `const std::shared_ptr &`) as suggested by reviewer. Also use a range-based for loop to loop over subcontainers in `TieredFormattercontainer::ForEach`. CHANGES SI

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The callback system to iterate over every formatter of a given kind in a TypeCategory

[Lldb-commits] [PATCH] D134768: [NFCI] More TypeCategoryImpl refactoring.

jgorbe abandoned this revision. jgorbe added a comment. whoops, I need to commit some other local change before this one. I'm going to abandon this revision and I'll re-send this patch when its dependency lands. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D134768: [NFCI] More TypeCategoryImpl refactoring.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The main aim of this patch is deleting the remaining instances of code reaching into

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jgorbe marked 3 inline comments as done. Closed by commit rG1f2a21820dfa: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer. (authored by jgorbe). R

[Lldb-commits] [PATCH] D134570: [lldb] Skip check for conflicting filter/synth when adding a new regex.

jgorbe updated this revision to Diff 462637. jgorbe added a comment. Added a couple of test cases to TestDataFormatterPythonSynth.py. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134570/new/ https://reviews.llvm.org/D134570 Files: lldb/source/Commands/CommandObjectType.cpp lldb/t

[Lldb-commits] [PATCH] D134570: [lldb] Skip check for conflicting filter/synth when adding a new regex.

jgorbe created this revision. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. When adding a new synthetic child provider, we check for an existing conflicting filter in the same category (and vice versa).

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

jgorbe marked 3 inline comments as done. jgorbe added a comment. Thanks for the review! Please take another look. Comment at: lldb/include/lldb/DataFormatters/TypeCategory.h:76 +uint32_t result = 0; +for (auto sc : m_subcontainers) { + result += sc->GetCount(); ---

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

jgorbe updated this revision to Diff 461775. jgorbe added a comment. Address review feedback: - Removed asserts on `GetXXXAtIndex` methods when the index is out of range. Return a default-initialized shared_ptr of the right type instead (which will result in an invalid value when returned back

[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

jgorbe marked an inline comment as done. jgorbe added inline comments. Comment at: lldb/include/lldb/lldb-private-enumerations.h:131-134 eFormatCategoryItemSummary = 0x0001, - eFormatCategoryItemRegexSummary = 0x0002, eFormatCategoryItemFilter = 0x0004, - eFormatCategoryI

[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdce688733600: [NFCI] Clean up enum FormatCategoryItem. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D134244?vs=461418&id=461613#toc Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

jgorbe created this revision. jgorbe added reviewers: labath, rupprecht, jingham. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. - Merge pairs like `eFormatCategoryItemSummary` and `eFormatCategoryIte

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

jgorbe created this revision. jgorbe added reviewers: labath, jingham. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. `FormatterContainerPair` is (as its name indicates) a very thin wrapper over two form

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef3fa232b338: [Formatters][NFCI] Replace 'is_regex' arguments with an enum. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe updated this revision to Diff 459845. jgorbe added a comment. Replaced `kNumFormatterMatchTypes` with `eLastFormatterMatchType` to avoid "unhandled enum value" warnings, as suggested by Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133240/new/ https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:841 + + kNumFormatterMatchTypes, +}; labath wrote: > I see the enums in this file use wildly inconsistent styles for the "largest > value" enumerator. However, you've picked the one

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe updated this revision to Diff 459618. jgorbe added a comment. Fixed mis-spelled member name in comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133240/new/ https://reviews.llvm.org/D133240 Files: lldb/bindings/interface/SBTypeNameSpecifier.i lldb/include/lldb/API/SBTyp

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe marked an inline comment as done. jgorbe added inline comments. Comment at: lldb/include/lldb/DataFormatters/FormattersContainer.h:46 /// just matching by comparing with m_type_name string. - bool m_is_regex; + lldb::FormatterMatchType m_match_type;

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe updated this revision to Diff 459610. jgorbe added a comment. Updated comment above the declaration of TypeMatcher::m_match_type that referred to the old m_is_regex boolean, to address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133240/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe added a comment. This is the first step towards something like this big diff: https://reviews.llvm.org/differential/diff/457740/. It's a pretty simple patch, but I would like some feedback about whether you think it's going in the right direction or I should do something else instead. H

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. Modify `SBTypeNameSpecifier` and `lldb_private::TypeMatcher` so they have an enum val

[Lldb-commits] [PATCH] D133230: [NFCI] Remove duplicate code in SBTypeCategory

jgorbe created this revision. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. TypeCategoryImpl has its own implementation of these, so it makes no sense to have the same logic inlined in SBTypeCategory.

[Lldb-commits] [PATCH] D131459: Move FormattersMatchCandidate flags to a struct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe01292457fc: Move FormattersMatchCandidate flags to a struct. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D131459?vs=

[Lldb-commits] [PATCH] D131459: Move FormattersMatchCandidate flags to a struct.

jgorbe created this revision. Herald added a project: All. jgorbe requested review of this revision. Herald added a project: LLDB. Move FormattersMatchCandidate flags to a struct. This removes some error-prone repetition in FormatManager::GetPossibleMatches, where the same three boolean flags are

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa3a2e611d84: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

jgorbe added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:1064 +// No regex means list everything. +return (regex == nullptr || (s == regex->GetText() || regex->Execute(s))); + } labath wrote: > What's up with all the parenthes

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

jgorbe updated this revision to Diff 446532. jgorbe added a comment. Removed unnecessary parentheses. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130219/new/ https://reviews.llvm.org/D130219 Files: lldb/source/Commands/CommandObjectType.cpp Index: lldb/source/Commands/CommandObjec

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

jgorbe created this revision. jgorbe added a reviewer: labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. Extract a bit of copy/pasted regex filtering logic into a separate function and simplify it

[Lldb-commits] [PATCH] D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.

jgorbe added a comment. I've been experimenting a little bit and it seems that I can avoid the deadlocks I was seeing by applying only the modification to `TypeCategoryMap::Add`. This would avoid the problem that @hawkinsw pointed out in my change to `FormatManager::GetCategoryForLanguage`. How

[Lldb-commits] [PATCH] D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.

jgorbe added inline comments. Comment at: lldb/source/DataFormatters/FormatManager.cpp:595 + { +std::lock_guard guard(m_language_categories_mutex); +m_language_categories_map[lang_type] = hawkinsw wrote: > Forgive me if I am speaking out of turn, but do

[Lldb-commits] [PATCH] D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.

jgorbe created this revision. jgorbe added reviewers: labath, JDevlieghere. Herald added a subscriber: pengfei. Herald added a project: All. jgorbe requested review of this revision. Herald added a project: LLDB. I've noticed (what looked like) deadlocking behavior while running some Python code t

[Lldb-commits] [PATCH] D126103: Remove `friend` classes from TypeCategoryMap

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0a61c2ce2af: Remove `friend` classes from TypeCategoryMap (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126103/new/ https://reviews.l

[Lldb-commits] [PATCH] D126103: Remove `friend` classes from TypeCategoryMap

jgorbe created this revision. jgorbe added reviewers: labath, JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. Herald added a project: LLDB. As far as I can tell, the only thing those `friend` classes access is the `ValueSP` typedef. Given that this is a map-is

  1   2   >