Re: [Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

krytarowski added a comment. Thanks! Repository: rL LLVM http://reviews.llvm.org/D15374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r255308 - Add NetBSD support in the buildDriver and buildLibrary routines

Author: kamil Date: Thu Dec 10 16:56:56 2015 New Revision: 255308 URL: http://llvm.org/viewvc/llvm-project?rev=255308=rev Log: Add NetBSD support in the buildDriver and buildLibrary routines Summary: NetBSD is like FreeBSD and Linux in these routines. Reviewers: clay.chang, tfiala, emaste,

[Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

krytarowski created this revision. krytarowski added reviewers: emaste, joerg, clay.chang, tfiala. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Herald added a subscriber: emaste. NetBSD is like FreeBSD and Linux in these routines.

Re: [Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

krytarowski updated this revision to Diff 42372. krytarowski added a comment. Strip zero character from platform name Repository: rL LLVM http://reviews.llvm.org/D15374 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [lldb] r254947 - Return gmake as the default name for GNU make on NetBSD

Author: kamil Date: Mon Dec 7 15:24:25 2015 New Revision: 254947 URL: http://llvm.org/viewvc/llvm-project?rev=254947=rev Log: Return gmake as the default name for GNU make on NetBSD Summary: The base make(1) on NetBSD is BSD make. In the default installation of NetBSD GNU make comes via pkgsrc

[Lldb-commits] [lldb] r254948 - Add initial NetBSD support in lldbsuite/test/lldbtest.py

Author: kamil Date: Mon Dec 7 15:25:57 2015 New Revision: 254948 URL: http://llvm.org/viewvc/llvm-project?rev=254948=rev Log: Add initial NetBSD support in lldbsuite/test/lldbtest.py Summary: Add new functions: - expectedFailureNetBSD() - expectedFlakeyNetBSD() - skipIfNetBSD() Add new

[Lldb-commits] [lldb] r254949 - Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase()

Author: kamil Date: Mon Dec 7 15:26:56 2015 New Revision: 254949 URL: http://llvm.org/viewvc/llvm-project?rev=254949=rev Log: Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase() Summary: NetBSD soon will reuse this feature while running tests.

Re: [Lldb-commits] [PATCH] D15261: Return gmake as the default name for GNU make on NetBSD

krytarowski added a comment. Thank you! Repository: rL LLVM http://reviews.llvm.org/D15261 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15263: Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase()

krytarowski added a comment. Thank you! Repository: rL LLVM http://reviews.llvm.org/D15263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

krytarowski added a comment. Thank you! Repository: rL LLVM http://reviews.llvm.org/D15262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

krytarowski updated the summary for this revision. krytarowski updated this revision to Diff 42013. Repository: rL LLVM http://reviews.llvm.org/D15262 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

krytarowski updated this revision to Diff 42014. Repository: rL LLVM http://reviews.llvm.org/D15262 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py === ---

[Lldb-commits] [PATCH] D15260: getwd(3) with NULL pointer extension is supported on NetBSD

krytarowski created this revision. krytarowski added reviewers: emaste, tfiala, clayborg. krytarowski added subscribers: joerg, lldb-commits. krytarowski set the repository for this revision to rL LLVM. The getwd() and getcwd() functions conform to IEEE Std 1003.1-1990 (``POSIX.1''). The IEEE

[Lldb-commits] [PATCH] D15261: Return gmake as the default name for GNU make on NetBSD

krytarowski created this revision. krytarowski added reviewers: emaste, clayborg, tfiala. krytarowski added subscribers: lldb-commits, joerg. krytarowski set the repository for this revision to rL LLVM. The base make(1) on NetBSD is BSD make. In the default installation of NetBSD GNU make comes

[Lldb-commits] [PATCH] D15263: Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase()

krytarowski created this revision. krytarowski added reviewers: clayborg, emaste, tfiala. krytarowski added subscribers: joerg, lldb-commits. krytarowski set the repository for this revision to rL LLVM. NetBSD soon will reuse this featur while running tests. Repository: rL LLVM

[Lldb-commits] [lldb] r254853 - Define new builder_netbsd

Author: kamil Date: Sat Dec 5 12:46:56 2015 New Revision: 254853 URL: http://llvm.org/viewvc/llvm-project?rev=254853=rev Log: Define new builder_netbsd Summary: This is used in tests. Reviewers: emaste, tfiala, clayborg Subscribers: zturner, lldb-commits, joerg Differential Revision:

[Lldb-commits] [lldb] r254858 - Document NetBSD platform support on the webpage

Author: kamil Date: Sat Dec 5 13:41:37 2015 New Revision: 254858 URL: http://llvm.org/viewvc/llvm-project?rev=254858=rev Log: Document NetBSD platform support on the webpage Summary: It's high time. Reviewers: emaste, clayborg Subscribers: labath, joerg, lldb-commits Differential Revision:

[Lldb-commits] [lldb] r254768 - Fix typo in a comment

Author: kamil Date: Fri Dec 4 15:23:24 2015 New Revision: 254768 URL: http://llvm.org/viewvc/llvm-project?rev=254768=rev Log: Fix typo in a comment Modified: lldb/trunk/source/Core/IOHandler.cpp Modified: lldb/trunk/source/Core/IOHandler.cpp URL:

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

krytarowski added a comment. In http://reviews.llvm.org/D15067#298701, @Eugene.Zelenko wrote: > I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use > llvm-config from build directory. I'm not sure how well find_program will > work if path to /bin will be not added to PATH, so

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

krytarowski added a comment. In http://reviews.llvm.org/D15065#298279, @zturner wrote: > This doesn't look substantially different than builder_freebsd. Assuming > there is no practical difference, how about just using that for both > freebsd and netbsd? The linux2, win32 and freebsd

[Lldb-commits] [PATCH] D15065: Define new builder_netbsd

krytarowski created this revision. krytarowski added reviewers: emaste, tfiala. krytarowski added subscribers: joerg, lldb-commits. krytarowski set the repository for this revision to rL LLVM. This is used in tests. Repository: rL LLVM http://reviews.llvm.org/D15065 Files:

[Lldb-commits] [PATCH] D15066: Plug-in PlatformNetBSD initializer and terminator

krytarowski created this revision. krytarowski added reviewers: clayborg, emaste. krytarowski added subscribers: joerg, lldb-commits. krytarowski set the repository for this revision to rL LLVM. Other platform parts needed to build this code are already merged. 2nd attempt. Repository: rL

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

krytarowski added a comment. @labath feel free to disagree with the regex files. It was copied from LLVM. If you disagree, help me please to export it in LLVM build for everybody or find a better solution. pkgsrc-wip commit affirming that it works:

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

krytarowski updated this revision to Diff 41366. krytarowski added a comment. Upload the proper latest patch. Repository: rL LLVM http://reviews.llvm.org/D15067 Files: cmake/modules/LLDBStandalone.cmake scripts/CMakeLists.txt source/Utility/CMakeLists.txt tools/lldb-mi/MIUtilParse.h

Re: [Lldb-commits] [PATCH] D14904: Document NetBSD platform support on the webpage

krytarowski removed rL LLVM as the repository for this revision. krytarowski updated this revision to Diff 41102. krytarowski added a comment. Readd accidently removed section. http://reviews.llvm.org/D14904 Files: www/build.html www/download.html www/index.html www/status.html

Re: [Lldb-commits] [PATCH] Define new builder_netbsd

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 For the reference, there was availability outage during this weekend on reviews.llvm.org. I was suggested to send a patch to this mailing list as a fall-back. Please review and merge with the LLDB sources. On 22.11.2015 17:23, Kamil Rytarowski via

[Lldb-commits] [PATCH] D14904: Document NetBSD platform support on the webpage

krytarowski created this revision. krytarowski added reviewers: clayborg, emaste. krytarowski added subscribers: lldb-commits, joerg. krytarowski set the repository for this revision to rL LLVM. It's high time. Repository: rL LLVM http://reviews.llvm.org/D14904 Files: www/build.html

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

krytarowski added a comment. In http://reviews.llvm.org/D14844#293692, @labath wrote: > If anyone hasn't found the link yet. it's > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. > There is no mailing list but you can monitor the webpage containing all >

[Lldb-commits] [PATCH] D14876: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

krytarowski created this revision. krytarowski added reviewers: clayborg, emaste. krytarowski added subscribers: joerg, lldb-commits, sivachandra, tberghammer. krytarowski set the repository for this revision to rL LLVM. This should push forward integration of the NetBSD code with others. This

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

krytarowski added a comment. In http://reviews.llvm.org/D14844#293787, @tberghammer wrote: > The problem is that in PlatformNetBSD::Initialize you call > Platform::SetHostPlatform unconditionally. You want to > call Platform::SetHostPlatform only if we are running on NetBSD so you have > to

Re: [Lldb-commits] [PATCH] D14876: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

krytarowski added a comment. Thank you, please land http://reviews.llvm.org/D14530 again. Repository: rL LLVM http://reviews.llvm.org/D14876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

krytarowski added a comment. Could you please reference a hyperlink to the breakage? Have we got some mailing list to monitor it? Jumping over logs in waterfall isn't much convenient. Repository: rL LLVM http://reviews.llvm.org/D14844 ___

Re: [Lldb-commits] [PATCH] D14530: Plug-in PlatformNetBSD initializer and terminator

krytarowski added a comment. Are we ready to land it? Without this patch I cannot launch lldb. Repository: rL LLVM http://reviews.llvm.org/D14530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

krytarowski added a comment. I would reject this patch. http://reviews.llvm.org/D14790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

krytarowski added a comment. I dislike delegating jobs (or hiding problems) of CMake (assuming that autoconf/gmake is already dead) to external scripts like Python ones. In the goal, I plan to add LLDB in the NetBSD base (next to LLVM and Clang) where there is no Python at all. In FreeBSD

Re: [Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

krytarowski added a comment. Sure, I'm just giving general feedback. From a user perspective I want to get yes/no information whether I need swig or not, if so what version. If we allow Python, I don't see any reason to not allowing swig. if some version gives you problems (license, bad code

Re: [Lldb-commits] [PATCH] D14740: Define LLDB_DISABLE_CURSES as a fallback for missing curses(3) or panel(3)

krytarowski abandoned this revision. krytarowski added a comment. I resign from this change. I will just go for -DLLDB_DISABLE_CURSES from command line on NetBSD-7.0. Repository: rL LLVM http://reviews.llvm.org/D14740 ___ lldb-commits mailing

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hello Ying, Regarding the NetBSD buildbot for LLDB one NetBSD we need a tweak. Please test for the existence (only on NetBSD) of a file /usr/include/panel.h. If it's missing please add '-DLLDB_DISABLE_CURSES' to CMake configure arguments. if [ !

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 It's fixed. It was my fault as I forgot to make updateScripts.sh available via PATH. Buildslave works properly. Thank you! On 18.11.2015 03:31, Kamil Rytarowski via lldb-commits wrote: > I've noted the first set of successfully built L

Re: [Lldb-commits] [PATCH] D14689: Embed libpanel(3) for NetBSD-7.0

krytarowski abandoned this revision. krytarowski added a comment. I will go with other way around. If curses(3) or libpanel(3) is missing, disable the curses(3) option for LLDB. Repository: rL LLVM http://reviews.llvm.org/D14689 ___

[Lldb-commits] [PATCH] D14740: Define LLDB_DISABLE_CURSES as a fallback for missing curses(3) or panel(3)

krytarowski created this revision. krytarowski added reviewers: clayborg, emaste. krytarowski added subscribers: lldb-commits, joerg, brucem. krytarowski set the repository for this revision to rL LLVM. This enables build on NetBSD-7.0. It would be nice to have a fall-back for externally provided

[Lldb-commits] [PATCH] D14531: Add more autotools/gmake NetBSD glue

krytarowski created this revision. krytarowski added subscribers: lldb-commits, brucem, joerg. krytarowski set the repository for this revision to rL LLVM. This diff approaches building the project natively on NetBSD with the autoconf/gmake framework. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14531: Add more autotools/gmake NetBSD glue

krytarowski added a comment. In http://reviews.llvm.org/D14531#285997, @tberghammer wrote: > I have no objection against this change but considering that LLVM plans to > remove the autotools/gmake support after branching the 3.8 release (most > likely in January 2016) it would be good if you

[Lldb-commits] [PATCH] D14528: Allow to override python-config executable name from command line

krytarowski created this revision. krytarowski added subscribers: joerg, lldb-commits, brucem. krytarowski set the repository for this revision to rL LLVM. pkgsrc (on NetBSD) ships with python2.7-config. Repository: rL LLVM http://reviews.llvm.org/D14528 Files: Makefile lib/Makefile

[Lldb-commits] [PATCH] D14529: Use library discovery for curses and panel

krytarowski created this revision. krytarowski added subscribers: lldb-commits, joerg, brucem. krytarowski set the repository for this revision to rL LLVM. This approach is tunable with custom paths for curses library. It also detects whether there are requirements met. I make use of it on

Re: [Lldb-commits] [PATCH] D14037: Reuse native curses(8) library on NetBSD

krytarowski updated this revision to Diff 39440. krytarowski added a comment. Rebase to master Repository: rL LLVM http://reviews.llvm.org/D14037 Files: source/Core/IOHandler.cpp Index: source/Core/IOHandler.cpp === ---

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

krytarowski added a subscriber: krytarowski. Comment at: tools/lldb/source/Host/common/File.cpp:301 @@ -299,1 +300,3 @@ + +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23) if (options & eOpenOptionCloseOnExec) labath wrote: > This needs to evaluate to

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

krytarowski added inline comments. Comment at: tools/lldb/source/Host/posix/PipePosix.cpp:43 @@ -40,3 +42,3 @@ // TODO: Add more platforms that support pipe2. -#if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) || defined(__NetBSD__) +#if (defined(__linux__)

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

krytarowski added inline comments. Comment at: tools/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:72 @@ -71,1 +71,3 @@ +// Missing defines due to bug: https://sourceware.org/bugzilla/show_bug.cgi?id=4125 + brucem wrote: > This bug was fixed in

Re: [Lldb-commits] [PATCH] D14037: Reuse native curses(8) library on NetBSD

krytarowski added a comment. I have successfully compiled this patch on FreeBSD. $ uname -a FreeBSD 10.1-RELEASE-p19 FreeBSD 10.1-RELEASE-p19 #0: Sat Aug 22 03:55:09 UTC 2015 r...@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

krytarowski added a comment. I have successfully compiled this patch on FreeBSD. $ uname -a FreeBSD 10.1-RELEASE-p19 FreeBSD 10.1-RELEASE-p19 #0: Sat Aug 22 03:55:09 UTC 2015 r...@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

krytarowski added a subscriber: brucem. krytarowski added a comment. +brucem, committer of the previous NetBSD glue Repository: rL LLVM http://reviews.llvm.org/D14042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14037: Reuse native curses(8) library on NetBSD

krytarowski added a subscriber: brucem. krytarowski added a comment. Bruce was involved in the older version with `config.h`. Repository: rL LLVM http://reviews.llvm.org/D14037 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

krytarowski abandoned this revision. krytarowski added a comment. Closing. We are going for reuse of the NetBSD native curses(8) library. The reason for it is limit of detecting ncurses on various systems. For example, Ubuntu ships with `` and linkage from ``, `ncurses.h` isn't detected by

Re: [Lldb-commits] [PATCH] D12995: Add support for lldb config.h and detect ncurses' include path

krytarowski abandoned this revision. krytarowski added a comment. Closing. We are going for reuse of the NetBSD native curses(8) library. The reason for it is limit of detecting ncurses on various systems. For example, Ubuntu ships with `` and linkage from ``, `ncurses.h` isn't detected by

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 21.10.2015 02:03, Ying Chen wrote: > > > On Tue, Oct 20, 2015 at 4:46 PM, Kamil Rytarowski > wrote: > > It just appeared there. > > I took your updateScripts.sh, moved it to my $PATH. Is it > everything?

Re: [Lldb-commits] New llvm build server account request

all NetBSD locally and adapt the scripts for this system. Ping-pong overmails can take another 2 weeks. On 21.10.2015 02:05, Kamil Rytarowski via lldb-commits wrote: > On 21.10.2015 02:03, Ying Chen wrote: > > >> On Tue, Oct 20, 2015 at 4:46 PM, Kamil Rytarowski <n...@gmx.com

Re: [Lldb-commits] New llvm build server account request

OS=linux;; Darwin) OS=darwin;; > *_NT-*) OS=windows;; esac > > There is need for NetBSD) OS=netbsd;; and new file > build-netbsd.sh. > > This is why, I suggested you to install NetBSD locally and adapt > the scripts for this system. Ping-pong overmails can take another 2 >

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 It just appeared there. I took your updateScripts.sh, moved it to my $PATH. Is it everything? Will the rest of the scripts from https://android.googlesource.com/platform/external/lldb-utils/+/lldb-mas ter-dev/buildbotScripts/bashShell/svntotbuild/

Re: [Lldb-commits] New llvm build server account request

bin/bash' to /usr/bin/env bash' it will be more portable and I will drop my /bin/bash linkage. Thank you in advance, On 21.10.2015 03:23, Kamil Rytarowski via lldb-commits wrote: > My $CC/$CXX is GCC 4.8.5. > > I have good reason for it - to not intermix system-wide and > fetched h

Re: [Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

krytarowski added a comment. There is already preliminary NetBSD support merged with trunk, I need this commit (or altered version of it) to build lldb against ncurses on this platform. Thank you for your time. Repository: rL LLVM http://reviews.llvm.org/D12994

Re: [Lldb-commits] [PATCH] D13707: Remove definition of ~PlatformNetBSD(), since its declaration is marked as '= default'

krytarowski added a comment. Thank you! Repository: rL LLVM http://reviews.llvm.org/D13707 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13711: Add initial CMake glue for the NetBSD platform

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. These changes aren't everything what is needed for the CMake target, but it's significantly approaching it. These

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski updated this revision to Diff 37077. Repository: rL LLVM http://reviews.llvm.org/D13334 Files: include/lldb/Host/Config.h include/lldb/Host/HostInfo.h include/lldb/Host/HostNativeThread.h include/lldb/Host/HostNativeThreadForward.h include/lldb/Host/netbsd/Config.h

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski added a comment. Primary reason to skip for now build scripts is that this patch takes long to be landed. http://reviews.llvm.org/D12994 I don't want to submit a diff to patches sources... Repository: rL LLVM http://reviews.llvm.org/D13334

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// labath wrote: > krytarowski wrote: > > labath wrote: > > > This

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// labath wrote: > krytarowski wrote: > > labath wrote: > > >

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01.10.2015 23:20, Joerg Sonnenberger via lldb-commits wrote: > On Thu, Oct 01, 2015 at 10:41:46AM +, Pavel Labath via > lldb-commits wrote: >> This platform code looks like it was copy-pasted from >> PlatformFreeBSD. Do you anticipate making

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

krytarowski updated this revision to Diff 35950. krytarowski added a comment. Use proper include. Repository: rL LLVM http://reviews.llvm.org/D12748 Files: tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp

Re: [Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

krytarowski added inline comments. Comment at: include/lldb/Config/config.h.cmake:6 @@ +5,3 @@ +#else +#define CONFIG_H + krytarowski wrote: > brucem wrote: > > brucem wrote: > > > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`. > > > > > >

Re: [Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

krytarowski added inline comments. Comment at: include/lldb/Config/config.h.cmake:6 @@ +5,3 @@ +#else +#define CONFIG_H + brucem wrote: > brucem wrote: > > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`. > > > > Also, why not use the same

Re: [Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

krytarowski updated this revision to Diff 35922. krytarowski added a comment. Fix typo. Repository: rL LLVM http://reviews.llvm.org/D12994 Files: CMakeLists.txt cmake/LLDBDependencies.cmake cmake/modules/LLDBConfig.cmake include/lldb/Config/config.h.cmake

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

krytarowski updated this revision to Diff 35923. krytarowski added a comment. Put the include into proper line and use "" instead of <>. Repository: rL LLVM http://reviews.llvm.org/D12748 Files: tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp

Re: [Lldb-commits] [PATCH] D13027: [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree.

krytarowski added a comment. Thanks http://reviews.llvm.org/D13027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13022: Use fcntl.h to retrieve the O_CREAT and O_RDRW constants.

krytarowski added a subscriber: krytarowski. krytarowski accepted this revision. krytarowski added a reviewer: krytarowski. krytarowski added a comment. You mean `O_RDWR`, not `O_RDRW`. The patch is correct on NetBSD. http://reviews.llvm.org/D13022

[Lldb-commits] [PATCH] D12995: Add support for lldb config.h and detect ncurses' include path

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added subscribers: lldb-commits, llvm-commits. krytarowski set the repository for this revision to rL LLVM. This change is required to get proper ncurses handling on NetBSD. Repository: rL LLVM

[Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Summary of the changes: - add config.h (CMake and autotools target). - Handle ncurses with a proper CMake

Re: [Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

krytarowski added a subscriber: krytarowski. krytarowski requested changes to this revision. krytarowski added a reviewer: krytarowski. This revision now requires changes to proceed. Comment at: tools/lldb-server/CMakeLists.txt:40 @@ +39,3 @@ + if (NOT LLDB_DISABLE_CURSES) +

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

krytarowski added a comment. Any interest? Repository: rL LLVM http://reviews.llvm.org/D12748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)

krytarowski added a comment. In http://reviews.llvm.org/D12750#244435, @sas wrote: > @brucem, not sure exactly what way forward you are suggesting. LLDB build > system supports cmake 2.8.12 and up, so we can't use FindBacktrace unless we > bump that to 3.0. Are we recommending we do that?

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

krytarowski added a comment. Please commit it if it's OK. Repository: rL LLVM http://reviews.llvm.org/D12746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

krytarowski updated this revision to Diff 34510. krytarowski added a comment. Rework the comment regarding SI_KERNEL. Repository: rL LLVM http://reviews.llvm.org/D12659 Files: source/Plugins/Process/POSIX/CrashReason.cpp Index: source/Plugins/Process/POSIX/CrashReason.cpp

Re: [Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)

krytarowski updated this revision to Diff 34490. krytarowski added a comment. typo Repository: rL LLVM http://reviews.llvm.org/D12750 Files: cmake/LLDBDependencies.cmake Index: cmake/LLDBDependencies.cmake === ---

[Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Problem caught on NetBSD with missing getopt_long_only(3). Repository: rL LLVM http://reviews.llvm.org/D12748

[Lldb-commits] [PATCH] D12749: Link liblldb.so with LLVMObjCARCOpts.a

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Problems reported on NetBSD: ``` llvm[4]: Linking Debug+Asserts executable lldb

[Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Linux and NetBSD versions are compatible, modulo flag values: - O_CLOEXEC and O_NONBLOCK are the same, - O_NOSIGPIPE

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

krytarowski added a comment. Still valid. Repository: rL LLVM http://reviews.llvm.org/D12659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12661: NetBSD doesn't provide struct statfs, make use of struct statvfs

krytarowski added a comment. Thank you. Place commit. Repository: rL LLVM http://reviews.llvm.org/D12661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D12661: NetBSD doesn't provide struct statfs, make use of struct statvfs

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D12661 Files: source/Host/posix/FileSystem.cpp Index:

[Lldb-commits] [PATCH] D12662: Prevent from a redefinition of _GLIBCXX_USE_NANOSLEEP

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Build warning caught on NetBSD. Repository: rL LLVM http://reviews.llvm.org/D12662 Files:

[Lldb-commits] [PATCH] D12654: Add missing include for va_list in MIUtilString.h

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Problem was caught on NetBSD. Repository: rL LLVM http://reviews.llvm.org/D12654 Files:

Re: [Lldb-commits] [PATCH] D12654: Add missing include for va_list in MIUtilString.h

krytarowski added a comment. Thank you. Please commit this change. Repository: rL LLVM http://reviews.llvm.org/D12654 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12582: Move GetOptInc to the common namespace

krytarowski added a comment. Thank you. When the review will be done, please commit it. Repository: rL LLVM http://reviews.llvm.org/D12582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski added inline comments. Comment at: include/lldb/Host/HostGetOpt.h:11 @@ -10,3 +10,1 @@ -#ifndef _MSC_VER - labath wrote: > krytarowski wrote: > > labath wrote: > > > How about just putting here > > > ``` > > > #if !defined(_MSC_VER) &&

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski added a comment. I've inlined replies to your comments. Comment at: include/lldb/Host/HostGetOpt.h:11 @@ -10,3 +10,1 @@ -#ifndef _MSC_VER - labath wrote: > How about just putting here > ``` > #if !defined(_MSC_VER) && !defined(__NetBSD__) > ``` I

[Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Implement it with the original NetBSD style. Repository: rL LLVM http://reviews.llvm.org/D12582 Files:

Re: [Lldb-commits] [PATCH] D12485: NetBSD ships with paccept(2), a superset of accept4(2)

krytarowski added a comment. Thank you. If everything is done, please commit it. Repository: rL LLVM http://reviews.llvm.org/D12485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

<    1   2