[Lldb-commits] [PATCH] D47551: [IRMemoryMap] Fix the alignment adjustment in Malloc

2018-05-30 Thread Lang Hames via Phabricator via lldb-commits
lhames added a comment. LGTM. I haven't looked at process memory management. How hard would your FIXME be to implement? - Lang. https://reviews.llvm.org/D47551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

2018-01-12 Thread Lang Hames via Phabricator via lldb-commits
lhames created this revision. lhames added a reviewer: davide. lhames added a project: LLDB. Herald added subscribers: llvm-commits, JDevlieghere. Failure to build the method override tables results in expression failures on the following trivial test case: class Base { public: virtual ~

[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

2018-01-12 Thread Lang Hames via Phabricator via lldb-commits
lhames added inline comments. Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2103 +static bool isOverload(clang::CXXMethodDecl *m1, clang::CXXMethodDecl *m2) { + // FIXME: This should detect covariant return types, but currently doesn't. aprantl

[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

2018-01-17 Thread Lang Hames via Phabricator via lldb-commits
lhames updated this revision to Diff 130284. lhames added a comment. Updated to address review comments: - assert changed to lldbassert - comments added - test case breakpoint comment simplified - unused import removed from testcase - testcase Makefile cleaned up Repository: rL LLVM https://

[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

2018-01-22 Thread Lang Hames via Phabricator via lldb-commits
lhames accepted this revision. lhames added a comment. Committed in r323163. Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2106 +// a vtable entry) from overloads (which require distinct entries). +static bool isOverload(clang::CXXMethodDecl *m1, clang::CXXMethod

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

2021-01-13 Thread Lang Hames via Phabricator via lldb-commits
lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Belatedly -- LGTM. I think an orc-greedy mode for LLI sounds like a great idea. Also, once we have it we should probably make it the default mode instead of MCJIT. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

2021-10-22 Thread Lang Hames via Phabricator via lldb-commits
lhames added a comment. Yeah -- this seems like a good idea to me. Thanks Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D32295: [RFC] Fix crash in expression evaluation

2017-04-20 Thread Lang Hames via Phabricator via lldb-commits
lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Approving the LLDB/Linux working again. Thanks for digging in to this Pavel. Greg Clayton appears to have hit the same issue recently too. Digging through bugs.llvm.org, it looks like this mig

[Lldb-commits] [PATCH] D32899: [RuntimeDyld] Fix debug section relocation (pr20457)

2017-05-07 Thread Lang Hames via Phabricator via lldb-commits
lhames requested changes to this revision. lhames added a comment. This revision now requires changes to proceed. Hi Pavel, This should be an llvm-rtdyld lit test (the unit-test is impressive, but this is RuntimeDyld specific so llvm-rtdyld is more appropriate). I've modified llvm-rtdyld and Ru

[Lldb-commits] [PATCH] D32899: [RuntimeDyld] Fix debug section relocation (pr20457)

2017-05-16 Thread Lang Hames via Phabricator via lldb-commits
lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. LGTM. :) And yes - I think it's reasonable to add that MCJIT unit test case too. Thanks for working on this! https://reviews.llvm.org/D32899 __

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

2017-07-06 Thread Lang Hames via Phabricator via lldb-commits
lhames added inline comments. Comment at: source/Symbol/ClangExternalASTSourceCommon.cpp:24 +template +static decltype(std::declval()(std::declval())) +WithExclusiveSourceMap(FnType fn) { Does std::result_of::type work as the return type? http://en.cppreference

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

2017-07-10 Thread Lang Hames via Phabricator via lldb-commits
lhames added a comment. I prefer the lambda syntax: Locking with an argument requires you to know the idiom (which wasn't immediately obvious to me), whereas the lambda enforces it implicitly. We could also consider writing an atomic access adapter for this (and other types). That would be gen