[Lldb-commits] [PATCH] D157960: [lldb][gui] Update TreeItem children's m_parent on move

This revision was automatically updated to reflect the committed changes. Closed by commit rG83695d45d621: [lldb][gui] Update TreeItem childrens m_parent on move (authored by kpdev42). Changed prior to commit: https://reviews.llvm.org/D157960?vs=550240=550655#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D157960: [lldb][gui] Update TreeItem children's m_parent on move

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Before this patch, any time

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added a comment. So what are next steps? Are we going for implementation of `DW_AT_no_unique_address` (which is going to be a non-standard extension) ? @dblaikie @aprantl @Michael137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

kpdev42 added a comment. Herald added a subscriber: asb. @jingham could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144392/new/ https://reviews.llvm.org/D144392 ___

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

kpdev42 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144390/new/ https://reviews.llvm.org/D144390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true; Michael137

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 512945. kpdev42 added a comment. Thanks for pointing out the bug @Michael137 . It seems that clang assigns arbitrary offsets for non_unique_address so analyzing them brings me nowhere. In this patch I tried assigning no_unique_address to every empty

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { +

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { +

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 511683. kpdev42 edited the summary of this revision. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files:

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 511362. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files:

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 507272. kpdev42 added a comment. Update patch after landing D145057 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files:

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

kpdev42 added a comment. In D144392#4139001 , @labath wrote: > I'm afraid you're fixing this at the wrong end. This kind of complex thread > control does not belong inside the debug stub. > > IIUC, the problematic sequence of events is: > > 1. lldb

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

kpdev42 added a comment. In D144390#4138869 , @DavidSpickett wrote: > What is the practical impact of the bug you are fixing? > > I guess it is something like if you set signal handling info, then attach to > something, that info is not used. Until you

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3896 + if (D->hasAttrs()) +ToField->setAttrs(D->getAttrs()); ToField->setAccess(D->getAccess()); balazske wrote: > The import of attributes is handled in function

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

kpdev42 added a comment. 1. There is a situation where the patch might go wrong. When stepping while inside: - a signal handler when `SA_NODEFER` flag is set (the same signal can be received while it is still being handled), and the signal is received again; - a handler that is set on

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, clayborg, k8stone, davide. kpdev42 added a project: LLDB. Herald added subscribers: JDevlieghere, s.egerton, dmgreen, simoncook, emaste. Herald added a project: All. kpdev42 requested review of this revision. Herald added

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Before this

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, davide, clayborg, k8stone. kpdev42 added projects: LLVM, LLDB. Herald added subscribers: Michael137, JDevlieghere, martong. Herald added a reviewer: shafik. Herald added a reviewer: shafik. Herald added a project: All. kpdev42

[Lldb-commits] [PATCH] D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

kpdev42 added a comment. In D140624#4079306 , @omjavaid wrote: > This rev has broken lldb-arm-ubuntu buildbot > https://lab.llvm.org/buildbot/#/builders/17/builds/33173 Sorry. I've added a small fix for it

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG2af0a478eaee: [lldb] Consider all breakpoints in breakpoint detection (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/

[Lldb-commits] [PATCH] D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

This revision was automatically updated to reflect the committed changes. Closed by commit rG92f0e4ccafac: [LLDB] Fixes summary formatter for libc++ map allowing modification of… (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140623: [LLDB] Fix for libc++ atomic allowing modification of contained value

This revision was automatically updated to reflect the committed changes. Closed by commit rGff9c31b23b76: [LLDB] Fix for libc++ atomic allowing modification of contained value (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 updated this revision to Diff 488154. kpdev42 added a comment. Renaming and cleanup according to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/ https://reviews.llvm.org/D140368 Files: lldb/source/Target/StopInfo.cpp

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 added a comment. @jingham May I kindly ask you to take a look at this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/ https://reviews.llvm.org/D140368 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/ https://reviews.llvm.org/D140368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 updated this revision to Diff 485434. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/ https://reviews.llvm.org/D140368 Files: lldb/source/Target/StopInfo.cpp

[Lldb-commits] [PATCH] D140624: [LLDB] Fix for libc++ map allowing modification of contained value

kpdev42 created this revision. kpdev42 added reviewers: davide, DavidSpickett, clayborg, k8stone. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D140623: [LLDB] Fix for libc++ atomic allowing modification of contained value

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, clayborg, k8stone, davide. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 added a comment. In D140368#4007234 , @DavidSpickett wrote: > The intent makes sense. We should stop and report user breakpoints triggered > while trying to execute some internal stepping plan, even if they overlap > what lldb was planning to

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 updated this revision to Diff 484745. kpdev42 added a comment. Renamed the test, added more tests for unconditional (enabled/disabled) breakpoints and breakpoints with callbacks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Currently in

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 added a comment. In D130062#3789671 , @aprantl wrote: > Out of curiosity — did you get an email notification from the bot? Hi, yes, I will add a priority to these notifications to react faster, sorry Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0fb69d17b4d: [lldb][DWARF5] Enable macro evaluation (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.org/D130062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D131783: [LLDB][JIT] Set processor for ARM architecture

This revision was automatically updated to reflect the committed changes. Closed by commit rGff9efe240c47: [LLDB][JIT] Set processor for ARM architecture (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131783/new/

[Lldb-commits] [PATCH] D131783: [LLDB][JIT] Set processor for ARM architecture

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett, granata.enrico. kpdev42 added a project: LLDB. Herald added subscribers: omjavaid, JDevlieghere, kristof.beyls. Herald added a project: All. kpdev42 requested review of this revision. Herald added a

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rGf63e2cfb7f52: [LLDB] Add basic floating point ops to IR interpreter (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126359/new/

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 updated this revision to Diff 451364. kpdev42 added a comment. Address review notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.org/D130062 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

kpdev42 updated this revision to Diff 450244. kpdev42 added a comment. Update test case so it compares JIT’ed and interpreted FP division results and also check operations on float type. Patch doesn’t implement long double, because IR interpreter currently doesn’t support instruction argument

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

kpdev42 added inline comments. Comment at: lldb/test/API/lang/c/fpeval/TestFPEval.py:32 +self.runCmd("run", RUN_SUCCEEDED) +self.expect("expr --allow-jit false -- a + b", VARIABLES_DISPLAYED_CORRECTLY, +substrs=['double', '44'])

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett. kpdev42 added a project: LLDB. Herald added subscribers: Enna1, JDevlieghere, mgorny. Herald added a project: All. kpdev42 requested review of this revision. Herald added a reviewer: jdoerfert. Herald

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

kpdev42 updated this revision to Diff 440109. kpdev42 added a comment. Herald added a subscriber: Michael137. Address review notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126359/new/ https://reviews.llvm.org/D126359 Files:

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

kpdev42 created this revision. kpdev42 added reviewers: clayborg, granata.enrico, davide, k8stone. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Patch adds support for fadd, fsub, fdiv, fmul and fcmp

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

This revision was automatically updated to reflect the committed changes. Closed by commit rG1aab5e653d2c: [LLDB] Provide target specific directories to libclang (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110827/new/

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

kpdev42 updated this revision to Diff 388118. kpdev42 added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110827/new/ https://reviews.llvm.org/D110827 Files:

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

kpdev42 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110827/new/ https://reviews.llvm.org/D110827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

kpdev42 added a comment. In D110827#3059120 , @clayborg wrote: > In D110827#3042820 , @kpdev42 wrote: > >> In D110827#3034767 , @clayborg >> wrote: >> >>> LLDB also

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

kpdev42 added a comment. In D110827#3034767 , @clayborg wrote: > Should we be testing if these directories exist before trying to use them? > Might be nice to avoid compiler warnings if the compiler will emit warnings > or errors if these directories

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

kpdev42 created this revision. kpdev42 added reviewers: clayborg, granata.enrico, labath. kpdev42 added a project: LLDB. Herald added subscribers: JDevlieghere, pengfei. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. On Linux some C++ and C include files