Author: tberghammer
Date: Mon Jul 4 04:11:08 2016
New Revision: 274488
URL: http://llvm.org/viewvc/llvm-project?rev=274488&view=rev
Log:
Fix ClangASTContext after some clang API changes
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext
tberghammer created this revision.
tberghammer added reviewers: clayborg, granata.enrico, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Fix the libc++ pretty printers for the android NDK
The libc++ shipped with the android NDK is shipped
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D21516
___
lldb-commits mailing list
lldb-commits@lists.l
Can you upload the patch to http://reviews.llvm.org/differential/ (we do
all of the code review there)?
On Fri, Jun 10, 2016 at 6:08 PM John Lindal via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> I never heard back on this. Should I file a ticket?
>
> Thanks,
> John
>
> On Thu, Apr 7, 2
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D21324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: tberghammer
Date: Thu Jun 2 20:03:04 2016
New Revision: 271618
URL: http://llvm.org/viewvc/llvm-project?rev=271618&view=rev
Log:
Fix makefile for TestExternCSymbols
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/extern_c/Makefile
Modified: lldb/trunk/packages/Python/ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271453: Fix JavaArraySyntheticFrontEnd for non-reference
ValueObject. (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D20875?vs=59265&id=59321#toc
Repository:
rL LLVM
htt
Author: tberghammer
Date: Wed Jun 1 19:45:38 2016
New Revision: 271453
URL: http://llvm.org/viewvc/llvm-project?rev=271453&view=rev
Log:
Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.
Summary: Fix missing return after checking that m_backend is not a pointer or
reference type.
R
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for fixing it (I seen strange issues caused by this so it
will help a lot).
http://reviews.llvm.org/D20875
___
lldb
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
looks good
Comment at: cmake/modules/LLDBConfig.cmake:432
@@ +431,3 @@
+message(WARNING
+"You appear to be using linking to libstdc++ version les
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D20623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
I had to revert this CL with rL270214 as it causes a build breakage (see
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/7282)
and makes a false assumption regarding host-target compatibility. Please
see my commit message in http://reviews.llvm.org/rL270214 for more de
Author: tberghammer
Date: Fri May 20 08:07:16 2016
New Revision: 270214
URL: http://llvm.org/viewvc/llvm-project?rev=270214&view=rev
Log:
Revert rL270207: "[LLDB][MIPS] Fix floating point handling in case of thread
step-out"
The CL causes a build breakage on platforms where sizeof(double) == siz
tberghammer abandoned this revision.
tberghammer added a comment.
Abandoning. as http://reviews.llvm.org/rL270062 fixed the same issue before I
managed to add a test for this CL.
http://reviews.llvm.org/D19535
___
lldb-commits mailing list
lldb-com
Author: tberghammer
Date: Fri May 20 05:58:55 2016
New Revision: 270201
URL: http://llvm.org/viewvc/llvm-project?rev=270201&view=rev
Log:
Work around android-arm NDK bug exposed by rL269992
In the android-arm ndk there is a duplicated typedef in link.h
and in unwind.h causing build erros. This CL
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with 1 minor comment inline. Feel free to ignore/postpone it if you
want
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2072-2073
@@ -21
Author: tberghammer
Date: Thu May 19 05:53:10 2016
New Revision: 270040
URL: http://llvm.org/viewvc/llvm-project?rev=270040&view=rev
Log:
Fix build after rL270009
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
http://llvm.o
Author: tberghammer
Date: Tue May 17 07:42:25 2016
New Revision: 269759
URL: http://llvm.org/viewvc/llvm-project?rev=269759&view=rev
Log:
xfail TestTopLevelExprs for Android API 21-22 (llvm.org/pr27787)
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopL
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Very nice!
I don't know how we missed this optimization before. Finally the size of
lldb-server starts to became more reasonable (3.7 MB on arm32)
http://reviews.llvm.org/D20236
Author: tberghammer
Date: Thu May 5 07:46:45 2016
New Revision: 268626
URL: http://llvm.org/viewvc/llvm-project?rev=268626&view=rev
Log:
Guard AddCXXSynthetic with LLDB_DISABLE_PYTHON
The function only avaibleble when python is enabled. Guard the new call
in the Java plugin with LLDB_DISABLE_PYT
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268622: Add support for displaying Java array types on
Andorid (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D19540?vs=55031&id=56263#toc
Repository:
rL LLVM
http://rev
Author: tberghammer
Date: Thu May 5 06:18:21 2016
New Revision: 268622
URL: http://llvm.org/viewvc/llvm-project?rev=268622&view=rev
Log:
Add support for displaying Java array types on Andorid
Differential revision: http://reviews.llvm.org/D19540
Modified:
lldb/trunk/include/lldb/Symbol/Java
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
http://reviews.llvm.org/D19927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Add support for displaying Java array types on Andorid
http://reviews.llvm.org/D19540
Files:
include/lldb/Symbol/JavaASTContext.h
source/Plugins/Language/Java/JavaFormatter
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Fix 2 LLVM assertion caused by an API miss-ues in Scalar
APInt::trunc only works if the destination size is strictly smaller
then the source size while APInt::sext and A
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
The change looks good with the explanation but there is a few thing we should
do for longer terms:
- Read the value of both Tag_ARM_ISA_use and Tag_THUMB_ISA_use and set the
archite
Author: tberghammer
Date: Mon Apr 25 10:51:45 2016
New Revision: 267422
URL: http://llvm.org/viewvc/llvm-project?rev=267422&view=rev
Log:
Fix ARM attribute parsing for Android after rL267291
Differential revision: http://reviews.llvm.org/D19480
Modified:
lldb/trunk/source/Core/ArchSpec.cpp
tberghammer added a comment.
I committed in this change based on the approval from @labath with the Android
- EABI support (no hard float) to get the LLDB Android ARM buildbots green
again. If you have any more question comment then please let me know and I am
happy to address them with a separ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267422: Fix ARM attribute parsing for Android after rL267291
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D19480?vs=54854&id=54864#toc
Repository:
rL LLVM
http://revie
tberghammer updated this revision to Diff 54854.
tberghammer added a comment.
I updated the diff to only address the soft-flat case (Android-EABI). This
fixes the most important case but I would like to fix the hard-flat case as
well in the not so distant future as we have the same problem (regr
tberghammer added a comment.
This patch only effects debugging (all modified file is part of LLDB).
I want to get the Android <-> EABI part fixed ASAP as a recent LLDB change
completely broke Android ARM debugging with adding ARM.Attributes support
(causing Environment mismatch between EABI and
tberghammer added a comment.
Both executables and shared libraries are containing ARM Attributes what
contains the information about soft-float vs hard-float. I am not sure how
accurate it is as in theory you can link together an object file compiled with
soft float with a one compiled with har
tberghammer added inline comments.
Comment at: source/Core/ArchSpec.cpp:1017
@@ +1016,3 @@
+// considered to be compatible. This is required as a workaround for
shared libraries compiled
+// for Android without the NOTE section indicating that they are using the
Android
tberghammer created this revision.
tberghammer added reviewers: labath, compnerd.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Fix ARM attribute parsing for Android after rL267291
http://reviews.llvm.org/D19480
Files
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
A producer string would be excellent but I know it is not easy to add it to all
part of the toolchain. In case of development compilers I would suggest to add
the version number of the nex
tberghammer accepted this revision.
tberghammer added a comment.
I don't really have an opinion about CheckPLTSize() function Greg proposes but
I definitely want to see some comment explaining why we say that a plt entry
less then 4 byte is invalid.
http://reviews.llvm.org/D19252
__
tberghammer accepted this revision.
tberghammer added a comment.
I think having an explicit value for resolve_tail_call_address with a comment
is valuable (not sure how much details we need in the comment) so when the next
person looking into related unwinding issue he/she will know that changin
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Is it possible to query the version of the go runtime we are currently
debugging and decide which symbol we look for instead of using this fallback
mechanism? I think it would make the code easier to understand and also ea
Author: tberghammer
Date: Wed Apr 20 04:54:47 2016
New Revision: 266867
URL: http://llvm.org/viewvc/llvm-project?rev=266867&view=rev
Log:
Fix xfail for test_tilde_home_directory on windows
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/llvm/TestLLVM.py
Modified:
lldb/tr
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D19153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D19114
___
lldb-commits mailing list
lldb-commits@lists.l
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
My understanding of the eh_frame is that "undefined" means the value of the
register is not recoverable in the current frame (default for volatile
registers) while the meaning of "same" is that this frame haven't messed wi
tberghammer accepted this revision.
tberghammer added a comment.
Looks good
http://reviews.llvm.org/D18984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added subscribers: lldb-commits, tberghammer.
/lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:333 I think
we don't need the second '~' as now you are accepting things like
``` ~~Foo, ~, ~~ ```
what shouldn't been accepted. I am happy to make the CL for removing it
tberghammer added a comment.
Generally looks good with 2 minor comment inline. I also run the test suite on
Android ARM (little endian) and everything looked fine
Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:127
@@ -119,3 +126,3 @@
else
-
tberghammer accepted this revision.
tberghammer added a comment.
Looks good
http://reviews.llvm.org/D18980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer accepted this revision.
tberghammer added a comment.
Looks good as I am not aware of any system where the plt sections has different
section name
http://reviews.llvm.org/D18973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
Author: tberghammer
Date: Mon Apr 11 03:54:57 2016
New Revision: 265921
URL: http://llvm.org/viewvc/llvm-project?rev=265921&view=rev
Log:
Fix makefile for TestMiThreadInfo after rL265858 (2nd try)
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/Makefile
Modified:
Author: tberghammer
Date: Mon Apr 11 03:45:01 2016
New Revision: 265920
URL: http://llvm.org/viewvc/llvm-project?rev=265920&view=rev
Log:
Fix makefile for TestMiThreadInfo after rL265858
The makefile was explicitly setting LDFLAGS what is breaking some rules
in the global makefile.
Modified:
Author: tberghammer
Date: Fri Apr 8 09:31:13 2016
New Revision: 265787
URL: http://llvm.org/viewvc/llvm-project?rev=265787&view=rev
Log:
Fix-up LLDB build after rL13179
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
http:/
tberghammer added a comment.
My guess is the root cause of the problem is that we are setting CFLAGS instead
of appending to CLAFGS_EXTRA (I changed it in my followup CL)
Users:
tfiala (Author)
http://reviews.llvm.org/rL265498
___
lldb-commits m
tberghammer added subscribers: lldb-commits, tberghammer.
tberghammer added a comment.
This CL caused a lot of breakage across various Linux/Android builders. I
created a fix at http://reviews.llvm.org/rL265527 but please verify it is still
working with OSX after that
/lldb/trunk/packages/Pyth
Author: tberghammer
Date: Wed Apr 6 05:34:29 2016
New Revision: 265527
URL: http://llvm.org/viewvc/llvm-project?rev=265527&view=rev
Log:
Fix and xfail TestRegisterVariables after rL265498
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile
lldb/trunk/p
Author: tberghammer
Date: Tue Apr 5 09:08:18 2016
New Revision: 265398
URL: http://llvm.org/viewvc/llvm-project?rev=265398&view=rev
Log:
[NFC] Cleanup the code used to run shell commands from tests
Previously we had 3 different method to run shell commands on the
target and 4 copy of code waitin
tberghammer added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbutil.py:1040
@@ +1039,3 @@
+# Exponential backoff!
+time.sleep(pow(2, i) * 0.25)
+else:
labath wrote:
> Please put 0.30 here. I remember needing to increa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265398: [NFC] Cleanup the code used to run shell commands
from tests (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D18789?vs=52681&id=52685#toc
Repository:
rL LLVM
http
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
[NFC] Cleanup the code used to run shell commands from tests
Previously we had 3 different method to run shell commands on the
target and 4 copy of code waiting until a given fil
Author: tberghammer
Date: Tue Apr 5 08:18:08 2016
New Revision: 265392
URL: http://llvm.org/viewvc/llvm-project?rev=265392&view=rev
Log:
Fix TestPlatformProcessConnect after rL265357
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/platform-process-connect/TestPlatformP
tberghammer added a comment.
This assert is NOT verifying the debug info itself. It is verifying that LLDB
asked the right SymbolFileDWARFDwo to find a DIE based on a DIERef.
Independently of the debug info (what can be garbage) passed in to LLDB this
assert should never fire if LLDB has no maj
This assert isn't checking for the correctness of the debug info (what is a
program input). It is checking that we passed the DIERef to the correct
SymbolFileDWARFDwo instance what is the contract of the API and should be
checked by an assert. This assert will only fire if we have a bug in LLDB
reg
tberghammer added inline comments.
Comment at:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:136
@@ +135,3 @@
+{
+assert(m_base_dwarf_cu->GetOffset() == die_ref.cu_offset);
+return DebugInfo()->GetDIEForDIEOffset(die_ref.die_offset);
c
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D18646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good (I don't like the syntax with a class level variable but don't know
any better one as using decorators for this would be very difficult)
http://reviews.llvm.org/D18598
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
Looks good but I don't understand why android is working while other linux
platforms isn't.
http://reviews.llvm.org/D18631
___
lldb-commits
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
I don't maintain any downstream branch to worry about merges but my personal
opinion is moving large amount of code around can cause some issue in the
future even for upstream. The 2 main issue I can think about:
- "git l
tberghammer added a comment.
I would prefer a more general solution then the one Pavel proposed because
currently we are adding 2 more options (abi and isa) but in the future we might
need a lot of other stuff as well and adding a new argument for each one will
be problematic (e.g. omit frame p
tberghammer added a reviewer: ted.
tberghammer added a comment.
Looks good (I added Ted as a reviewer for hexagon).
http://reviews.llvm.org/D18531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tberghammer added a comment.
I think it should be fine to make it public as it don't do anything what can
mess up the private state of the DynamicLoader. In general visibility in LLDB
are decided in a bit randomly so usually it is fine to change them if the
implementation looks like it won't br
tberghammer added a comment.
What is your opinion about replacing the ProcessGDBRemote::LoadModuleAtAddress
with the following code:
lldb::ModuleSP
ProcessGDBRemote::LoadModuleAtAddress (const FileSpec &file, lldb::addr_t
base_addr, bool value_is_offset)
{
DynamicLoader* loader = Ge
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:334
@@ +333,3 @@
+virtual std::unique_ptr
+GetDWOForCompileUnit(DWARFCompileUnit &dw
tberghammer added a comment.
You can pass extra compiler flags to the test suit with the -E option (haven't
tested it). I would suggest to use that option and then xfail based on it
(xfail if extra flags contain -foo).
In long term I would prefer to not add a new option to expectedFailureAll bu
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D18146
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: tberghammer
Date: Tue Mar 8 07:33:14 2016
New Revision: 262925
URL: http://llvm.org/viewvc/llvm-project?rev=262925&view=rev
Log:
Fix log in Broadcaster causing a crash
Modified:
lldb/trunk/source/Core/Broadcaster.cpp
Modified: lldb/trunk/source/Core/Broadcaster.cpp
URL:
http://llvm
Author: tberghammer
Date: Tue Mar 8 05:43:56 2016
New Revision: 262923
URL: http://llvm.org/viewvc/llvm-project?rev=262923&view=rev
Log:
Try to fix windows build after rL262863
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
Modified:
lldb/trunk/source/P
Author: tberghammer
Date: Fri Mar 4 05:26:44 2016
New Revision: 262711
URL: http://llvm.org/viewvc/llvm-project?rev=262711&view=rev
Log:
Add reverse file remapping for breakpoint set
LLDB can remap a source file to a new directory based on the
"target.sorce-map" to handle the usecase when the so
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262711: Add reverse file remapping for breakpoint set
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17848?vs=49732&id=49812#toc
Repository:
rL LLVM
http://reviews.llvm
tberghammer added a comment.
It is a good point. I don't think displaying incorrect path for a breakpoint is
a big issue so I don't plan to address it now but we should do it at some point.
http://reviews.llvm.org/D17848
___
lldb-commits mailing li
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Add reverse file remapping for breakpoint set
LLDB can remap a source file to a new directory based on the
"target.sorce-map" to handle the usecase when the source code
Author: tberghammer
Date: Wed Mar 2 06:42:43 2016
New Revision: 262482
URL: http://llvm.org/viewvc/llvm-project?rev=262482&view=rev
Log:
Upgrade the arm/thumb architecture used by the disassembler
Previously we were using thumbv7 and armv8.1a what ended up showing a
few undefined instruction whe
Author: tberghammer
Date: Tue Mar 1 09:01:05 2016
New Revision: 262339
URL: http://llvm.org/viewvc/llvm-project?rev=262339&view=rev
Log:
DWARFExpression: Don't resolve load address in DW_OP_plus
If we have a TargetLoadAddress on the top of the DWARF stack then a
DW_OP_plus or a DW_OP_plus_ucons
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good but please verify that the new test is passes on other architectures
and XFAIL the test accordingly.
If you have to XFAIL something then I would prefer to split this test
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good (it would be nice if we can split GetReturnValueObjectImpl to
multiple function as it starts to become pretty big and hard to read but I
don't think we shouldn't do it as
Author: tberghammer
Date: Fri Feb 26 09:47:35 2016
New Revision: 262028
URL: http://llvm.org/viewvc/llvm-project?rev=262028&view=rev
Log:
Add new java plugin files to the xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL
Author: tberghammer
Date: Fri Feb 26 09:33:32 2016
New Revision: 262023
URL: http://llvm.org/viewvc/llvm-project?rev=262023&view=rev
Log:
Revert part of rL262014 as it caused issues on gcc-i386
Modified:
lldb/trunk/source/Expression/DWARFExpression.cpp
Modified: lldb/trunk/source/Expression/
Author: tberghammer
Date: Fri Feb 26 08:21:27 2016
New Revision: 262016
URL: http://llvm.org/viewvc/llvm-project?rev=262016&view=rev
Log:
Fix address class lookup for absolute symbols
Modified:
lldb/trunk/source/Symbol/ObjectFile.cpp
Modified: lldb/trunk/source/Symbol/ObjectFile.cpp
URL:
ht
This revision was automatically updated to reflect the committed changes.
tberghammer marked 2 inline comments as done.
Closed by commit rL262015: Add a set of new plugins to handle Java debugging
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17616?vs=49089&id=491
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262014: Add support for DW_OP_push_object_address in dwarf
expressions (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17604?vs=49047&id=49179#toc
Repository:
rL LLVM
ht
tberghammer marked 2 inline comments as done.
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81
@@ +80,3 @@
+HardcodedFormatters::HardcodedSummaryFinder
+JavaLanguage::GetHardcodedSummaries()
+{
granata.enrico wrote:
> Is there any reason to use hardcod
Author: tberghammer
Date: Fri Feb 26 08:21:10 2016
New Revision: 262014
URL: http://llvm.org/viewvc/llvm-project?rev=262014&view=rev
Log:
Add support for DW_OP_push_object_address in dwarf expressions
Additionally fix the type of some dwarf expression where we had a
confusion between scalar and l
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Add a set of new plugins to handle Java debugging
The purpose of these plugins is to make LLDB capable of debugging ja
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for DW_OP_push_object_address in dwarf expressions
Additionally fix the type of some dwarf expression where we had a confusion
between scalar and load addr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261858: Handle the case when a variable is only valid in
part of the enclosing scope (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17449?vs=48908&id=49034#toc
Repository:
Author: tberghammer
Date: Thu Feb 25 06:23:43 2016
New Revision: 261859
URL: http://llvm.org/viewvc/llvm-project?rev=261859&view=rev
Log:
Add support for handling absolute symbols in ELF
Most address represented in lldb as section plus offset and handling of
absolute addresses is problematic in s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261859: Add support for handling absolute symbols in ELF
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17450?vs=48947&id=49036#toc
Repository:
rL LLVM
http://reviews.l
Author: tberghammer
Date: Thu Feb 25 06:23:37 2016
New Revision: 261858
URL: http://llvm.org/viewvc/llvm-project?rev=261858&view=rev
Log:
Handle the case when a variable is only valid in part of the enclosing scope
DWARF stores this information in the DW_AT_start_scope attribute. This
CL add supp
tberghammer added a comment.
In http://reviews.llvm.org/D17450#357477, @clayborg wrote:
> We should probably make it such that if a section has the type
> eSectionTypeAbsoluteAddress that we do the right thing inside the following
> functions:
> Section::GetLoadBaseAddress(...);
> Section::Sl
tberghammer updated this revision to Diff 48947.
tberghammer marked an inline comment as done.
http://reviews.llvm.org/D17450
Files:
include/lldb/lldb-enumerations.h
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/ObjectFile/Mac
tberghammer updated this revision to Diff 48908.
tberghammer added a comment.
I added the memory optimization to represent the case when no DW_AT_start_scope
is specified as an empty range map. This way the memory impact for C/C++ will
be only an empty std::vector per variable.
Regarding the lo
tberghammer added a comment.
In http://reviews.llvm.org/D17535#360519, @bhushan wrote:
> In MIPS, we can not put a breakpoint in middle of an atomic sequence.
> If we do so (and that breakpoint is hit) then continuing from breakpoint
> address will cause "SC" to fail due to a breakpoint excepti
tberghammer added a comment.
I can live with that but I still think the scope information belongs to the
variable and not to the DWARF expression representing it's location. As far as
I see keeping the information inside the variable have lower memory impact
(assuming an empty list means full s
101 - 200 of 725 matches
Mail list logo
