Re: [Lldb-commits] [PATCH] D28666: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5

LGTM. Jim and I also thought this test was incredibly brittle. You really want assembly or something that guarantees that variables will be in registers. On Fri, Jan 13, 2017 at 1:43 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath accepted this revision. > > labath ad

[Lldb-commits] [lldb] r289479 - Removing myself from code ownership file

Author: tfiala Date: Mon Dec 12 16:42:00 2016 New Revision: 289479 URL: http://llvm.org/viewvc/llvm-project?rev=289479&view=rev Log: Removing myself from code ownership file I'm transitioning away from my current employer, and I do not foresee myself spending much time on LLDB in the near future.

Re: [Lldb-commits] [lldb] r288044 - fix up Xcode build for r287916

Sure thing :-) On Mon, Nov 28, 2016 at 1:17 PM, Tim Hammerquist wrote: > Thanks, Todd! > > On Mon, Nov 28, 2016 at 9:19 AM, Todd Fiala via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: tfiala >> Date: Mon Nov 28 11:19:03 2016 >&g

[Lldb-commits] [lldb] r288044 - fix up Xcode build for r287916

Author: tfiala Date: Mon Nov 28 11:19:03 2016 New Revision: 288044 URL: http://llvm.org/viewvc/llvm-project?rev=288044&view=rev Log: fix up Xcode build for r287916 Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/vi

[Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

tfiala accepted this revision. tfiala added a comment. LGTM! All tests passed on macOS 10.12.2 public beta with Xcode 8.1. https://reviews.llvm.org/D26721 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

Great. Back soon... On Wed, Nov 16, 2016 at 3:50 PM, Zachary Turner wrote: > No you can go ahead. The new changes I found are not specific to Mac, I > should find problems if there's any with the additional changes. > > On Wed, Nov 16, 2016 at 3:42 PM Todd Fiala wrote: > >> Okay cool. I'm bu

Re: [Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

Okay cool. I'm building against this now. Should I hold off testing? On Wed, Nov 16, 2016 at 3:41 PM, Zachary Turner wrote: > It's no problem, I actually found a few functions I forgot to convert, so > I'm making some additional changes. Nothing that requires additional > testing, but at the

Re: [Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

Hey Zachary, I had to run home unexpectedly. The build worked but I left before the test results came out. If you ran it on Linux and the Linux tests passed, we can address issues that show up on the macOS side. I will also try it at home on macOS, but I don't think you need to hold up with the

Re: [Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

Yep - I followed that. I'm just doing the "build + test" verification on macOS. On Wed, Nov 16, 2016 at 11:41 AM, Zachary Turner wrote: > BTW, I would still like to get Chris to take a look at my usage of > llvm::Twine. Even if it works, I'm not sure if I used it correctly. > > On Wed, Nov 16

[Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

tfiala added a comment. I'm going to test this one now, stacked on top of the final macOS-working version of https://reviews.llvm.org/D26698. Tell me now if you want it tested independently of https://reviews.llvm.org/D26698. https://reviews.llvm.org/D26721

[Lldb-commits] [PATCH] D26698: Remove SBStream accessor that lets you manipulate the internal buffer.

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Here is the adjusted patch that fixes the issue I was seeing on TestTerminal.py. My first set of changes had a lifetime issue where I needed a const char* that was synthesized on the fly and

[Lldb-commits] [PATCH] D26698: Remove SBStream accessor that lets you manipulate the internal buffer.

tfiala added a comment. TestTerminal.py's test_launch_in_terminal() is timing out consistently with the current change + my diff attached above. I'm looking into it now. (It quite possibly is due to the build fixes I did above). I'm attaching the 'sample' (callstack sampling) from the failure

[Lldb-commits] [PATCH] D26698: Remove SBStream accessor that lets you manipulate the internal buffer.

tfiala added a comment. Hi Zachary, I'm uploading a file of diffs I needed to get the macOS build to compile and link. There were a small handful of macOS-only paths that needed an adjustment. You'll want to look those over to see if I did them the right way. I'm now in the process of runnin

[Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

tfiala added a comment. I can give this one a run though on macOS in the morning. https://reviews.llvm.org/D26721 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26698: Remove SBStream accessor that lets you manipulate the internal buffer.

tfiala added a comment. I can run this through in the morning on macOS. https://reviews.llvm.org/D26698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26618: Make some code not manipulate the underlying buffer of a StreamString

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Built and passed all existing tests. https://reviews.llvm.org/D26618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

[Lldb-commits] [PATCH] D26618: Make some code not manipulate the underlying buffer of a StreamString

tfiala added a comment. I will give this a run a bit later this morning. Should be no later than early afternoon. https://reviews.llvm.org/D26618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D26553: Remove weak-linked symbols for SBBreakpointListImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rL286631: Remove weak-linked symbols for SBBreakpointListImpl (authored by tfiala). Changed prior to commit: https://reviews.llvm.org/D26553?vs=77639&id=77662#toc Repository: rL LLVM https://reviews.l

[Lldb-commits] [lldb] r286631 - Remove weak-linked symbols for SBBreakpointListImpl

Author: tfiala Date: Fri Nov 11 15:06:40 2016 New Revision: 286631 URL: http://llvm.org/viewvc/llvm-project?rev=286631&view=rev Log: Remove weak-linked symbols for SBBreakpointListImpl Summary: Similar to SBStructuredData's Impl class, SBBreakpointListImpl was getting weak-link exported in the ll

[Lldb-commits] [PATCH] D26553: Remove weak-linked symbols for SBBreakpointListImpl

tfiala created this revision. tfiala added a reviewer: jingham. tfiala added a subscriber: lldb-commits. Similar to SBStructuredData's Impl class, SBBreakpointListImpl was getting weak-link exported in the lldb namespace. This change list fixes that by moving out of the lldb public namespace, w

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

Okay cool, thanks Chris! -Todd > On Nov 10, 2016, at 1:40 PM, Chris Bieneman wrote: > > I just pushed r286504, which expects the string to not be quoted. This should > solve the bot failures. > > -Chris > >> On Nov 10, 2016, at 1:30 PM, Todd Fiala > > wrote: >>

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

I'm at a point where I can look at it. On Thu, Nov 10, 2016 at 12:17 PM, Tim Hammerquist wrote: > Looks like the quotes around the lldb version string aren't properly > preserved in the xcodeproj file as they are in CMake. > > Can any of the LLDB devs more comfortable with plumbing the depths of

[Lldb-commits] [PATCH] D26513: [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities

tfiala added a comment. Looks fine to me pending that one question on the TSAN check (i.e. if the existing TSAN check is as good as your new ASAN check, LGTM). Comment at: packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py:23 @skipIfRemote -@s

[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

tfiala added a comment. Adding Jim, as I just want one of him or Greg to review. https://reviews.llvm.org/D26510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

tfiala created this revision. tfiala added a reviewer: clayborg. tfiala added a subscriber: lldb-commits. BuildAndIntegration is the configuration used to build Apple-built LLDB. This configuration currently requires NDEBUG to be specified. This change adds a new Xcode variable, LLDB_NDEBUG_CF

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL286413: Fix weak symbol linkage in SBStructuredData, update docs. (authored by tfiala). Changed prior to commit: https://reviews.llvm.org/D26470?vs=77405&id=77411#toc Repository: rL LLVM https://rev

[Lldb-commits] [lldb] r286413 - Fix weak symbol linkage in SBStructuredData, update docs.

Author: tfiala Date: Wed Nov 9 17:21:04 2016 New Revision: 286413 URL: http://llvm.org/viewvc/llvm-project?rev=286413&view=rev Log: Fix weak symbol linkage in SBStructuredData, update docs. Summary: This change fixes an issue where I was leaking a weakly-linked symbol in the SBAPI. It also updat

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

tfiala added a comment. Thanks, Jim! https://reviews.llvm.org/D26470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26478: Unify Darwin and Non-Darwin printing of version output

tfiala accepted this revision. tfiala added a reviewer: tfiala. tfiala added a comment. This revision is now accepted and ready to land. Looks good, @beanz! https://reviews.llvm.org/D26478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

tfiala updated this revision to Diff 77405. tfiala added a comment. Adjusted web docs. https://reviews.llvm.org/D26470 Files: API/SBStructuredData.cpp SB-api-coding-rules.html lldb/API/SBStructuredData.h Index: SB-api-coding-rules.html

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

tfiala added a comment. Making changes to the text... Comment at: SB-api-coding-rules.html:51-54 +An example of this is the SBValue class. Please note it is necessary for the Impl class to +not be

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

tfiala created this revision. tfiala added a reviewer: jingham. tfiala added a subscriber: lldb-commits. This change fixes an issue where I was leaking a weakly-linked symbol in the SBAPI. It also updates the docs to call out what I did wrong. https://reviews.llvm.org/D26470 Files: API/SBSt

[Lldb-commits] [lldb] r285726 - change ProcessAttach test to no-debug-info

Author: tfiala Date: Tue Nov 1 13:50:34 2016 New Revision: 285726 URL: http://llvm.org/viewvc/llvm-project?rev=285726&view=rev Log: change ProcessAttach test to no-debug-info Fixes: https://bugs.swift.org/browse/SR-3103 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/pr

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

tfiala added a comment. > @zturner wrote: > Can I have some background? What is the linking problem? Hi Zachary, This review has comments that pretty much cover it exhaustively: https://reviews.llvm.org/D26093 That'd be a good place to start. https://reviews.llvm.org/D26188 __

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

tfiala added inline comments. Comment at: source/API/CMakeLists.txt:109 else() -# Don't use an explicit export. Instead, tell the linker to -# export all symbols. > This does not affect affect the state of backtracing. The option to export > all symb

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

tfiala added a comment. I'll let Greg comment on the public ABI expansion (i.e. including llvm of a specific version, which may differ from LLDB.framework clients that contain different versions of LLVM). My guess is this is not going to work for us, since we have long-lived frameworks shipped

[Lldb-commits] [PATCH] D26170: Find clang resource directory via *nix-style lookup

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks reasonable. Comment at: source/Host/macosx/HostInfoMacOSX.mm:235-239 size_t framework_pos = raw_path.find("LLDB.framework"); - if (framework_pos != std::string::npo

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. In https://reviews.llvm.org/D26093#583358, @labath wrote: > The snippets you showed are pretty-much expected behavior. The backtrace that > gets printed as a part of the log messages is coming from the backtrace(3) > library, which has pretty limited backtracing capabili

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. Here's what you get with the same codebase, but using this cmake line instead: cmake -GNinja ../llvm -DCMAKE_BUILD_TYPE=Debug -DLLDB_EXPORT_ALL_SYMBOLS:BOOL=YES bin/lldb (lldb) log enable -S lldb process (lldb) target create /bin/ls Current executable set to

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. >> Could you elaborate on this? > > Sure, I'll see if I can reproduce the lack of backtrace symbol lookup that I > was experiencing without exporting those symbols back in roughly Oct/Nov > 2015. We've been using this flag ever since to address it. > >> I've been debug

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. In https://reviews.llvm.org/D26093#582825, @labath wrote: > In https://reviews.llvm.org/D26093#582618, @tfiala wrote: > > > > If it unblocks something it might be ok, but it doesn't actually fix the > > > problem. > > > > It allows debugging of lldb with lldb on Ubuntu.

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL285484: Limit LLDB_EXPORT_ALL_SYMBOLS to lldb symbols (authored by tfiala). Changed prior to commit: https://reviews.llvm.org/D26093?vs=76229&id=76282#toc Repository: rL LLVM https://reviews.llvm.or

[Lldb-commits] [lldb] r285484 - Limit LLDB_EXPORT_ALL_SYMBOLS to lldb symbols

Author: tfiala Date: Fri Oct 28 19:29:15 2016 New Revision: 285484 URL: http://llvm.org/viewvc/llvm-project?rev=285484&view=rev Log: Limit LLDB_EXPORT_ALL_SYMBOLS to lldb symbols LLDB_EXPORT_ALL_SYMBOLS used to instruct the build to export all the symbols in liblldb on CMake builds. This change

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. In https://reviews.llvm.org/D26093#582659, @beanz wrote: > In https://reviews.llvm.org/D26093#582618, @tfiala wrote: > > > The current usage of CommandLine via global static constructors in > > Debug.cpp seems like a poor choice, as it forces all users of llvm with > > N

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. In https://reviews.llvm.org/D26093#582583, @beanz wrote: > This patch ends up hiding the problem, not fixing it. Yes. > If it unblocks something it might be ok, but it doesn't actually fix the > problem. It allows debugging of lldb with lldb on Ubuntu. This broke rec

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

tfiala abandoned this revision. tfiala added a comment. I'm at a loss for the workflow to close this. I originally commandeered it to do an abort on it, but that didn't work. I'm going to abandon it, and see if I can kill it then. Repository: rL LLVM https://reviews.llvm.org/D25830 ___

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. The reason why it doesn't blow up in the hidden case is that liblldb.so has already internally resolved the storage, doesn't involve dynamic resolution, and has its own data location. Ditto for lldb-mi's copy. So they are separate islands. There are two totally separa

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. In https://reviews.llvm.org/D26093#582412, @tfiala wrote: > In https://reviews.llvm.org/D26093#582395, @labath wrote: > > > I am a bit surprised that this fixes the problem. I would have expected > > that the problem would occur in case when we *do* restrict exports, > >

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added a comment. In https://reviews.llvm.org/D26093#582395, @labath wrote: > I am a bit surprised that this fixes the problem. I would have expected that > the problem would occur in case when we *do* restrict exports, This matches my expectations. When I was using the flag the exporte

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala added inline comments. Comment at: API/CMakeLists.txt:106 # from working on some systems but limits the liblldb size. -MESSAGE("-- Symbols (liblldb): only exporting liblldb.exports symbols") +MESSAGE("-- Symbols (liblldb): only exporting symbols in lldb namesp

[Lldb-commits] [PATCH] D26093: Limit LLDB_EXPORT_ALL_SYMBOLS to additionally export only the lldb_private namespace symbols

tfiala created this revision. tfiala added reviewers: labath, tberghammer. tfiala added a subscriber: lldb-commits. Herald added a subscriber: mgorny. My original implementation of this last year was to just export everything from liblldb.so. As lldb-mi recently started including a separate copy

[Lldb-commits] [PATCH] D25922: Test infra: expose CFLAGS_NO_ARCH for use by test custom build rules

tfiala added a comment. > I am not that excited by this, but I don't see a much better way to achieve > the result. :) > Possibly I'd consider making the variable name positive (instead of > CFLAGS_NO_DEBUG, have a INCLUDES var, and then the test can use $(INCLUDES) > $(TRIPLE_CFLAGS)). Jim a

[Lldb-commits] [lldb] r285032 - remove xfail from TestObjCNewSyntax.py test_expr_gmodules()

Author: tfiala Date: Mon Oct 24 16:46:46 2016 New Revision: 285032 URL: http://llvm.org/viewvc/llvm-project?rev=285032&view=rev Log: remove xfail from TestObjCNewSyntax.py test_expr_gmodules() Fixes: rdar://27792848 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-new-synt

[Lldb-commits] [PATCH] D25922: Test infra: expose CFLAGS_NO_ARCH for use by test custom build rules

tfiala created this revision. tfiala added reviewers: jingham, labath. tfiala added a subscriber: lldb-commits. The TestUniversal.py test was attempting to build its own CFLAGS unreliably. Essentially it just wanted the prevailing CFLAGS without the arch spec. This change does the following: -

[Lldb-commits] [PATCH] D25886: [Test Suite] Properly respect --framework option

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks good. I do wonder if we should have a general helper for lines like this: sys.platform.rstrip('0123456789') in ('freebsd', 'linux', 'netbsd', 'darwin') but that doesn't have to be loo

[Lldb-commits] [PATCH] D25887: [Test Suite] Pull generateSource into lldbtest

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

tfiala commandeered this revision. tfiala edited reviewers, added: vivkong; removed: tfiala. tfiala added a comment. @beanz and I discussed. This isn't needed here at all. The issue is entirely in the current manifestation of the GitHub side of swift-lldb. Closing this out, we'll resolve in Gi

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

tfiala added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:20 + find_program(LLVM_CONFIG "llvm-config" +HINTS ${FIND_PATHS}) if(LLVM_CONFIG) One question here would be what happens if FIND_PATHS stays "". Does find_program deal with an

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

tfiala added a comment. (It would be good to wait for feedback from the others, though). Repository: rL LLVM https://reviews.llvm.org/D25830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D25830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

Actually that's a good point. We can default to bash but add a setting to override. The issue we have to solve is that the current approach fails with non-POSIX shells. -Todd > On Oct 18, 2016, at 4:09 PM, Joerg Sonnenberger wrote: > > joerg added a comment. > > OK, this is OSX specific, but

[Lldb-commits] [PATCH] D25714: [Test Suite] Allow overriding codesign identity

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D25745: [CMake] Rename lldb-launcher to darwin-debug

tfiala accepted this revision. tfiala added a subscriber: labath. tfiala added a comment. This revision is now accepted and ready to land. This seems fine, but @labath might want to weigh in if Android tools have a hard-baked assumption anywhere on lldb-launcher. https://reviews.llvm.org/D25745

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Yep, looks right. We shouldn't be assuming the shell. https://reviews.llvm.org/D25750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25753: Use clang --driver-mode instead of guessing c++ compiler path

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] r284484 - xfail TestMiSyntax.py's test_lldbmi_output_grammar on macOS

Author: tfiala Date: Tue Oct 18 10:15:24 2016 New Revision: 284484 URL: http://llvm.org/viewvc/llvm-project?rev=284484&view=rev Log: xfail TestMiSyntax.py's test_lldbmi_output_grammar on macOS Needs to be investigated. This is failing locally and on the Xcode CI. rdar://28805064 Modified:

[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

tfiala requested changes to this revision. tfiala added a comment. This revision now requires changes to proceed. Okay. I think we need a minor tweak, to drop the REQUIRED on the Backtrace usage. https://reviews.llvm.org/D23977 ___ lldb-commits ma

[Lldb-commits] [PATCH] D25570: [CMake] Populate LLDB.framework's headers directory

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

tfiala added a comment. (Retro) Ah nice, I like the generator expression you put in there. Repository: rL LLVM https://reviews.llvm.org/D25490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D25489: Use LLDB_SRC for relative paths

tfiala added a comment. (Retro) LGTM. Repository: rL LLVM https://reviews.llvm.org/D25489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

tfiala added a comment. (Retro) LGTM. Repository: rL LLVM https://reviews.llvm.org/D25488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25487: Fix building tests without system headers on Darwin

tfiala added a comment. (Retro) yep, this looked fine. Repository: rL LLVM https://reviews.llvm.org/D25487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

tfiala accepted this revision. tfiala added a comment. Looks good! https://reviews.llvm.org/D25486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

tfiala added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:414 + +find_package(Backtrace REQUIRED) Hi Sylvestre! It's hard to tell without more context, but it looks like this location has most/all configurations going through it. For OSes that d

[Lldb-commits] [lldb] r283497 - disable TSAN tests on macOS i386

Author: tfiala Date: Thu Oct 6 16:30:33 2016 New Revision: 283497 URL: http://llvm.org/viewvc/llvm-project?rev=283497&view=rev Log: disable TSAN tests on macOS i386 These are erroring out on macOS i386. Tracked by: rdar://28659145 Modified: lldb/trunk/packages/Python/lldbsuite/test/decorat

[Lldb-commits] [lldb] r283493 - xfail TestReportData.py on i386

Author: tfiala Date: Thu Oct 6 16:16:37 2016 New Revision: 283493 URL: http://llvm.org/viewvc/llvm-project?rev=283493&view=rev Log: xfail TestReportData.py on i386 Tracked by: rdar://28658860 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py Modifi

[Lldb-commits] [lldb] r283492 - xfail TestQueues on macOS

Author: tfiala Date: Thu Oct 6 16:07:45 2016 New Revision: 283492 URL: http://llvm.org/viewvc/llvm-project?rev=283492&view=rev Log: xfail TestQueues on macOS This test is failing on CI. I cannot get it to fail on my local setup. Tracked by: rdar://28658529 Modified: lldb/trunk/packages/Py

[Lldb-commits] [lldb] r283484 - xfail TestSBTypeTypeClass.py on macOS i386

Author: tfiala Date: Thu Oct 6 14:23:29 2016 New Revision: 283484 URL: http://llvm.org/viewvc/llvm-project?rev=283484&view=rev Log: xfail TestSBTypeTypeClass.py on macOS i386 Tracked by: rdar://28656677 Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/sbtype_typeclass/TestSBT

[Lldb-commits] [lldb] r283483 - xfail TestDataFormatterNSIndexPath.py on macOS i386

Author: tfiala Date: Thu Oct 6 14:18:48 2016 New Revision: 283483 URL: http://llvm.org/viewvc/llvm-project?rev=283483&view=rev Log: xfail TestDataFormatterNSIndexPath.py on macOS i386 Tracked by: rdar://28656605 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-forma

[Lldb-commits] [lldb] r283482 - xfail TestExec.py on macOS i386

Author: tfiala Date: Thu Oct 6 14:12:05 2016 New Revision: 283482 URL: http://llvm.org/viewvc/llvm-project?rev=283482&view=rev Log: xfail TestExec.py on macOS i386 Tracked by: rdar://28656532 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py Modified: ll

[Lldb-commits] [lldb] r283481 - xfail TestDiagnoseDereferenceFunctionReturn.py on macOS i386

Author: tfiala Date: Thu Oct 6 14:04:58 2016 New Revision: 283481 URL: http://llvm.org/viewvc/llvm-project?rev=283481&view=rev Log: xfail TestDiagnoseDereferenceFunctionReturn.py on macOS i386 Tracked by: rdar://28656408 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/f

[Lldb-commits] [lldb] r283477 - xfail TestDarwinLogBasic.py for i386 macOS

Author: tfiala Date: Thu Oct 6 13:25:54 2016 New Revision: 283477 URL: http://llvm.org/viewvc/llvm-project?rev=283477&view=rev Log: xfail TestDarwinLogBasic.py for i386 macOS Tracked by: rdar://28655626 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/darwin_log/basic/Te

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

tfiala added a comment. I also just added a test case to validate we get a non-None answer to test instance self.id() calls. We use it in several places, so might as well make that explicit. That went in as r283156. https://reviews.llvm.org/D24988 _

[Lldb-commits] [lldb] r283156 - add a simple test case to validate test id()

Author: tfiala Date: Mon Oct 3 17:49:13 2016 New Revision: 283156 URL: http://llvm.org/viewvc/llvm-project?rev=283156&view=rev Log: add a simple test case to validate test id() Since we count on it in a few places, the test verifies that the test instance has an id() method that returns somethin

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Much better. I see you found test.id(), which gets as the module.class.test_method setup. That will be unique. Thanks! LGTM. https://reviews.llvm.org/D24988 ___

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

tfiala added a comment. In https://reviews.llvm.org/D24988#559314, @fjricci wrote: > For an example of something that couldn't be disabled with the original > implementation, consider a test like: > > `CreateDuringStepTestCase.test_step_inst` > > Disabling by method name (`test_step_inst`) would

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. That works fine. LGTM. https://reviews.llvm.org/D25099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala added a comment. In https://reviews.llvm.org/D25099#559701, @zturner wrote: > I know what this is. It should be fixed in this patch, I guess I didn't have > the newest patch uploaded. Okay, I'll give that a shot now. https://reviews.llvm.org/D25099

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala requested changes to this revision. tfiala added a reviewer: tfiala. tfiala added a comment. This revision now requires changes to proceed. I'm getting one test crash (segfault) in logging/TestLogging.py: Exception Type:EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVAL

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala added a comment. I will test this on macOS. I will have the results this afternoon. https://reviews.llvm.org/D25099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D25099: Refactor Args a different way

Yep I plan on doing that. -Todd > On Oct 3, 2016, at 10:29 AM, Zachary Turner wrote: > > He lgtm'ed my last patch, so I guess he's ok with the general concept. > Perhaps if someone could just run the test suite for me that would be good > enough. > >> On Mon, Oct 3, 2016 at 10:25 AM Todd Fi

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala added a comment. @zturner , Greg is out this week (and was last Friday as well). I'll get somebody over here to review. https://reviews.llvm.org/D25099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

tfiala added a comment. Hey @fjricci , What is the motivation for this change? It looks like the existing code works based on file names, which are required to be unique in the system. It looks like you're attempting to move it over to a classname.method scheme. Is that right? If so, class

[Lldb-commits] [lldb] r282990 - test infra: clear file-charged issues on rerun of file

Author: tfiala Date: Fri Sep 30 19:17:08 2016 New Revision: 282990 URL: http://llvm.org/viewvc/llvm-project?rev=282990&view=rev Log: test infra: clear file-charged issues on rerun of file This change addresses the corner case bug in the test infrastructure where a test file times out *outside* of

[Lldb-commits] [lldb] r282628 - use assertEquals in TestSBTypeClassMembers

Author: tfiala Date: Wed Sep 28 15:39:50 2016 New Revision: 282628 URL: http://llvm.org/viewvc/llvm-project?rev=282628&view=rev Log: use assertEquals in TestSBTypeClassMembers This change replaces the self.assertTrue() calls with self.assertEquals() so that test failures get more context on failu

[Lldb-commits] [lldb] r282605 - zorg Xcode python test suite target arch update

Author: tfiala Date: Wed Sep 28 11:43:47 2016 New Revision: 282605 URL: http://llvm.org/viewvc/llvm-project?rev=282605&view=rev Log: zorg Xcode python test suite target arch update This changes the Xcode target used by the Green Dragon Xcode CI. When calling xcodebuild with LLDB_PYTHON_TESTSUITE_

[Lldb-commits] [lldb] r282508 - convert TestFatArchives.py over to no-debug-info test

Author: tfiala Date: Tue Sep 27 12:17:21 2016 New Revision: 282508 URL: http://llvm.org/viewvc/llvm-project?rev=282508&view=rev Log: convert TestFatArchives.py over to no-debug-info test We only use the .o-style debug info here regardless, so having it run all three debuginfo styles was a waste.

[Lldb-commits] [lldb] r282496 - xfail TestExec.py on macOS

Author: tfiala Date: Tue Sep 27 10:57:12 2016 New Revision: 282496 URL: http://llvm.org/viewvc/llvm-project?rev=282496&view=rev Log: xfail TestExec.py on macOS Tracked by: rdar://28476369 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py Modified: lldb/tr

Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

tfiala added a comment. BTW, regarding this part: > On Ubuntu 16.04, the requisite support can be retrieved with: > > sudo apt-get install perf-tools-unstable This was incorrect. The perf tool was actually present even without the perf-tools-unstable on Ubuntu 16.04 x86_64. It is just tha

Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL282436: added Linux support for test timeout sampling (authored by tfiala). Changed prior to commit: https://reviews.llvm.org/D24890?vs=72382&id=72553#toc Repository: rL LLVM https://reviews.llvm.or

  1   2   3   4   5   6   7   8   9   10   >