JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
I'm probably not the most qualified to sign off on this, but the review has
stalled and I don't see anything obviously wrong here so LGTM.
Comment at:
lldb/sour
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2121
+return SendErrorResponse(llvm::make_error(
+inconvertibleErrorCode(), "Malformed thread-id"));
+
JDevlieghere wrote:
> Would i
JDevlieghere added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2121
+return SendErrorResponse(llvm::make_error(
+inconvertibleErrorCode(), "Malformed thread-id"));
+
mgorny wrote:
> JDevlie
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb7c140335beb: [lldb] [gdb-remote server] Support selecting
process via Hg (authored by mgorny).
Herald added a project: LLDB.
Repository:
rG LLVM
mgorny created this revision.
mgorny added reviewers: labath, emaste, krytarowski.
mgorny requested review of this revision.
Support using the extended thread-id syntax with Hg packet to select
a subprocess. This makes it possible to start providing support for
running some of the debugger packet
mgorny updated this revision to Diff 337241.
mgorny added a comment.
Rebase.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100261/new/
https://reviews.llvm.org/D100261
Files:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
lldb/source/Plugins/Process/gdb
labath added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2102
+ if (pid == StringExtractorGDBRemote::AllProcesses)
+return SendUnimplementedResponse("Selecting all processes not supported");
+ if (pid == LLDB_INV
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2102
+ if (pid == StringExtractorGDBRemote::AllProcesses)
+return SendUnimplementedResponse("Selecting all processes not supported");
+ if (pid == LLDB_INV
mgorny updated this revision to Diff 337541.
mgorny marked an inline comment as done.
mgorny added a comment.
Revert accidental whitespace change.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100261/new/
https://reviews.llvm.org/D100261
Files:
lldb/source/Plugins/Process/gdb-remote/
mgorny updated this revision to Diff 340310.
mgorny added a comment.
Add tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100261/new/
https://reviews.llvm.org/D100261
Files:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
lldb/test/API/tools/lldb-ser
rovka added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2130
+return SendErrorResponse(llvm::make_error(
+inconvertibleErrorCode(), "No current process and no PID provided"));
+
Just a driv
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2130
+return SendErrorResponse(llvm::make_error(
+inconvertibleErrorCode(), "No current process and no PID provided"));
+
rovka wrot
12 matches
Mail list logo