[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord abandoned this revision. bulbazord added a comment. Not going with this change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103210/new/ https://reviews.llvm.org/D103210 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord added a comment. In D103210#2795619 , @teemperor wrote: >> We have a method called `Language::GetMethodNameVariants`, that could be >> extended/modified to be more suitable. Unless you had something else in >> mind? Maybe something more specif

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

teemperor added a comment. Sorry for the delay! > We have a method called `Language::GetMethodNameVariants`, that could be > extended/modified to be more suitable. Unless you had something else in mind? > Maybe something more specific to Symtab mapping like > `Language::GetFunctionNameSearchVa

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord added a comment. In D103210#2784645 , @teemperor wrote: > +1 to not add any language-specific terms to the Language API. > > Looking over the code, it seems what the code is doing its: > > - Going over the symbol names. > - Creating a search ind

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

teemperor added a comment. +1 to not add any language-specific terms to the Language API. Looking over the code, it seems what the code is doing its: - Going over the symbol names. - Creating a search index from the symbol names that is optionally grouped via the `FunctionNameType` cases (and t

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

jingham added a comment. The idea seems good, but I'm not sure how you are going to extend it? "Selector" seems a pretty ObjC specific term to me. Will this be what you use to get the "method name" part of the C++ names? That would look a bit odd to me, but OTOH having a GetSelector in all t

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord added a comment. Let me know how you feel about this abstraction/idea. I think we'll need something like this at some point to remove most of the remaining dependencies (e.g. in Module.cpp) so I'd like to get something good going here. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord created this revision. bulbazord added a reviewer: teemperor. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are several instances where one may want to ask questions about the name of a method/function/whatever.