[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch resolves the paths in the file/directory fields before

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308 } if (FileSystem::Instance().IsDirectory(file)) { SetError("Not a file!"); ---

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308 } if (FileSystem::Instance().IsDirectory(file)) { SetError("Not a file!"); clayborg wrote: > This is checking for a directory, not a file Not sure what y

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308 } if (FileSystem::Instance().IsDirectory(file)) { SetError("Not a file!");

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa98f394e81f4: [LLDB][GUI] Resolve paths in file/directory fields (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev added a comment. @clayborg Did you check D106564 ? This is the last patch needed to do the rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106553/new/ https://reviews.llvm.org/D106553 _

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

clayborg added a comment. In D106553#2905223 , @OmarEmaraDev wrote: > @clayborg Did you check D106564 ? This is > the last patch needed to do the rebase. Just committed that one and also the one that selects the right