[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec671f3ea00b: [lldb] Support .debug_rnglists.dwo sections in dwp file (authored by kimanh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh added a comment. I've split up the code that addresses the .debug_rnglists from the code that takes care of better error handling (https://reviews.llvm.org/D109231). I'll commit the reviewed part (this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh updated this revision to Diff 370562. kimanh added a comment. - splitting up new code (for error handling) into a different CL - keep code that was already accepted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.ll

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:556 + " (ranges list base: 0x%" PRIx64 "): %s", + offset, m_ranges_base, toString(table_or_error.takeError()).c_str()); } jankratochvil wrote: > kima

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh updated this revision to Diff 369547. kimanh added a comment. - Updating error messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.llvm.org/D107456 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:556 + " (ranges list base: 0x%" PRIx64 "): %s", + offset, m_ranges_base, to

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh added a comment. Friendly ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.llvm.org/D107456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh added a comment. Thanks a lot for the review! Very sorry for my late update, I was out on vacation and then had to catch up with mails. Updated the revision now. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:537 +if (const llvm::DWARFUnitIndex::Entr

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh updated this revision to Diff 367758. kimanh marked 2 inline comments as done. kimanh added a comment. - Incorporating Jan's patch - Adding error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.llvm.org/D107

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:519 +contribution->Length); +return DWARFDataExtractor(); + } Here could be an error message. Comment at: l

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh created this revision. kimanh updated this revision to Diff 364081. kimanh added a comment. kimanh updated this revision to Diff 364364. kimanh added reviewers: labath, jankratochvil. kimanh published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-com