[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

This revision was automatically updated to reflect the committed changes. Closed by commit rGd723ad5bcf71: Enable libc++ in the build for libcxx initializerlist pretty printers (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

teemperor added a comment. There is one on Green Dragon with a few Clang versions and I there is my Linux one with a all GCC/Clang versions Repository: rG LLVM Github

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

labath added a comment. In D112163#3077124 , @dblaikie wrote: > In D112163#3077112 , @teemperor > wrote: > >> LGTM, thanks! >> >> Tests with libc++ as a category are not run on Windows or when GCC is the >>

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

dblaikie added a comment. In D112163#3077112 , @teemperor wrote: > LGTM, thanks! > > Tests with libc++ as a category are not run on Windows or when GCC is the > test compiler, so those decorators are redundant. Removing the Clang XFAIL > also seems

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Tests with libc++ as a category are not run on Windows or when GCC is the test compiler, so those decorators are redundant. Removing the Clang XFAIL also seems fine, I

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

dblaikie added a comment. Herald added a subscriber: JDevlieghere. Looks like this test, when it was introduced/substantially refactored in D9426 - what was missing compared to all the other tests updated to run on linux, was the Makefile change to use libc++,

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

dblaikie created this revision. dblaikie added reviewers: teemperor, labath. dblaikie requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112163 Files: