[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

labath created this revision. labath added reviewers: stella.stamenova, JDevlieghere. Herald added a subscriber: mgorny. labath requested review of this revision. Herald added a project: LLDB. This macro was being used to select the proper import/export annotations on SB classes. Non-windows clien

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117564/new/ https://reviews.llvm.org/D117564 __

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. Neat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117564/new/ https://reviews.llvm.org/D117564 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2a162e63bd7: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. Before this change, it was very easy to build liblldb as a static library (just don't define IMPORT_LIBLLDB and EXPORT_LIBLLDB). After this change, this is no longer possible on Windows (but it still works fine everywhere else). Is this intentional? Repository: rG LL

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

labath added a comment. Well.. I wouldn't say it was intentional, but building (lib)lldb as a static library is not really supported either. Like, there's no way to do that from cmake. Some people using other build systems do that nonetheless, but it comes with all kinds of strings (regardless

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. > So what happens now if you define LLDB_IN_LIBLLDB? Does dllexport explode if > used in a static library? Do you mean define it for all targets, instead of for just liblldb? If just for liblldb, then the link fails because (e.g.) driver tries to dllimport the symbols i

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

labath added a comment. In D117564#3254798 , @thakis wrote: >> So what happens now if you define LLDB_IN_LIBLLDB? Does dllexport explode if >> used in a static library? > > Do you mean define it for all targets, instead of for just liblldb? > > If just f

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. > The background here is that I found this patch in one of my old WIP branches. > The next patch in the series was going to define LLDB_API to > `__attribute__((visibility("default")))` on the non-windows path (and make > everything else hidden), but I have no idea why I

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

labath added a comment. I've done that with rG57ebfea38c03e5cd2d0677eabd2abf761b336097 , if you're still interested in static builds. It took me a while to get to that, as I was fighting fires which also had to do with funky l