[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG268089b6ac4b: Fix the encoding and decoding of UniqueCStringMapT objects when saved to… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

yinghuitan added a comment. Also, to help diagnostics this kind of issue in future, it may worth to add an extra debug mode check in in `UniqueCStringMap` to ensure they are sorted. For example, in debug mode, add a `m_isSorted` flag which is set by `UniqueCStringMap::Sort()` method. All the

[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. This is a great finding! The change looks good. Some questions though: - Do you have any theory why we only see this issue on Mac not Linux? (For anyone else reading this, I found

[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. UniqueCStringMap objects are a