[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

paulkirth added a comment. It's probably fine to reland this after D125570 lands, since that should unblock us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

MaskRay added a comment. In D124673#3512190 , @phosek wrote: > In D124673#3512070 , @MaskRay wrote: > >> In D124673#3512037 , @paulkirth >> wrote: >> >>> Hi, Sorry for th

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

phosek added a comment. In D124673#3512070 , @MaskRay wrote: > In D124673#3512037 , @paulkirth > wrote: > >> Hi, Sorry for the late notification, but I think this change may not apply >> correctly to all configs

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

MaskRay added a comment. In D124673#3512037 , @paulkirth wrote: > Hi, Sorry for the late notification, but I think this change may not apply > correctly to all configs. > > We're seeing a breakage in Fuchsia's Clang CI builders: > https://luci-milo.apps

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

paulkirth added a comment. Hi, Sorry for the late notification, but I think this change may not apply correctly to all configs. We're seeing a breakage in Fuchsia's Clang CI builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8814329895908917697/overview

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1aed14bfea0: [llvm][lldb] use FindLibEdit.cmake everywhere (authored by upsj, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj added a comment. I don't have commit access to LLVM, so feel free to merge it Tobias Ribizel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 ___ lldb-com

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426983. upsj marked an inline comment as done. upsj added a comment. move standalone-specific code to LLDBStandalone.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

JDevlieghere added inline comments. Comment at: lldb/CMakeLists.txt:3-5 +if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS) + set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake) +endif() Can this go in `lldb/cmake/modules/LLDBStandalone.cmake`? Repository:

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426628. upsj added a comment. fix standalone builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cmake lldb/CMakeLists.txt lldb

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

JDevlieghere added a comment. In D124673#3484157 , @MaskRay wrote: > I vaguely recall that some lldb bots use a stand-alone build. Yup, that's correct. The bot in question is https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ Reposi

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

MaskRay added a comment. I vaguely recall that some lldb bots use a stand-alone build. Say I have a build directory /tmp/RelA with `-DLLVM_ENABLE_PROJECTS=clang` cmake -GNinja -S~/llvm-project/lldb -Bout/lldb -DCMAKE_PREFIX_PATH=/tmp/RelA will print CMake Warning at cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426215. upsj added a comment. restore some of the previous behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cmake lldb/cmake

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426080. upsj added a comment. improve handling of disabled libedit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cmake lldb/cmake/

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426072. upsj added a comment. revert remaining unnecessary change from initial diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cm

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426071. upsj added a comment. fix broken build without libedit, improve find module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cm

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426068. upsj added a comment. Herald added a subscriber: JDevlieghere. The previous setup didn't work for clang-query, so I added a CMake IMPORTED target for LibEdit and used it everywhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj created this revision. upsj added reviewers: mgorny, MaskRay. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. upsj requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Currently, LLVM's LineEd