[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGce233e714665: [lldb] Use the just-built libc++ for testing the LLDB data formatters (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D129166#3636658 , @dblaikie wrote: >> The overall logic and the include and library paths make sense to me. The >> rpath thingy will not work on

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

dblaikie added a comment. > The overall logic and the include and library paths make sense to me. The > rpath thingy will not work on windows as it (afaik) has no equivalent feature > (it has the equivalent of (DY)LD_LIBRARY_PATH though). Any idea what the libc++ tests do on Windows then? (on

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere updated this revision to Diff 442994. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129166/new/ https://reviews.llvm.org/D129166 Files: lldb/packages/Python/lldbsuite/test/builders/builder.py lldb/packages/Python/lldbsuite/test/configuration.py

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

labath added a comment. The overall logic and the include and library paths make sense to me. The rpath thingy will not work on windows as it (afaik) has no equivalent feature (it has the equivalent of (DY)LD_LIBRARY_PATH though). Do you just want to make that unsupported. I don't think we're

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere updated this revision to Diff 442635. JDevlieghere added a comment. Herald added a subscriber: mgorny. I still have to test different configurations, but putting it up here for feedback about the general direction. This doesn't account yet for remote runs. Should be easy to detect

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere added a comment. In D129166#3633243 , @labath wrote: > In D129166#3633116 , @JDevlieghere > wrote: > >> Thanks for the thoughtful reply Pavel. The remote tests are something we >> care about as

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

labath added a comment. In D129166#3633116 , @JDevlieghere wrote: > Thanks for the thoughtful reply Pavel. The remote tests are something we care > about as well, so I'd like to have a solution for that. What do you think > about adding a "stdlib"

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere added a comment. In D129166#3632597 , @labath wrote: > I'm afraid this will not work on systems which do not default to libc++ > (which includes at least linux and windows), because `-stdlib=libc++` is not > "equivalent" to `-nostdlib++

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

labath added a comment. I'm afraid this will not work on systems which do not default to libc++ (which includes at least linux and windows), because `-stdlib=libc++` is not "equivalent" to `-nostdlib++ -lc++` -- the former changes the include paths to use libc++, while the latter doesn't. And,

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere created this revision. JDevlieghere added reviewers: labath, dblaikie, clayborg, aprantl, mib. Herald added a project: All. JDevlieghere requested review of this revision. Make sure we use the libc++ from the build dir. Currently, by passing `-stdlib=libc++`, we might pick up the