This revision was automatically updated to reflect the committed changes.
Closed by commit rG0538e5431afd: Move GetControlFlowKinds logic to
DisassemblerLLVMC.cpp (authored by Walter Erquinigo wall...@fb.com).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
persona0220 updated this revision to Diff 447437.
persona0220 added a comment.
Add default implementation for GetControlFlowKind()
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130320/new/
https://reviews.llvm.org/D130320
Files:
lldb/include/lldb/Core/Disassembler.h
wallace added a comment.
Just one more change and good to go
Comment at: lldb/include/lldb/Core/Disassembler.h:87
+ virtual lldb::InstructionControlFlowKind
+ GetControlFlowKind(const ExecutionContext *exe_ctx) = 0;
could add a default implementation here?
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
great! thank you. I'll land this
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130320/new/
https://reviews.llvm.org/D130320
___
persona0220 updated this revision to Diff 446680.
persona0220 edited the summary of this revision.
persona0220 added a comment.
Not to cache the control flow kind
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130320/new/
https://reviews.llvm.org/D130320
Files:
persona0220 created this revision.
persona0220 added reviewers: wallace, jj10306.
Herald added a project: All.
persona0220 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This diff move the logic of `GetControlFlowKind()` from
