[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

2022-08-25 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbaeb17cdfa4b: [lldb] Add more dylib paths for exception breakpoints (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132598/new/

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

2022-08-25 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } aprantl

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

2022-08-24 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132598/new/ https://reviews.llvm.org/D132598

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

2022-08-24 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } fdeazeve

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

2022-08-24 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } aprantl

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

2022-08-24 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } Should these

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

2022-08-24 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When setting a breakpoint upon throwing exceptions, LLDB only searches for the libc++abi code inside dylibs named: 1.