This revision was automatically updated to reflect the committed changes.
Closed by commit rGbaeb17cdfa4b: [lldb] Add more dylib paths for exception
breakpoints (authored by fdeazeve).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132598/new/
fdeazeve added inline comments.
Comment at:
lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457
+filter_modules.EmplaceBack("libc++abi.1.0.dylib");
+filter_modules.EmplaceBack("libc++abi.1.dylib");
}
aprantl
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
LGTM too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132598/new/
https://reviews.llvm.org/D132598
aprantl added inline comments.
Comment at:
lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457
+filter_modules.EmplaceBack("libc++abi.1.0.dylib");
+filter_modules.EmplaceBack("libc++abi.1.dylib");
}
fdeazeve
fdeazeve added inline comments.
Comment at:
lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457
+filter_modules.EmplaceBack("libc++abi.1.0.dylib");
+filter_modules.EmplaceBack("libc++abi.1.dylib");
}
aprantl
aprantl added inline comments.
Comment at:
lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457
+filter_modules.EmplaceBack("libc++abi.1.0.dylib");
+filter_modules.EmplaceBack("libc++abi.1.dylib");
}
Should these
fdeazeve created this revision.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
When setting a breakpoint upon throwing exceptions, LLDB only
searches for the libc++abi code inside dylibs named:
1.