[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. I've reverted this while I find an Ubuntu machine to investigate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 ___ lldb-commits mail

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. It seems that a linux bot is failing after this: https://lab.llvm.org/buildbot/#/builders/68/builds/39086 This job does _not_ build the libcxx projects, and yet the `LIBCPP_INCLUDE_DIR` variable is defined. I'm investigating Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc38eeecbc7d9: [lldb] Use just-built libcxx for tests when available (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 458793. fdeazeve edited the summary of this revision. fdeazeve added a comment. Updated wording of error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 File

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

aprantl added a comment. Could we land this today so we can get the bots green again? Please still make sure to respond to any post-commit feedback from @labath in case there's anything hasn't been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:396 + ifneq ($(or $(USE_LIBSTDCPP), $(USE_LIBCPP)),) + $(error Cannot use system's library and a custom library toget

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added inline comments. Comment at: lldb/test/API/commands/expression/fixits/TestFixIts.py:54 +# FIXME: LLDB struggles with this when stdlib has debug info. +if not lldbutil.has_debug_info_in_libcxx(target): +self.assertEquals(value.GetError().

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 458439. fdeazeve added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 Files: lldb/packages/Python/lldbsuite/test/make/Makefil

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

labath added inline comments. Comment at: lldb/test/API/commands/expression/fixits/TestFixIts.py:54 +# FIXME: LLDB struggles with this when stdlib has debug info. +if not lldbutil.has_debug_info_in_libcxx(target): +self.assertEquals(value.GetError().Ge

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. I had add extra checks to some tests which are known to fail with debug builds of the standard library, disabling them while a fix is not proposed. Didn't want devs using debug configures to suddenly start seeing test failures Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 458240. fdeazeve added a comment. Added test changes for tests known to be faulty in the presence of a standard library containing debug symbols, so that developers using debug builds don't see any failures. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

labath accepted this revision. labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:381-386 +ifneq ($(and $(USE_LIBSTDCPP), $(USE_LIBCPP)),) + $(error Libcxx and Libstdc++ cannot be used together) +endif + +ifeq (1, $(USE_SYSTEM_

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 457252. fdeazeve added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 Files: lldb/packages/Python/lldbsuite/test/make/Makefil

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. > is used by (a lot) more tests than just TestAppleSimulatorOSType. In that > case, I would say that this argument should be passed directly from python, > as a part of the `self.build` command (the test already passes a bunch of > arguments there anyway). Good catc

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

labath added a comment. In D132940#3761082 , @fdeazeve wrote: > In D132940#3761038 , @labath wrote: > >>> Cross-platform (such as API/macosx/macCatalyst and API/tools/lldb-server). >> >> What makes these two tests

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. In D132940#3761038 , @labath wrote: >> Cross-platform (such as API/macosx/macCatalyst and API/tools/lldb-server). > > What makes these two tests special? These two tests are _always_ building binaries for Mac Catalyst (API/maco

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

labath added a comment. > Cross-platform (such as API/macosx/macCatalyst and API/tools/lldb-server). I find this statement fairly surprising. One should be able to run ~all tests in a "cross-platform" manner (i.e. where the test architecture is different than lldb (host) arch). What makes these

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 ___

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. This patch should finally enable us to fix the LLDB bots using older versions of Clang: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://r

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 456652. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. Improved error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 Files: lldb/packa

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit improves upon cc0b5ebf7fc8 , which adde