[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. In D134878#3869947 , @mehdi_amini wrote: > From what I saw when you posted the discourse thread initially, I understand > you're targeting user-visible features, and mostly from the "toolchain" side > of the project. >

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

mehdi_amini added a comment. From what I saw when you posted the discourse thread initially, I understand you're targeting user-visible features, and mostly from the "toolchain" side of the project. However I find the language here to be potentially confusing for the API surface of the

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8673444598be: Update developer policy on potentially breaking changes (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. In D134878#3836840 , @aaron.ballman wrote: > Pinging reviewers from projects other than libcxx (I'm hoping to get buy-in > from someone on the LLVM side of things; lldb would be nice as well). I'll be landing this later

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. Pinging reviewers from projects other than libcxx (I'm hoping to get buy-in from someone on the LLVM side of things; lldb would be nice as well). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

ldionne accepted this revision. ldionne added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:140 + +* After the change has been committed to the repository, the potentially + disruptive changes described in the release notes should be posted to the

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

Mordante added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. aaron.ballman wrote: > Mordante

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. Mordante wrote: > I didn't

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman updated this revision to Diff 463949. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Applying review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878 Files:

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks a lot for working on this! A few small nits, otherwise LGTM. Comment at: llvm/docs/DeveloperPolicy.rst:112 + +Please help notify users of potential disruptions

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:140 + +* After the change has been committed to the repository, the potentially + disruptive changes described in the release notes should be posted to the ldionne wrote: > I wonder

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

ldionne added a comment. Thanks for working on this! FWIW, this more or less standardizes what we've been doing in libc++ for the past ~1.5 years and it's been pretty low effort for us to do. And putting my vendor hat on, it's been extremely useful for me to track down potential issues when

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a reviewer: JDevlieghere. aaron.ballman added a comment. Adding someone from lldb as a review for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a subscriber: mehdi_amini. aaron.ballman added a comment. Note: I would love to add a vendors group to Phabricator for LLVM and lldb (and any other project we think has vendors), but this requires admin privileges to do. @mehdi_amini, is this something you could help out

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman created this revision. aaron.ballman added reviewers: rnk, lattner, ldionne, rjmccall, Mordante, tahonermann, bruno, tonic. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. We've recently had issues appropriately notifying