This revision was automatically updated to reflect the committed changes.
Closed by commit rGb1256f2345f6: [lldb/Interpreter] Introduce
ScriptedPlatform{,Python}Interface (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139251/new/
mib updated this revision to Diff 488488.
mib added a comment.
Add `AttachToProcess` method to interface
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139251/new/
https://reviews.llvm.org/D139251
Files:
lldb/include/lldb/Interpreter/ScriptInterpreter.h
mib updated this revision to Diff 488006.
mib marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139251/new/
https://reviews.llvm.org/D139251
Files:
lldb/include/lldb/Interpreter/ScriptInterpreter.h
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPlatformPythonInterface.cpp:97
+
+#endif
nit: This `#endif` should have a ` //
mib updated this revision to Diff 481848.
mib marked 4 inline comments as done.
mib added a comment.
Address @bulbazord comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139251/new/
https://reviews.llvm.org/D139251
Files:
lldb/include/lldb/Interpreter/ScriptInterpreter.h
bulbazord added inline comments.
Comment at: lldb/include/lldb/Interpreter/ScriptedPlatformInterface.h:14
+#include "lldb/Interpreter/ScriptedInterface.h"
+#include "lldb/Target/MemoryRegionInfo.h"
+
What is `MemoryRegionInfo.h` for?
Comment
mib created this revision.
mib added reviewers: JDevlieghere, bulbazord.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch introduces both the ScriptedPlatformInterface and the
