augusto2112 created this revision.
augusto2112 added a reviewer: aprantl.
Herald added a subscriber: inglorion.
Herald added a project: All.
augusto2112 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Make the lldb test target depend on LTO
DavidSpickett added a comment.
If you don't have LTO, does this mean that only that one test won't run, or
will the whole suite not run?
Perhaps I misunderstand the purpose of add_lldb_test_dependency.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
augusto2112 added a comment.
@DavidSpickett right now if you don't have LTO the test will run but fail.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140051/new/
https://reviews.llvm.org/D140051
___
lldb
DavidSpickett added a comment.
Sorry I should have been specific. With this change applied, when you don't
have LTO, we'll just skip the individual test, or we'll not do testing at all?
Wondering if this is an all or nothing situation, which would be unfortunate
for a single test.
Repository:
aprantl added a comment.
@DavidSpickett Is it possible to configure LLVM to not build with libLTO? Which
CMake flag controls this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140051/new/
https://reviews.llvm.org/D140051
DavidSpickett added a comment.
Well that was my confusion, no there isn't an option. So how does one end up
with a build that doesn't include it. Perhaps a standalone build of lldb, built
with a prebuilt llvm that didn't package libLTO?
Which sounds perfectly legitimate and the test should be s
aprantl added a comment.
> Well that was my confusion, no there isn't an option. So how does one end up
> with a build that doesn't include it. Perhaps a standalone build of lldb,
> built with a prebuilt llvm that didn't package libLTO?
This is just about adding a dependency between lldb-test-d
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
> If you just run ninja check-lldb prior to this patch libLTO would not be
> built.
Great, put that in the commit message.
What I was trying to get at was the meaning of depends
augusto2112 added a comment.
@DavidSpickett thanks for the review, I've updated the commit message to be
clearer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140051/new/
https://reviews.llvm.org/D140051
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf85cc6009aa7: [lldb] Add LTO dependency to lldb test suite
(authored by augusto2112).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140051/new/
https://revi
10 matches
Mail list logo