Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2016-05-12 Thread Kamil Rytarowski via lldb-commits
krytarowski resigned from this revision. krytarowski removed a reviewer: krytarowski. krytarowski added a comment. This patch looks dead -- no activity. Repository: rL LLVM http://reviews.llvm.org/D14182 ___ lldb-commits mailing list lldb-commits

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-30 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. For future diffs please include additional context (e.g. git diff -U9) Repository: rL LLVM http://reviews.llvm.org/D14182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-30 Thread Mark Chandler via lldb-commits
mchandler-blizzard created this revision. mchandler-blizzard added reviewers: labath, ovyalov. mchandler-blizzard added a subscriber: lldb-commits. mchandler-blizzard set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer. Adds checks for posix f

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-30 Thread Mark Chandler via lldb-commits
mchandler-blizzard added inline comments. Comment at: tools/lldb/source/Host/common/File.cpp:301 @@ -299,1 +300,3 @@ + +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23) if (options & eOpenOptionCloseOnExec) krytarowski wrote: > labath wrote: > > This need

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-29 Thread Kamil Rytarowski via lldb-commits
krytarowski added inline comments. Comment at: tools/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:72 @@ -71,1 +71,3 @@ +// Missing defines due to bug: https://sourceware.org/bugzilla/show_bug.cgi?id=4125 + brucem wrote: > This bug was fixed in 2007,

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-29 Thread Kamil Rytarowski via lldb-commits
krytarowski added inline comments. Comment at: tools/lldb/source/Host/posix/PipePosix.cpp:43 @@ -40,3 +42,3 @@ // TODO: Add more platforms that support pipe2. -#if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) || defined(__NetBSD__) +#if (defined(__linux__) &

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-29 Thread Bruce Mitchener via lldb-commits
brucem added a subscriber: brucem. brucem requested changes to this revision. brucem added a reviewer: brucem. Comment at: tools/lldb/source/Host/linux/HostThreadLinux.cpp:33 @@ -32,3 +32,3 @@ { -#if (defined(__GLIBC__) && defined(_GNU_SOURCE)) || defined(__ANDROID__) +#if (defin

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-29 Thread Kamil Rytarowski via lldb-commits
krytarowski requested changes to this revision. krytarowski added a reviewer: krytarowski. Comment at: tools/lldb/source/Host/posix/PipePosix.cpp:32 @@ -31,1 +31,3 @@ +#include + Is this file just for Linux? Comment at: tools/lldb/source/Host/

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-29 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: krytarowski. Comment at: tools/lldb/source/Host/common/File.cpp:301 @@ -299,1 +300,3 @@ + +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23) if (options & eOpenOptionCloseOnExec) labath wrote: > This needs to evaluate to tru

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-29 Thread Pavel Labath via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Thanks for the patch. Looks good, but we need to make sure things continue to work on non-linux systems... Comment at: tools/lldb/source/Host/common/File.cpp:301 @@