[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64a2520bacb5: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 518167. sgraenitz marked an inline comment as done. sgraenitz added a comment. Address feedback and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 Files:

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2663 +// the actual range check below. +if (addend < 0 && static_cast(std::abs(addend)) > value)

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Double-checked and found source locations on Raspberry Pi 3b with this patch applied https://github.com/llvm/llvm-project/issues/61948#issuecomment-1508305542 Is there more feedback on this? It would be nice to land it soon, i.e. before EuroLLVM =) Repository: rG

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Addressed feedback and added handling for `R_ARM_REL32`. I didn't see a real-world case for it yet. Hope it's ok to have the error reported for the time being. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2640 +static void

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 513179. sgraenitz added a comment. Add error reporting for `R_ARM_REL32` relocations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 Files:

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 513178. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rename new function to `ApplyELF32ABS32RelRelocation()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

peter.smith added a comment. From the Arm side this looks good. Strictly speaking R_ARM_ABS32 doesn't require overflow checking, but in this context adding it makes sense. It is definitely the case that addends are signed in Arm, I guess there may be a 32-bit ABI that has unsigned REL addends,

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 511155. sgraenitz added a comment. Second try for the out-of-range test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 Files:

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 511151. sgraenitz added a comment. Add the missing 5th relocation to the test that exercises the out-of-range case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Adding an abstraction for reading implicit addend or somehow integrate it into `ELFRelocation::RelocAddend32()` might be more confusing for the reader than keeping it in the function inline. What do you think? Comment at:

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz created this revision. sgraenitz added reviewers: DavidSpickett, peter.smith, labath, davide. Herald added subscribers: omjavaid, kristof.beyls, emaste. Herald added a project: All. sgraenitz requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: